Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

UXW-1872 Fix some tooltips text color in dark theme (#65182)

Denis Berezin46b8b2791d25
diff --git a/frontend/src/metabase/admin/databases/components/DatabaseConnectionHealthInfo.tsx b/frontend/src/metabase/admin/databases/components/DatabaseConnectionHealthInfo.tsx
index 08286c3b68a..18e13ca9824 100644
--- a/frontend/src/metabase/admin/databases/components/DatabaseConnectionHealthInfo.tsx
+++ b/frontend/src/metabase/admin/databases/components/DatabaseConnectionHealthInfo.tsx
@@ -27,7 +27,11 @@ export const DatabaseConnectionHealthInfo = ({
{ isUninitialized: true },
{ isFetching: true },
{ isLoading: true },
- () => ({ message: t`Loading...`, color: "text-light" }) as const,
+ () =>
+ ({
+ message: t`Loading...`,
+ color: "var(--mb-color-tooltip-text)",
+ }) as const,
)
.with(
{ currentData: { status: "error" } },
@@ -38,7 +42,7 @@ export const DatabaseConnectionHealthInfo = ({
() =>
({
message: t`Failed to retrieve database health status.`,
- color: "text-light",
+ color: "var(--mb-color-tooltip-text)",
}) as const,
)
.exhaustive();
diff --git a/frontend/src/metabase/common/components/CopyButton/CopyButton.tsx b/frontend/src/metabase/common/components/CopyButton/CopyButton.tsx
index cc90bf2740b..0149a67f4b3 100644
--- a/frontend/src/metabase/common/components/CopyButton/CopyButton.tsx
+++ b/frontend/src/metabase/common/components/CopyButton/CopyButton.tsx
@@ -58,7 +58,7 @@ export const CopyButton = ({
<CopyToClipboard text={value} onCopy={onCopyValue}>
<div className={className} style={style} data-testid="copy-button">
<Tooltip
- label={<Text fw={700} c="white">{t`Copied!`}</Text>}
+ label={<Text fw={700} c="inherit">{t`Copied!`}</Text>}
opened={copied}
>
<span onKeyDown={copyOnEnter}>{target}</span>
diff --git a/frontend/src/metabase/common/components/upload/UploadTooltip.tsx b/frontend/src/metabase/common/components/upload/UploadTooltip.tsx
index 94f6f8b8fc2..1b1eaa341cf 100644
--- a/frontend/src/metabase/common/components/upload/UploadTooltip.tsx
+++ b/frontend/src/metabase/common/components/upload/UploadTooltip.tsx
@@ -19,11 +19,11 @@ export const UploadTooltip = ({
<Box ta="center">
<Text
size="sm"
- c="var(--mb-color-text-white)"
+ c="var(--mb-color-tooltip-text)"
>{t`Upload data to ${collection.name}`}</Text>
<Text
size="sm"
- c="var(--mb-color-text-tertiary)"
+ c="var(--mb-color-tooltip-text-secondary)"
>{t`${UPLOAD_DATA_FILE_TYPES.join(
", ",
)} (${MAX_UPLOAD_STRING} MB max)`}</Text>
diff --git a/frontend/src/metabase/search/components/InfoText/InfoTextEditedInfo.styled.tsx b/frontend/src/metabase/search/components/InfoText/InfoTextEditedInfo.styled.tsx
index 62b54a2536a..b944d0cbbb1 100644
--- a/frontend/src/metabase/search/components/InfoText/InfoTextEditedInfo.styled.tsx
+++ b/frontend/src/metabase/search/components/InfoText/InfoTextEditedInfo.styled.tsx
@@ -29,5 +29,5 @@ export const LastEditedInfoText = styled(LastEditInfoLabel)`
`;
export const LastEditedInfoTooltip = styled(LastEditInfoLabel)`
- color: var(--mb-color-text-white);
+ color: var(--mb-color-tooltip-text);
`;
diff --git a/frontend/src/metabase/setup/components/SettingsPage/SettingsPage.tsx b/frontend/src/metabase/setup/components/SettingsPage/SettingsPage.tsx
index fa70d65554d..29b34d50db1 100644
--- a/frontend/src/metabase/setup/components/SettingsPage/SettingsPage.tsx
+++ b/frontend/src/metabase/setup/components/SettingsPage/SettingsPage.tsx
@@ -38,7 +38,7 @@ export const SettingsPage = (): JSX.Element => {
const TOOLTIP_WIDTH = 220;
const label = (
- <Text size="sm" c="text-white">
+ <Text size="sm" c="var(--mb-color-tooltip-text)">
{tooltipText}
</Text>
);
diff --git a/frontend/src/metabase/timelines/collections/components/TimelineEmptyState/TimelineEmptyState.tsx b/frontend/src/metabase/timelines/collections/components/TimelineEmptyState/TimelineEmptyState.tsx
index 5b962a3cb50..dd12d977546 100644
--- a/frontend/src/metabase/timelines/collections/components/TimelineEmptyState/TimelineEmptyState.tsx
+++ b/frontend/src/metabase/timelines/collections/components/TimelineEmptyState/TimelineEmptyState.tsx
@@ -27,7 +27,7 @@ const TimelineEmptyState = ({
const applicationName = useSelector(getApplicationName);
return (
<Stack align="center" ta="center" gap="lg">
- <Tooltip color="text-light" label={t`Launch of v2.0`} offset={-24} opened>
+ <Tooltip label={t`Launch of v2.0`} offset={-24} opened>
<Box maw="6rem">
<img src={EmptyEvent} alt={t`Collection event illustration`} />
</Box>