The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Error a test that accesses unmocked routes (#64311)
Fraser46c6bcd677e5
diff --git a/enterprise/frontend/src/embedding-sdk-bundle/test/auth-flow/jwt.unit.spec.tsx b/enterprise/frontend/src/embedding-sdk-bundle/test/auth-flow/jwt.unit.spec.tsxindex 4c95b6fd094..b99d9ef101d 100644--- a/enterprise/frontend/src/embedding-sdk-bundle/test/auth-flow/jwt.unit.spec.tsx+++ b/enterprise/frontend/src/embedding-sdk-bundle/test/auth-flow/jwt.unit.spec.tsx@@ -7,6 +7,7 @@ import { ComponentProvider } from "embedding-sdk-bundle/components/public/Componimport { StaticQuestion } from "embedding-sdk-bundle/components/public/StaticQuestion";import type { MetabaseProviderProps } from "embedding-sdk-bundle/types/metabase-provider";import { defineMetabaseAuthConfig } from "embedding-sdk-package/lib/public/define-metabase-auth-config";+import { createMockSettings, createMockUser } from "metabase-types/api/mocks";import {MOCK_INSTANCE_URL,@@ -170,6 +171,16 @@ describe("Auth Flow - JWT", () => {},);+ fetchMock.get(`${instanceUrlWithSubpath}/api/user/current`, {+ status: 200,+ body: createMockUser(),+ });++ fetchMock.get(`${instanceUrlWithSubpath}/api/session/properties`, {+ status: 200,+ body: createMockSettings(),+ });+const authConfig = defineMetabaseAuthConfig({metabaseInstanceUrl: instanceUrlWithSubpath,});diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/components/JobView/JobView.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/transforms/components/JobView/JobView.unit.spec.tsxindex b10900527eb..59413c32b57 100644--- a/enterprise/frontend/src/metabase-enterprise/transforms/components/JobView/JobView.unit.spec.tsx+++ b/enterprise/frontend/src/metabase-enterprise/transforms/components/JobView/JobView.unit.spec.tsx@@ -1,3 +1,7 @@+import {+ setupListTransformJobTransformsEndpoint,+ setupListTransformTagsEndpoint,+} from "__support__/server-mocks";import { renderWithProviders, screen } from "__support__/ui";import { createMockTransformJob } from "metabase-types/api/mocks";@@ -14,6 +18,11 @@ function setup({ job = createMockTransformJob() }: SetupOpts) {const onScheduleChange = jest.fn();const onTagListChange = jest.fn();+ setupListTransformTagsEndpoint([]);+ if (job.id) {+ setupListTransformJobTransformsEndpoint(job.id, []);+ }+renderWithProviders(<JobViewjob={job}diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/pages/JobListPage/JobList/JobList.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/transforms/pages/JobListPage/JobList/JobList.unit.spec.tsxindex dc51e540b9f..d6884584aa6 100644--- a/enterprise/frontend/src/metabase-enterprise/transforms/pages/JobListPage/JobList/JobList.unit.spec.tsx+++ b/enterprise/frontend/src/metabase-enterprise/transforms/pages/JobListPage/JobList/JobList.unit.spec.tsx@@ -64,12 +64,15 @@ function setup({describe("JobList", () => {it("should show the last run status", async () => {+ const jobId = 1;setup({jobs: [createMockTransformJob({+ id: jobId,last_run: createMockTransformRun({ status: "started" }),}),],+ jobTransforms: new Map([[jobId, { data: [createMockTransform()] }]]),});expect(await screen.findByText("In progress")).toBeInTheDocument();});diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformPage/ManageSection/ManageSection.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformPage/ManageSection/ManageSection.unit.spec.tsxindex 05d0bd46a71..80685c6533a 100644--- a/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformPage/ManageSection/ManageSection.unit.spec.tsx+++ b/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformPage/ManageSection/ManageSection.unit.spec.tsx@@ -1,9 +1,11 @@import { Route } from "react-router";+import { setupAdhocQueryMetadataEndpoint } from "__support__/server-mocks";import { renderWithProviders, screen } from "__support__/ui";import { getTransformUrl } from "metabase-enterprise/transforms/urls";import type { Transform } from "metabase-types/api";import {+ createMockCardQueryMetadata,createMockTransform,createMockTransformRun,} from "metabase-types/api/mocks";@@ -15,6 +17,8 @@ type SetupOpts = {};function setup({ transform = createMockTransform() }: SetupOpts) {+ setupAdhocQueryMetadataEndpoint(createMockCardQueryMetadata());+renderWithProviders(<Routepath={getTransformUrl(transform.id)}diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformPage/TargetSection/TargetSection.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformPage/TargetSection/TargetSection.unit.spec.tsxindex 2fa90257b3a..d65110af526 100644--- a/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformPage/TargetSection/TargetSection.unit.spec.tsx+++ b/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformPage/TargetSection/TargetSection.unit.spec.tsx@@ -1,9 +1,11 @@import { Route } from "react-router";+import { setupDatabaseEndpoints } from "__support__/server-mocks";import { renderWithProviders, screen } from "__support__/ui";import { getTransformUrl } from "metabase-enterprise/transforms/urls";import type { Transform } from "metabase-types/api";import {+ createMockDatabase,createMockTransform,createMockTransformRun,} from "metabase-types/api/mocks";@@ -15,6 +17,8 @@ type SetupOpts = {};function setup({ transform = createMockTransform() }: SetupOpts) {+ setupDatabaseEndpoints(createMockDatabase({ id: 1 }));+renderWithProviders(<Routepath={getTransformUrl(transform.id)}diff --git a/frontend/src/metabase/admin/settings/components/Email/SMTPConnectionCard/tests/setup.tsx b/frontend/src/metabase/admin/settings/components/Email/SMTPConnectionCard/tests/setup.tsxindex 85e030674fc..14b1da6154b 100644--- a/frontend/src/metabase/admin/settings/components/Email/SMTPConnectionCard/tests/setup.tsx+++ b/frontend/src/metabase/admin/settings/components/Email/SMTPConnectionCard/tests/setup.tsx@@ -1,9 +1,13 @@import { setupEnterprisePlugins } from "__support__/enterprise";+import { setupPropertiesEndpoints } from "__support__/server-mocks";import { mockSettings } from "__support__/settings";import { renderWithProviders } from "__support__/ui";import { SMTPConnectionCard } from "metabase/admin/settings/components/Email/SMTPConnectionCard/SMTPConnectionCard";import type { TokenFeatures } from "metabase-types/api";-import { createMockTokenFeatures } from "metabase-types/api/mocks";+import {+ createMockSettings,+ createMockTokenFeatures,+} from "metabase-types/api/mocks";import { createMockState } from "metabase-types/store/mocks";export interface SetupOpts {@@ -19,13 +23,15 @@ export function setup({isHosted = true,smtpOverrideEnabled = false,}: SetupOpts = {}) {- const settings = mockSettings({+ const settings = {"token-features": createMockTokenFeatures(tokenFeatures),"is-hosted?": isHosted,"smtp-override-enabled": smtpOverrideEnabled,- });+ };++ setupPropertiesEndpoints(createMockSettings(settings));- const state = createMockState({ settings });+ const state = createMockState({ settings: mockSettings(settings) });if (hasEnterprisePlugins) {setupEnterprisePlugins();diff --git a/frontend/src/metabase/common/components/MetadataInfo/TableInfoIcon/TableInfoIcon.unit.spec.tsx b/frontend/src/metabase/common/components/MetadataInfo/TableInfoIcon/TableInfoIcon.unit.spec.tsxindex 82bcc598cd4..e1981e3092e 100644--- a/frontend/src/metabase/common/components/MetadataInfo/TableInfoIcon/TableInfoIcon.unit.spec.tsx+++ b/frontend/src/metabase/common/components/MetadataInfo/TableInfoIcon/TableInfoIcon.unit.spec.tsx@@ -1,3 +1,4 @@+import { setupTableEndpoints } from "__support__/server-mocks";import { createMockEntitiesState } from "__support__/store";import { act, fireEvent, renderWithProviders, screen } from "__support__/ui";import type { Table } from "metabase-types/api";@@ -11,6 +12,8 @@ type SetupOpts = {};function setup({ table }: SetupOpts) {+ setupTableEndpoints(table);+const state = createMockState({entities: createMockEntitiesState({tables: [table],diff --git a/frontend/src/metabase/dashboard/containers/AutomaticDashboardApp/AutomaticDashboardApp.unit.spec.tsx b/frontend/src/metabase/dashboard/containers/AutomaticDashboardApp/AutomaticDashboardApp.unit.spec.tsxindex b7bc20e0d5f..d25e98f6dd0 100644--- a/frontend/src/metabase/dashboard/containers/AutomaticDashboardApp/AutomaticDashboardApp.unit.spec.tsx+++ b/frontend/src/metabase/dashboard/containers/AutomaticDashboardApp/AutomaticDashboardApp.unit.spec.tsx@@ -1,7 +1,10 @@import userEvent from "@testing-library/user-event";import { Route } from "react-router";-import { setupAutoDashboardEndpoints } from "__support__/server-mocks";+import {+ setupAutoDashboardEndpoints,+ setupDatabaseListEndpoint,+} from "__support__/server-mocks";import { createMockEntitiesState } from "__support__/store";import {renderWithProviders,@@ -32,6 +35,7 @@ const setup = async () => {databases: [TEST_DATABASE_WITH_ACTIONS],}),);+ setupDatabaseListEndpoint([TEST_DATABASE_WITH_ACTIONS]);renderWithProviders(<Route path="/auto/dashboard/*" component={AutomaticDashboardApp} />,diff --git a/frontend/src/metabase/home/components/Onboarding/tests/setup.tsx b/frontend/src/metabase/home/components/Onboarding/tests/setup.tsxindex e24dbfe7896..49c84710018 100644--- a/frontend/src/metabase/home/components/Onboarding/tests/setup.tsx+++ b/frontend/src/metabase/home/components/Onboarding/tests/setup.tsx@@ -1,10 +1,12 @@import { Route } from "react-router";import { setupEnterprisePlugins } from "__support__/enterprise";+import { setupPropertiesEndpoints } from "__support__/server-mocks";import { mockSettings } from "__support__/settings";import { renderWithProviders } from "__support__/ui";import type { TokenFeatures } from "metabase-types/api";import {+ createMockSettings,createMockTokenFeatures,createMockTokenStatus,createMockUser,@@ -41,7 +43,7 @@ export const setup = ({tokenFeatures = {},}: SetupProps = {}) => {const hasTokenFeatures = Object.entries(tokenFeatures).length > 0;-+ setupPropertiesEndpoints(createMockSettings());const state = createMockState({app: createMockAppState({tempStorage: {diff --git a/frontend/src/metabase/nav/containers/MainNavbar/MainNavbarContainer/GettingStartedSection.unit.spec.tsx b/frontend/src/metabase/nav/containers/MainNavbar/MainNavbarContainer/GettingStartedSection.unit.spec.tsxindex 71d314c6e23..992bdbc2abe 100644--- a/frontend/src/metabase/nav/containers/MainNavbar/MainNavbarContainer/GettingStartedSection.unit.spec.tsx+++ b/frontend/src/metabase/nav/containers/MainNavbar/MainNavbarContainer/GettingStartedSection.unit.spec.tsx@@ -1,7 +1,8 @@import userEvent from "@testing-library/user-event";+import { setupDatabaseListEndpoint } from "__support__/server-mocks";import { renderWithProviders, screen } from "__support__/ui";-import { createMockUser } from "metabase-types/api/mocks";+import { createMockDatabase, createMockUser } from "metabase-types/api/mocks";import { createMockState } from "metabase-types/store/mocks";import { GettingStartedSection } from "./GettingStartedSection";@@ -15,6 +16,9 @@ const setup = ({} = {}) => {const onAddDataModalOpen = jest.fn();+ const mockDbs = [createMockDatabase({ id: 1 })];+ setupDatabaseListEndpoint(mockDbs);+renderWithProviders(<GettingStartedSectionnonEntityItem={{ type: "collection" }}diff --git a/frontend/src/metabase/public/components/EmbedModal/EmbedModalContent/tests/setup.tsx b/frontend/src/metabase/public/components/EmbedModal/EmbedModalContent/tests/setup.tsxindex 4a85fa1ac82..fedc4976aa3 100644--- a/frontend/src/metabase/public/components/EmbedModal/EmbedModalContent/tests/setup.tsx+++ b/frontend/src/metabase/public/components/EmbedModal/EmbedModalContent/tests/setup.tsx@@ -1,6 +1,7 @@import { Route } from "react-router";import { setupEnterprisePlugins } from "__support__/enterprise";+import { setupTokenStatusEndpoint } from "__support__/server-mocks";import { mockSettings } from "__support__/settings";import { renderWithProviders } from "__support__/ui";import type { EmbedResource } from "metabase/public/lib/types";@@ -71,6 +72,10 @@ export function setup(setupEnterprisePlugins();}+ setupTokenStatusEndpoint({+ valid: true,+ });+const view = renderWithProviders(<Routepath="*"diff --git a/frontend/src/metabase/visualizations/components/ObjectDetail/ObjectDetailWrapper.unit.spec.tsx b/frontend/src/metabase/visualizations/components/ObjectDetail/ObjectDetailWrapper.unit.spec.tsxindex 041e95a4439..a357d294da8 100644--- a/frontend/src/metabase/visualizations/components/ObjectDetail/ObjectDetailWrapper.unit.spec.tsx+++ b/frontend/src/metabase/visualizations/components/ObjectDetail/ObjectDetailWrapper.unit.spec.tsx@@ -1,5 +1,6 @@import userEvent from "@testing-library/user-event";+import { setupTableEndpoints } from "__support__/server-mocks";import { createMockEntitiesState } from "__support__/store";import { testDataset } from "__support__/testDataset";import {@@ -36,6 +37,8 @@ const MOCK_CARD = createMockCard({});async function setup(options?: Partial<ObjectDetailProps>) {+ setupTableEndpoints(MOCK_TABLE);+const state = createMockState({entities: createMockEntitiesState({questions: [MOCK_CARD],diff --git a/frontend/test/jest-setup-env.js b/frontend/test/jest-setup-env.jsindex 9b6068d10b9..a50a9fa317c 100644--- a/frontend/test/jest-setup-env.js+++ b/frontend/test/jest-setup-env.js@@ -1,19 +1,30 @@import "@testing-library/jest-dom";import fetchMock from "fetch-mock";+// Fail tests on any unmocked fetch requests+// errors in fetchMock.catch don't fail the test immediately, so we need to+// collect them and fail the test in afterEach+let unmockedRouteErrors = [];+beforeEach(() => {+ unmockedRouteErrors = [];fetchMock.mockGlobal();+ fetchMock.catch((callLog) => {+ const { url, options } = callLog;+ const errorMessage = `Unmocked ${options.method} request to: ${url}`;+ unmockedRouteErrors.push(errorMessage);+ throw new Error(errorMessage);+ });});afterEach(() => {fetchMock.removeRoutes();fetchMock.callHistory.clear();- fetchMock.catch((url, request) => {- const errorMessage = `Caught unmocked ${request.method} request to: ${url}`;- Promise.reject(errorMessage);-- // consider all not mocked requests are broken- return 500;- });+ // Fail the test if there were any unmocked routes+ if (unmockedRouteErrors.length > 0) {+ const errors = unmockedRouteErrors.join("\n");+ unmockedRouteErrors = [];+ throw new Error(`Test completed with unmocked routes:\n${errors}`);+ }});