Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Split viz registry from the index file (#79682)

Fraser4724b7bde489
diff --git a/enterprise/frontend/src/metabase-enterprise/custom_viz/custom-viz-plugins.tsx b/enterprise/frontend/src/metabase-enterprise/custom_viz/custom-viz-plugins.tsx
index 61ba4ff96f4..2eda293d114 100644
--- a/enterprise/frontend/src/metabase-enterprise/custom_viz/custom-viz-plugins.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/custom_viz/custom-viz-plugins.tsx
@@ -18,7 +18,7 @@ import { PLUGIN_CUSTOM_VIZ } from "metabase/plugins";
import { getSubpathSafeUrl } from "metabase/urls";
import { measureText } from "metabase/utils/measure-text";
import { retry } from "metabase/utils/retry";
-import visualizations, { registerVisualization } from "metabase/visualizations";
+import { registerVisualization, visualizations } from "metabase/visualizations";
import {
getCustomPluginIdentifier,
getPluginAssetUrl,
diff --git a/enterprise/frontend/src/metabase-enterprise/dependencies/utils.ts b/enterprise/frontend/src/metabase-enterprise/dependencies/utils.ts
index 760eccce6ac..b381ee5b057 100644
--- a/enterprise/frontend/src/metabase-enterprise/dependencies/utils.ts
+++ b/enterprise/frontend/src/metabase-enterprise/dependencies/utils.ts
@@ -2,7 +2,7 @@ import { c, msgid, ngettext, t } from "ttag";
import * as Urls from "metabase/urls";
import type { NamedUser } from "metabase/utils/user";
-import visualizations from "metabase/visualizations";
+import { visualizations } from "metabase/visualizations";
import type {
AnalysisFindingError,
AnalysisFindingErrorType,
diff --git a/enterprise/frontend/src/metabase-enterprise/replacement/components/SourceReplacementStatus/SourceReplacementStatus.tsx b/enterprise/frontend/src/metabase-enterprise/replacement/components/SourceReplacementStatus/SourceReplacementStatus.tsx
index 7c49610c1fc..5608d310dad 100644
--- a/enterprise/frontend/src/metabase-enterprise/replacement/components/SourceReplacementStatus/SourceReplacementStatus.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/replacement/components/SourceReplacementStatus/SourceReplacementStatus.tsx
@@ -12,7 +12,7 @@ import {
isSpinnerVisible,
} from "metabase/status/components/utils/status";
import useStatusVisibility from "metabase/status/hooks/use-status-visibility";
-import visualizations from "metabase/visualizations";
+import { visualizations } from "metabase/visualizations";
import {
useGetSourceReplacementRunQuery,
useListSourceReplacementRunsQuery,
diff --git a/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/ChartTypeDropdown/ChartTypeDropdown.tsx b/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/ChartTypeDropdown/ChartTypeDropdown.tsx
index f274d6aea05..ed4eee94ec8 100644
--- a/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/ChartTypeDropdown/ChartTypeDropdown.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/ChartTypeDropdown/ChartTypeDropdown.tsx
@@ -4,8 +4,9 @@ import { t } from "ttag";
import type { IconName } from "metabase/embedding-sdk/types/icon";
import { Combobox, Flex, Icon, Text, useCombobox } from "metabase/ui";
import { isNotNull } from "metabase/utils/types";
-import visualizations, {
+import {
getIconForVisualizationType,
+ visualizations,
} from "metabase/visualizations";
import type { Visualization } from "metabase/visualizations/types";
import type { CardDisplayType } from "metabase-types/api";
diff --git a/frontend/src/embedding-sdk-bundle/lib/sdk-question/run-question-query.ts b/frontend/src/embedding-sdk-bundle/lib/sdk-question/run-question-query.ts
index df3c7ee1d20..652dd1abd53 100644
--- a/frontend/src/embedding-sdk-bundle/lib/sdk-question/run-question-query.ts
+++ b/frontend/src/embedding-sdk-bundle/lib/sdk-question/run-question-query.ts
@@ -4,7 +4,7 @@ import { PLUGIN_CUSTOM_VIZ } from "metabase/plugins";
import { runQuestionQuery } from "metabase/querying/run-query";
import type { Dispatch } from "metabase/redux/store";
import { isNotNull } from "metabase/utils/types";
-import visualizations from "metabase/visualizations";
+import { visualizations } from "metabase/visualizations";
import { getSensibleDisplays } from "metabase/visualizations/lib/sensibility";
import type Question from "metabase-lib/v1/Question";
import type {
diff --git a/frontend/src/metabase/dashboard/components/ParameterSettings/MoveParameterMenu/MoveParameterMenu.tsx b/frontend/src/metabase/dashboard/components/ParameterSettings/MoveParameterMenu/MoveParameterMenu.tsx
index 3559f243305..c04207675b5 100644
--- a/frontend/src/metabase/dashboard/components/ParameterSettings/MoveParameterMenu/MoveParameterMenu.tsx
+++ b/frontend/src/metabase/dashboard/components/ParameterSettings/MoveParameterMenu/MoveParameterMenu.tsx
@@ -7,7 +7,7 @@ import CS from "metabase/css/core/index.css";
import { useDispatch, useSelector } from "metabase/redux";
import { Flex, Group, Icon, Select, Text } from "metabase/ui";
import { isQuestionDashCard } from "metabase/utils/dashboard";
-import visualizations from "metabase/visualizations";
+import { visualizations } from "metabase/visualizations";
import type {
BaseDashboardCard,
IconName,
diff --git a/frontend/src/metabase/documents/utils/visualizationUtils.ts b/frontend/src/metabase/documents/utils/visualizationUtils.ts
index 99fe912ebb5..069590424e1 100644
--- a/frontend/src/metabase/documents/utils/visualizationUtils.ts
+++ b/frontend/src/metabase/documents/utils/visualizationUtils.ts
@@ -1,8 +1,9 @@
import { useMemo } from "react";
import { isNotNull } from "metabase/utils/types";
-import visualizations, {
+import {
getIconForVisualizationType,
+ visualizations,
} from "metabase/visualizations";
import { getSensibleVisualizations } from "metabase/visualizations/lib/sensibility";
import type {
diff --git a/frontend/src/metabase/embedding/mcp/utils/getMcpChartTypes.ts b/frontend/src/metabase/embedding/mcp/utils/getMcpChartTypes.ts
index 4800d8e4afc..3a476cfda74 100644
--- a/frontend/src/metabase/embedding/mcp/utils/getMcpChartTypes.ts
+++ b/frontend/src/metabase/embedding/mcp/utils/getMcpChartTypes.ts
@@ -1,4 +1,4 @@
-import visualizations from "metabase/visualizations";
+import { visualizations } from "metabase/visualizations";
import type { CardDisplayType, IconName } from "metabase-types/api";
// Default visualization can be any sensible visualization, so the
diff --git a/frontend/src/metabase/query_builder/components/chart-type-selector/ChartTypeList/ChartTypeList.unit.spec.tsx b/frontend/src/metabase/query_builder/components/chart-type-selector/ChartTypeList/ChartTypeList.unit.spec.tsx
index f71f31a1c83..db0cf534f71 100644
--- a/frontend/src/metabase/query_builder/components/chart-type-selector/ChartTypeList/ChartTypeList.unit.spec.tsx
+++ b/frontend/src/metabase/query_builder/components/chart-type-selector/ChartTypeList/ChartTypeList.unit.spec.tsx
@@ -1,6 +1,6 @@
import { renderWithProviders, screen, within } from "__support__/ui";
import { checkNotNull } from "metabase/utils/types";
-import visualizations from "metabase/visualizations";
+import { visualizations } from "metabase/visualizations";
import { DEFAULT_VIZ_ORDER } from "metabase/visualizations/lib/viz-order";
import { registerVisualizations } from "metabase/visualizations/register";
diff --git a/frontend/src/metabase/query_builder/components/chart-type-selector/ChartTypeOption/ChartTypeOption.tsx b/frontend/src/metabase/query_builder/components/chart-type-selector/ChartTypeOption/ChartTypeOption.tsx
index fefa9566ae1..9c543a73493 100644
--- a/frontend/src/metabase/query_builder/components/chart-type-selector/ChartTypeOption/ChartTypeOption.tsx
+++ b/frontend/src/metabase/query_builder/components/chart-type-selector/ChartTypeOption/ChartTypeOption.tsx
@@ -11,7 +11,7 @@ import {
Text,
Tooltip,
} from "metabase/ui";
-import visualizations from "metabase/visualizations";
+import { visualizations } from "metabase/visualizations";
import type { VisualizationDisplay } from "metabase-types/api";
import ChartTypeOptionS from "./ChartTypeOption.module.css";
diff --git a/frontend/src/metabase/query_builder/components/chart-type-selector/use-question-visualization-state.ts b/frontend/src/metabase/query_builder/components/chart-type-selector/use-question-visualization-state.ts
index b2297de8fdc..c41669e8b5c 100644
--- a/frontend/src/metabase/query_builder/components/chart-type-selector/use-question-visualization-state.ts
+++ b/frontend/src/metabase/query_builder/components/chart-type-selector/use-question-visualization-state.ts
@@ -1,6 +1,6 @@
import { useCallback } from "react";
-import visualizations from "metabase/visualizations";
+import { visualizations } from "metabase/visualizations";
import type Question from "metabase-lib/v1/Question";
import type { VisualizationDisplay } from "metabase-types/api";
import { isCustomVizDisplay } from "metabase-types/guards";
diff --git a/frontend/src/metabase/query_builder/components/view/sidebars/ChartSettingsSidebar.tsx b/frontend/src/metabase/query_builder/components/view/sidebars/ChartSettingsSidebar.tsx
index c2cb579b3ae..9c5d29b9a31 100644
--- a/frontend/src/metabase/query_builder/components/view/sidebars/ChartSettingsSidebar.tsx
+++ b/frontend/src/metabase/query_builder/components/view/sidebars/ChartSettingsSidebar.tsx
@@ -14,7 +14,7 @@ import {
onCloseChartSettings,
onOpenChartType,
} from "metabase/redux/query-builder";
-import visualizations from "metabase/visualizations";
+import { visualizations } from "metabase/visualizations";
import { QuestionChartSettings } from "metabase/visualizations/components/ChartSettings";
import type Question from "metabase-lib/v1/Question";
import type { Dataset, VisualizationSettings } from "metabase-types/api";
diff --git a/frontend/src/metabase/reference/databases/TableQuestions.tsx b/frontend/src/metabase/reference/databases/TableQuestions.tsx
index 55409615d7b..35f5bc3c6a8 100644
--- a/frontend/src/metabase/reference/databases/TableQuestions.tsx
+++ b/frontend/src/metabase/reference/databases/TableQuestions.tsx
@@ -13,7 +13,7 @@ import S from "metabase/reference/components/List/List.module.css";
import { ListItem } from "metabase/reference/components/ListItem";
import { getMetadata } from "metabase/selectors/metadata";
import * as Urls from "metabase/urls";
-import visualizations from "metabase/visualizations";
+import { visualizations } from "metabase/visualizations";
import type Metadata from "metabase-lib/v1/metadata/Metadata";
import type { Card } from "metabase-types/api";
diff --git a/frontend/src/metabase/reference/segments/SegmentQuestions.tsx b/frontend/src/metabase/reference/segments/SegmentQuestions.tsx
index e488dbfce61..cdfd669ab17 100644
--- a/frontend/src/metabase/reference/segments/SegmentQuestions.tsx
+++ b/frontend/src/metabase/reference/segments/SegmentQuestions.tsx
@@ -13,7 +13,7 @@ import S from "metabase/reference/components/List/List.module.css";
import { ListItem } from "metabase/reference/components/ListItem";
import { getMetadata } from "metabase/selectors/metadata";
import * as Urls from "metabase/urls";
-import visualizations from "metabase/visualizations";
+import { visualizations } from "metabase/visualizations";
import type Metadata from "metabase-lib/v1/metadata/Metadata";
import ReferenceHeader from "../components/ReferenceHeader";
diff --git a/frontend/src/metabase/visualizations/echarts/cartesian/utils/timeseries.unit.spec.ts b/frontend/src/metabase/visualizations/echarts/cartesian/utils/timeseries.unit.spec.ts
index 1e0e99bd9b3..c5022528949 100644
--- a/frontend/src/metabase/visualizations/echarts/cartesian/utils/timeseries.unit.spec.ts
+++ b/frontend/src/metabase/visualizations/echarts/cartesian/utils/timeseries.unit.spec.ts
@@ -6,7 +6,6 @@ import utc from "dayjs/plugin/utc";
dayjs.extend(utc);
dayjs.extend(timezone);
-import { getVisualizationTransformed } from "metabase/visualizations";
import type { ChartLayout } from "metabase/visualizations/echarts/cartesian/layout/types";
import type {
CartesianChartDateTimeAbsoluteUnit,
@@ -32,6 +31,8 @@ import {
createMockSingleSeries,
} from "metabase-types/api/mocks";
+import { getVisualizationTransformed } from "../../../lib/registry";
+
function createMockChartMeasurements(
outerWidth: number,
xTickWidth: number,
diff --git a/frontend/src/metabase/visualizations/index.ts b/frontend/src/metabase/visualizations/index.ts
index bc58ecd5f40..be555500610 100644
--- a/frontend/src/metabase/visualizations/index.ts
+++ b/frontend/src/metabase/visualizations/index.ts
@@ -1,243 +1,18 @@
-import type { ComponentType } from "react";
-import { t } from "ttag";
-import _ from "underscore";
-
-import { isStorybookActive } from "metabase/env";
-import type {
- DatasetData,
- IconName,
- RawSeries,
- Series,
- TransformedSeries,
- VisualizationDisplay,
-} from "metabase-types/api";
-
-import type { RemappingHydratedDatasetColumn } from "./types";
-import type {
- Visualization,
- VisualizationDefinition,
-} from "./types/visualization";
-
-// The static-viz bundle registers bare definitions with no component; the app
-// bundles register full components carrying their definition statics.
-export type RegisteredVisualization = Visualization | VisualizationDefinition;
-
-const visualizations = new Map<VisualizationDisplay, RegisteredVisualization>();
-const aliases = new Map<string, RegisteredVisualization>();
-const settingWidgets = new Map<string, ComponentType<any>>();
-visualizations.get = function (key) {
- return (
- Map.prototype.get.call(this, key) ||
- aliases.get(key) ||
- defaultVisualization
- );
-};
-
-let defaultVisualization: RegisteredVisualization;
-export function setDefaultVisualization(
- visualization: RegisteredVisualization,
-) {
- defaultVisualization = visualization;
-}
-
-function isVisualizationComponent(
- visualization: RegisteredVisualization | undefined,
-) {
- return typeof visualization === "function";
-}
-
-export function registerVisualization(visualization: RegisteredVisualization) {
- if (visualization == null) {
- throw new Error(t`Visualization is null`);
- }
- const identifier = visualization.identifier;
- if (identifier == null) {
- throw new Error(
- t`Visualization must define an 'identifier' static variable: ` +
- visualization.name,
- );
- }
- if (visualizations.has(identifier)) {
- const registeredVisualization = visualizations.get(identifier);
- const isReplacingDefinitionWithComponent =
- isVisualizationComponent(visualization) &&
- !isVisualizationComponent(registeredVisualization);
- const isRegisteringDefinitionOverComponent =
- !isVisualizationComponent(visualization) &&
- isVisualizationComponent(registeredVisualization);
-
- if (isRegisteringDefinitionOverComponent) {
- return;
- }
-
- if (!isReplacingDefinitionWithComponent) {
- if (isStorybookActive) {
- console.error(
- `Visualization with that identifier is already registered: ` +
- visualization.name,
- );
-
- // do not throw if it's storybook
- return;
- }
-
- throw new Error(
- t`Visualization with that identifier is already registered: ` +
- visualization.name,
- );
- }
- }
- visualizations.set(identifier, visualization);
- for (const alias of visualization.aliases || []) {
- aliases.set(alias, visualization);
- }
-}
-
-export function registerSettingWidgets(
- widgets: Record<string, ComponentType<any>>,
-) {
- for (const [key, widget] of Object.entries(widgets)) {
- settingWidgets.set(key, widget);
- }
-}
-
-export function getSettingWidgetComponent(key: string) {
- return settingWidgets.get(key);
-}
-
-type SeriesLike = Array<{ card: { display: VisualizationDisplay } }>;
-
-export function getVisualization(display: VisualizationDisplay | null) {
- return display ? visualizations.get(display) : defaultVisualization;
-}
-
-export function getVisualizationRaw(
- series: SeriesLike,
-): RegisteredVisualization | undefined {
- return visualizations.get(series[0].card.display);
-}
-
-export function getVisualizationTransformed(
- series: RawSeries | TransformedSeries,
-) {
- // don't transform if we don't have the data
- if (
- _.any(series, (s) => s.data == null) ||
- _.any(series, (s) => s.error != null)
- ) {
- return {
- series,
- visualization: getVisualizationRaw(series),
- };
- }
-
- // if a visualization has a transformSeries function, do the transformation until it returns the same visualization / series
- let visualization, lastSeries;
- do {
- visualization = visualizations.get(series[0].card.display);
- if (!visualization) {
- throw new Error(t`No visualization for ${series[0].card.display}`);
- }
- lastSeries = series;
- if (typeof visualization.transformSeries === "function") {
- series = visualization.transformSeries(series);
- }
- if (series !== lastSeries) {
- series = Object.assign([...series], { _raw: lastSeries });
- }
- } while (series !== lastSeries);
-
- return { series, visualization };
-}
-
-export function getIconForVisualizationType(display: VisualizationDisplay): {
- name: IconName;
- iconUrl?: string;
-} {
- const viz = visualizations.get(display);
- return {
- name: viz?.iconName ?? "unknown",
- iconUrl: viz?.iconUrl,
- };
-}
-
-export const extractRemappings = (series: Series) => {
- const se = series.map((s) => ({
- ...s,
- data: s.data && extractRemappedColumns(s.data),
- }));
- return se;
-};
-
-export function getMaxMetricsSupported(display: VisualizationDisplay) {
- const visualization = visualizations.get(display);
- return visualization?.maxMetricsSupported || Infinity;
-}
-
-export function getMaxDimensionsSupported(display: VisualizationDisplay) {
- const visualization = visualizations.get(display);
- return visualization?.maxDimensionsSupported || 2;
-}
-
-export function canSavePng(display: VisualizationDisplay) {
- const visualization = visualizations.get(display);
- return visualization?.canSavePng ?? true;
-}
-
-export function getDefaultSize(display: VisualizationDisplay) {
- const visualization = visualizations.get(display);
- return visualization?.defaultSize;
-}
-
-export function isCartesianChart(display: VisualizationDisplay) {
- const visualization = visualizations.get(display);
- const settingNames = Object.keys(visualization?.settings ?? {});
- return (
- settingNames.includes("graph.dimensions") &&
- settingNames.includes("graph.metrics")
- );
-}
-
-// removes columns with `remapped_from` property and adds a `remapping` to the appropriate column
-export const extractRemappedColumns = (data: DatasetData) => {
- const cols: RemappingHydratedDatasetColumn[] = data.cols.map((col) => ({
- ...col,
- remapped_from_index:
- col.remapped_from != null
- ? _.findIndex(data.cols, (c) => c.name === col.remapped_from)
- : undefined,
- remapping: col.remapped_to != null ? new Map() : undefined,
- }));
-
- const rows = data.rows.map((row) =>
- row.filter((value, colIndex) => {
- const col = cols[colIndex];
- if (col.remapped_from != null) {
- if (
- col.remapped_from_index == null ||
- !cols[col.remapped_from_index] ||
- !cols[col.remapped_from_index].remapping
- ) {
- console.warn("Invalid remapped_from", col);
- return true;
- }
- cols[col.remapped_from_index].remapped_to_column = col;
- cols[col.remapped_from_index].remapping?.set(
- row[col.remapped_from_index],
- row[colIndex],
- );
- return false;
- } else {
- return true;
- }
- }),
- );
- return {
- ...data,
- rows,
- cols: cols.filter((col) => col.remapped_from == null),
- };
-};
-
-// eslint-disable-next-line import/no-default-export
-export default visualizations;
+export {
+ type RegisteredVisualization,
+ canSavePng,
+ getDefaultSize,
+ getIconForVisualizationType,
+ getMaxDimensionsSupported,
+ getMaxMetricsSupported,
+ getSettingWidgetComponent,
+ getVisualization,
+ getVisualizationRaw,
+ getVisualizationTransformed,
+ isCartesianChart,
+ registerSettingWidgets,
+ registerVisualization,
+ setDefaultVisualization,
+ visualizations,
+} from "./lib/registry";
+export { extractRemappedColumns, extractRemappings } from "./lib/remapping";
diff --git a/frontend/src/metabase/visualizations/lib/registry.ts b/frontend/src/metabase/visualizations/lib/registry.ts
new file mode 100644
index 00000000000..a912a5e8708
--- /dev/null
+++ b/frontend/src/metabase/visualizations/lib/registry.ts
@@ -0,0 +1,191 @@
+import type { ComponentType } from "react";
+import { t } from "ttag";
+import _ from "underscore";
+
+import { isStorybookActive } from "metabase/env";
+import type {
+ IconName,
+ RawSeries,
+ TransformedSeries,
+ VisualizationDisplay,
+} from "metabase-types/api";
+
+import type {
+ Visualization,
+ VisualizationDefinition,
+} from "../types/visualization";
+
+// The static-viz bundle registers bare definitions with no component; the app
+// bundles register full components carrying their definition statics.
+export type RegisteredVisualization = Visualization | VisualizationDefinition;
+
+export const visualizations = new Map<
+ VisualizationDisplay,
+ RegisteredVisualization
+>();
+const aliases = new Map<string, RegisteredVisualization>();
+const settingWidgets = new Map<string, ComponentType<any>>();
+visualizations.get = function (key) {
+ return (
+ Map.prototype.get.call(this, key) ||
+ aliases.get(key) ||
+ defaultVisualization
+ );
+};
+
+let defaultVisualization: RegisteredVisualization;
+export function setDefaultVisualization(
+ visualization: RegisteredVisualization,
+) {
+ defaultVisualization = visualization;
+}
+
+function isVisualizationComponent(
+ visualization: RegisteredVisualization | undefined,
+) {
+ return typeof visualization === "function";
+}
+
+export function registerVisualization(visualization: RegisteredVisualization) {
+ if (visualization == null) {
+ throw new Error(t`Visualization is null`);
+ }
+ const identifier = visualization.identifier;
+ if (identifier == null) {
+ throw new Error(
+ t`Visualization must define an 'identifier' static variable: ` +
+ visualization.name,
+ );
+ }
+ if (visualizations.has(identifier)) {
+ const registeredVisualization = visualizations.get(identifier);
+ const isReplacingDefinitionWithComponent =
+ isVisualizationComponent(visualization) &&
+ !isVisualizationComponent(registeredVisualization);
+ const isRegisteringDefinitionOverComponent =
+ !isVisualizationComponent(visualization) &&
+ isVisualizationComponent(registeredVisualization);
+
+ if (isRegisteringDefinitionOverComponent) {
+ return;
+ }
+
+ if (!isReplacingDefinitionWithComponent) {
+ if (isStorybookActive) {
+ console.error(
+ `Visualization with that identifier is already registered: ` +
+ visualization.name,
+ );
+
+ // do not throw if it's storybook
+ return;
+ }
+
+ throw new Error(
+ t`Visualization with that identifier is already registered: ` +
+ visualization.name,
+ );
+ }
+ }
+ visualizations.set(identifier, visualization);
+ for (const alias of visualization.aliases || []) {
+ aliases.set(alias, visualization);
+ }
+}
+
+export function registerSettingWidgets(
+ widgets: Record<string, ComponentType<any>>,
+) {
+ for (const [key, widget] of Object.entries(widgets)) {
+ settingWidgets.set(key, widget);
+ }
+}
+
+export function getSettingWidgetComponent(key: string) {
+ return settingWidgets.get(key);
+}
+
+type SeriesLike = Array<{ card: { display: VisualizationDisplay } }>;
+
+export function getVisualization(display: VisualizationDisplay | null) {
+ return display ? visualizations.get(display) : defaultVisualization;
+}
+
+export function getVisualizationRaw(
+ series: SeriesLike,
+): RegisteredVisualization | undefined {
+ return visualizations.get(series[0].card.display);
+}
+
+export function getIconForVisualizationType(display: VisualizationDisplay): {
+ name: IconName;
+ iconUrl?: string;
+} {
+ const viz = visualizations.get(display);
+ return {
+ name: viz?.iconName ?? "unknown",
+ iconUrl: viz?.iconUrl,
+ };
+}
+
+export function getMaxMetricsSupported(display: VisualizationDisplay) {
+ const visualization = visualizations.get(display);
+ return visualization?.maxMetricsSupported || Infinity;
+}
+
+export function getMaxDimensionsSupported(display: VisualizationDisplay) {
+ const visualization = visualizations.get(display);
+ return visualization?.maxDimensionsSupported || 2;
+}
+
+export function canSavePng(display: VisualizationDisplay) {
+ const visualization = visualizations.get(display);
+ return visualization?.canSavePng ?? true;
+}
+
+export function getDefaultSize(display: VisualizationDisplay) {
+ const visualization = visualizations.get(display);
+ return visualization?.defaultSize;
+}
+
+export function getVisualizationTransformed(
+ series: RawSeries | TransformedSeries,
+) {
+ // don't transform if we don't have the data
+ if (
+ _.any(series, (s) => s.data == null) ||
+ _.any(series, (s) => s.error != null)
+ ) {
+ return {
+ series,
+ visualization: getVisualizationRaw(series),
+ };
+ }
+
+ // if a visualization has a transformSeries function, do the transformation until it returns the same visualization / series
+ let visualization, lastSeries;
+ do {
+ visualization = visualizations.get(series[0].card.display);
+ if (!visualization) {
+ throw new Error(t`No visualization for ${series[0].card.display}`);
+ }
+ lastSeries = series;
+ if (typeof visualization.transformSeries === "function") {
+ series = visualization.transformSeries(series);
+ }
+ if (series !== lastSeries) {
+ series = Object.assign([...series], { _raw: lastSeries });
+ }
+ } while (series !== lastSeries);
+
+ return { series, visualization };
+}
+
+export function isCartesianChart(display: VisualizationDisplay) {
+ const visualization = visualizations.get(display);
+ const settingNames = Object.keys(visualization?.settings ?? {});
+ return (
+ settingNames.includes("graph.dimensions") &&
+ settingNames.includes("graph.metrics")
+ );
+}
diff --git a/frontend/src/metabase/visualizations/lib/remapping.ts b/frontend/src/metabase/visualizations/lib/remapping.ts
new file mode 100644
index 00000000000..3d90960c2e3
--- /dev/null
+++ b/frontend/src/metabase/visualizations/lib/remapping.ts
@@ -0,0 +1,53 @@
+import _ from "underscore";
+
+import type { RemappingHydratedDatasetColumn } from "metabase/visualizations/types";
+import type { DatasetData, Series } from "metabase-types/api";
+
+// removes columns with `remapped_from` property and adds a `remapping` to the appropriate column
+export const extractRemappedColumns = (data: DatasetData) => {
+ const cols: RemappingHydratedDatasetColumn[] = data.cols.map((col) => ({
+ ...col,
+ remapped_from_index:
+ col.remapped_from != null
+ ? _.findIndex(data.cols, (c) => c.name === col.remapped_from)
+ : undefined,
+ remapping: col.remapped_to != null ? new Map() : undefined,
+ }));
+
+ const rows = data.rows.map((row) =>
+ row.filter((value, colIndex) => {
+ const col = cols[colIndex];
+ if (col.remapped_from != null) {
+ if (
+ col.remapped_from_index == null ||
+ !cols[col.remapped_from_index] ||
+ !cols[col.remapped_from_index].remapping
+ ) {
+ console.warn("Invalid remapped_from", col);
+ return true;
+ }
+ cols[col.remapped_from_index].remapped_to_column = col;
+ cols[col.remapped_from_index].remapping?.set(
+ row[col.remapped_from_index],
+ row[colIndex],
+ );
+ return false;
+ } else {
+ return true;
+ }
+ }),
+ );
+ return {
+ ...data,
+ rows,
+ cols: cols.filter((col) => col.remapped_from == null),
+ };
+};
+
+export const extractRemappings = (series: Series) => {
+ const se = series.map((s) => ({
+ ...s,
+ data: s.data && extractRemappedColumns(s.data),
+ }));
+ return se;
+};
diff --git a/frontend/src/metabase/visualizations/lib/sensibility.ts b/frontend/src/metabase/visualizations/lib/sensibility.ts
index 4956bc063c3..7621e28f091 100644
--- a/frontend/src/metabase/visualizations/lib/sensibility.ts
+++ b/frontend/src/metabase/visualizations/lib/sensibility.ts
@@ -1,8 +1,5 @@
import _ from "underscore";
-import visualizations, {
- type RegisteredVisualization,
-} from "metabase/visualizations";
import { getSeriesWithDisplay } from "metabase/visualizations/lib/series";
import { getComputedSettingsForSeries } from "metabase/visualizations/lib/settings/visualization";
import { sanitizeResultData } from "metabase/visualizations/shared/utils/data";
@@ -27,6 +24,7 @@ import {
} from "metabase-types/api";
import { isCustomVizDisplay } from "metabase-types/guards/visualization";
+import { type RegisteredVisualization, visualizations } from "./registry";
import { DEFAULT_VIZ_ORDER } from "./viz-order";
const MAX_RECOMMENDED = 12;
diff --git a/frontend/src/metabase/visualizations/lib/settings/column.ts b/frontend/src/metabase/visualizations/lib/settings/column.ts
index f2af637de9d..0386344c712 100644
--- a/frontend/src/metabase/visualizations/lib/settings/column.ts
+++ b/frontend/src/metabase/visualizations/lib/settings/column.ts
@@ -55,7 +55,7 @@ import type {
VisualizationSettings,
} from "metabase-types/api";
-import { getVisualization, getVisualizationRaw } from "../..";
+import { getVisualization, getVisualizationRaw } from "../registry";
import { nestedSettings } from "./nested";
diff --git a/frontend/src/metabase/visualizations/lib/settings/graph.ts b/frontend/src/metabase/visualizations/lib/settings/graph.ts
index 7a8500ea827..9d979a4dc50 100644
--- a/frontend/src/metabase/visualizations/lib/settings/graph.ts
+++ b/frontend/src/metabase/visualizations/lib/settings/graph.ts
@@ -2,12 +2,6 @@ import { t } from "ttag";
import _ from "underscore";
import { color } from "metabase/ui/colors";
-import {
- getMaxDimensionsSupported,
- getMaxMetricsSupported,
-} from "metabase/visualizations";
-import { trackStackedSeriesEnabled } from "metabase/visualizations/analytics";
-import { dimensionIsNumeric } from "metabase/visualizations/lib/numeric";
import { columnSettings } from "metabase/visualizations/lib/settings/column";
import { seriesSetting } from "metabase/visualizations/lib/settings/series";
import { getOptionFromColumn } from "metabase/visualizations/lib/settings/utils";
@@ -57,10 +51,13 @@ import { getColumnKey } from "metabase-lib/v1/queries/utils/column-key";
import { isNumeric } from "metabase-lib/v1/types/utils/isa";
import type { Series, VisualizationDisplay } from "metabase-types/api";
+import { trackStackedSeriesEnabled } from "../../analytics";
import type {
ChartSettingEnumToggleProps,
ChartSettingSegmentedControlProps,
} from "../../types/widget-props";
+import { dimensionIsNumeric } from "../numeric";
+import { getMaxDimensionsSupported, getMaxMetricsSupported } from "../registry";
export const getSeriesDisplays = (
transformedSeries: Series,
diff --git a/frontend/src/metabase/visualizations/lib/settings/typed-utils.ts b/frontend/src/metabase/visualizations/lib/settings/typed-utils.ts
index 3ec1174c8e0..d43bb438fc1 100644
--- a/frontend/src/metabase/visualizations/lib/settings/typed-utils.ts
+++ b/frontend/src/metabase/visualizations/lib/settings/typed-utils.ts
@@ -1,7 +1,6 @@
import { getIn } from "icepick";
import _ from "underscore";
-import { getVisualization } from "metabase/visualizations";
import type {
VisualizationSettingDefinition,
VisualizationSettingsDefinitions,
@@ -13,6 +12,8 @@ import type {
VisualizationSettings,
} from "metabase-types/api";
+import { getVisualization } from "../registry";
+
// Merge two settings objects together.
// Settings from the second argument take precedence over the first.
export function mergeSettings(
diff --git a/frontend/src/metabase/visualizations/lib/settings/typed-utils.unit.spec.ts b/frontend/src/metabase/visualizations/lib/settings/typed-utils.unit.spec.ts
index 26ed269aa13..7788d4d60dc 100644
--- a/frontend/src/metabase/visualizations/lib/settings/typed-utils.unit.spec.ts
+++ b/frontend/src/metabase/visualizations/lib/settings/typed-utils.unit.spec.ts
@@ -1,10 +1,11 @@
-import { registerVisualization } from "metabase/visualizations";
import { BarChart } from "metabase/visualizations/visualizations/BarChart";
import {
createMockCard,
createMockTableColumnOrderSetting,
} from "metabase-types/api/mocks";
+import { registerVisualization } from "../registry";
+
import {
extendCardWithDashcardSettings,
mergeSettings,
diff --git a/frontend/src/metabase/visualizations/lib/settings/visualization.ts b/frontend/src/metabase/visualizations/lib/settings/visualization.ts
index 2efa5036f6a..8a6799d1b1d 100644
--- a/frontend/src/metabase/visualizations/lib/settings/visualization.ts
+++ b/frontend/src/metabase/visualizations/lib/settings/visualization.ts
@@ -2,7 +2,6 @@ import { assocIn } from "icepick";
import { t } from "ttag";
import { isVirtualDashCard } from "metabase/utils/dashboard";
-import { getVisualizationRaw } from "metabase/visualizations";
import { trackCardSetToHideWhenNoResults } from "metabase/visualizations/lib/settings/analytics";
import type {
ComputedVisualizationSettings,
@@ -16,6 +15,7 @@ import type {
VisualizationSettings,
} from "metabase-types/api";
+import { getVisualizationRaw } from "../registry";
import {
getComputedSettings,
getPersistableDefaultSettings,
diff --git a/frontend/src/metabase/visualizations/shared/settings/cartesian-chart.ts b/frontend/src/metabase/visualizations/shared/settings/cartesian-chart.ts
index 286ee951c3a..d23842f8ef2 100644
--- a/frontend/src/metabase/visualizations/shared/settings/cartesian-chart.ts
+++ b/frontend/src/metabase/visualizations/shared/settings/cartesian-chart.ts
@@ -2,10 +2,6 @@ import { t } from "ttag";
import _ from "underscore";
import { isNotNull } from "metabase/utils/types";
-import {
- getMaxDimensionsSupported,
- getMaxMetricsSupported,
-} from "metabase/visualizations";
import {
getCardsColumns,
getCardsReferencedColumns,
@@ -36,6 +32,11 @@ import type {
VisualizationDisplay,
} from "metabase-types/api";
+import {
+ getMaxDimensionsSupported,
+ getMaxMetricsSupported,
+} from "../../lib/registry";
+
export function getDefaultDimensionFilter(display: string) {
return display === "scatter" ? isAny : isDimension;
}
diff --git a/frontend/src/metabase/visualizer/components/VisualizationPicker/VisualizationPicker.tsx b/frontend/src/metabase/visualizer/components/VisualizationPicker/VisualizationPicker.tsx
index 77a03e955da..0f78350dcef 100644
--- a/frontend/src/metabase/visualizer/components/VisualizationPicker/VisualizationPicker.tsx
+++ b/frontend/src/metabase/visualizer/components/VisualizationPicker/VisualizationPicker.tsx
@@ -2,7 +2,7 @@ import { useMemo } from "react";
import { EntityIcon } from "metabase/common/components/EntityIcon";
import { Center, SegmentedControl } from "metabase/ui";
-import visualizations from "metabase/visualizations";
+import { visualizations } from "metabase/visualizations";
import type { VisualizationDisplay } from "metabase-types/api";
import { trackVisualizerDataChanged } from "../analytics";
diff --git a/frontend/src/metabase/visualizer/utils/dashboard-card-supports-visualizer.ts b/frontend/src/metabase/visualizer/utils/dashboard-card-supports-visualizer.ts
index 1289c16d87b..e69f8fc3a05 100644
--- a/frontend/src/metabase/visualizer/utils/dashboard-card-supports-visualizer.ts
+++ b/frontend/src/metabase/visualizer/utils/dashboard-card-supports-visualizer.ts
@@ -1,4 +1,4 @@
-import visualizations from "metabase/visualizations";
+import { visualizations } from "metabase/visualizations";
import type { VisualizationDisplay } from "metabase-types/api";
export const DEFAULT_VISUALIZER_DISPLAY = "bar";