Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Guard v60 dependency_status data migrations against missing source columns (#74463)

Eric Normand4809d20eae04
diff --git a/resources/migrations/060/20260402_dependency_status.yaml b/resources/migrations/060/20260402_dependency_status.yaml
index bcc59af98ca..7fc668b339c 100644
--- a/resources/migrations/060/20260402_dependency_status.yaml
+++ b/resources/migrations/060/20260402_dependency_status.yaml
@@ -105,6 +105,12 @@ databaseChangeLog:
id: v60.2026-04-02T00:00:03
author: ericnormand
comment: Migrate dependency_analysis_version from report_card to dependency_status
+ validCheckSum: ANY
+ preConditions:
+ - onFail: MARK_RAN
+ - columnExists:
+ tableName: report_card
+ columnName: dependency_analysis_version
changes:
- sql:
sql: >-
@@ -118,6 +124,12 @@ databaseChangeLog:
id: v60.2026-04-02T00:00:04
author: ericnormand
comment: Migrate dependency_analysis_version from transform to dependency_status
+ validCheckSum: ANY
+ preConditions:
+ - onFail: MARK_RAN
+ - columnExists:
+ tableName: transform
+ columnName: dependency_analysis_version
changes:
- sql:
sql: >-
@@ -131,6 +143,12 @@ databaseChangeLog:
id: v60.2026-04-02T00:00:05
author: ericnormand
comment: Migrate dependency_analysis_version from native_query_snippet to dependency_status
+ validCheckSum: ANY
+ preConditions:
+ - onFail: MARK_RAN
+ - columnExists:
+ tableName: native_query_snippet
+ columnName: dependency_analysis_version
changes:
- sql:
sql: >-
@@ -144,6 +162,12 @@ databaseChangeLog:
id: v60.2026-04-02T00:00:06
author: ericnormand
comment: Migrate dependency_analysis_version from report_dashboard to dependency_status
+ validCheckSum: ANY
+ preConditions:
+ - onFail: MARK_RAN
+ - columnExists:
+ tableName: report_dashboard
+ columnName: dependency_analysis_version
changes:
- sql:
sql: >-
@@ -157,6 +181,12 @@ databaseChangeLog:
id: v60.2026-04-02T00:00:07
author: ericnormand
comment: Migrate dependency_analysis_version from document to dependency_status
+ validCheckSum: ANY
+ preConditions:
+ - onFail: MARK_RAN
+ - columnExists:
+ tableName: document
+ columnName: dependency_analysis_version
changes:
- sql:
sql: >-
@@ -170,6 +200,12 @@ databaseChangeLog:
id: v60.2026-04-02T00:00:08
author: ericnormand
comment: Migrate dependency_analysis_version from sandboxes to dependency_status
+ validCheckSum: ANY
+ preConditions:
+ - onFail: MARK_RAN
+ - columnExists:
+ tableName: sandboxes
+ columnName: dependency_analysis_version
changes:
- sql:
sql: >-
@@ -183,6 +219,12 @@ databaseChangeLog:
id: v60.2026-04-02T00:00:09
author: ericnormand
comment: Migrate dependency_analysis_version from segment to dependency_status
+ validCheckSum: ANY
+ preConditions:
+ - onFail: MARK_RAN
+ - columnExists:
+ tableName: segment
+ columnName: dependency_analysis_version
changes:
- sql:
sql: >-
@@ -196,6 +238,12 @@ databaseChangeLog:
id: v60.2026-04-02T00:00:10
author: ericnormand
comment: Migrate dependency_analysis_version from measure to dependency_status
+ validCheckSum: ANY
+ preConditions:
+ - onFail: MARK_RAN
+ - columnExists:
+ tableName: measure
+ columnName: dependency_analysis_version
changes:
- sql:
sql: >-
diff --git a/test/metabase/app_db/schema_migrations_test.clj b/test/metabase/app_db/schema_migrations_test.clj
index 3d1368e085a..02a1133e123 100644
--- a/test/metabase/app_db/schema_migrations_test.clj
+++ b/test/metabase/app_db/schema_migrations_test.clj
@@ -2932,6 +2932,17 @@
:created_at :%now
:updated_at :%now}))))))))
+(deftest dependency-status-segment-handles-missing-column-migration-test
+ (testing "Migration v60.2026-04-02T00:00:09 MARK_RANs when segment.dependency_analysis_version is missing (issue #74443)"
+ (impl/test-migrations ["v60.2026-04-02T00:00:09" "v60.2026-04-02T00:00:09"] [migrate!]
+ ;; Simulate the broken partial-migration state: source column gone before the data-migration runs.
+ (t2/query "ALTER TABLE segment DROP COLUMN dependency_analysis_version")
+ (migrate!)
+ (testing "T00:00:09 is recorded as MARK_RAN"
+ (is (= "MARK_RAN"
+ (:exectype (liquibase/changelog-by-id mdb.connection/*application-db*
+ "v60.2026-04-02T00:00:09"))))))))
+
;;;
;;; 62 tests
;;;