The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
fix: have metabot fix it button sometimes disappears (#74531)
Maksym Yakubych482e74de5513
diff --git a/frontend/src/metabase/querying/components/QueryVisualization/QueryVisualization.jsx b/frontend/src/metabase/querying/components/QueryVisualization/QueryVisualization.jsxindex c0c2d19f6f7..a882470592a 100644--- a/frontend/src/metabase/querying/components/QueryVisualization/QueryVisualization.jsx+++ b/frontend/src/metabase/querying/components/QueryVisualization/QueryVisualization.jsx@@ -87,7 +87,6 @@ export function QueryVisualization(props) {via={result.via}question={question}duration={result.duration}- isResultDirty={isResultDirty}/>) : result?.data ? (<VisualizationResultdiff --git a/frontend/src/metabase/querying/components/QueryVisualization/VisualizationError/VisualizationError.tsx b/frontend/src/metabase/querying/components/QueryVisualization/VisualizationError/VisualizationError.tsxindex 5420d658a05..172759694d9 100644--- a/frontend/src/metabase/querying/components/QueryVisualization/VisualizationError/VisualizationError.tsx+++ b/frontend/src/metabase/querying/components/QueryVisualization/VisualizationError/VisualizationError.tsx@@ -32,7 +32,6 @@ interface VisualizationErrorProps {duration: number;error: DatasetError;errorType?: DatasetErrorType;- isResultDirty?: boolean;}export function VisualizationError({@@ -42,7 +41,6 @@ export function VisualizationError({duration,error,errorType,- isResultDirty,}: VisualizationErrorProps) {const query = question.query();const showMetabaseLinks = useSelector(getShowMetabaseLinks);@@ -150,7 +148,7 @@ export function VisualizationError({{t`Learn how to debug SQL errors`}</ExternalLink>)}- {!isResultDirty && <FixSqlQueryButton />}+ <FixSqlQueryButton /></Flex></Flex></Box>diff --git a/frontend/src/metabase/querying/components/QueryVisualization/VisualizationError/tests/premium.unit.spec.ts b/frontend/src/metabase/querying/components/QueryVisualization/VisualizationError/tests/premium.unit.spec.tsindex de41ff97798..e9fd99b6133 100644--- a/frontend/src/metabase/querying/components/QueryVisualization/VisualizationError/tests/premium.unit.spec.ts+++ b/frontend/src/metabase/querying/components/QueryVisualization/VisualizationError/tests/premium.unit.spec.ts@@ -51,6 +51,23 @@ describe("VisualizationError (EE with token)", () => {screen.queryByText("Learn how to debug SQL errors"),).not.toBeInTheDocument();});++ it("should show the Metabot fix button", async () => {+ const card = createMockCard({+ dataset_query: {+ database: database.id,+ type: "native",+ native: {+ query: "SELECT * FROM ORDERS",+ },+ },+ });+ setup({ database, card });++ expect(+ await screen.findByRole("button", { name: /Have Metabot fix it/ }),+ ).toBeInTheDocument();+ });});describe("NoSQL databases", () => {