Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Move range-for-value into value (#70622)

Fraser49a3037d2a8a
diff --git a/frontend/src/metabase-lib/v1/queries/utils/range-for-value.ts b/frontend/src/metabase-lib/v1/queries/utils/range-for-value.ts
deleted file mode 100644
index bdbee7d26f3..00000000000
--- a/frontend/src/metabase-lib/v1/queries/utils/range-for-value.ts
+++ /dev/null
@@ -1,10 +0,0 @@
-import type { DatasetColumn } from "metabase-types/api";
-
-/**
- * @returns min and max for a value in a column
- */
-export const rangeForValue = (value: unknown, column: DatasetColumn) => {
- if (typeof value === "number" && column?.binning_info?.bin_width) {
- return [value, value + column.binning_info.bin_width];
- }
-};
diff --git a/frontend/src/metabase/lib/formatting/value.tsx b/frontend/src/metabase/lib/formatting/value.tsx
index 27c78415365..8197402abac 100644
--- a/frontend/src/metabase/lib/formatting/value.tsx
+++ b/frontend/src/metabase/lib/formatting/value.tsx
@@ -12,7 +12,6 @@ import {
clickBehaviorIsValid,
getDataFromClicked,
} from "metabase-lib/v1/parameters/utils/click-behavior";
-import { rangeForValue } from "metabase-lib/v1/queries/utils/range-for-value";
import {
isBoolean,
isCoordinate,
@@ -22,6 +21,7 @@ import {
isTime,
isURL,
} from "metabase-lib/v1/types/utils/isa";
+import type { DatasetColumn } from "metabase-types/api";
import { formatDateTimeWithUnit, formatRange } from "./date";
import { formatEmail } from "./email";
@@ -241,6 +241,12 @@ export function formatValueRaw(
}
}
+function rangeForValue(value: unknown, column: DatasetColumn) {
+ if (typeof value === "number" && column?.binning_info?.bin_width) {
+ return [value, value + column.binning_info.bin_width];
+ }
+}
+
function isDateValue(value: unknown): value is Date {
return Object.prototype.toString.call(value) === "[object Date]";
}