The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
BEGUILD-37: Ratchet dynamic vars with a kondo linter (#82995)
Eric Normand4a463e69eb15
diff --git a/.clj-kondo/config.edn b/.clj-kondo/config.ednindex 97155c9c939..1e08c0c3a7d 100644--- a/.clj-kondo/config.edn+++ b/.clj-kondo/config.edn@@ -65,6 +65,7 @@:metabase/check-testing-not-empty {:level :warning}:metabase/defsetting-must-specify-export {:level :warning}:metabase/defsetting-namespace {:level :warning}+ :metabase/discourage-dynamic-vars {:level :warning}:metabase/discourage-millis-duration {:level :warning}:metabase/mbql-query-first-arg {:level :warning}:metabase/missing-test-expr-requires-in-cljs {:level :warning}@@ -588,7 +589,11 @@:hooks{:analyze-call- {cljs.test/deftest hooks.clojure.test/deftest+ {cljs.core/def hooks.clojure.core.def/lint-dynamic+ cljs.core/defn hooks.clojure.core.def/lint-dynamic+ cljs.core/defn- hooks.clojure.core.def/lint-dynamic+ cljs.core/defonce hooks.clojure.core.def/lint-dynamic+ cljs.test/deftest hooks.clojure.test/deftestcljs.test/is hooks.clojure.test/iscljs.test/testing hooks.clojure.test/testingcljs.test/use-fixtures hooks.clojure.test/use-fixtures@@ -803,7 +808,11 @@metabase.util.log/tracef hooks.metabase.util.log/infofmetabase.util.log/warn hooks.metabase.util.log/infometabase.util.log/warnf hooks.metabase.util.log/infof+ metabase.util.malli.defn/defn hooks.clojure.core.def/lint-dynamic+ metabase.util.malli.defn/defn- hooks.clojure.core.def/lint-dynamicmetabase.util.malli.registry/def hooks.metabase.util.malli.registry/def+ metabase.util.malli/defn hooks.clojure.core.def/lint-dynamic+ metabase.util.malli/defn- hooks.clojure.core.def/lint-dynamicmetabase.util.match/match-one hooks.metabase.util.match/match-onemetabase.util.match/match-many hooks.metabase.util.match/match-manymetabase.util.match/matches? hooks.metabase.util.match/matches?diff --git a/.clj-kondo/ratchets.edn b/.clj-kondo/ratchets.ednindex 8a16341cb6c..11e96cc5abf 100644--- a/.clj-kondo/ratchets.edn+++ b/.clj-kondo/ratchets.edn@@ -22,6 +22,7 @@:equals-true 1:main-without-gen-class 1:metabase/disallow-hardcoded-driver-names-in-tests 34+ :metabase/discourage-dynamic-vars 395:metabase/discourage-millis-duration 1:metabase/i-like-making-cams-eyes-bleed-with-horrifically-long-tests 13:metabase/modules 24@@ -76,6 +77,7 @@:comment-exempt #{:deprecated-namespace:discouraged-namespace:discouraged-var+ :metabase/discourage-dynamic-vars:metabase/modules:metabase/validate-defendpoint-has-response-schema:metabase/validate-defendpoint-query-params-use-kebab-casediff --git a/.clj-kondo/src/hooks/clojure/core/def.clj b/.clj-kondo/src/hooks/clojure/core/def.cljindex 2557f02eda6..6bee88711d6 100644--- a/.clj-kondo/src/hooks/clojure/core/def.clj+++ b/.clj-kondo/src/hooks/clojure/core/def.clj@@ -32,14 +32,60 @@:message "Use kebab-case names for functions and variables. [:metabase/check-def-no-underscores]":type :metabase/check-def-no-underscores)))))+(defn- attr-map+ "The attr-map of a `defn`-like form, which Clojure merges into the var metadata, or nil.+ A map in a `def` or `defonce` is the value, not an attr-map."+ [node]+ (let [[head _name & args] (:children node)]+ (when-not (#{"def" "defonce"} (name (hooks/sexpr head)))+ (loop [[arg & more :as args] args]+ (cond+ (hooks/string-node? arg) (recur more)+ ;; a Malli `:- schema` return annotation+ (and (hooks/keyword-node? arg) (= :- (hooks/sexpr arg))) (recur (rest more))+ (hooks/map-node? arg) (hooks/sexpr arg)+ ;; a multi-arity body can end with a trailing attr-map+ (hooks/list-node? arg) (let [trailing (last args)]+ (when (hooks/map-node? trailing)+ (hooks/sexpr trailing))))))))++(defn- dynamic?+ "Whether the var defined by `def-node` is dynamic, through metadata on `symbol-node` or a `defn` attr-map."+ [def-node symbol-node]+ (or (some (fn [meta-node]+ (let [m (hooks/sexpr meta-node)]+ (or (= m :dynamic)+ (and (map? m) (true? (:dynamic m))))))+ (:meta symbol-node))+ (true? (:dynamic (attr-map def-node)))))++(defn- check-symbol-is-not-dynamic [def-node symbol-node]+ (when (dynamic? def-node symbol-node)+ ;; Report on the form, not the name: `kondo-insert-ignores` puts the ignore on the line above the finding,+ ;; and the line above the name can be inside the form, where an ignore has no effect.+ (hooks/reg-finding!+ (assoc (meta def-node)+ :message "Avoid new dynamic vars; pass the value as an argument or hang it on a stateful component. [:metabase/discourage-dynamic-vars]"+ :type :metabase/discourage-dynamic-vars))))++(defn- name-symbol [node]+ (let [[_def & args] (:children node)]+ (some (fn [arg]+ (when (and (hooks/token-node? arg)+ (symbol? (hooks/sexpr arg)))+ arg))+ args)))+(defn lint-def* [{:keys [node]}]- (let [[_def & args] (:children node)- name-symbol (some (fn [arg]- (when (and (hooks/token-node? arg)- (symbol? (hooks/sexpr arg)))- arg))- args)]- (check-symbol-is-kebab-case name-symbol)))+ (let [symbol-node (name-symbol node)]+ (check-symbol-is-kebab-case symbol-node)+ (check-symbol-is-not-dynamic node symbol-node)))++(defn lint-dynamic+ "Hook for def-like macros that should get only the dynamic-var check. Leaves the node unchanged."+ [{:keys [node]}]+ (check-symbol-is-not-dynamic node (name-symbol node))+ nil)(defn lint-def [x](lint-def* x)diff --git a/.clj-kondo/test/hooks/clojure/core/def_test.clj b/.clj-kondo/test/hooks/clojure/core/def_test.cljnew file mode 100644index 00000000000..53e08be4042--- /dev/null+++ b/.clj-kondo/test/hooks/clojure/core/def_test.clj@@ -0,0 +1,82 @@+(ns hooks.clojure.core.def-test+ (:require+ [clj-kondo.core :as kondo]+ [clj-kondo.hooks-api :as hooks]+ [clj-kondo.impl.utils]+ [clojure.test :refer :all]+ [hooks.clojure.core.def]))++(defn- lint-def+ "Lint the def form in string `s`. A string, not a quoted form, because `pr-str` drops `^:dynamic`."+ [s]+ (binding [clj-kondo.impl.utils/*ctx* {:config {:linters {:metabase/discourage-dynamic-vars {:level :warning}}}+ :ignores (atom nil)+ :findings (atom [])+ :namespaces (atom {})}]+ (hooks.clojure.core.def/lint-def {:node (hooks/parse-string s)})+ @(:findings clj-kondo.impl.utils/*ctx*)))++(defn- config-findings+ "Lint string `s` as `lang` with the real `.clj-kondo` config and return the findings whose type is in `types`."+ [types lang s]+ (->> (with-in-str s (kondo/run! {:lint ["-"] :lang lang :config-dir ".clj-kondo" :cache false}))+ :findings+ (filter (comp types :type))))++(deftest ^:parallel discourage-dynamic-vars-test+ (testing "BEGUILD-37: new dynamic vars are flagged so the ratchet budget stops them from growing"+ (are [s] (=? [{:type :metabase/discourage-dynamic-vars}]+ (lint-def s))+ "(def ^:dynamic *x* nil)"+ "(def ^:private ^:dynamic *x* nil)"+ "(def ^:dynamic ^:private *x* nil)"+ "(def ^{:dynamic true} *x* nil)"+ "(def ^{:private true, :dynamic true} *x* nil)"+ "(def ^:dynamic *x* \"docstring\" nil)"+ "(defonce ^:dynamic *x* nil)"+ "(defn f {:dynamic true} [] nil)"+ "(defn f \"docstring\" {:dynamic true} [] nil)"+ "(defn f \"docstring\" ([] 1) ([a] a) {:dynamic true})"+ "(mu/defn f :- :int \"docstring\" {:dynamic true} [] 1)")))++(deftest ^:parallel discourage-dynamic-vars-location-test+ (testing "the finding sits on the form, so `kondo-insert-ignores` puts the ignore above the form, not inside it"+ (is (=? [{:row 1 :col 1}]+ (lint-def "(def ^{:dynamic true\n :doc \"docs\"}\n *x*\n nil)")))))++(deftest ^:parallel discourage-dynamic-vars-ok-test+ (testing "non-dynamic defs are not flagged"+ (are [s] (= [] (lint-def s))+ "(def x nil)"+ "(def ^:private x nil)"+ "(def ^{:dynamic false} x nil)"+ "(def ^{:private true} x nil)"+ "(def x {:dynamic true})"+ "(defonce x {:dynamic true})"+ "(clojure.core/def x {:dynamic true})"+ "(clojure.core/defonce x {:dynamic true})"+ "(cljs.core/defonce x {:dynamic true})"+ "(defn f {:private true} [] nil)"+ "(defn f [] {:dynamic true})"+ "(defn f ([] 1) ([a] {:dynamic true}))")))++(deftest ^:synchronized discourage-dynamic-vars-config-test+ (testing "BEGUILD-37: config.edn sends defn, the mu/defn variants, and cljs defs to the dynamic-var check"+ (are [lang s] (=? [{:row 1}] (config-findings #{:metabase/discourage-dynamic-vars} lang s))+ :clj "(ns x) (defn ^:dynamic *f* [] nil)"+ :clj "(ns x (:require [metabase.util.malli :as mu])) (mu/defn ^:dynamic *f* :- :int [] 1)"+ :clj "(ns x (:require [metabase.util.malli :as mu])) (mu/defn- ^:dynamic *f* :- :int [] 1)"+ :clj "(ns x (:require [metabase.util.malli.defn :as mu.defn])) (mu.defn/defn ^:dynamic *f* :- :int [] 1)"+ :clj "(ns x (:require [metabase.util.malli.defn :as mu.defn])) (mu.defn/defn- ^:dynamic *f* :- :int [] 1)"+ :cljs "(ns x) (def ^:dynamic *x* 1)"+ :cljs "(ns x) (defn ^:dynamic *f* [] nil)"+ :cljs "(ns x) (defn- ^:dynamic *f* [] nil)"+ :cljs "(ns x) (defonce ^:dynamic *x* 1)"+ :cljc "(ns x) #?(:cljs (def ^:dynamic *x* 1))")))++(deftest ^:synchronized discourage-dynamic-vars-naming-checks-test+ (testing "lint-dynamic runs only the dynamic check, not the def naming checks"+ (are [lang s] (= [] (config-findings #{:metabase/check-def-no-underscores :metabase/check-def-check-not-uppercase-name}+ lang s))+ :clj "(ns x (:require [metabase.util.malli :as mu])) (mu/defn SOME_FN :- :string [x :- :int] (str x))"+ :cljs "(ns x) (def SOME_VALUE 1)")))diff --git a/bin/build/src/build_drivers/common.clj b/bin/build/src/build_drivers/common.cljindex 47e41ef1088..230b811ffa5 100644--- a/bin/build/src/build_drivers/common.clj+++ b/bin/build/src/build_drivers/common.clj@@ -3,10 +3,12 @@[clojure.tools.deps.alpha :as deps][metabuild-common.core :as u]))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *driver-project-dir*"Override [[driver-project-dir]]."nil)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *target-directory*"Override the target directory where we'll put the finished uberjar ([[driver-jar-destination-directory]])."nil)diff --git a/bin/build/src/metabuild_common/output.clj b/bin/build/src/metabuild_common/output.cljindex 21f4bcd16c9..0021fa984a7 100644--- a/bin/build/src/metabuild_common/output.clj+++ b/bin/build/src/metabuild_common/output.clj@@ -6,6 +6,7 @@(set! *warn-on-reflection* true)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *steps*"Vector of all the parent steps/substeps we're currently in the process of working on. (See [[metabuild-common.steps]]for more info."diff --git a/dev/src/dev/debug_qp.clj b/dev/src/dev/debug_qp.cljindex f162e5ad06c..d836f09d728 100644--- a/dev/src/dev/debug_qp.clj+++ b/dev/src/dev/debug_qp.clj@@ -65,6 +65,7 @@(compare (str x) (str y))(compare x-order y-order))))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *shorten-namespaced-keywords?*"Whether to shorten something like `:metabase.query-processor.util.add-alias-info/source-table` to`::add/source-table` if an alias exists for the keyword namespace in the current namespace ([[*ns*]])."@@ -148,8 +149,11 @@;; see docstring for [[process-query-debug]] for descriptions of what these do.+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *print-full?* true)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *print-metadata?* false)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *print-names?* true)(defn- remove-metadata@@ -248,6 +252,7 @@(println (format "[post] %s transformed row" middleware-var))(print-transform-result before after))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *printer* print-formatted-event);;;; [[to-mbql-shorthand]]diff --git a/dev/src/dev/deps_graph.clj b/dev/src/dev/deps_graph.cljindex 3ef0ccd78f4..5f7297633c2 100644--- a/dev/src/dev/deps_graph.clj+++ b/dev/src/dev/deps_graph.clj@@ -20,6 +20,7 @@;; Many functions in this namespace re-parse the same files over and over again during testing, so introduce a;; mechanism for bounded caching of those parsed files.+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *parsed-file-cache* nil)(def ^:private Filediff --git a/dev/src/dev/explain_analyze.clj b/dev/src/dev/explain_analyze.cljindex 706511faf4e..62d005a7a54 100644--- a/dev/src/dev/explain_analyze.clj+++ b/dev/src/dev/explain_analyze.clj@@ -21,6 +21,7 @@(set! *warn-on-reflection* true)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *analyze-query*"When bound to true, EXPLAIN ANALYZE will be run for each query executed by Toucan 2."false)diff --git a/dev/src/dev/kondo_ratchet.clj b/dev/src/dev/kondo_ratchet.cljindex ea53bf6fb2d..a9fd41c04a8 100644--- a/dev/src/dev/kondo_ratchet.clj+++ b/dev/src/dev/kondo_ratchet.clj@@ -13,10 +13,12 @@(set! *warn-on-reflection* true)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *ratchets-file*"Kondo budgets, relative to the repo root. Rebind to read a merge stage or test fixture."".clj-kondo/ratchets.edn")+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *module-ratchets-file*"Module-boundary budgets, relative to the repo root. Rebind to read a merge stage or test fixture."".clj-kondo/config/modules/ratchets.edn")@@ -287,7 +289,7 @@(def ^:private source-extensions[".clj" ".cljc" ".cljs"])-;; Concatenated so this file never contains a literal ignore marker.+;; Concatenated so the scan does not count this definition as an ignore.(def ^:private ignore-marker(str ":clj-kondo" "/ignore"))diff --git a/dev/src/dev/memory.clj b/dev/src/dev/memory.cljindex 26bb0b29e09..58a94fe61b4 100644--- a/dev/src/dev/memory.clj+++ b/dev/src/dev/memory.clj@@ -40,6 +40,7 @@(log/warnf "Allocated: %s" (mb-str (:allocations m#)))(:result m#)))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^{:dynamic true:private true} *memory-log-level* -1)diff --git a/dev/src/user.clj b/dev/src/user.cljindex ff43c249dda..80e9ff77d7b 100644--- a/dev/src/user.clj+++ b/dev/src/user.clj@@ -144,6 +144,7 @@(in-ns 'dev):loaded)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^{:dynamic true:doc "When true, the backend code will be reloaded on every request.This value is set by the `--hot` command line argument to the `:dev-start` alias."}diff --git a/dev/test/dev/n_plus_one_detection_test.clj b/dev/test/dev/n_plus_one_detection_test.cljindex 845724d6528..7ab345c8988 100644--- a/dev/test/dev/n_plus_one_detection_test.clj+++ b/dev/test/dev/n_plus_one_detection_test.clj@@ -11,6 +11,7 @@(let [v (:one (t2/query-one {:select [[1 :one]]}))](assoc row k v)))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *cached?* nil);; A simple hydration function that simulates caching. The first time it's called, it hits the database, but itdiff --git a/enterprise/backend/src/metabase_enterprise/action_v2/data_editing.clj b/enterprise/backend/src/metabase_enterprise/action_v2/data_editing.cljindex f380073b46a..eb30653cbda 100644--- a/enterprise/backend/src/metabase_enterprise/action_v2/data_editing.clj+++ b/enterprise/backend/src/metabase_enterprise/action_v2/data_editing.clj@@ -23,10 +23,12 @@"Queue used to recalculate the field values for updated columns in the background."(ArrayBlockingQueue. 1000))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *field-value-invalidate-queue*"A layer of indirection on the actual [[field-value-invalidation-queue]], for testing."nil)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *invalidate-select-batch-size*"Chunk size when fetching :model/Field rows for invalidation. Keeps a single SQL `IN (…)`clause well under the smallest driver parameter limit (Oracle: 1000, SQL Server: 2100)."diff --git a/enterprise/backend/src/metabase_enterprise/advanced_config/file.clj b/enterprise/backend/src/metabase_enterprise/advanced_config/file.cljindex ecc33c685c5..af771331b63 100644--- a/enterprise/backend/src/metabase_enterprise/advanced_config/file.clj+++ b/enterprise/backend/src/metabase_enterprise/advanced_config/file.clj@@ -132,6 +132,7 @@(s/assert* spec section-config))true)))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *supported-versions*"Range of config file versions (inclusive) that we'll support. If the version is out of this range, spec validationwill fail and trigger an error. See ns documentation for [[metabase.config.file]] for more details."@@ -147,6 +148,7 @@(s/keys :req-un [:metabase.config.file.config/version:metabase.config.file.config/config]))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *env*"Environment variables and system properties used in this namespace. This is a dynamic versionof [[environ.core/env]]; it is dynamic for test mocking purposes.diff --git a/enterprise/backend/src/metabase_enterprise/audit_app/query_processor/middleware/handle_audit_queries.clj b/enterprise/backend/src/metabase_enterprise/audit_app/query_processor/middleware/handle_audit_queries.cljindex 3c353372fb3..08f09977893 100644--- a/enterprise/backend/src/metabase_enterprise/audit_app/query_processor/middleware/handle_audit_queries.clj+++ b/enterprise/backend/src/metabase_enterprise/audit_app/query_processor/middleware/handle_audit_queries.clj@@ -125,6 +125,7 @@{:type qp.error-type/invalid-query:status-code 400}))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *additional-query-params*"Additional `internal` query params beyond `type`, `fn`, and `args`. These are bound to this dynamic var which is achance to do something clever outside of the normal function args. For example audit app uses `limit` and `offset`diff --git a/enterprise/backend/src/metabase_enterprise/cache/task/refresh_cache_configs.clj b/enterprise/backend/src/metabase_enterprise/cache/task/refresh_cache_configs.cljindex e8fb4fbb2bf..92017ab21fc 100644--- a/enterprise/backend/src/metabase_enterprise/cache/task/refresh_cache_configs.clj+++ b/enterprise/backend/src/metabase_enterprise/cache/task/refresh_cache_configs.clj@@ -31,10 +31,12 @@(doto (BasicThreadFactory$Builder.)(.namingPattern "preemptive-caching-thread-pool-%d"))))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *parameterized-queries-to-rerun-per-card*"Number of query variations (e.g. with different parameters) to run for a single cached card."10)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *run-cache-refresh-async*"Should cache refresh jobs be run asynchronously? Defaults to true, can be set to false for testing."true)diff --git a/enterprise/backend/src/metabase_enterprise/content_translation/dictionary.clj b/enterprise/backend/src/metabase_enterprise/content_translation/dictionary.cljindex 59dd1ca5a0a..d2065efe181 100644--- a/enterprise/backend/src/metabase_enterprise/content_translation/dictionary.clj+++ b/enterprise/backend/src/metabase_enterprise/content_translation/dictionary.clj@@ -14,6 +14,7 @@(set! *warn-on-reflection* true)(def ^:private http-status-unprocessable 422)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *header-adjustment* 0)(defn- translation-keydiff --git a/enterprise/backend/src/metabase_enterprise/database_routing/common.clj b/enterprise/backend/src/metabase_enterprise/database_routing/common.cljindex 879cd7f555e..21684d4fcc7 100644--- a/enterprise/backend/src/metabase_enterprise/database_routing/common.clj+++ b/enterprise/backend/src/metabase_enterprise/database_routing/common.clj@@ -11,6 +11,7 @@[db-or-id](database-routing.db/router-user-attribute (u/the-id db-or-id)))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic ^:private *database-routing-on* :unset)(defn- router-db-or-id->destination-db-id*diff --git a/enterprise/backend/src/metabase_enterprise/database_routing/middleware.clj b/enterprise/backend/src/metabase_enterprise/database_routing/middleware.cljindex 18935136913..66e9fda3ee1 100644--- a/enterprise/backend/src/metabase_enterprise/database_routing/middleware.clj+++ b/enterprise/backend/src/metabase_enterprise/database_routing/middleware.clj@@ -15,6 +15,7 @@[metabase.util :as u][metabase.util.i18n :refer [tru]]))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *destination-database-id*"Bound to the destination database id during query execution when DB routing has swapped in a destination DB.Mirrors the shape of [[metabase-enterprise.impersonation.driver/*impersonation-role*]]: analytics code reads itdiff --git a/enterprise/backend/src/metabase_enterprise/dependencies/models/analysis_finding.clj b/enterprise/backend/src/metabase_enterprise/dependencies/models/analysis_finding.cljindex 3a531cbcf5a..792cb8f6586 100644--- a/enterprise/backend/src/metabase_enterprise/dependencies/models/analysis_finding.clj+++ b/enterprise/backend/src/metabase_enterprise/dependencies/models/analysis_finding.clj@@ -25,6 +25,7 @@(and (contains? changes :result) (not (contains? changes :analyzed_at)))(assoc :analyzed_at (mi/now)))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *current-analysis-finding-version*"Current version of the query validation logic.This should be incremented when the analysis logic changes.diff --git a/enterprise/backend/src/metabase_enterprise/entity_retrieval/index_table.clj b/enterprise/backend/src/metabase_enterprise/entity_retrieval/index_table.cljindex 2f3b4d52150..81182f1e11a 100644--- a/enterprise/backend/src/metabase_enterprise/entity_retrieval/index_table.clj+++ b/enterprise/backend/src/metabase_enterprise/entity_retrieval/index_table.clj@@ -56,6 +56,7 @@{:vectors "library_entity_index":meta "library_entity_index_meta"})+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *tables*"Table names to use, or nil for [[default-tables]]. Bound by tests to isolated names."nil)diff --git a/enterprise/backend/src/metabase_enterprise/impersonation/driver.clj b/enterprise/backend/src/metabase_enterprise/impersonation/driver.cljindex 9b9b2b77e70..af607a3d992 100644--- a/enterprise/backend/src/metabase_enterprise/impersonation/driver.clj+++ b/enterprise/backend/src/metabase_enterprise/impersonation/driver.clj@@ -123,6 +123,7 @@(when-let [role (and api/*current-user-id* (connection-impersonation-role db-id))]{:role role}))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *impersonation-role*"Set by Impersonation middleware, via the query processor, to define the role that should be used by`set-role-if-supported!`. If not set (for example, when we're not in the context of a query) we'll compute itdiff --git a/enterprise/backend/src/metabase_enterprise/security_center/matching.clj b/enterprise/backend/src/metabase_enterprise/security_center/matching.cljindex 4e183847e60..6fe67e2af53 100644--- a/enterprise/backend/src/metabase_enterprise/security_center/matching.clj+++ b/enterprise/backend/src/metabase_enterprise/security_center/matching.clj@@ -56,6 +56,7 @@(or (get matching-query (mdb/db-type))(get matching-query :default)))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *query-timeout-seconds*"Maximum execution time in seconds for advisory matching queries."120)diff --git a/enterprise/backend/src/metabase_enterprise/semantic_search/embedding.clj b/enterprise/backend/src/metabase_enterprise/semantic_search/embedding.cljindex 3633909847c..0b9733a8ea7 100644--- a/enterprise/backend/src/metabase_enterprise/semantic_search/embedding.clj+++ b/enterprise/backend/src/metabase_enterprise/semantic_search/embedding.clj@@ -305,6 +305,7 @@(assoc % endpoint (new-embedder-circuit-breaker))))endpoint)))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *bypass-circuit-breaker*"Bind true to run an embedding call without consulting or tripping the breaker.The health probe binds it so the probe stays an independent signal and can't flip the breaker from insidediff --git a/enterprise/backend/src/metabase_enterprise/semantic_search/index.clj b/enterprise/backend/src/metabase_enterprise/semantic_search/index.cljindex 46bab180779..3e97b3b3a9d 100644--- a/enterprise/backend/src/metabase_enterprise/semantic_search/index.clj+++ b/enterprise/backend/src/metabase_enterprise/semantic_search/index.clj@@ -48,6 +48,7 @@[honey-sql & {:as opts}](sql/format honey-sql (merge opts {:quoted true})))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *batch-size*"The number of documents to process per batch when updating the index."150)@@ -396,6 +397,7 @@opts)))(merge-with + stats)))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *retrying* false)(defonce ^:privatediff --git a/enterprise/backend/src/metabase_enterprise/serialization/api.clj b/enterprise/backend/src/metabase_enterprise/serialization/api.cljindex c3fa0ebdebf..0827c015e42 100644--- a/enterprise/backend/src/metabase_enterprise/serialization/api.clj+++ b/enterprise/backend/src/metabase_enterprise/serialization/api.clj@@ -30,6 +30,7 @@(set! *warn-on-reflection* true)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *additive-logging*"If custom loggers should pass logs to parent loggers (to system Metabase logs), used to clean up test output."true)diff --git a/enterprise/backend/test/metabase_enterprise/database_routing/embedding_test.clj b/enterprise/backend/test/metabase_enterprise/database_routing/embedding_test.cljindex 72ad9c5a749..74150cc20c5 100644--- a/enterprise/backend/test/metabase_enterprise/database_routing/embedding_test.clj+++ b/enterprise/backend/test/metabase_enterprise/database_routing/embedding_test.clj@@ -14,6 +14,7 @@(defn random-embedding-secret-key [] (u.random/secure-hex 32))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *secret-key* nil)(defn sign [claims] (jwt/sign claims *secret-key*))diff --git a/enterprise/backend/test/metabase_enterprise/scim/v2/api_test.clj b/enterprise/backend/test/metabase_enterprise/scim/v2/api_test.cljindex d4c1d0e7bd0..5ba8f3ebfae 100644--- a/enterprise/backend/test/metabase_enterprise/scim/v2/api_test.clj+++ b/enterprise/backend/test/metabase_enterprise/scim/v2/api_test.clj@@ -12,6 +12,7 @@(use-fixtures :once (fixtures/initialize :test-users))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *scim-api-key* nil)(defn with-scim-setup-impl!diff --git a/enterprise/backend/test/metabase_enterprise/semantic_search/test_util.clj b/enterprise/backend/test/metabase_enterprise/semantic_search/test_util.cljindex 4a3b95306ad..26cd07beae5 100644--- a/enterprise/backend/test/metabase_enterprise/semantic_search/test_util.clj+++ b/enterprise/backend/test/metabase_enterprise/semantic_search/test_util.clj@@ -244,6 +244,7 @@mock-documents-for-embeddingsbase-embedding-vectors)))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *extra-mock-embeddings*"Dynamic var for test-specific mock embeddings. Merged with [[mock-embeddings]] in [[get-mock-embedding]]."nil)diff --git a/enterprise/backend/test/metabase_enterprise/semantic_search/vector_strategy_matrix_test.clj b/enterprise/backend/test/metabase_enterprise/semantic_search/vector_strategy_matrix_test.cljindex 922140c799b..b7343f86631 100644--- a/enterprise/backend/test/metabase_enterprise/semantic_search/vector_strategy_matrix_test.clj+++ b/enterprise/backend/test/metabase_enterprise/semantic_search/vector_strategy_matrix_test.clj@@ -249,6 +249,7 @@(throw (ex-info "vector-strategy matrix assumes the stock hnsw.ef_search default"{:hnsw.ef_search ef-search}))))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *index*"The semantic index the helpers below operate on; [[graph-approximation-test]] rebinds it."semantic.tu/mock-index)diff --git a/enterprise/backend/test/metabase_enterprise/sso/integrations/oidc_test.clj b/enterprise/backend/test/metabase_enterprise/sso/integrations/oidc_test.cljindex bf4db998c54..e8158a0a08b 100644--- a/enterprise/backend/test/metabase_enterprise/sso/integrations/oidc_test.clj+++ b/enterprise/backend/test/metabase_enterprise/sso/integrations/oidc_test.clj@@ -188,10 +188,12 @@;;; -------------------------------------------------- Group Sync Tests --------------------------------------------------+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *group-sync-claims*"Dynamic var to control what claims the group sync mock returns."{:groups ["test-group"]})+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *group-sync-email*"Dynamic var to control the email returned by the group sync mock."diff --git a/mage/src/mage/be_dev.clj b/mage/src/mage/be_dev.cljindex f1ef351bae6..d7da508f836 100644--- a/mage/src/mage/be_dev.clj+++ b/mage/src/mage/be_dev.clj@@ -75,6 +75,7 @@{:read-cond :allow}~(if (str/blank? code) "::loaded" code)))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^{:dynamic true:doc "Set this to true to suppress stdout output from nrepl-eval."}*quiet-nrepl-eval* false)diff --git a/mage/src/mage/ci_report.clj b/mage/src/mage/ci_report.cljindex e3a4eed8ca4..8341766c4fc 100644--- a/mage/src/mage/ci_report.clj+++ b/mage/src/mage/ci_report.clj@@ -52,6 +52,7 @@line)))(str/join "\n")))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *progress-log* nil)(defn- log-progress [msg]diff --git a/mage/src/mage/color.clj b/mage/src/mage/color.cljindex a65800780ab..85f10d985cc 100644--- a/mage/src/mage/color.clj+++ b/mage/src/mage/color.clj@@ -4,6 +4,7 @@(set! *warn-on-reflection* true)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *disable-colors*"If set to true, all color functions will return the input string as is."(if (System/getenv "NO_COLOR") true false))diff --git a/mage/src/mage/modules.clj b/mage/src/mage/modules.cljindex 54dfb38d0c4..96ca49a6508 100644--- a/mage/src/mage/modules.clj+++ b/mage/src/mage/modules.clj@@ -12,6 +12,7 @@(set! *warn-on-reflection* true)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic ^:private *github-output-only?* false)(def default-modules-which-trigger-driversdiff --git a/mage/src/mage/util.clj b/mage/src/mage/util.cljindex 0e22b086332..d2219258baf 100644--- a/mage/src/mage/util.clj+++ b/mage/src/mage/util.clj@@ -195,6 +195,7 @@(println " mage <task-name> -h")task+descriptions))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *skip-warning* "Skips warnings for can-run?" false)(defn can-run? [cmd]diff --git a/modules/drivers/athena/src/metabase/driver/athena.clj b/modules/drivers/athena/src/metabase/driver/athena.cljindex 93aff6e9941..a7a9311dd60 100644--- a/modules/drivers/athena/src/metabase/driver/athena.clj+++ b/modules/drivers/athena/src/metabase/driver/athena.clj@@ -206,6 +206,7 @@;;; ------------------------------------------------- date functions -------------------------------------------------+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *loading-data*"HACK! Whether we're loading data (e.g. in [[metabase.test.data.athena]]). We can't use `timestamp with time zone`literals when loading data because Athena doesn't let you use a `timestamp with time zone` value for a `timestamp`diff --git a/modules/drivers/athena/test/metabase/test/data/athena.clj b/modules/drivers/athena/test/metabase/test/data/athena.cljindex 261b3cbc871..3bbd72de319 100644--- a/modules/drivers/athena/test/metabase/test/data/athena.clj+++ b/modules/drivers/athena/test/metabase/test/data/athena.clj@@ -234,6 +234,7 @@(u/prog1 (existing-databases*)(reset! cached-existing-databases <>))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *allow-database-creation*"Whether to allow database creation. This is normally disabled to prevent people from accidentally loading duplicatedata into Athena or somehow stomping over existing databases and breaking CI. If you want to create a new dataset,diff --git a/modules/drivers/bigquery-cloud-sdk/src/metabase/driver/bigquery_cloud_sdk.clj b/modules/drivers/bigquery-cloud-sdk/src/metabase/driver/bigquery_cloud_sdk.cljindex ccfc0ea72d6..eb207445c58 100644--- a/modules/drivers/bigquery-cloud-sdk/src/metabase/driver/bigquery_cloud_sdk.clj+++ b/modules/drivers/bigquery-cloud-sdk/src/metabase/driver/bigquery_cloud_sdk.clj@@ -141,6 +141,7 @@;;; +----------------------------------------------------------------------------------------------------------------+;;; | Transducing Query Results |;;; +----------------------------------------------------------------------------------------------------------------++#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *page-callback*"Callback to execute when a new page is retrieved, used for testing"(constantly nil))@@ -653,6 +654,7 @@;;; wildly inaccurate -- a TEXT column may hold 5 bytes or 5 MB), we *measure* it: fetch a small probe page, then;;; recompute the next page size from the average bytes/row actually seen, so each page targets a fixed byte budget.+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *page-byte-budget*"Target measured bytes per result page for `tabledata.list` sampling. The next page size is`budget / measured-bytes-per-row`, clamped to [1, remaining]. Kept well under the server's ~10 MB page cap to leave@@ -660,6 +662,7 @@stays small. Regular query execution uses the larger [[*query-page-byte-budget*]]."(* 4 1024 1024))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *query-page-byte-budget*"Target measured bytes per result page for regular query execution. Deliberately larger than [[*page-byte-budget*]]because the QP streams rows and holds only one parsed page at a time, and the number of `getQueryResults` round trips@@ -819,6 +822,7 @@;;; 1. The initial query done by `execute-bigquery` where the `.query` call can be shortcircuited by `cancel-chan`.;;; 2. The "lazy" iteration of `TableResult` done by the QP. Any exceptions, or `cancel-chan` checking will be done in the context of the pipeline, solely around the code in `reducible-bigquery-results`.+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic ^Long *page-size*"Maximum number of rows to return per page in a query. Leave unset (falls back to [[initial-page-rows]] for the firstpage, then adaptive sizing) by default, but override for testing."@@ -1059,6 +1063,7 @@(throw-cancelled sql parameters))):ready (bigquery-execute-response result job client respond cancel-chan)))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(mu/defn- ^:dynamic *process-native*[respond :- fn?database :- :metabase.warehouses.schema/database-or-metadatadiff --git a/modules/drivers/bigquery-cloud-sdk/src/metabase/driver/bigquery_cloud_sdk/common.clj b/modules/drivers/bigquery-cloud-sdk/src/metabase/driver/bigquery_cloud_sdk/common.cljindex dd08da2238c..0ef77eceb2c 100644--- a/modules/drivers/bigquery-cloud-sdk/src/metabase/driver/bigquery_cloud_sdk/common.clj+++ b/modules/drivers/bigquery-cloud-sdk/src/metabase/driver/bigquery_cloud_sdk/common.clj@@ -13,6 +13,7 @@(set! *warn-on-reflection* true)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic ^String *bigquery-timezone-id*"BigQuery stores all of it's timestamps in UTC. That timezone can be changed via a SQL function invocation in anative query, but that change in timezone is not conveyed through the BigQuery API. In most situationsdiff --git a/modules/drivers/bigquery-cloud-sdk/src/metabase/driver/bigquery_cloud_sdk/query_processor.clj b/modules/drivers/bigquery-cloud-sdk/src/metabase/driver/bigquery_cloud_sdk/query_processor.cljindex 9527ecd48d6..70207986b3c 100644--- a/modules/drivers/bigquery-cloud-sdk/src/metabase/driver/bigquery_cloud_sdk/query_processor.clj+++ b/modules/drivers/bigquery-cloud-sdk/src/metabase/driver/bigquery_cloud_sdk/query_processor.clj@@ -629,6 +629,7 @@;; this is a little hacky, I'm 99% sure we could just have the [[sql.qp/->honeysql]] method for `:field` swap out the;; `::add/source-table` to a `[project.dataset table]` pair but this will have to do for now.+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *field-is-from-join-or-source-query?* false)(defn- should-qualify-identifier?@@ -829,6 +830,7 @@[_ t](format "timestamp \"%s %s\"" (u.date/format-sql (t/local-date-time t)) (.getId (t/zone-id t))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *compiling-cumulative-aggregation* false)(defmethod sql.qp/->honeysql [:bigquery-cloud-sdk :cum-count]diff --git a/modules/drivers/databricks/test/metabase/driver/databricks_test.clj b/modules/drivers/databricks/test/metabase/driver/databricks_test.cljindex 0cbd24f5441..bd3a3e53bed 100644--- a/modules/drivers/databricks/test/metabase/driver/databricks_test.clj+++ b/modules/drivers/databricks/test/metabase/driver/databricks_test.clj@@ -22,6 +22,7 @@[metabase.util :as u][toucan2.core :as t2]))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *multi-level?* false);; certain tests need to be run twice; once with the multi-level schema and once without.diff --git a/modules/drivers/databricks/test/metabase/test/data/databricks.clj b/modules/drivers/databricks/test/metabase/test/data/databricks.cljindex ea9b8da3be0..e1174f4bc44 100644--- a/modules/drivers/databricks/test/metabase/test/data/databricks.clj+++ b/modules/drivers/databricks/test/metabase/test/data/databricks.clj@@ -99,6 +99,7 @@;; Dataset can be destroyed using `tx/destroy-db` to remove the data from Databricks instance.;; [[*allow-database-deletion*]] must be bound to true. Then `t2/delete!` can be used to remove the reference from;; application database.+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *allow-database-creation*"Same approach is used in Databricks driver as in Athena. Dataset creation is disabled by default. Datasets arepreloaded in Databricks instance that tests run against. If you need to create new database on the instance,@@ -122,6 +123,7 @@(log/infof "Creating Databricks database %s" (pr-str schema))(apply (get-method tx/create-db! :sql-jdbc/test-extensions) driver dbdef options)))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *allow-database-deletion*"This is used to control `tx/destroy-db!`. Disabling database deletion is useful in CI. Specifically, if initial syncof some test dataset our test code destroys the database. In Databricks we want to avoid this, because datasets arediff --git a/modules/drivers/hive-like/src/metabase/driver/hive_like.clj b/modules/drivers/hive-like/src/metabase/driver/hive_like.cljindex 4ede71146eb..2309a0cb2f9 100644--- a/modules/drivers/hive-like/src/metabase/driver/hive_like.clj+++ b/modules/drivers/hive-like/src/metabase/driver/hive_like.clj@@ -263,6 +263,7 @@[_driver _coercion-strategy expr][:to_timestamp expr (h2x/literal "yyyyMMddHHmmss")])+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *inline-param-style*"How we should include inline params when compiling SQL. `:friendly` (the default) or `:paranoid`. `:friendly` makes abest-effort attempt to escape strings and generate SQL that is nice to look at, but should not be considered safediff --git a/modules/drivers/mongo/src/metabase/driver/mongo.clj b/modules/drivers/mongo/src/metabase/driver/mongo.cljindex 762a9516fa1..6e4d7c74fad 100644--- a/modules/drivers/mongo/src/metabase/driver/mongo.clj+++ b/modules/drivers/mongo/src/metabase/driver/mongo.clj@@ -239,6 +239,7 @@;; > If people have problems with that, I think we can make it configurable.7)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(mu/defn- ^:dynamic *sample-stages*"Stages to get sample of a collection in [[describe-table-pipeline]]. Dynamic for testing purposes."[collection-name :- :stringdiff --git a/modules/drivers/mongo/src/metabase/driver/mongo/connection.clj b/modules/drivers/mongo/src/metabase/driver/mongo/connection.cljindex de4c5fce315..a46cb4c9c4a 100644--- a/modules/drivers/mongo/src/metabase/driver/mongo/connection.clj+++ b/modules/drivers/mongo/src/metabase/driver/mongo/connection.clj@@ -25,6 +25,7 @@(set! *warn-on-reflection* true)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *mongo-client*"Stores an instance of `MongoClient` bound by [[with-mongo-client]]."nil)diff --git a/modules/drivers/mongo/src/metabase/driver/mongo/execute.clj b/modules/drivers/mongo/src/metabase/driver/mongo/execute.cljindex 526f3144df5..2527d7f35c7 100644--- a/modules/drivers/mongo/src/metabase/driver/mongo/execute.clj+++ b/modules/drivers/mongo/src/metabase/driver/mongo/execute.clj@@ -171,6 +171,7 @@aggregate (.aggregate db session pipe)](init-aggregate! aggregate timeout-ms)))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(defn- ^:dynamic *aggregate*[^MongoDatabase db^String colldiff --git a/modules/drivers/mongo/src/metabase/driver/mongo/query_processor.clj b/modules/drivers/mongo/src/metabase/driver/mongo/query_processor.cljindex b177c74c74b..d054b561f48 100644--- a/modules/drivers/mongo/src/metabase/driver/mongo/query_processor.clj+++ b/modules/drivers/mongo/src/metabase/driver/mongo/query_processor.clj@@ -240,6 +240,7 @@;;; | QP Impl |;;; +----------------------------------------------------------------------------------------------------------------++#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic ^:private *next-alias-index*"Tracks index of next alias for join compilation. It is bound in [[mbql->native]] to `volatile!` valued 0. Henceevery compilation starts with a fresh 0. Indices are used in [[handle-join]] to make aliases unique. Index values@@ -253,6 +254,7 @@(vswap! *next-alias-index* inc));; TODO (Cam 2026-07-24) get rid of this dynamic var and attach the mappings directly to the `query` itself+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic ^:private *field-mappings*"The mapping from the fields to the projected names createdby the nested query."diff --git a/modules/drivers/mongo/test/metabase/test/data/mongo.clj b/modules/drivers/mongo/test/metabase/test/data/mongo.cljindex 87f72a87c33..e728054057d 100644--- a/modules/drivers/mongo/test/metabase/test/data/mongo.clj+++ b/modules/drivers/mongo/test/metabase/test/data/mongo.clj@@ -59,6 +59,7 @@(mongo.connection/with-mongo-database [^MongoDatabase db (tx/dbdef->connection-details driver :server dbdef)](.drop db)))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *remove-nil?*"When creating a dataset, omit any nil-valued fields from the documents."false)diff --git a/modules/drivers/oracle/test/metabase/test/data/oracle.clj b/modules/drivers/oracle/test/metabase/test/data/oracle.cljindex 41bf0b5bcbe..0387b233f9c 100644--- a/modules/drivers/oracle/test/metabase/test/data/oracle.clj+++ b/modules/drivers/oracle/test/metabase/test/data/oracle.clj@@ -301,6 +301,7 @@;; if the ResultSet returns anything we know the table is already loaded.(.next rset))))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *override-describe-database-to-filter-by-db-name?*"Whether to override the production implementation for `describe-database` with a special one that only syncsthe tables qualified by the database name. This is `true` by default during tests to fake database isolation.diff --git a/modules/drivers/presto-jdbc/src/metabase/driver/presto_jdbc.clj b/modules/drivers/presto-jdbc/src/metabase/driver/presto_jdbc.cljindex e3583b163da..8bfe6b4e899 100644--- a/modules/drivers/presto-jdbc/src/metabase/driver/presto_jdbc.clj+++ b/modules/drivers/presto-jdbc/src/metabase/driver/presto_jdbc.clj@@ -195,6 +195,7 @@(sql/register-fn! ::mod #'format-mod)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic ^:private *inline-param-style*"How we should include inline params when compiling SQL. `:friendly` (the default) or `:paranoid`. `:friendly` makes abest-effort attempt to escape strings and generate SQL that is nice to look at, but should not be considered safe@@ -698,6 +699,7 @@;;; Connection spec from the top-level call, and if the `:presto-jdbc/force-fresh?` is passed in to recursive calls;;; we'll create a NEW connection using the original spec every time. See for example the code;;; in [[metabase.test.data.presto-jdbc]]+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic ^:private *original-connection-spec* nil)(defn- set-connection-options! [driver ^java.sql.Connection conn {:keys [^String session-timezone write?], :as _options}]diff --git a/modules/drivers/redshift/test/metabase/test/data/redshift.clj b/modules/drivers/redshift/test/metabase/test/data/redshift.cljindex 61bbad874af..2c43383e0b7 100644--- a/modules/drivers/redshift/test/metabase/test/data/redshift.clj+++ b/modules/drivers/redshift/test/metabase/test/data/redshift.clj@@ -389,6 +389,7 @@{:write? true}delete-session-schema!))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *override-describe-database-to-filter-by-db-name?*"Whether to override the production implementation for `describe-database` with a special one that only syncsthe tables qualified by the database name. This is `true` by default during tests to fake database isolation.diff --git a/modules/drivers/sqlserver/src/metabase/driver/sqlserver.clj b/modules/drivers/sqlserver/src/metabase/driver/sqlserver.cljindex 7b79dd93ebb..bbe5f1bdd4a 100644--- a/modules/drivers/sqlserver/src/metabase/driver/sqlserver.clj+++ b/modules/drivers/sqlserver/src/metabase/driver/sqlserver.clj@@ -272,6 +272,7 @@(driver/validate-db-details! driver details)((get-method driver/can-connect? :sql-jdbc) driver details))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *field-options*"The options part of the `:field` clause we're currently compiling."nil)@@ -895,6 +896,7 @@[driver [_ _opts arg]](sql.qp/->honeysql driver [:percentile {} arg 0.5]))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *compared-field-options*"This variable is set to the options of the field we are comparing(presumably in a filter)."diff --git a/modules/drivers/vertica/test/metabase/test/data/vertica.clj b/modules/drivers/vertica/test/metabase/test/data/vertica.cljindex f6d33f3563d..3b4dea50e0e 100644--- a/modules/drivers/vertica/test/metabase/test/data/vertica.clj+++ b/modules/drivers/vertica/test/metabase/test/data/vertica.clj@@ -284,6 +284,7 @@;; if the ResultSet returns anything we know the table is already loaded.(.next rset))))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *override-describe-database-to-filter-by-db-name?*"Whether to override the production implementation for `describe-database` with a special one that only syncsthe tables qualified by the database name. This is `true` by default during tests to fake database isolation.diff --git a/src/metabase/actions/actions.clj b/src/metabase/actions/actions.cljindex 89b493c2570..8bcb88c702d 100644--- a/src/metabase/actions/actions.clj+++ b/src/metabase/actions/actions.clj@@ -95,6 +95,7 @@(pr-str driver)){:status-code 400}))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *misc-value-cache*"A cache that lives for the duration of the top-level Action invoked by [[perform-action!]]. You can use this to storemiscellaneous values such as things that need to be fetched from the application database to avoid duplicate callsdiff --git a/src/metabase/activity_feed/models/recent_views.clj b/src/metabase/activity_feed/models/recent_views.cljindex f406672fe05..7c0c2b150ab 100644--- a/src/metabase/activity_feed/models/recent_views.clj+++ b/src/metabase/activity_feed/models/recent_views.clj@@ -55,6 +55,7 @@(let [defaults {:timestamp (t/zoned-date-time)}](merge defaults log-entry)))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *recent-views-stored-per-user-per-model*"The number of recently viewed items to keep per user per model. This is used to keep the most recent views of eachmodel type in [[rv-models]]."diff --git a/src/metabase/ai_tracing/core.clj b/src/metabase/ai_tracing/core.cljindex 03aaff0bd92..71e4e6410ca 100644--- a/src/metabase/ai_tracing/core.clj+++ b/src/metabase/ai_tracing/core.clj@@ -44,23 +44,27 @@;;;; ----------------------------------------- Gate (separate axis) -----------------------------------------+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *capture*"Per-run capture sink: an atom holding the vector of root span maps, or nil.Bound ONLY by an entrypoint. nil ⇒ ai-tracing is inert (the production safety gate)."nil)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *parent*"The current in-flight span node (an atom), or nil at top level. Conveyed across theagent's virtual-thread tool execution via `bound-fn*`, so concurrent tool spans nestunder the correct parent."nil)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *session-id*"The eval session id (OTel trace-id analog). Minted at the root of a fresh capture, or suppliedby the caller (e.g. MCP's `Mcp-Session-Id`). Conveyed across virtual threads via `bound-fn*`;drives the per-session log file routing."nil)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *retain-tree*"When true, each finished span is also retained in the in-memory tree ([[*capture*]] / its parent's`:children`) so an in-process caller can read the whole trace back as a return value (seediff --git a/src/metabase/analytics/sdk.clj b/src/metabase/analytics/sdk.cljindex 93347bc1cc0..57939883508 100644--- a/src/metabase/analytics/sdk.clj+++ b/src/metabase/analytics/sdk.clj@@ -23,6 +23,7 @@(set! *warn-on-reflection* true)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *version* "Used to track information about the metabase embedding client version." nil)(defmacro with-version! "Used to track information about the metabase embedding client version."@@ -32,6 +33,7 @@(defn get-version "Returns [[*version*]]." [] *version*)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *client* "Used to track information about the metabase embedding client." nil)(defmacro with-client! "Used to track information about the metabase embedding client client."@@ -41,16 +43,19 @@(defn get-client "Returns [[*client*]] dynamic var" [] *client*)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *client-identifier*"Used to track the identifier of the concrete embedding client, e.g. the data-app name."nil)(defn get-client-identifier "Returns [[*client-identifier*]]." [] *client-identifier*)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *route* "Used to track the API route for the current request (e.g. \"public\", \"guest-embed\")." nil)(defn get-route "Returns [[*route*]]." [] *route*)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *auth-method* "Used to track the authentication method for the current request (e.g. \"password\", \"jwt\", \"api-key\")." nil)(defmacro with-auth-method! "Binds [[*auth-method*]] for the duration of `body`."diff --git a/src/metabase/api/common.clj b/src/metabase/api/common.cljindex 35542725b85..a99b5af57d9 100644--- a/src/metabase/api/common.clj+++ b/src/metabase/api/common.clj@@ -102,32 +102,38 @@;; These get bound by middleware for each HTTP request.;;; TODO -- move this to [[metabase.request.current]]+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic ^Integer *current-user-id*"Int ID or `nil` of user associated with current API call."nil);;; TODO -- move this to [[metabase.request.current]]+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *current-user*"Delay that returns the `User` (or nil) associated with the current API call.ex. `@*current-user*`"(atom nil)) ; default binding is just something that will return nil when dereferenced;;; TODO -- move this to [[metabase.request.current]]+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic ^Boolean *is-superuser?*"Is the current user a superuser?"false);;; TODO -- move this to [[metabase.request.current]]+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic ^Boolean *is-group-manager?*"Is the current user a group manager of at least one group?"false);;; TODO -- move this to [[metabase.request.current]]+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic ^Boolean *is-data-analyst?*"Is the current user a data analyst with access to Data Studio?"false);;; TODO -- move this to [[metabase.request.current]]+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *current-user-permissions-set*"Delay to the set of permissions granted to the current user. See documentation in [[metabase.permissions.models.permissions]] formore information about the Metabase permissions system."diff --git a/src/metabase/api/macros.clj b/src/metabase/api/macros.cljindex 3b3b81019ae..f75e9b70194 100644--- a/src/metabase/api/macros.clj+++ b/src/metabase/api/macros.clj@@ -423,6 +423,7 @@(defn- encoder [schema](mr/cached ::encoder schema #(mc/encoder schema encode-transformer)))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *enable-response-validation*"Whether to validate responses against Malli schemas in [[defendpoint]]... normally enabled for dev/test and disabledfor prod for performance purposes. You can change this binding if you want to disable it for weird test reasons ordiff --git a/src/metabase/api/macros/defendpoint/open_api.clj b/src/metabase/api/macros/defendpoint/open_api.cljindex a5a22c62efc..34ead84e789 100644--- a/src/metabase/api/macros/defendpoint/open_api.clj+++ b/src/metabase/api/macros/defendpoint/open_api.clj@@ -14,6 +14,7 @@[metabase.util.malli.registry :as mr][metabase.util.malli.schema :as ms]))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *definitions* nil)(defn- sanitize-schema-namediff --git a/src/metabase/app_db/cluster_lock.clj b/src/metabase/app_db/cluster_lock.cljindex 773d549ee25..999c6780241 100644--- a/src/metabase/app_db/cluster_lock.clj+++ b/src/metabase/app_db/cluster_lock.clj@@ -285,6 +285,7 @@(do-with-lock-wait-timeout conn timeout #(acquire-lock-row!* conn lock-name-str timeout mode ambient-transaction?))(acquire-lock-row!* conn lock-name-str timeout mode ambient-transaction?)))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *detached-locks-held*"Lock-name strings currently held by [[do-with-detached-cluster-lock]] in this dynamic scope. A detachedhold lives on a dedicated connection, so re-acquiring the same name from this scope — detached ordiff --git a/src/metabase/app_db/connection.clj b/src/metabase/app_db/connection.cljindex 9e5bf2c2397..7833f0665f0 100644--- a/src/metabase/app_db/connection.clj+++ b/src/metabase/app_db/connection.clj@@ -100,6 +100,7 @@:id (swap! application-db-counter inc):lock (ReentrantReadWriteLock.)}))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic ^ApplicationDB *application-db*"Type info and [[javax.sql.DataSource]] for the current Metabase application database. Create a new instancewith [[application-db]]."@@ -168,6 +169,7 @@[_connectable f](t2.conn/do-with-connection *application-db* f))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *transaction-depth* 0)(defn in-transaction?@@ -178,7 +180,9 @@;; Accumulate 0-arity thunks to run just before / just after the outermost transaction commits. Each is;; bound to a fresh atom when the outermost transaction starts (see [[do-with-transaction]]) and shared by;; the whole nested-transaction tree; nil outside any transaction.+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *before-commit-callbacks* nil)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *after-commit-callbacks* nil);; Holds an atom set to true when a rollback fails and leaves behind writes that should have been discarded. The atom@@ -187,12 +191,14 @@;;;; Once set it stays set. Clearing it correctly would mean tracking the depth that failed: a sibling scope rolling;; back to its own, later savepoint does not discard an earlier scope's writes.+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *rollback-required* nil);; Open savepoints in creation order, each with whether its scope has finished. Shared by the tree, including threads;; that inherit its bindings. Releasing a savepoint destroys every later one, so a scope may only release once no;; later scope is still running; a sibling thread's early release would otherwise leave that scope nothing to release;; or roll back to, and on postgres the failed release aborts the transaction.+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *open-savepoints* nil)(defn- set-savepoint! [^java.sql.Connection connection]@@ -240,6 +246,7 @@;; diverge.(log/warnf "Failed to release savepoint: %s" (ex-message e)))))))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *transaction-state*"When non-nil, an atom holding a map of arbitrary per-transaction data, shared by the wholenested-transaction tree and thrown away when the outermost transaction ends. Any subsystem can stashdiff --git a/src/metabase/app_db/custom_migrations.clj b/src/metabase/app_db/custom_migrations.cljindex 69fd14bff4f..d3d6cce29f8 100644--- a/src/metabase/app_db/custom_migrations.clj+++ b/src/metabase/app_db/custom_migrations.clj@@ -1173,6 +1173,7 @@[](nil? (t2/query-one {:select [:*] :from :metabase_database})))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *create-sample-content*"If true, we create sample content in the `CreateSampleContent` migration. This is bound to false sometimes inload-from-h2, during serialization load, and in some tests because the sample content makes tests slow enough todiff --git a/src/metabase/app_db/custom_migrations/util.clj b/src/metabase/app_db/custom_migrations/util.cljindex c608ffbf24f..14ead562c48 100644--- a/src/metabase/app_db/custom_migrations/util.clj+++ b/src/metabase/app_db/custom_migrations/util.clj@@ -10,6 +10,7 @@(defn- set-jdbc-backend-properties! [](metabase.task.bootstrap/set-jdbc-backend-properties! (mdb.connection/db-type)))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *allow-temp-scheduling*"If true, the scheduler will be started temporarily for migrations that require it. If false, migrations that use `do-with-temp-schedule` will be a no-op."true)diff --git a/src/metabase/app_db/data_source.clj b/src/metabase/app_db/data_source.cljindex 35f41ce865a..932dc0b1f4e 100644--- a/src/metabase/app_db/data_source.clj+++ b/src/metabase/app_db/data_source.clj@@ -18,6 +18,7 @@(set! *warn-on-reflection* true)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(defn ^:dynamic *current-millis*"Returns the current time millis, but can be overridden for testing."[]diff --git a/src/metabase/app_db/liquibase.clj b/src/metabase/app_db/liquibase.cljindex c81e9675953..62c1e171c58 100644--- a/src/metabase/app_db/liquibase.clj+++ b/src/metabase/app_db/liquibase.clj@@ -306,6 +306,7 @@(log/warn "Releasing liquibase lock before migrations finished")(release-lock-if-needed! liquibase)))))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *lock-depth* 0)(defn- assert-locked [liquibase]diff --git a/src/metabase/channel/render/js/svg.clj b/src/metabase/channel/render/js/svg.cljindex 2557b956749..99a1b1867c5 100644--- a/src/metabase/channel/render/js/svg.clj+++ b/src/metabase/channel/render/js/svg.clj@@ -85,16 +85,19 @@;; The document deliberately gets no base URI so that Batik will not fetch any external references or local files(.createDocument factory nil is))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic ^:private *svg-render-width*"Width to render svg images. Intentionally large to improve quality. Consumers should be aware and resize asneeded. Email should include width tags; slack automatically resizes inline and provides a nice detail view whenclicked."(float 1200))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic ^:private *svg-render-height*"Height to render svg images. If not bound, will preserve aspect ratio of original image."nil)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *chart-size*"When bound to a map `{:width <px> :height <px>}`, isomorphic (ECharts) charts rendered via[[*javascript-visualization*]] use `:width`/`:height` as their intrinsic (logical) SVG@@ -113,6 +116,7 @@chart fills its grid cell's full width."nil)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *svg-background-color*"Background color for rendered PNG images. Set to nil for transparent background.Defaults to white to ensure charts are readable in dark mode email clients."@@ -177,6 +181,7 @@:contentsvg-string->bytes))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(defn ^:dynamic *javascript-visualization*"Clojure entrypoint to render javascript visualizations. This functions is dynanic only for testing purposes."[cards-with-data dashcard-viz-settings]diff --git a/src/metabase/channel/render/pdf.clj b/src/metabase/channel/render/pdf.cljindex bde7ef70d5e..44c1d81fb75 100644--- a/src/metabase/channel/render/pdf.clj+++ b/src/metabase/channel/render/pdf.clj@@ -75,6 +75,7 @@(set! *warn-on-reflection* true)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *debug-boxes*"When true, fill the *allocated* bounding box (the full space available, not the content's actual extent) behindeach chart (red) and each card title / heading card (light blue), so one can see how much of its cell the content@@ -142,6 +143,7 @@;; page draws we collect link rectangles into `*link-rects*` and add the annotations afterward.;; --------------------------------------------------------------------------------------------+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *link-rects*"While a page renders, an atom holding a vector of `{:x0 :y0 :x1 :y1 :href}` rectangles for the clickable linkannotations to add to the page once drawing is done."diff --git a/src/metabase/channel/render/pdf/font.clj b/src/metabase/channel/render/pdf/font.cljindex 25377f12be4..1da6bf5ebed 100644--- a/src/metabase/channel/render/pdf/font.clj+++ b/src/metabase/channel/render/pdf/font.clj@@ -65,6 +65,7 @@;; selectors, and note that ZWJ/skin-tone sequences render as their component glyphs (no GSUB shaping).:emoji "fonts/pdf/NotoEmoji-Regular.ttf"})+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *fonts*"Per-document map of `{face-keyword {:fallbacks [<phys> ...]} ...}`, where each `<phys>` is`{:font <PDType0Font> :cmap <CmapLookup>}`. Bound while a document is being rendered, because `PDType0Fonts` are@@ -275,6 +276,7 @@+ 0.0(font-runs face (visual-order (normalize-ws s)))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^{:dynamic true:arglists '([face ^String s])}*em-width*diff --git a/src/metabase/channel/render/table.clj b/src/metabase/channel/render/table.cljindex ee4e714357a..08183b31d86 100644--- a/src/metabase/channel/render/table.clj+++ b/src/metabase/channel/render/table.clj@@ -11,6 +11,7 @@(set! *warn-on-reflection* true)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *text-wrapping-fallback-width*"The CSS width given to a text-wrapping column that has no explicit `table.column_widths` entry. Email and Slackclients won't wrap a cell without an explicit width, so this defaults to a wide value. Renderers that lay the tablediff --git a/src/metabase/channel/slack.clj b/src/metabase/channel/slack.cljindex 31027e95957..2b4f9c536fd 100644--- a/src/metabase/channel/slack.clj+++ b/src/metabase/channel/slack.clj@@ -25,6 +25,7 @@;; received. This would happen if access to the Slack workspace is manually revoked via the Slack UI.#{"invalid_auth", "account_inactive", "token_revoked", "token_expired"})+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *send-token-error-emails?*"Whether to send an email to all admins when an invalid or revoked token error is received in response to a SlackAPI call. Should be set to false when checking if an unsaved token is valid. (Default: `true`)"diff --git a/src/metabase/channel/urls.clj b/src/metabase/channel/urls.cljindex a1f37750e88..a7c8e1ff73d 100644--- a/src/metabase/channel/urls.clj+++ b/src/metabase/channel/urls.clj@@ -72,6 +72,7 @@[^Integer id](str (site-url) (card-path id)))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *dashcard-parameters*"Bind dashboard parameters for dashcard deeplinked urls"{})diff --git a/src/metabase/cmd/copy.clj b/src/metabase/cmd/copy.cljindex 38dfcd4affa..5b40a247bbd 100644--- a/src/metabase/cmd/copy.clj+++ b/src/metabase/cmd/copy.clj@@ -203,6 +203,7 @@(log/errorf "Error inserting chunk: %s" (ex-message e))(throw e))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *copy-h2-database-details*"Whether [[copy-data!]] (and thus [[metabase.cmd.load-from-h2/load-from-h2!]]) should copy connection details for H2Databases from the source application database. Normally disabled for security reasons. This is only here so we candiff --git a/src/metabase/collections/models/collection.clj b/src/metabase/collections/models/collection.cljindex cb988a766a4..489fef27e0b 100644--- a/src/metabase/collections/models/collection.clj+++ b/src/metabase/collections/models/collection.clj@@ -167,6 +167,7 @@[](collections.db/root-remote-synced-collection))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(defonce ^:dynamic ^:private *clearing-remote-sync* false)(defn clear-remote-synced-collection!@@ -1650,6 +1651,7 @@(cons (perms/collection-readwrite-path (u/the-id collection))(map perms/collection-readwrite-path descendant-ids)))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *allow-modifying-tenant-root-collections?*"We archive tenant root collections only when the tenant is archived."false)@@ -2046,6 +2048,7 @@;;; ----------------------------------------------------- DELETE -----------------------------------------------------+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(defonce ^:dynamic ^{:doc "Whether to allow deleting Personal Collections. Normally we should *never* allow this, butin the single case of deleting a User themselves, we need to allow this. (Note that in normal usage, Users never getdeleted, but rather archived; thus this code is used solely by our test suite, by things such as the `with-temp`diff --git a/src/metabase/config/core.clj b/src/metabase/config/core.cljindex 600df3fd7e5..07a14eda8cd 100644--- a/src/metabase/config/core.clj+++ b/src/metabase/config/core.clj@@ -194,6 +194,7 @@This is needed in the OSS edition to filter out users for setup/has-user-setup."13371338)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *disable-setting-cache*"Whether to disable database cache. Here for loading circularity reasons."false)@@ -204,6 +205,7 @@[](not (false? (config-bool :mb-load-sample-content))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *request-id*"A unique identifier for the current request. This is bound by`metabase.server.middleware.request-id/wrap-request-id`."diff --git a/src/metabase/dashboards_rest/api.clj b/src/metabase/dashboards_rest/api.cljindex 94ba7db3132..3325521b2d2 100644--- a/src/metabase/dashboards_rest/api.clj+++ b/src/metabase/dashboards_rest/api.clj@@ -332,6 +332,7 @@"Using 10 seconds for the cache TTL."(* 10 1000))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *dashboard-load-id* nil);; This is a kind of two-layer memoization:diff --git a/src/metabase/documents/models/document.clj b/src/metabase/documents/models/document.cljindex 70ad861cd81..1d9c5538761 100644--- a/src/metabase/documents/models/document.clj+++ b/src/metabase/documents/models/document.clj@@ -68,6 +68,7 @@[f](reset! doc-content-visibility-fn f))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *content-gate-pending*"Document ids whose content gate is currently being evaluated on this thread.@@ -77,6 +78,7 @@has no answer, so deny rather than recur into a stack overflow inside an authorization check."#{})+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *cache*"Cache atom bound by [[with-content-gate-cache]], or nil to adjudicate on every call."nil)diff --git a/src/metabase/driver.clj b/src/metabase/driver.cljindex c94841d9ed1..81e637522f6 100644--- a/src/metabase/driver.clj+++ b/src/metabase/driver.clj@@ -44,6 +44,7 @@;;; | Current Driver |;;; +----------------------------------------------------------------------------------------------------------------++#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *driver*"Current driver (a keyword such as `:postgres`) in use by the Query Processor/tests/etc. Bind this with `with-driver`below. The QP binds the driver this way in the `bind-driver` middleware."@@ -1184,6 +1185,7 @@[_ native-form]native-form)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic ^{:added "0.51.0"} *compile-with-inline-parameters*"Whether to compile an MBQL query to native with parameters spliced inline (as opposed to using placeholders like `?`and passing the parameters separately.) Normally we want to pass parameters separately to protect against SQL@@ -1683,6 +1685,7 @@;;; | Upload |;;; +----------------------------------------------------------------------------------------------------------------++#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *insert-chunk-rows*"The number of rows to insert at a time when uploading data to a database. This can be bound for testing purposes."nil)diff --git a/src/metabase/driver/common.clj b/src/metabase/driver/common.cljindex 404fdd0b3a2..38dbc28dd05 100644--- a/src/metabase/driver/common.clj+++ b/src/metabase/driver/common.clj@@ -457,6 +457,7 @@(def ^:private ^clojure.lang.PersistentVector days-of-week[:monday :tuesday :wednesday :thursday :friday :saturday :sunday])+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *start-of-week*"Used to override the [[metabase.lib-be.core/start-of-week]] settings.Primarily being used to calculate week-of-year in US modes where the start-of-week is always Sunday.diff --git a/src/metabase/driver/connection.clj b/src/metabase/driver/connection.cljindex a644b377b16..6ca728e6eb0 100644--- a/src/metabase/driver/connection.clj+++ b/src/metabase/driver/connection.clj@@ -66,6 +66,7 @@(mr/def ::connection-type(into [:enum] connection-types))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic ^:private *connection-type*"Which connection details [[effective-details]] should resolve.@@ -132,6 +133,7 @@[& body]`(do-with-transform-connection (fn [] ~@body)))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic ^:private *suppress-resolution-telemetry*false)diff --git a/src/metabase/driver/settings.clj b/src/metabase/driver/settings.cljindex ed8be139378..22e0716eae6 100644--- a/src/metabase/driver/settings.clj+++ b/src/metabase/driver/settings.clj@@ -199,14 +199,17 @@\"service unavailable\" (HTTP 503) error instead of joining the queue. Raise it to tolerate deeper bursts; set it to`0` to allow an unbounded queue.")+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic ^Long *query-timeout-ms*"Maximum amount of time query is allowed to run, in ms."(u/minutes->ms (db-query-timeout-minutes)))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic ^Long *network-timeout-ms*"Maximum amount of time to wait for a response from the database, in ms."(jdbc-network-timeout-ms))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *allow-testing-h2-connections*"Whether to allow testing new H2 connections. Normally this is disabled, which effectively means you cannot create newH2 databases from the API, but this flag is here to disable that behavior for syncing existing databases, or when@@ -217,10 +220,12 @@(or (config/config-bool :mb-dangerous-unsafe-enable-testing-h2-connections-do-not-enable)false))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *impersonation-allow-write?*"Whether write-back operations are permitted while connection impersonation is active. Normally `false`."false)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *allow-testing-sqlite-connections*"Whether to allow testing new SQLite connections. Normally disabled on hosted Metabase, which effectively preventsusers from creating new SQLite databases from the API. Internal flows that need to test connections to the bundleddiff --git a/src/metabase/driver/sql/query_processor.clj b/src/metabase/driver/sql/query_processor.cljindex 7eae0abc177..f079d189c4a 100644--- a/src/metabase/driver/sql/query_processor.clj+++ b/src/metabase/driver/sql/query_processor.clj@@ -51,6 +51,7 @@;; TODO (Cam 2026-08-11) "Inner query" is MBQL 4 terminology, since we're using MBQL 5 now, rename this to `stage` and;; rename all the `inner-query` function args & local variables to `stage` as well+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *inner-query*"The INNER query currently being processed, for situations where we need to refer back to it."nil)@@ -1860,6 +1861,7 @@(select-keys (driver-api/field (driver-api/metadata-provider) field-id)[:effective-type])))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *parent-honeysql-col-type-info*"To be bound in `->honeysql <driver> <op>` where op is on of {:>, :>=, :<, :<=, :=, :between}`. It carries thecompiled LHS's full HoneySQL type-info (see [[metabase.util.honey-sql-2/type-info]]) merged with `:base-type` anddiff --git a/src/metabase/driver/sql_jdbc/actions.clj b/src/metabase/driver/sql_jdbc/actions.cljindex 8b51aaf7f32..825b15bf12c 100644--- a/src/metabase/driver/sql_jdbc/actions.clj+++ b/src/metabase/driver/sql_jdbc/actions.clj@@ -131,6 +131,7 @@e)))))))column->value)))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic ^Connection *connection*"Data warehouse JDBC Connection to use for doing CRUD Actions. Bind this to reuse the same Connection/transactionthroughout a single bulk Action."diff --git a/src/metabase/driver/sql_jdbc/execute.clj b/src/metabase/driver/sql_jdbc/execute.cljindex 26b38f76a81..80099ebe548 100644--- a/src/metabase/driver/sql_jdbc/execute.clj+++ b/src/metabase/driver/sql_jdbc/execute.clj@@ -305,6 +305,7 @@(old-method-impl driver database session-timezone)))))(datasource-with-diagnostic-info! driver db-or-id-or-spec))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic ^{:added "0.47.0"} *connection-recursion-depth*"In recursive calls to [[do-with-connection-with-options]] we don't want to set options AGAIN, because this mightbreak things. For example in a top-level `:write?` call, we might disable auto-commit and run things in a@@ -1088,6 +1089,7 @@connection-with-timezoneset-timezone-sql])+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic^{:doc "Dynamic context for resilient connection management. Contains a map with:- :db - the database instance, used to create new connectionsdiff --git a/src/metabase/driver/sql_jdbc/execute/diagnostic.clj b/src/metabase/driver/sql_jdbc/execute/diagnostic.cljindex 0d532d07e3e..a37643a9bb0 100644--- a/src/metabase/driver/sql_jdbc/execute/diagnostic.clj+++ b/src/metabase/driver/sql_jdbc/execute/diagnostic.clj@@ -5,6 +5,7 @@(set! *warn-on-reflection* true)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *diagnostic-info*"Atom used to hold diagnostic info for the current query execution, to be made available via a helper macro/fn below."nil)diff --git a/src/metabase/driver/sql_jdbc/sync/describe_database.clj b/src/metabase/driver/sql_jdbc/sync/describe_database.cljindex dc04caf52da..1fb827ce7dc 100644--- a/src/metabase/driver/sql_jdbc/sync/describe_database.clj+++ b/src/metabase/driver/sql_jdbc/sync/describe_database.clj@@ -65,6 +65,7 @@honeysql (sql.qp/apply-top-level-clause driver :limit honeysql {:limit 0})](sql.qp/format-honeysql driver honeysql)))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *select-probe-query-timeout-seconds*"time to wait on the select probe query"15)diff --git a/src/metabase/driver/util.clj b/src/metabase/driver/util.cljindex ea1cb7f05aa..f66dc18b9d4 100644--- a/src/metabase/driver/util.clj+++ b/src/metabase/driver/util.clj@@ -166,6 +166,7 @@:errors {:host (str (deferred-tru "check your host settings"))}}cause)))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *allow-private-connection-hosts*"When true, an `:external-only` [[driver.settings/warehouse-allowed-networks]] policy is enforced as`:allow-private`. Bound only by [[do-with-database-network-policy]]."@@ -315,6 +316,7 @@critical metabase features that use this check."5000)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *memoize-supports?*"If true, [[supports?]] is memoized for the application DB. Memoization is disabled in dev and test mode by default to avoidaccidental coupling between tests."diff --git a/src/metabase/formatter/datetime.clj b/src/metabase/formatter/datetime.cljindex bf7fb3ee695..114f8adf054 100644--- a/src/metabase/formatter/datetime.clj+++ b/src/metabase/formatter/datetime.clj@@ -15,6 +15,7 @@(set! *warn-on-reflection* true)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *formatting-locale*"Dynamic var to hold the current locale for datetime formatting.Defaults to the site locale from system settings."diff --git a/src/metabase/lib/card.cljc b/src/metabase/lib/card.cljcindex 1e66fe34e8c..ad248f10420 100644--- a/src/metabase/lib/card.cljc+++ b/src/metabase/lib/card.cljc@@ -150,6 +150,7 @@(mr/def ::maybe-columns[:maybe [:sequential {:min 1} ::column]])+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *card-metadata-columns-card-ids*"Used to track the ID of Cards we're resolving columns for, to avoid infinite recursion for Cards that have circularreferences between one another."diff --git a/src/metabase/lib/computed.cljc b/src/metabase/lib/computed.cljcindex 9764a31cef5..07cbb44e96e 100644--- a/src/metabase/lib/computed.cljc+++ b/src/metabase/lib/computed.cljc@@ -34,6 +34,7 @@[](count weak-map))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *computed-cache*"Dynamic var that holds an atom used for caching derived values for [[with-cache-sticky*]].@@ -63,6 +64,7 @@(.set weak-map query m)m))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(defn ^:dynamic *cache-hit-hook*"A function `(f cache-key)` called whenever the sticky or ephemeral caches are hit.@@ -70,6 +72,7 @@[cache-key](log/debug (str (u/colorize :green "HIT: ") (name (first cache-key)) " " (hash (rest cache-key)))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(defn ^:dynamic *cache-miss-hook*"A function `(f cache-key)` called whenever the sticky or ephemeral caches are missed.diff --git a/src/metabase/lib/convert.cljc b/src/metabase/lib/convert.cljcindex 61a7cdd9fa2..32d8c98601b 100644--- a/src/metabase/lib/convert.cljc+++ b/src/metabase/lib/convert.cljc@@ -28,9 +28,11 @@[metabase.util.performance :refer [mapv some select-keys not-empty #?(:clj doseq) #?(:clj for)]])#?@(:cljs [(:require-macros [metabase.lib.convert :refer [with-aggregation-list]])]))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *mbql5-uuid->legacy-index*{})+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *legacy-index->mbql5-uuid*{})@@ -97,12 +99,14 @@clean-stage-schema-errorsclean-stage-ref-errors))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *clean-query*"If true (this is the default), the query is cleaned.When converting queries at later stages of the preprocessing pipeline, this cleaning might not be desirable."true)#?(:clj+ #_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *card-clean-hook*"Set by [[metabase.lib-be.models.transforms]] to a function which expects to be called like`(f pre-cleaning-query post-cleaning-query)`, when [[clean]] makes material changes.diff --git a/src/metabase/lib/equality.cljc b/src/metabase/lib/equality.cljcindex 063e7ddeff1..df13d417176 100644--- a/src/metabase/lib/equality.cljc+++ b/src/metabase/lib/equality.cljc@@ -69,6 +69,7 @@(or (empty? more-x)(recur more-x more-y))))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *side->uuid->index* nil)(defn- aggregation-uuid->indexdiff --git a/src/metabase/lib/expression.cljc b/src/metabase/lib/expression.cljcindex 94872d757a6..2fcb6fc96a2 100644--- a/src/metabase/lib/expression.cljc+++ b/src/metabase/lib/expression.cljc@@ -155,6 +155,7 @@[_query _stage-number [_expression _opts expression-name]]expression-name)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *nested*"Whether the display name we are generated is recursively nested inside another display name. For infix math operatorswe'll wrap the results in parentheses to make the display name more obvious."diff --git a/src/metabase/lib/field/resolution.cljc b/src/metabase/lib/field/resolution.cljcindex 857a670810f..58f4e3f8d61 100644--- a/src/metabase/lib/field/resolution.cljc+++ b/src/metabase/lib/field/resolution.cljc@@ -615,6 +615,7 @@:source/table-defaults:source/previous-stage)))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *recursive-expression-resolution?* false)(defn- maybe-resolve-expression-in-current-stage [query stage-number id-or-name]@@ -632,6 +633,7 @@(declare resolve-from-previous-stage-or-source)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *in-deduplicated-column-resolution?* false)(defn- resolve-nonexistent-deduplicated-column-namediff --git a/src/metabase/lib/metadata/cache.cljc b/src/metabase/lib/metadata/cache.cljcindex fda51dd1816..447c8946eaa 100644--- a/src/metabase/lib/metadata/cache.cljc+++ b/src/metabase/lib/metadata/cache.cljc@@ -157,12 +157,14 @@(log/warn "Not a cached-metadata-provider"))nil)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(defn ^:dynamic *cache-hit-hook*"Function called whenever we have a cache hit. Normally just does boring logging but dynamic so we can test thisstuff."[k](log/debug (str (u/colorize :green "HIT: ") (name (first k)) " " (hash (rest k)))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(defn ^:dynamic *cache-miss-hook*"Function called whenever we have a cache miss. Normally just does boring logging but dynamic so we can test thisstuff."diff --git a/src/metabase/lib/metadata/calculation.cljc b/src/metabase/lib/metadata/calculation.cljcindex 0856ebfc6e8..4b7176e9be8 100644--- a/src/metabase/lib/metadata/calculation.cljc+++ b/src/metabase/lib/metadata/calculation.cljc@@ -42,6 +42,7 @@name generation. For a joined column, this might look like \"Venues → Price\"."[:enum :default :long])+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *display-name-style*"Display name style to use when not explicitly passed in to [[display-name]].":default)@@ -191,6 +192,7 @@;; anything else: use `pr-str` representation.(pr-str x)))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *propagate-binning-and-bucketing*"Enable propagation of ref's `:temporal-unit` into `:inherited-temporal-unit` of a column or setting ofthe `:lib/original-binning` option.diff --git a/src/metabase/lib/metadata/invocation_tracker.cljc b/src/metabase/lib/metadata/invocation_tracker.cljcindex 52ac1f7e27b..d61b9e41d9c 100644--- a/src/metabase/lib/metadata/invocation_tracker.cljc+++ b/src/metabase/lib/metadata/invocation_tracker.cljc@@ -6,6 +6,7 @@[pretty.core :as pretty]))[metabase.lib.metadata.protocols :as lib.metadata.protocols]))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *to-track-metadata-types*"Set of metadata types to track.Currently only `:metadata/card` is tracked for updating report_card.last_used_at.diff --git a/src/metabase/lib/metric.cljc b/src/metabase/lib/metric.cljcindex 45aece2bba2..7feab88f887 100644--- a/src/metabase/lib/metric.cljc+++ b/src/metabase/lib/metric.cljc@@ -142,6 +142,7 @@(#{:query :native} (lib.util/normalized-query-type query))mbql.normalize/normalize))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *metric-expansion-path*"Metric card IDs whose [[lib.metadata.calculation/metadata-method]] `:metric` expansion is in flight on thisthread/binding, outermost first. A metric's metadata is computed from its inner aggregation, which may itself be adiff --git a/src/metabase/lib/normalize.cljc b/src/metabase/lib/normalize.cljcindex 7d816047bff..7184de267f8 100644--- a/src/metabase/lib/normalize.cljc+++ b/src/metabase/lib/normalize.cljc@@ -52,6 +52,7 @@(pr-str (me/humanize (:explain error))))(:value error))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *error-fn*default-error-fn)diff --git a/src/metabase/lib/ref.cljc b/src/metabase/lib/ref.cljcindex aba1f887e08..52146131917 100644--- a/src/metabase/lib/ref.cljc+++ b/src/metabase/lib/ref.cljc@@ -11,6 +11,7 @@;;; TODO (Cam 6/12/25) -- update `ref-method` to take an options map instead of needing a dynamic variable for stuff;;; like this.+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *ref-style*"The style of field ref to generate -- either the default Lib-style (`:ref.style/default`) or the broken legacy stylereturned by the QP results (`:ref.style/broken-legacy-qp-results`). These broken refs are mostly generated fordiff --git a/src/metabase/lib/schema.cljc b/src/metabase/lib/schema.cljcindex 9f66a1ec5df..afe4fa2bbef 100644--- a/src/metabase/lib/schema.cljc+++ b/src/metabase/lib/schema.cljc@@ -233,6 +233,7 @@acc))stage stage))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *HACK-disable-ref-validation*"Whether to validate join aliases in field refs and expression refs. This is only disable-able as a hack to supportX-Rays code which generates fragments of stages that drop joins and expressions and then adds them again after thediff --git a/src/metabase/lib/schema/expression.cljc b/src/metabase/lib/schema/expression.cljcindex 5daeb1f611f..69f94b46fbf 100644--- a/src/metabase/lib/schema/expression.cljc+++ b/src/metabase/lib/schema/expression.cljc@@ -101,6 +101,7 @@(i18n/tru "type-of {0} returned an invalid type {1}" (pr-str expr) (pr-str expr-type)))(is-type? expr-type base-type)))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *suppress-expression-type-check?*"Set this `true` to skip any type checks for expressions. This is useful while constructing expressions in Lib withfull metadata, but it breaks during legacy conversion in some cases.diff --git a/src/metabase/lib_be/metadata/jvm.clj b/src/metabase/lib_be/metadata/jvm.cljindex 84eb0424e5b..01754c81cce 100644--- a/src/metabase/lib_be/metadata/jvm.clj+++ b/src/metabase/lib_be/metadata/jvm.clj@@ -574,6 +574,7 @@lib.metadata.cached-provider/cached-metadata-providerlib.metadata.invocation-tracker/invocation-tracker-provider))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *metadata-provider-cache*"Bind this to a `(atom (clojure.core.cache/basic-cache-factory {}))` or similar cache-atom, and[[application-database-metadata-provider]] will use it for caching the `MetadataProvider` for each `database-id`diff --git a/src/metabase/llm/provider/settings.clj b/src/metabase/llm/provider/settings.cljindex 842a2989979..7472480b1a3 100644--- a/src/metabase/llm/provider/settings.clj+++ b/src/metabase/llm/provider/settings.clj@@ -225,6 +225,7 @@;;; ---------------------------------------------- Provider connections ------------------------------------------+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *allow-llm-provider-write*"Whether a trusted provider API operation may persist [[llm-providers]] during an HTTP request."false)diff --git a/src/metabase/metabot/agent/core.clj b/src/metabase/metabot/agent/core.cljindex e7212968317..88610c7c22b 100644--- a/src/metabase/metabot/agent/core.clj+++ b/src/metabase/metabot/agent/core.clj@@ -47,6 +47,7 @@;; Or via the API with `"debug": true` in the request body, which emits the;; debug log as a "debug_log" data part in the SSE stream.+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *debug-log*"When bound to an atom, collects full LLM request/response data per iteration.Each entry is a map with :iteration, :request, and :response keys.diff --git a/src/metabase/metabot/metadata_perms.clj b/src/metabase/metabot/metadata_perms.cljindex df6f90135d8..43be52da297 100644--- a/src/metabase/metabot/metadata_perms.clj+++ b/src/metabase/metabot/metadata_perms.clj@@ -9,6 +9,7 @@(set! *warn-on-reflection* true)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *cache*"Cache atom bound by [[with-cache]], or nil to read through to the app DB on every call."nil)diff --git a/src/metabase/metabot/scope.clj b/src/metabase/metabot/scope.cljindex 260aef019e4..743036a4d5f 100644--- a/src/metabase/metabot/scope.clj+++ b/src/metabase/metabot/scope.clj@@ -192,12 +192,14 @@;;; Metabot-specific scope state;;; ──────────────────────────────────────────────────────────────────+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *current-user-scope*"Set of scope strings granted to the current user. Defaults to `#{}` (nopermissions granted). Bind this in the request path once scope resolutionis wired up."#{})+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *current-user-metabot-permissions*"Map of metabot permission type to value for the current user.e.g. `{:permission/metabot-sql-generation :yes, :permission/metabot-nlq :no, ...}`.@@ -205,12 +207,14 @@consumers should fall back to `perm-type-defaults`."nil)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *current-user-capabilities*"The request's capabilities (strings/keywords as sent by the API). Bound in the request pathalongside `*current-user-scope*` so capability-gated checks (e.g. which skills are loadable)match the manifest, which is built from the same capabilities. Defaults to `#{}`."#{})+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *current-loadable-skill-ids*"Request-scoped atom containing the set of skill ids that appeared in the currentprofile's skill manifest. When bound, `load_skill` rejects ids outside this setdiff --git a/src/metabase/metabot/tools/shared.clj b/src/metabase/metabot/tools/shared.cljindex a5947cc18e3..3cb2309f868 100644--- a/src/metabase/metabot/tools/shared.clj+++ b/src/metabase/metabot/tools/shared.clj@@ -13,15 +13,18 @@"row" "pivot" "scatter" "waterfall" "sankey" "scalar""smartscalar" "gauge" "progress" "funnel" "object" "map"])+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *memory-atom*"Dynamic memory atom bound for tools that need access to agent state."nil)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *metabot-id*"The resolved metabot ID for the current agent session. Bound during the agent loopso that tools can scope queries to the correct metabot instance's collection."nil)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *profile-id*"The profile keyword for the current agent session, e.g. `:nlq`. Bound during theagent loop so that tools can adapt their output to the active profile."diff --git a/src/metabase/metabot/tools/shared/content_store.clj b/src/metabase/metabot/tools/shared/content_store.cljindex c87406ea650..f52330e4ea5 100644--- a/src/metabase/metabot/tools/shared/content_store.clj+++ b/src/metabase/metabot/tools/shared/content_store.clj@@ -29,6 +29,7 @@(set! *warn-on-reflection* true)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *last-lookup-refused?*"Set to `true` by [[read-checked]] when a lookup was refused on permissions rather than simplymissing.diff --git a/src/metabase/metabot/used_tables.clj b/src/metabase/metabot/used_tables.cljindex 3347adf266a..5d188e2c121 100644--- a/src/metabase/metabot/used_tables.clj+++ b/src/metabase/metabot/used_tables.clj@@ -210,6 +210,7 @@all-tables (collect-tables queries)](->rows message-id all-tables))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *run-synchronously?*"When true, [[record-used-tables!]] extracts and inserts on the calling thread instead of the backgroundexecutor. Bound to true in tests so assertions can read `metabot_used_table` rows immediately after a turn isdiff --git a/src/metabase/model_persistence/models/persisted_info.clj b/src/metabase/model_persistence/models/persisted_info.cljindex 5746d79161d..14ed5db3f69 100644--- a/src/metabase/model_persistence/models/persisted_info.clj+++ b/src/metabase/model_persistence/models/persisted_info.clj@@ -68,6 +68,7 @@[query :- :metabase.lib-be.schema/maybe-legacy-or-empty-query](String. ^bytes (codecs/bytes->b64 (qp.util/query-hash query))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *allow-persisted-substitution*"Allow persisted substitution. When refreshing, set this to nil to ensure that all underlying queries are used torebuild the persisted table."diff --git a/src/metabase/models/interface.clj b/src/metabase/models/interface.cljindex 98d03f24a69..859ef737505 100644--- a/src/metabase/models/interface.clj+++ b/src/metabase/models/interface.clj@@ -59,6 +59,7 @@modelinstance])+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *deserializing?*"This is dynamically bound to true when deserializing. A few pieces of the Toucan magic are undesirable fordeserialization and are skipped based on this var. (Entity ids are not one of them: the insert hook generates andiff --git a/src/metabase/models/resolution.clj b/src/metabase/models/resolution.cljindex aeb22d315d1..412bb426a8f 100644--- a/src/metabase/models/resolution.clj+++ b/src/metabase/models/resolution.clj@@ -191,6 +191,7 @@(t2.model/resolve-model metabase-models-keyword)))(next-method symb)))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *table-name-resolved* false)(methodical/defmethod t2.model/table-name :around :defaultdiff --git a/src/metabase/models/serialization.clj b/src/metabase/models/serialization.cljindex 613a6a7a683..7d62c06733b 100644--- a/src/metabase/models/serialization.clj+++ b/src/metabase/models/serialization.clj@@ -299,6 +299,7 @@(defmethod make-spec :default [_ _] nil)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(defn ^:dynamic *make-spec*"Cachable wrapper around [[make-spec]] that is memoized inside [[with-cache]]."[model-name opts]@@ -816,6 +817,7 @@;;; ## General foreign keys+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(mu/defn ^:dynamic *export-fk*"Given a numeric foreign key and its model (symbol, name or IModel), looks up the entity by ID and gets its entity IDor identity hash.@@ -838,6 +840,7 @@(throw e#))nil)))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(mu/defn ^:dynamic *import-fk*"Given an identifier, and the model it represents (symbol, name or IModel), looks up the correspondingentity and gets its primary key.@@ -853,6 +856,7 @@model :- :metabase.models.serialization.path/model-keyword-or-symbol](resolve/import-fk (import-resolver) eid model))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(mu/defn ^:dynamic *export-fk-keyed*"Given a numeric ID, look up a different identifying field for that entity, and return it as a portable ID.Eg. `Database.name`.@@ -865,6 +869,7 @@field :- :keyword](resolve/export-fk-keyed (export-resolver) id model field))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(defn ^:dynamic *import-fk-keyed*"Given a single, portable, identifying field and the model it refers to, this resolves the entity and returns itsnumeric `:id`.@@ -876,6 +881,7 @@(resolve/import-fk-keyed (import-resolver) portable model field));;; ## Users+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(mu/defn ^:dynamic *export-user*"Exports a user as the email address.This just calls [[*export-fk-keyed*]], but the counterpart [[*import-user*]] is more involved. This is a unique function@@ -883,6 +889,7 @@[id :- [:maybe ::lib.schema.id/user]](resolve/export-user (export-resolver) id))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(mu/defn ^:dynamic *import-user*"Imports a user by their email address.If a user with that email address exists, returns its primary key.@@ -893,6 +900,7 @@;;; ## Databases+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(defn ^:dynamic *export-database-fk*"Given a numeric database ID, return its name as a portable reference.[[*import-database-fk*]] is the inverse."@@ -900,6 +908,7 @@(when id(resolve/export-fk-keyed (export-resolver) id :model/Database :name)))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(defn ^:dynamic *import-database-fk*"Given a portable database name, resolve it back to a numeric ID.[[*export-database-fk*]] is the inverse."@@ -908,6 +917,7 @@;;; ## Tables+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(mu/defn ^:dynamic *export-table-fk*"Given a numeric `table_id`, return a portable table reference.If the `table_id` is `nil`, return `nil`. This is legal for a native question.@@ -917,6 +927,7 @@(when table-id(resolve/export-table-fk (export-resolver) table-id)))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(mu/defn ^:dynamic *import-table-fk*"Given a `table_id` as exported by [[*export-table-fk*]], resolve it back into a numeric `table_id`.The input might be nil, in which case so is the output. This is legal for a native question."@@ -967,6 +978,7 @@;; the export. Export order can't be arranged around field-fk reuse either, so even a bounded;; cache has no reliable hit rate. If caching is ever added here (e.g. for the reuse-heavy;; FK-target refs), it MUST be bounded so no O(field-count) structure can blow up memory.+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(mu/defn ^:dynamic *export-field-fk*"Given a numeric `field_id`, return a portable field reference.That has the form `[db-name schema table-name field-name]`, where the `schema` might be nil.@@ -977,6 +989,7 @@[db-name schema table-name] (*export-table-fk* (:table_id (first fields)))](into [db-name schema table-name] (map :name fields)))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(mu/defn ^:dynamic *import-field-fk*"Given a `field_id` as exported by [[*export-field-fk*]], resolve it back into a numeric `field_id`."[[_db-name _schema _table-name & _fields :as field-id] :- [:maybe [:cat string? [:maybe string?] string? #_fields [:+ string?]]]]@@ -1027,6 +1040,7 @@(cond->> mbqlschema (lib/normalize schema mbql))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *required-lib-uuids-for-export* nil)(mu/defn- collect-required-lib-uuids :- [:set ::lib.schema.common/uuid]@@ -1201,6 +1215,7 @@(import-mbql-map m)));; Unfortunately, settings depend on serdes, so we can't read settings directly in serdes (circular dep)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *skip-schema-validation?*"When true, [[import-mbql]] stores a normalized query without checking it against this instance's query schema."false)diff --git a/src/metabase/models/serialization/resolve.clj b/src/metabase/models/serialization/resolve.cljindex 3afee116f3b..dc3f69372b7 100644--- a/src/metabase/models/serialization/resolve.clj+++ b/src/metabase/models/serialization/resolve.clj@@ -39,10 +39,12 @@;;; Dynamic vars — bound to resolver instances;;; ============================================================+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *export-resolver*"The current `SerdesExportResolver` instance. Bound during export."nil)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *import-resolver*"The current `SerdesImportResolver` instance. Bound during import."nil)@@ -51,6 +53,7 @@;;; Agent surface;;; ============================================================+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *numeric-ids-allowed?*"Whether bare numeric table/field/card ids are accepted alongside portable references insidea query body being resolved.diff --git a/src/metabase/models/serialization/resolve/mp.clj b/src/metabase/models/serialization/resolve/mp.cljindex a1a19aaa559..7b949b4a776 100644--- a/src/metabase/models/serialization/resolve/mp.clj+++ b/src/metabase/models/serialization/resolve/mp.clj@@ -277,6 +277,7 @@;;; Content store - Metabase asset lookups by portable entity id or numeric id;;; ============================================================+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *audit-refusals?*"Whether a permission-aware [[ContentStore]] audits a refusal, i.e. leaves the ERROR log lineand `:event/read-permission-failure` that `api/read-check` does, rather than throwing a barediff --git a/src/metabase/mq/listener.clj b/src/metabase/mq/listener.cljindex 1338433a0c9..7b965893724 100644--- a/src/metabase/mq/listener.clj+++ b/src/metabase/mq/listener.clj@@ -13,6 +13,7 @@(set! *warn-on-reflection* true)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *listeners*"channel → {:listener fn} for all channels."(atom {}))diff --git a/src/metabase/mq/publish_buffer.clj b/src/metabase/mq/publish_buffer.cljindex 376a6f70b7b..3f9a4cd6213 100644--- a/src/metabase/mq/publish_buffer.clj+++ b/src/metabase/mq/publish_buffer.clj@@ -13,15 +13,18 @@(set! *warn-on-reflection* true)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *publish-buffer-ms*"Time window in ms to buffer rapid-fire publishes. 0 = immediate publish.Resets on every new message (sliding window)."100)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *publish-buffer-max-ms*"Maximum time in ms since the first message before a flush is forced. 0 = no max."5000)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *publish-buffer*"Accumulation buffer for rapid-fire publishes.channel → {:messages [...] :deadline-ms long :created-ms long}"diff --git a/src/metabase/mq/queue/backend.clj b/src/metabase/mq/queue/backend.cljindex de37cd82066..d0431a2572f 100644--- a/src/metabase/mq/queue/backend.clj+++ b/src/metabase/mq/queue/backend.clj@@ -50,6 +50,7 @@(shutdown! [this]"Shuts down all queue resources for this backend."))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *backend*"The active `QueueBackend` instance. Set by `metabase.mq.init/start!`."nil)diff --git a/src/metabase/mq/queue/concurrency.clj b/src/metabase/mq/queue/concurrency.cljindex d402033a796..f498dacf6bf 100644--- a/src/metabase/mq/queue/concurrency.clj+++ b/src/metabase/mq/queue/concurrency.clj@@ -20,6 +20,7 @@(set! *warn-on-reflection* true)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *in-flight*"channel → how many batches this node is currently delivering for it. A channel with nothing inflight is absent rather than zero, so the map stays small.diff --git a/src/metabase/mq/queue/registry.clj b/src/metabase/mq/queue/registry.cljindex e42e758cb67..c820da0627e 100644--- a/src/metabase/mq/queue/registry.clj+++ b/src/metabase/mq/queue/registry.clj@@ -53,6 +53,7 @@(fn [{:keys [exclusive max-concurrent-batches]}](not (and exclusive max-concurrent-batches)))]])+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *queues*"queue-name (keyword) → config map for every declared queue.diff --git a/src/metabase/notification/events/notification.clj b/src/metabase/notification/events/notification.cljindex 63d60fb3017..48e3ceab7c5 100644--- a/src/metabase/notification/events/notification.clj+++ b/src/metabase/notification/events/notification.clj@@ -64,6 +64,7 @@(when (supported-topics topic)(models.notification/notifications-for-event topic)))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *skip-sending-notification?*"Used as a hack for when we need to skip sending notifications for certain events.diff --git a/src/metabase/notification/send.clj b/src/metabase/notification/send.cljindex fa046483d3b..c9a64abcf8b 100644--- a/src/metabase/notification/send.clj+++ b/src/metabase/notification/send.clj@@ -456,6 +456,7 @@[:map {:closed true}[:notification/sync? :boolean]])+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *default-options*"The default options for sending a notification."{:notification/sync? false})diff --git a/src/metabase/parameters/chain_filter.clj b/src/metabase/parameters/chain_filter.cljindex 2e97908baad..dedd6bfdf9c 100644--- a/src/metabase/parameters/chain_filter.clj+++ b/src/metabase/parameters/chain_filter.clj@@ -124,6 +124,7 @@[:lhs ::table-field-endpoint][:rhs ::table-field-endpoint]])+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *enable-reverse-joins*"Whether to chain filter via joins where we must follow relationships in reverse, e.g. child -> parent (e.g.Restaurant -> Category instead of the usual Category -> Restaurant*)@@ -550,6 +551,7 @@(get v->human-readable v (get v->human-readable (str v))))values)))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *allow-implicit-uuid-field-remapping*"Should implicit remapping be allowed _for uuid fields_? Not eg. for`GET /dashboard/:id/params/:param-key/search/:query` to search on actual field that was pickeddiff --git a/src/metabase/parameters/custom_values.clj b/src/metabase/parameters/custom_values.cljindex 85319dc5931..f10a570cfe7 100644--- a/src/metabase/parameters/custom_values.clj+++ b/src/metabase/parameters/custom_values.clj@@ -57,6 +57,7 @@;;; ---------------------------------------------------- source=card ------------------------------------------------------+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *max-rows*"Maximum number of rows returned when running a card.It's 1000 because it matches with the limit for chain-filter.diff --git a/src/metabase/parameters/params.clj b/src/metabase/parameters/params.cljindex 5a7e917be4b..f1f99b6fbda 100644--- a/src/metabase/parameters/params.clj+++ b/src/metabase/parameters/params.clj@@ -69,6 +69,7 @@{:parameter_mappings parameter-mappings:errors (:errors (mr/explain schema parameter-mappings))})))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *ignore-current-user-perms-and-return-all-field-values*"Whether to ignore permissions for the current User and return *all* FieldValues for the Fields being parameterized byCards and Dashboards. This determines how `:param_values` gets hydrated for Card and Dashboard. Normally, this is@@ -295,6 +296,7 @@(update-in [:param-id->field-ids param-id] conj field-id))ctx)))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *field-id-context*"Context for effective computation of field ids for parameters. Bound inthe [[metabase.dashboards-rest.api/hydrate-dashboard-details]]. Meant to be used in the [[field-id-into-context-rf]], todiff --git a/src/metabase/permissions/models/data_permissions.clj b/src/metabase/permissions/models/data_permissions.cljindex e852e7f813e..181bd845e5e 100644--- a/src/metabase/permissions/models/data_permissions.clj+++ b/src/metabase/permissions/models/data_permissions.clj@@ -32,6 +32,7 @@(methodical/defmethod t2/table-name :model/DataPermissions [_model] :data_permissions)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic ^:private *skip-cluster-locks*"When true, skip per-(db-id, perm-type) cluster locks. Should only be bound to truewhen a coarser lock is already held by the calling code."@@ -232,6 +233,7 @@caller passing a very large set is split across several queries rather than failing outright."5000)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *use-perms-cache?*"Bind to `false` to intentionally bypass the permissions caches and fetch data straight from the DB."true)@@ -248,6 +250,7 @@(and *use-perms-cache?*(= user-id api/*current-user-id*)))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *perms-cache-misses-are-errors?*"Whether a permission check that has to load turns into an exception rather than a query. Bound to true by[[with-relevant-permissions-for-user]] in dev and test, so an unprimed batch of checks fails loudly there and@@ -310,6 +313,7 @@;;; --------------------------------------------- Database level cache ---------------------------------------------+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *db-permission-cache*"Request cache for every whole-database question:`{user-id {perm-type {db-id {:database v :every-table v :any-table v}}}}`.@@ -339,6 +343,7 @@Checks that walk a list of databases should [[prime-database-perms-cache]] first, exactly as table checks do."(atom {:db-ids #{} :perms {}}))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *all-db-permission-cache*"Request cache for the questions that scan *every* database rather than asking about one --[[user-has-any-perms-of-type?]]. Shaped like [[*db-permission-cache*]]'s `:perms`, but loaded in full, so it needs@@ -415,6 +420,7 @@;;; ---------------------------------------------- Schema level cache ----------------------------------------------+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *schema-permission-cache*"Request cache for [[schema-permission-for-user]]: `{:db-ids #{} :perms {user-id {perm-type {db-id entry}}}}`where each entry is `{:default v, :schemas {schema v}}` — per schema, the coalesced value of the schema's table@@ -463,6 +469,7 @@;;; ---------------------------------------------- Table level cache -----------------------------------------------+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *table-permission-cache*"Request cache for [[table-permission-for-user]]:@@ -560,6 +567,7 @@;;; ---------------------------------------------- Table level checks ----------------------------------------------+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *additional-table-permissions*"See the `with-additional-table-permission` macro below."{})@@ -846,6 +854,7 @@[_user-id]#{})+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *sandboxes-for-user*"Filled by `enforced-sandboxes-for-user`. Empty on OSS instances, or EE instances without the `sandboxes` feature."(delay nil))diff --git a/src/metabase/permissions/models/permissions.clj b/src/metabase/permissions/models/permissions.cljindex 9a6fb00eef1..5cd199d8320 100644--- a/src/metabase/permissions/models/permissions.clj+++ b/src/metabase/permissions/models/permissions.clj@@ -188,11 +188,13 @@;;; -------------------------------------------------- Dynamic Vars --------------------------------------------------+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic ^Boolean *allow-root-entries*"Should we allow permissions entries like `/`? By default, this is disallowed, but you can temporarily disable it herewhen creating the default entry for `Admin`."false)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic ^Boolean *allow-admin-permissions-changes*"Should we allow changes to be made to permissions belonging to the Admin group? By default this is disabled toprevent accidental tragedy, but you can enable it here when creating the default entry for `Admin`."diff --git a/src/metabase/permissions/models/permissions_group.clj b/src/metabase/permissions/models/permissions_group.cljindex da0f53a9f1a..31d43ea7d62 100644--- a/src/metabase/permissions/models/permissions_group.clj+++ b/src/metabase/permissions/models/permissions_group.clj@@ -92,6 +92,7 @@(when (exists-with-name? group-name)(throw (ex-info (tru "A group with that name already exists.") {:status-code 400}))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic ^:private *allow-modifying-magic-groups*"Dynamic var that, when bound to true, allows modifying magic groups. Used by [[sync-data-analyst-group-for-oss!]]."false)diff --git a/src/metabase/permissions/models/permissions_group_membership.clj b/src/metabase/permissions/models/permissions_group_membership.cljindex 96c96da4153..c3b1646eecf 100644--- a/src/metabase/permissions/models/permissions_group_membership.clj+++ b/src/metabase/permissions/models/permissions_group_membership.clj@@ -20,11 +20,13 @@"Exception message when try to remove the last admin."(deferred-tru "You cannot remove the last member of the ''Admin'' group!"))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *allow-changing-all-users-group-members*"Should we allow people to be added to or removed from the All Users permissions group? By default, this is `false`,but enable it when adding or deleting users."false)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *allow-changing-all-external-users-group-members*"Should we allow people to be added to or removed from the All tenant users permissions group? By default, this is`false`, but enable it when adding or deleting users."@@ -69,8 +71,10 @@(throw (ex-info (str fail-to-remove-last-admin-msg){:status-code 400}))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic ^:private *update-user-when-added-to-admin-group?* true)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *allow-direct-deletion*"Should we allow direct `t2/delete!` calls on PermissionsGroupMembership? By default this is `false`; only theblessed helper functions like `remove-user-from-group!` bind this to `true`."diff --git a/src/metabase/premium_features/token_check.clj b/src/metabase/premium_features/token_check.cljindex 7393b1434ff..75b366aa576 100644--- a/src/metabase/premium_features/token_check.clj+++ b/src/metabase/premium_features/token_check.clj@@ -300,6 +300,7 @@:status "invalid":error-details (trs "Token should be a valid 64 hexadecimal character token or an airgap token.")})))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *token-check-happening* "Var to prevent recursive calls to `fetch-token-status`" false)(p/defprotocol+ TokenChecker@@ -412,6 +413,7 @@(catch Throwable t(log/warnf "Failed to mirror :locked-meters from token-check response: %s" (ex-message t))))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *testing-only-call-after-refresh*"When non-nil, a zero-arg function called after async background refresh completes.For testing only — do not use in production."@@ -514,6 +516,7 @@:error-details (.getMessage e)})))(-clear-cache! [_] (-clear-cache! token-checker))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *customize-checker*"Dynamic variable allowing for customized token checkers. In the app, we want all of these in place. Only in testsshould we construct ones without circuit breakers "@@ -614,6 +617,7 @@(log/errorf "Error validating token: %s" (ex-message e)));; log every five minutes:ttl/threshold (* 1000 60 5))]+ #_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(mu/defn ^:dynamic *token-features* :- [:set ms/NonBlankString]"Get the features associated with the system's premium features token."[]diff --git a/src/metabase/pulse/models/pulse.clj b/src/metabase/pulse/models/pulse.cljindex ede5385f51d..7490e3eaf8c 100644--- a/src/metabase/pulse/models/pulse.clj+++ b/src/metabase/pulse/models/pulse.clj@@ -85,6 +85,7 @@(collection/check-allowed-content :model/Pulse (:collection_id notification))(collection/check-collection-namespace :model/Pulse (:collection_id notification)))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *allow-moving-dashboard-subscriptions*"If true, allows the collection_id on a dashboard subscription to be modified. This shouldonly be done when the associated dashboard is being moved to a new collection."@@ -305,6 +306,7 @@:id{:default []}))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *allow-hydrate-archived-cards*"By default the :cards hydration method only return active cards,but in cases we need to send email after a card is archived, we need to be able to hydrate archived card as well."diff --git a/src/metabase/pulse/models/pulse_channel.clj b/src/metabase/pulse/models/pulse_channel.cljindex bc93bbefa27..5599ef49f0c 100644--- a/src/metabase/pulse/models/pulse_channel.clj+++ b/src/metabase/pulse/models/pulse_channel.clj@@ -140,6 +140,7 @@{:email email})(get pcid->recipients (:id pc))))))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *archive-parent-pulse-when-last-channel-is-deleted*"Should we automatically archive a Pulse when its last `PulseChannel` is deleted? Normally we do, but this is disabledin [[update-notification-channels!]] which creates/deletes/updates several channels sequentially."diff --git a/src/metabase/query_permissions/impl.clj b/src/metabase/query_permissions/impl.cljindex 3b01c2b6f32..80509cfefbc 100644--- a/src/metabase/query_permissions/impl.clj+++ b/src/metabase/query_permissions/impl.clj@@ -166,6 +166,7 @@(when (seq query)(:table-ids (query->source-ids query))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *card-instances*"A map from card IDs to card instances with the collection_id (possibly nil).Useful when bulk loading cards from different databases."diff --git a/src/metabase/query_processor/card.clj b/src/metabase/query_processor/card.cljindex 4bb5e36f8d6..3c82e32b509 100644--- a/src/metabase/query_processor/card.clj+++ b/src/metabase/query_processor/card.clj@@ -132,6 +132,7 @@(assoc :cache-strategy cs)(->> (lib/normalize ::lib.schema/query))))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *allow-arbitrary-mbql-parameters*"In 0.41.0+ you can no longer add arbitrary `:parameters` to a query for a saved question -- only parameters fortemplate tags that are part of a /native/ query may be supplied (only native queries can have template tags); thediff --git a/src/metabase/query_processor/debug.clj b/src/metabase/query_processor/debug.cljindex 83435ca773c..70a2ca118de 100644--- a/src/metabase/query_processor/debug.clj+++ b/src/metabase/query_processor/debug.clj@@ -8,6 +8,7 @@(binding [metabase.query-processor.debug/*debug* true](metabase.query-processor/process-query query)")+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *debug*"Whether to enable debug tapping."false)diff --git a/src/metabase/query_processor/interface.clj b/src/metabase/query_processor/interface.cljindex c8149417312..70aa16e3787 100644--- a/src/metabase/query_processor/interface.clj+++ b/src/metabase/query_processor/interface.clj@@ -9,11 +9,13 @@;;;; TODO - I think we should just remove this entirely, it's not used consistently and it's more trouble than it's;; worth. Just dial down the log level a bit where we're currently using this+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic ^Boolean *disable-qp-logging*"Should we disable logging for the QP? (e.g., during sync we probably want to turn it off to keep logs lesscluttered)."false)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *skip-middleware-because-app-db-access*"Dynamic variable that skips middleware (when bound to true) because it accesses the app-db. Will be replaced inQUE2-488"diff --git a/src/metabase/query_processor/middleware/cache.clj b/src/metabase/query_processor/middleware/cache.cljindex 37b6eb0d16a..c1e927936b8 100644--- a/src/metabase/query_processor/middleware/cache.clj+++ b/src/metabase/query_processor/middleware/cache.clj@@ -41,6 +41,7 @@[initial-metadata row-1 row-2 ... row-n final-metadata]"3)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *backend*"Current cache backend. Dynamically rebindable primary for test purposes."(i/cache-backend (config/config-kw :mb-qp-cache-backend)))@@ -73,6 +74,7 @@(defn- schedule-purge! [backend](grouper/submit! @purge-queue backend))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *in-fn*"The `in-fn` provided by [[impl/do-with-serialization]]."nil)@@ -85,6 +87,7 @@(m/update-existing object :json_query lib/prepare-for-serialization)object))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *result-fn*"The `result-fn` provided by [[impl/do-with-serialization]]."nil)@@ -202,6 +205,7 @@(u/prog1 (qp.pipeline/*reduce* (cached-results-rff rff query-hash) metadata reducible-rows)(log/trace "All cached rows reduced"))))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *refresh-lease-duration-ms*"How long a claimed stale-while-revalidate refresh lease is honored before another process may take it over (e.g. ifthe claiming process crashed mid-refresh). Should comfortably exceed a normal query's run time."diff --git a/src/metabase/query_processor/middleware/permissions.clj b/src/metabase/query_processor/middleware/permissions.cljindex ba428790121..6324135b969 100644--- a/src/metabase/query_processor/middleware/permissions.clj+++ b/src/metabase/query_processor/middleware/permissions.clj@@ -17,6 +17,7 @@[metabase.util.log :as log][metabase.util.malli :as mu]))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *card-id*"ID of the Card currently being executed, if there is one. Bind this in a Card-execution so we will useCard [Collection] perms checking rather than ad-hoc perms checking."@@ -54,6 +55,7 @@(throw-inactive-table-error (lib.metadata.protocols/database (qp.store/metadata-provider))table)))))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *param-values-query*"Used to allow users looking at a dashboard to view (possibly chained) filters."false)diff --git a/src/metabase/query_processor/middleware/process_userland_query.clj b/src/metabase/query_processor/middleware/process_userland_query.cljindex db5a27c5eab..5fe521a3a19 100644--- a/src/metabase/query_processor/middleware/process_userland_query.clj+++ b/src/metabase/query_processor/middleware/process_userland_query.clj@@ -210,6 +210,7 @@:is_db_routed (qp.middleware.enterprise/currently-db-routed?)}destination-db-id (assoc :database_id destination-db-id))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic ^:private *execution-context-ref*"Bound to an atom by [[process-userland-query-middleware]] for each userland query.[[capture-execution-context-middleware]] writes the snapshotted impersonation/db-routing context here while thediff --git a/src/metabase/query_processor/middleware/wrap_value_literals.clj b/src/metabase/query_processor/middleware/wrap_value_literals.cljindex dc6c2665f8c..738098cb4bd 100644--- a/src/metabase/query_processor/middleware/wrap_value_literals.clj+++ b/src/metabase/query_processor/middleware/wrap_value_literals.clj@@ -32,6 +32,7 @@(when-let [unit (lib/raw-temporal-bucket col)]{:unit unit}))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(defn- ^:dynamic *type-info*"This is the type info for the LHS in something likediff --git a/src/metabase/query_processor/pipeline.clj b/src/metabase/query_processor/pipeline.cljindex ed5497bb01e..51996488fbf 100644--- a/src/metabase/query_processor/pipeline.clj+++ b/src/metabase/query_processor/pipeline.clj@@ -7,12 +7,14 @@[metabase.util.i18n :as i18n][metabase.util.log :as log]))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *pivot?*"True while [[metabase.query-processor.pivot]] is re-running its generated sub-queries through the query processor.These sub-queries carry internal `:qp.pivot/*` keys and already-derived annotations, so preprocessing must not stripinternal keys from them."false)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic ^clojure.core.async.impl.channels.ManyToManyChannel *canceled-chan*"If this channel is bound, you can send it a message to cancel the query. You can check if it has received a messageto see if the query has been canceled.@@ -41,12 +43,14 @@(throw result)result))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(defn ^:dynamic *result*"Called exactly once with the final result, which is the result of either [[*reduce*]] (if query completedsuccessfully), or an Exception (if it did not)."[result](default-result-handler result))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(defn ^:dynamic *execute*"Called by [[*run*]] to have driver run query. By default, [[metabase.driver/execute-reducible-query]]. `respond` is acallback with the signature:@@ -64,6 +68,7 @@(let [context {:canceled-chan *canceled-chan*}](driver/execute-reducible-query driver query context respond))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(defn ^:dynamic *reduce*"Called by [[*run*]] (inside the `respond` callback provided by it) to reduce results of query. Reduces results, thencalls [[*result*]] with the reduced results."@@ -111,6 +116,7 @@(or (instance? InterruptedException e)(some-> (ex-cause e) interrupted-exception?)))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(defn ^:dynamic *run*"Function for running the query. Calls [[*execute*]], then [[*reduce*]] on the results."[query rff]diff --git a/src/metabase/query_processor/pivot.clj b/src/metabase/query_processor/pivot.cljindex bf774859c5e..f503f28d975 100644--- a/src/metabase/query_processor/pivot.clj+++ b/src/metabase/query_processor/pivot.clj@@ -587,6 +587,7 @@:qp.pivot/num-remapped-breakouts num-remapped-breakouts:qp.pivot/remapped-indexes remap)))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic ^:private *pivot-max-result-rows*"Maximum number of result rows for each pivot sub-query. Divided by the number of aggregations since each aggregationadds a column to the output, so fewer rows are needed to fill the pivot table."@@ -711,6 +712,7 @@[](boolean (some-> (resolve 'clojure.test/*testing-vars*) deref seq)))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *check-pivot-parity?*"Controls whether [[run-pivot-query]] runs both the native and multi-query pivot paths whenever both areapplicable and reports disagreement via [[*on-parity-mismatch*]]. Left at the default sentinel@@ -740,6 +742,7 @@:actual native-outcome})(log/warnf "Pivot parity mismatch — native and multi-query paths disagree: %s" (pr-str ctx))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *on-parity-mismatch*"Called with `{:native-outcome ..., :multi-outcome ...}` when the two pivot paths disagree under[[*check-pivot-parity?*]]. Each outcome is either the result map returned by the path, or thediff --git a/src/metabase/query_processor/settings.clj b/src/metabase/query_processor/settings.cljindex fabb248ee6f..11165a13f3e 100644--- a/src/metabase/query_processor/settings.clj+++ b/src/metabase/query_processor/settings.clj@@ -58,6 +58,7 @@details."1048575)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic ^:private *minimum-download-row-limit*"Minimum download row limit. Using dynamic so we can rebind in tests"absolute-max-results)diff --git a/src/metabase/query_processor/setup.clj b/src/metabase/query_processor/setup.cljindex bf93d7b3deb..ebf6247a935 100644--- a/src/metabase/query_processor/setup.clj+++ b/src/metabase/query_processor/setup.clj@@ -273,6 +273,7 @@#'do-with-resolved-database]);;; ↑↑↑ SETUP MIDDLEWARE ↑↑↑ happens from BOTTOM to TOP e.g. [[do-with-resolved-database]] is the first to do its thing+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *has-setup*"This is here so we can skip calling the setup middleware if it's already done. Not super important, since the setupmiddleware should all no-op, but it keeps the stacktraces tidier so we do not have a bunch of calls that don't dodiff --git a/src/metabase/query_processor/store.clj b/src/metabase/query_processor/store.cljindex 080a86b1dd5..9ad5c645bd4 100644--- a/src/metabase/query_processor/store.clj+++ b/src/metabase/query_processor/store.clj@@ -42,6 +42,7 @@(throw (ex-info "Error: Query Processor store is not initialized. Initialize it with qp.store/with-metadata-provider"{})))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *store*"Dynamic var used as the QP store for a given query execution."uninitialized-store)@@ -54,6 +55,7 @@"Key sequence for a value in the store's miscellaneous cache; [[cached]] prefixes it with a unique symbol."[:sequential [:or :keyword :symbol :int :string]])+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *DANGER-allow-replacing-metadata-provider*"This is (almost) only for tests! When enabled, [[with-metadata-provider]] can completely replace the current metadataprovider (and cache) with a new one. This is reset to false after the QP store is replaced the first time.diff --git a/src/metabase/query_processor/streaming/xlsx.clj b/src/metabase/query_processor/streaming/xlsx.cljindex 10ab1fbc3eb..0b4d6ae2533 100644--- a/src/metabase/query_processor/streaming/xlsx.clj+++ b/src/metabase/query_processor/streaming/xlsx.clj@@ -373,6 +373,7 @@[^Cell cell t styles typed-styles](set-cell! cell (t/offset-date-time t) styles typed-styles))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *number-of-characters-cell*"Total number of characters that a cell can contain, 32767 is the maximum number supported by the cell.";; See https://support.microsoft.com/en-us/office/excel-specifications-and-limits-1672b34d-7043-467e-8e27-269d656771c3@@ -570,6 +571,7 @@scaled-val)](set-cell! cell parsed-value styles typed-cell-styles))))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *auto-sizing-threshold*"The maximum number of rows we should use for auto-sizing. If this number is too large, exportsof large datasets will be prohibitively slow."diff --git a/src/metabase/query_processor/timezone.clj b/src/metabase/query_processor/timezone.cljindex cec978b6230..9215406656a 100644--- a/src/metabase/query_processor/timezone.clj+++ b/src/metabase/query_processor/timezone.clj@@ -19,10 +19,13 @@(set! *warn-on-reflection* true)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *report-timezone-id-override* nil)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *database-timezone-id-override* nil)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *results-timezone-id-override* nil);; TODO - consider making this `metabase.util.date-2/the-timezone-id`diff --git a/src/metabase/query_processor/util.clj b/src/metabase/query_processor/util.cljindex c70ec103a6d..0435c95b92d 100644--- a/src/metabase/query_processor/util.clj+++ b/src/metabase/query_processor/util.clj@@ -104,6 +104,7 @@(merge new-col (select-keys old-col preserved-keys))new-col))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *execute-async?*"Whether to save QueryExecutions (and other post-execution side effects) asynchronously via the batch-processingqueue. Bind (or redef, when the query runs on another thread) to `false` in tests to save synchronously on thediff --git a/src/metabase/query_processor/util/add_alias_info.clj b/src/metabase/query_processor/util/add_alias_info.cljindex 30b7ff039b6..50be5a6fb7f 100644--- a/src/metabase/query_processor/util/add_alias_info.clj+++ b/src/metabase/query_processor/util/add_alias_info.clj@@ -65,6 +65,7 @@[metabase.util.match :as match][metabase.util.performance :refer [mapv select-keys some empty? not-empty get-in]]))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(mu/defn- ^:dynamic *escape-alias-fn* :- :string[driver :- :keywords :- :string]diff --git a/src/metabase/request/current.clj b/src/metabase/request/current.cljindex 2f83eef2f6d..d70b46e73a4 100644--- a/src/metabase/request/current.clj+++ b/src/metabase/request/current.clj@@ -7,6 +7,7 @@[clojure.string :as str][metabase.request.settings :as request.settings]))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *request*nil)@@ -27,6 +28,7 @@[request & body]`(do-with-current-request ~request (^:once fn* [] ~@body)))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *limit*nil)@@ -35,6 +37,7 @@[]*limit*)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *offset*nil)@@ -43,6 +46,7 @@[]*offset*)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *paged?*false)diff --git a/src/metabase/request/session.clj b/src/metabase/request/session.cljindex f4b3ca6403f..a04605682e5 100644--- a/src/metabase/request/session.clj+++ b/src/metabase/request/session.clj@@ -14,6 +14,7 @@(some-> (request.db/current-user user-id)user/add-attributes)))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *user-local-values-user-id*"User ID that we've previous bound [[*user-local-values*]] for. This exists so we can avoid rebinding it in recursivecalls to [[with-current-user]] if it is already bound, as this can mess things up since thingsdiff --git a/src/metabase/search/appdb/index.clj b/src/metabase/search/appdb/index.cljindex a831b1451e7..5fe9ec7aa95 100644--- a/src/metabase/search/appdb/index.clj+++ b/src/metabase/search/appdb/index.clj@@ -34,10 +34,12 @@(defonce ^:private next-sync-at (atom nil))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(defonce ^:dynamic ^:private ^{:doc "This atom is often reset! in threads, so modifications should be done only when locking it first."}*indexes*(atom {:active nil, :pending nil}))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *mocking-tables* false)(defmethod search.engine/reset-tracking! :search.engine/appdb [_]diff --git a/src/metabase/search/config.clj b/src/metabase/search/config.cljindex a647915acbd..0ec2bdef1ef 100644--- a/src/metabase/search/config.clj+++ b/src/metabase/search/config.clj@@ -10,6 +10,7 @@[metabase.util.malli.registry :as mr][metabase.util.malli.schema :as ms]))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *db-max-results*"Number of raw results to fetch from the database. This number is in place to prevent massive application DB load byreturning tons of results; this number should probably be adjusted downward once we have UI in place to indicatediff --git a/src/metabase/search/ingestion.clj b/src/metabase/search/ingestion.cljindex 37046facc59..3de0a8c336b 100644--- a/src/metabase/search/ingestion.clj+++ b/src/metabase/search/ingestion.clj@@ -203,10 +203,12 @@(filter some?)(reduce + 0)))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *force-sync*"Force ingestion to happen immediately, on the same thread."false)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *disable-updates*"Used by tests to disable updates, for example when testing migrations, where the schema is wrong."false)diff --git a/src/metabase/search/spec.clj b/src/metabase/search/spec.cljindex 136f973db55..bdb26382c51 100644--- a/src/metabase/search/spec.clj+++ b/src/metabase/search/spec.clj@@ -513,6 +513,7 @@(sequential? form) (mapv canonicalize form):else form))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *testing-only-index-version-hash*"Override for tests that need a specific index version."nil)diff --git a/src/metabase/server/settings.clj b/src/metabase/server/settings.cljindex b1d06971306..cdd66ef2285 100644--- a/src/metabase/server/settings.clj+++ b/src/metabase/server/settings.clj@@ -114,6 +114,7 @@ x.com"):doc "Timeout in milliseconds to wait after query cancellation before escalating to thread interruption.This is used to free up threads that are stuck waiting for a DB response after a query has been cancelled.")+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic ^Long *thread-interrupt-escalation-timeout-ms*"Timeout in milliseconds to wait after query cancellation before escalating to thread interruption."(thread-interrupt-escalation-timeout-ms))diff --git a/src/metabase/server/streaming_response.clj b/src/metabase/server/streaming_response.cljindex 515ae95e73f..3fce2b9c139 100644--- a/src/metabase/server/streaming_response.clj+++ b/src/metabase/server/streaming_response.clj@@ -44,6 +44,7 @@(cond-> (Throwable->map e)(server.settings/hide-stacktraces) (dissoc :via :trace)))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *response*"The `HttpServletResponse` for the current streaming response.Bound automatically inside `streaming-response` bodies in the Jetty async path.@@ -51,6 +52,7 @@[[set-content-type!]] to interact with it."nil)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *request*"The Jetty `Request` for the current streaming response.Bound automatically inside `streaming-response` bodies in the Jetty async path.@@ -58,6 +60,7 @@occurs after the response has already been committed."nil)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *completed?*"An `AtomicBoolean` that is set to `true` when the async context has been completed,either by the worker thread or by Jetty's timeout/error callbacks. When `true`, thediff --git a/src/metabase/settings/models/setting.clj b/src/metabase/settings/models/setting.cljindex 044587191f5..1a389d4e22e 100644--- a/src/metabase/settings/models/setting.clj+++ b/src/metabase/settings/models/setting.clj@@ -36,6 +36,7 @@(java.util.concurrent TimeUnit)(java.util.concurrent.locks ReentrantLock)))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *database*"The database upon which we are operating, from which [[*database-local-values*]] are taken.This is used to do a just-in-time check whether a given setting is enabled for the given database, so that we can@@ -45,6 +46,7 @@You may need to manually bind it in other places where you want to use Database-local values."nil)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *database-local-values*"Database-local Settings values (as a map of Setting name -> already-deserialized value). This comes from the value of`Database.settings` in the application DB. When bound, any Setting that *can* be Database-local will have a value@@ -54,6 +56,7 @@You may need to manually bind it in other places where you want to use Database-local values."nil)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *user-local-values*"User-local Settings values (as a delay to a atom containing a map of Setting name -> already-deserialized value). Thiscomes from the value of `User.settings` in the application DB. When bound, any Setting that *can* be User-local will@@ -75,6 +78,7 @@"user-recent-views""most-recently-viewed-dashboard"})+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *allow-retired-setting-names*"A dynamic val that controls whether it's allowed to use retired settings.Primarily used in test to disable retired setting check."@@ -410,6 +414,7 @@(swap! @*user-local-values* u/assoc-dissoc setting-name value)(settings.db/update-user-settings! api/*current-user-id* (json/encode @@*user-local-values*))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *enforce-setting-access-checks*"A dynamic var that controls whether we should enforce checks on setting access. Defaults to false; should beset to true when settings are being written directly via /api/setting endpoints."@@ -534,6 +539,7 @@(log/warnf "Deprecated %s is set; rename it to %s."legacy-env primary-env)))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *disable-init* false)(declare get)@@ -563,6 +569,7 @@(settings.db/setting-value setting-name-str)(core/get cache setting-name-str))))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *deprecated-db-key-warned*"Set of deprecated DB keys that have already triggered a warning. Dynamic so tests can rebind it."(atom #{}))diff --git a/src/metabase/setup_rest/api.clj b/src/metabase/setup_rest/api.cljindex 1cb1838a493..9977dda34f1 100644--- a/src/metabase/setup_rest/api.clj+++ b/src/metabase/setup_rest/api.clj@@ -29,6 +29,7 @@(every-pred string? #'setup/token-match?)]](i18n/deferred-tru "Token does not match the setup token.")))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic ^:private *allow-api-setup-after-first-user-is-created*"We must not allow users to setup multiple super users after the first user is created. But tests still need to be ableto. This var is redef'd to false by certain tests to allow that."diff --git a/src/metabase/slackbot/query.clj b/src/metabase/slackbot/query.cljindex e42d2719c03..d3236ec34fd 100644--- a/src/metabase/slackbot/query.clj+++ b/src/metabase/slackbot/query.clj@@ -80,10 +80,12 @@"Maximum number of columns Slack table blocks support."20)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *slack-table-max-cell-length*"Maximum text length per cell. Longer values are truncated with ellipsis."128)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *slack-table-max-chars*"Undocumented Slack limit: table blocks exceeding 10,000 characters are rejected with`table_character_count_must_not_exceed_10000`. We use 9,500 as a budget for cell text contentdiff --git a/src/metabase/sql_tools/settings.clj b/src/metabase/sql_tools/settings.cljindex b9bad486bc1..69c5025e000 100644--- a/src/metabase/sql_tools/settings.clj+++ b/src/metabase/sql_tools/settings.clj@@ -28,6 +28,7 @@(def ^:private available-parser-backends#{:macaw :sqlglot})+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *parser-backend-override*"Dynamic var for overriding the parser backend in tests.When bound, [[current-parser-backend]] returns this instead of the setting."diff --git a/src/metabase/sync/analyze/fingerprint.clj b/src/metabase/sync/analyze/fingerprint.cljindex c592c1b6a09..58be557674c 100644--- a/src/metabase/sync/analyze/fingerprint.clj+++ b/src/metabase/sync/analyze/fingerprint.clj@@ -60,6 +60,7 @@:updated-fingerprints 0:fingerprints-attempted fields-count})+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *truncation-size*"The maximum size of :type/Text to be selected from the database in `table-rows-sample`. In practice we see largetext blobs and want to balance taking enough for distinct counts and but not so much that we risk out of memory@@ -98,6 +99,7 @@;;; | WHICH FIELDS NEED UPDATED FINGERPRINTS? |;;; +----------------------------------------------------------------------------------------------------------------++#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *refingerprint?*"Whether we are refingerprinting or doing the normal fingerprinting. Refingerprinting should get fields that alreadyare analyzed and have fingerprints."diff --git a/src/metabase/sync/field_values.clj b/src/metabase/sync/field_values.cljindex 80533dfc333..d9f9c02e746 100644--- a/src/metabase/sync/field_values.clj+++ b/src/metabase/sync/field_values.clj@@ -240,6 +240,7 @@(into {} (for [table-id table-ids][table-id (-> table-id table-id->db-id db-id->is-on-demand?)]))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *on-demand-select-batch-size*"Chunk size when fetching :model/Field rows for on-demand updates. Keeps a single SQL `IN (…)`clause under the smallest driver parameter limit (Oracle: 1000, SQL Server: 2100)."diff --git a/src/metabase/sync/interface.clj b/src/metabase/sync/interface.cljindex b42dabaeda0..702be1000ab 100644--- a/src/metabase/sync/interface.clj+++ b/src/metabase/sync/interface.clj@@ -191,6 +191,7 @@;; v3 that includes new "global" fingerprint info, both the v2-fingerprinted numeric Fields and the v1-fingerprinted;; textual Fields can be upgraded to v3.+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *fingerprint-version->types-that-should-be-re-fingerprinted*"Map of fingerprint version to the set of Field base types that need to be upgraded to this version the nexttime we do analysis. The highest-numbered entry is considered the latest version of fingerprints."@@ -201,6 +202,7 @@5 #{:type/Text}6 #{:type/Number :type/Text :type/DateTime}})+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic ^Long *latest-fingerprint-version*"The newest (highest-numbered) version of our Field fingerprints."(apply max (keys *fingerprint-version->types-that-should-be-re-fingerprinted*)))diff --git a/src/metabase/sync/sync_metadata/indexes.clj b/src/metabase/sync/sync_metadata/indexes.cljindex 7cd2da73ae7..b717826d8c4 100644--- a/src/metabase/sync/sync_metadata/indexes.clj+++ b/src/metabase/sync/sync_metadata/indexes.clj@@ -60,6 +60,7 @@#{}indexes))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *update-partition-size*"Size of the partition of indexes to update using one `t2/update!` call. Dynamic for testing purposes."5000)diff --git a/src/metabase/sync/util.clj b/src/metabase/sync/util.cljindex 7b8d99b7c04..9c05ce2a9eb 100644--- a/src/metabase/sync/util.clj+++ b/src/metabase/sync/util.clj@@ -221,6 +221,7 @@javax.net.ssl.SSLHandshakeException]](register-transient-exception klass))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *log-exceptions-and-continue?*"Whether to log exceptions during a sync step and proceed with the rest of the sync process. This is the defaultbehavior. You can disable this for debugging or test purposes."@@ -432,6 +433,7 @@(when (not= (:initial_sync_status table) "complete")(sync.db/update-table! (u/the-id table) {:initial_sync_status "complete"})))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *batch-size*"Size of table update partition."20000)diff --git a/src/metabase/task/impl.clj b/src/metabase/task/impl.cljindex 7401e5e6610..0f0640b754c 100644--- a/src/metabase/task/impl.clj+++ b/src/metabase/task/impl.clj@@ -42,6 +42,7 @@;;; | SCHEDULER INSTANCE |;;; +----------------------------------------------------------------------------------------------------------------++#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(defonce ^:dynamic ^{:doc "Override the global Quartz scheduler by binding this var."}*quartz-scheduler*(atom nil))diff --git a/src/metabase/task_history/models/task_history.clj b/src/metabase/task_history/models/task_history.cljindex 032faeabf57..4e2fe82390e 100644--- a/src/metabase/task_history/models/task_history.clj+++ b/src/metabase/task_history/models/task_history.clj@@ -141,6 +141,7 @@info)](task-history.db/update-task-history! th-id updated-info)))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic ^Clock *log-capture-clock*"The java.time.Clock used for captured log message `:timestamp` values. Can be overridden for tests."(Clock/systemUTC))diff --git a/src/metabase/task_history/models/task_run.clj b/src/metabase/task_history/models/task_run.cljindex 02bf0de1b42..50c72f9a96e 100644--- a/src/metabase/task_history/models/task_run.clj+++ b/src/metabase/task_history/models/task_run.clj@@ -63,6 +63,7 @@:entity_type mi/transform-keyword:status mi/transform-keyword})+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *run-id*"The ID of the current task run. Set by [[with-task-run]]."nil)diff --git a/src/metabase/tracing/core.clj b/src/metabase/tracing/core.cljindex 87a861746d3..7326c7e70d1 100644--- a/src/metabase/tracing/core.clj+++ b/src/metabase/tracing/core.clj@@ -244,6 +244,7 @@;;; ------------------------------------------------ Primary Macro -------------------------------------------------+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *span-attrs*"Atom of attrs already written to the active `with-span`. Used by [[add-span-attrs!]] to detect duplicate writes; nil outside a `with-span`."nil)diff --git a/src/metabase/upload/impl.clj b/src/metabase/upload/impl.cljindex 6a95fed76a1..9521f4ff095 100644--- a/src/metabase/upload/impl.clj+++ b/src/metabase/upload/impl.clj@@ -460,6 +460,7 @@;;;; | Create upload;;;; +------------------++#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *auxiliary-sync-steps*"For testing purposes, we'd like to control whether the analyze and field values steps of sync are run synchronously, or not at all.In production this should always be asynchronous, so users can use the table earlier."diff --git a/src/metabase/util.cljc b/src/metabase/util.cljcindex 1a0f88e49bf..5873d46a844 100644--- a/src/metabase/util.cljc+++ b/src/metabase/util.cljc@@ -805,6 +805,7 @@pprint-to-str):cljs pprint-to-str))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *profile-level*"Impl for `profile` macro -- don't use this directly. Nesting-level for the `profile` macro e.g. 0 for a top-level`profile` form or 1 for a form inside that."diff --git a/src/metabase/util/date_2/parse/builder.clj b/src/metabase/util/date_2/parse/builder.cljindex 15c2fa46b9c..fc469226dd7 100644--- a/src/metabase/util/date_2/parse/builder.clj+++ b/src/metabase/util/date_2/parse/builder.clj@@ -53,6 +53,7 @@:case-sensitive (.parseCaseSensitive builder):case-insensitive (.parseCaseInsensitive builder)))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *options*{:strictness :strict:case-sensitivity :case-sensitive})diff --git a/src/metabase/util/experiment.cljc b/src/metabase/util/experiment.cljcindex af4566983ad..1cacd667ff8 100644--- a/src/metabase/util/experiment.cljc+++ b/src/metabase/util/experiment.cljc@@ -24,6 +24,7 @@experiments-enabled-fn(atom (constantly false)))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *enabled-override*"When non-nil, used as the enabled? value instead of consulting [[experiments-enabled-fn]]. Bind this per-thread(e.g. via a test fixture) to enable or disable experiments locally without touching the global atom."@@ -47,6 +48,7 @@Nil means no reporting. Can be overridden per-experiment via :report-fn in the opts map."}default-report-fn (atom nil))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *report-fn-override*"When non-nil, used as the report-fn instead of consulting [[default-report-fn]] (the per-experiment `:report-fn`option still takes precedence over both). Bind this per-thread to install a thread-local reporter."@@ -57,6 +59,7 @@[f](reset! default-report-fn f))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *sync?*"When true, forces synchronous candidate execution on JVM. For testing only."false)diff --git a/src/metabase/util/http.clj b/src/metabase/util/http.cljindex 3ddd0b4a0e5..2e4c29e1439 100644--- a/src/metabase/util/http.clj+++ b/src/metabase/util/http.clj@@ -24,6 +24,7 @@(defn- parse-http-headers [headers](json/decode headers))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(defn ^:dynamic *fetch-as-json*"Fetches url and parses body as json, returning it."[url headers]@@ -273,6 +274,7 @@(every? #(address-allowed-for-network-policy? policy %)(host->inet-addresses hostname))))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^DnsResolver ^:dynamic *system-dns-resolver*"The underlying system DNS resolver. Exposed as a dynamic var so tests can inject a fakehost->address mapping"@@ -294,6 +296,7 @@(throw (ex-info "Refusing to connect to a non-permitted network address"{:ssrf true :policy policy :host host}))))))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *proxy-selector*"The `ProxySelector` [[jvm-proxied-url?]] asks. nil reads `ProxySelector/getDefault` at call time, which is whatApache HttpClient's route planner does; tests bind it rather than installing a selector process-wide."diff --git a/src/metabase/util/i18n.clj b/src/metabase/util/i18n.cljindex 81a0fd9263b..3451abe46e8 100644--- a/src/metabase/util/i18n.clj+++ b/src/metabase/util/i18n.clj@@ -27,11 +27,13 @@normalized-locale-stringtranslate])+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *user-locale*"Bind this to a string, keyword, or `Locale` to set the locale for the current User. To get the locale we should*use*, use the `user-locale` function instead."nil)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *site-locale-override*"Bind this to a string, keyword to override the value returned by `site-locale`. For testing purposes,such as when swapping out an application database temporarily, when the setting table may not even exist."diff --git a/src/metabase/util/i18n/impl.clj b/src/metabase/util/i18n/impl.cljindex d9e4b666435..9f3a31f6c47 100644--- a/src/metabase/util/i18n/impl.clj+++ b/src/metabase/util/i18n/impl.clj@@ -213,6 +213,7 @@(log/errorf "Invalid format string %s: %s" (pr-str format-string) (ex-message e))format-string)))))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *in-site-locale-from-setting*"Whether we're currently inside a call to [[site-locale-from-setting]], so we can prevent infinite recursion."false)diff --git a/src/metabase/util/log/capture.cljc b/src/metabase/util/log/capture.cljcindex 982a7306a5a..be01d550770 100644--- a/src/metabase/util/log/capture.cljc+++ b/src/metabase/util/log/capture.cljc@@ -23,6 +23,7 @@[clojure.set :as set][clojure.string :as str]))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic ^{:arglists '([namespace-str level-int])} *capture-logs-fn*"Function with the signature that given a namespace string and log level (as an int), returns a function that shouldbe used to capture a log message, if messages at that level should be captured. Its signature isdiff --git a/src/metabase/util/malli/closed_schemas.clj b/src/metabase/util/malli/closed_schemas.cljindex 1e44dfe4897..e3bea469e42 100644--- a/src/metabase/util/malli/closed_schemas.clj+++ b/src/metabase/util/malli/closed_schemas.clj@@ -14,6 +14,7 @@(set! *warn-on-reflection* true)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *enabled*"Whether the checks in this namespace do anything; off in prod."(not config/is-prod?))diff --git a/src/metabase/util/malli/fn.clj b/src/metabase/util/malli/fn.cljindex 1415b37b1e0..ef10b0947e7 100644--- a/src/metabase/util/malli/fn.clj+++ b/src/metabase/util/malli/fn.clj@@ -144,6 +144,7 @@(for [arity (:arities arities-value)](arity-schema (:values arity) return-schema options)))))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *enforce*"Whether [[validate-input]] and [[validate-output]] should validate things or not.diff --git a/src/metabase/util/malli/registry.cljc b/src/metabase/util/malli/registry.cljcindex 611b5354e93..b8f1b2aa7d5 100644--- a/src/metabase/util/malli/registry.cljc+++ b/src/metabase/util/malli/registry.cljc@@ -27,6 +27,7 @@str))x))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *cache-miss-hook*"A hook that is called whenever there is a cache miss, for side effects.This is used in tests or to monitor cache misses."diff --git a/src/metabase/util/markdown.clj b/src/metabase/util/markdown.cljindex 8d68b048b9e..c93abb4572f 100644--- a/src/metabase/util/markdown.clj+++ b/src/metabase/util/markdown.clj@@ -197,6 +197,7 @@(str/replace "`" "\u00ad`\u00ad")(str/replace "~" "\u00ad~\u00ad")))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *site-url*"The instance's site URL, bound by [[process-markdown]] from its `site-url` argument. A dynamic var ratherthan a threaded parameter because [[resolve-uri]] is reached through the AST multimethods and flexmark'sdiff --git a/src/metabase/util/retry.clj b/src/metabase/util/retry.cljindex 1ff74562a47..06676c57d66 100644--- a/src/metabase/util/retry.clj+++ b/src/metabase/util/retry.clj@@ -31,6 +31,7 @@initial-interval-millis (assoc :backoff-ms (cond-> [initial-interval-millis max-interval-millis]multiplier (conj multiplier)))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *test-time-config-hook*"This should only be used during testing to modify the final config map passed to Diehard."identity)diff --git a/src/metabase/warehouse_schema/field_values/distinct_batch.clj b/src/metabase/warehouse_schema/field_values/distinct_batch.cljindex 8b4f2190a23..dbefc373772 100644--- a/src/metabase/warehouse_schema/field_values/distinct_batch.clj+++ b/src/metabase/warehouse_schema/field_values/distinct_batch.clj@@ -42,6 +42,7 @@(set! *warn-on-reflection* true)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *batch-size*"Number of per-field arms unioned into one query. Keeps query text well under driver limits."50)diff --git a/src/metabase/warehouse_schema/models/field_values.clj b/src/metabase/warehouse_schema/models/field_values.cljindex 1d99341fd2b..97b1ed1fba3 100644--- a/src/metabase/warehouse_schema/models/field_values.clj+++ b/src/metabase/warehouse_schema/models/field_values.clj@@ -53,10 +53,12 @@"The maximum character length for a stored FieldValues entry."100)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic ^Long *total-max-length*"Maximum total length for a FieldValues entry (combined length of all values for the field)."(long (* analyze/auto-list-cardinality-threshold entry-max-length)))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic ^Integer *distinct-limit*"Per-column row cap for warehouse-side distinct-value fetches. Used by the UNION ALL per-arm`LIMIT`, by the per-field MBQL `lib/limit` in `distinct-values`, and by `persist-field-values!`@@ -434,6 +436,7 @@[field-id](get-latest-field-values field-id :full nil))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *fv-select-batch-size*"Chunk size when fetching FieldValues by `field_id [:in …]`. Keeps a single SQL `IN (…)` clauseunder the smallest driver parameter limit (Oracle: 1000, SQL Server: 2100). Wide tables can@@ -528,6 +531,7 @@See [[detached-fetch!]]."(atom {}))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *fetch-max-age-ms*"How long a detached fetch may run before it is canceled, and how long a caller will wait on one.@@ -545,6 +549,7 @@what this endpoint promises its callers, and that is a decision of its own."(* 60 60 1000))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *max-in-flight-fetches*"Ceiling on the registry, independent of whatever else happens to bound it.diff --git a/src/metabase/warehouses/models/database.clj b/src/metabase/warehouses/models/database.cljindex f0ac87eb95b..1e6cfeda6b5 100644--- a/src/metabase/warehouses/models/database.clj+++ b/src/metabase/warehouses/models/database.clj@@ -388,6 +388,7 @@;; self-heal.(check-and-schedule-tasks-for-db! (t2.realize/realize database))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *normalizing-details*"Track whether we're calling [[driver/normalize-db-details]] already to prevent infiniterecursion. [[driver/normalize-db-details]] is actually done for side effects!"@@ -714,6 +715,7 @@:is_stub false:uploads_enabled false}}))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *include-h2-in-extract?*"When false (the default), [[serdes/extract-query]] skips H2 databases because they are rejected at import timeby [[assert-not-h2!]]. Round-trip tests that exercise H2 throughout — and rebind `assert-not-h2!` accordingly —diff --git a/src/metabase/warehouses_rest/api.clj b/src/metabase/warehouses_rest/api.cljindex 9f842986830..81af409c91f 100644--- a/src/metabase/warehouses_rest/api.clj+++ b/src/metabase/warehouses_rest/api.clj@@ -1151,6 +1151,7 @@;; TODO - do we also want an endpoint to manually trigger analysis. Or separate ones for classification/fingerprinting?+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *rescan-values-async*"Boolean indicating whether the rescan_values job should be done async or not. Defaults to `true`. Should only be reboundin tests to force the scan to block."diff --git a/src/metabase/xrays/domain_entities/specs.clj b/src/metabase/xrays/domain_entities/specs.cljindex cbd8c06cb71..7e28cc757c4 100644--- a/src/metabase/xrays/domain_entities/specs.clj+++ b/src/metabase/xrays/domain_entities/specs.clj@@ -158,6 +158,7 @@(def ^:private domain-entities-dir "domain_entity_specs/")+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *domain-entity-specs*"Delay with registered domain entities specs, loaded from YAML and coerced to match the [[DomainEntitySpec]] schema."(delay (into {} (for [spec (yaml/load-dir domain-entities-dir (comp coerce-to-domain-entity-specdiff --git a/src/metabase/xrays/transforms/specs.clj b/src/metabase/xrays/transforms/specs.cljindex 1759d52bf07..450091c73de 100644--- a/src/metabase/xrays/transforms/specs.clj+++ b/src/metabase/xrays/transforms/specs.clj@@ -148,6 +148,7 @@(def ^:private transforms-dir "transforms/")+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *transform-specs*"Delay for all transform specs, loaded from YAML and coerced to the [[TransformSpec]] schema."(delay (yaml/load-dir transforms-dir (comp coerce-to-transform-spec add-metadata-to-steps))))diff --git a/test/metabase/actions/test_util.clj b/test/metabase/actions/test_util.cljindex fa6d7f21666..27243db1b7b 100644--- a/test/metabase/actions/test_util.clj+++ b/test/metabase/actions/test_util.clj@@ -29,6 +29,7 @@(set! *warn-on-reflection* true)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic ^:private *actions-test-data-tables*#{"categories"})diff --git a/test/metabase/analytics/snowplow_test.clj b/test/metabase/analytics/snowplow_test.cljindex 4737576c362..342289fc9b8 100644--- a/test/metabase/analytics/snowplow_test.clj+++ b/test/metabase/analytics/snowplow_test.clj@@ -21,6 +21,7 @@(use-fixtures :once (fixtures/initialize :db))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *snowplow-collector*"Fake Snowplow collector"(atom []))diff --git a/test/metabase/api/common_test.clj b/test/metabase/api/common_test.cljindex 35e1a9bb8f7..50f1bcc2611 100644--- a/test/metabase/api/common_test.clj+++ b/test/metabase/api/common_test.clj@@ -99,6 +99,7 @@(is (= [1 2 3] (api/parse-multi-values-param ["1" "2" "3"] parse-long)))));; set up for testing permission failure event publishing+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *events* nil)(methodical/defmethod events/publish-event! ::permission-failure-eventdiff --git a/test/metabase/app_db/custom_migrations/metrics_v2_batch_test.clj b/test/metabase/app_db/custom_migrations/metrics_v2_batch_test.cljindex 15cd0f14089..66ed429ce7c 100644--- a/test/metabase/app_db/custom_migrations/metrics_v2_batch_test.clj+++ b/test/metabase/app_db/custom_migrations/metrics_v2_batch_test.clj@@ -20,6 +20,7 @@(def ^:private data-file"metric-v2-test-data.zip")+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic ^FileSystem *data-fs* nil)(defn- metric-pathsdiff --git a/test/metabase/dashboards_rest/api_test.clj b/test/metabase/dashboards_rest/api_test.cljindex 4d2efe42a7d..85a6d0fae2e 100644--- a/test/metabase/dashboards_rest/api_test.clj+++ b/test/metabase/dashboards_rest/api_test.clj@@ -1636,6 +1636,7 @@(is (= (map #(dissoc % :id) original-tabs)(map #(dissoc % :id) new-tabs))))))))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic ^:private^{:doc "Set of ids that will report [[mi/can-write]] as true."}*readable-card-ids* #{})diff --git a/test/metabase/embedding_rest/api/embed_test.clj b/test/metabase/embedding_rest/api/embed_test.cljindex 1377dcc8d6e..b0992847b4f 100644--- a/test/metabase/embedding_rest/api/embed_test.clj+++ b/test/metabase/embedding_rest/api/embed_test.clj@@ -37,6 +37,7 @@(defn random-embedding-secret-key [] (u.random/secure-hex 32))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *secret-key* nil)(defn sign [claims] (jwt/sign claims *secret-key*))diff --git a/test/metabase/embedding_rest/api/preview_embed_test.clj b/test/metabase/embedding_rest/api/preview_embed_test.cljindex ec92f54c98f..a814cb34426 100644--- a/test/metabase/embedding_rest/api/preview_embed_test.clj+++ b/test/metabase/embedding_rest/api/preview_embed_test.clj@@ -537,6 +537,7 @@(defn random-embedding-secret-key [] (u.random/secure-hex 32))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *secret-key* nil)(defn sign [claims] (jwt/sign claims *secret-key*))diff --git a/test/metabase/events/impl_test.clj b/test/metabase/events/impl_test.cljindex 5329369025a..39693b766c3 100644--- a/test/metabase/events/impl_test.clj+++ b/test/metabase/events/impl_test.clj@@ -5,6 +5,7 @@[metabase.events.impl :as events][methodical.core :as methodical]))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *method-calls* nil)(events.hierarchy/derive! ::test-topics :metabase/event)diff --git a/test/metabase/glossary/core_test.clj b/test/metabase/glossary/core_test.cljindex 50b41838f1f..08b5a33e6a9 100644--- a/test/metabase/glossary/core_test.clj+++ b/test/metabase/glossary/core_test.clj@@ -10,6 +10,7 @@;; `publish-event!` is a methodical multimethod, so capture events with a handler on a test-only parent topic;; rather than by redefining the var (see the docstring of [[metabase.events.impl/publish-event!]]).+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *events* nil)(events/derive! ::glossary-test-event :metabase/event)diff --git a/test/metabase/lib/drill_thru/test_util.cljc b/test/metabase/lib/drill_thru/test_util.cljcindex c53a65437ae..e60418893a3 100644--- a/test/metabase/lib/drill_thru/test_util.cljc+++ b/test/metabase/lib/drill_thru/test_util.cljc@@ -116,6 +116,7 @@(def ^:private TestCase(test-case-schema))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *native-card-id* nil)(defonce ^:private last-native-card-id (atom 12))diff --git a/test/metabase/lib/test_util/generators.cljc b/test/metabase/lib/test_util/generators.cljcindex d3c169d3602..65b618cac40 100644--- a/test/metabase/lib/test_util/generators.cljc+++ b/test/metabase/lib/test_util/generators.cljc@@ -104,6 +104,7 @@-1(tu.rng/rand-int (count (:stages query)))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *safe-for-old-refs*"Controls whether the generators will construct queries with things like multiple joins to the same table, whichcreate ambiguous refs in classic MBQL 5.@@ -331,6 +332,7 @@(add-step {:kind :join:weight 30})+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *available-cards*"To be bound to cards available for use by generator in joins.@@ -487,6 +489,7 @@```"(mk-step-control 0.04 0.16))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *step-control* step-control:default)(defn- choose-step [kinds]diff --git a/test/metabase/lib/test_util/generators/filters.cljc b/test/metabase/lib/test_util/generators/filters.cljcindex 83338faaf45..b2c11f2e07e 100644--- a/test/metabase/lib/test_util/generators/filters.cljc+++ b/test/metabase/lib/test_util/generators/filters.cljc@@ -87,6 +87,7 @@:column column}))));; Filter clauses ================================================================================+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *filterable-columns* nil)(defmulti ^:private gen-filter-clausediff --git a/test/metabase/metabot/test_util.clj b/test/metabase/metabot/test_util.cljindex 54e31d590a3..e61c7006bbb 100644--- a/test/metabase/metabot/test_util.clj+++ b/test/metabase/metabot/test_util.clj@@ -15,6 +15,7 @@(def ^:private fixture-dir "test_resources/llm")+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *live*"When true, `raw-fixture` makes real API calls even if a cached file exists.Bind to `true` in the REPL to re-capture all fixtures:diff --git a/test/metabase/metabot/tools/shared/content_store_test.clj b/test/metabase/metabot/tools/shared/content_store_test.cljindex f8be72cc4ec..91292d573d0 100644--- a/test/metabase/metabot/tools/shared/content_store_test.clj+++ b/test/metabase/metabot/tools/shared/content_store_test.clj@@ -49,6 +49,7 @@(measure-by-id [_ _id] measure-id)(segment-by-id [_ _id] segment-id)))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic ^:private *stub-can-read?*"Controls the [[mi/can-read?]] answer for [[stub-row]]s below."true)diff --git a/test/metabase/query_processor/date_bucketing_test.clj b/test/metabase/query_processor/date_bucketing_test.cljindex 80aed464192..c1c37e25cf8 100644--- a/test/metabase/query_processor/date_bucketing_test.clj+++ b/test/metabase/query_processor/date_bucketing_test.clj@@ -1269,6 +1269,7 @@(u.date/greater-than-period-duration? (u.date/period-duration (:created_at (mt/db)) (t/zoned-date-time))(t/seconds max-age-seconds)))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *recreate-db-if-stale?* true)(defn- count-of-grouping! [^TimestampDatasetDef dataset field-grouping & relative-datetime-args]diff --git a/test/metabase/query_processor/middleware/cache_test.clj b/test/metabase/query_processor/middleware/cache_test.cljindex bc7a06b0b2a..cc657e6a2f8 100644--- a/test/metabase/query_processor/middleware/cache_test.clj+++ b/test/metabase/query_processor/middleware/cache_test.clj@@ -51,11 +51,13 @@(initialize/initialize-if-needed! :db)(thunk)))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *save-chan*"Gets a message whenever results are saved to the test backend, or if the reducing function stops serializing resultsbecause of an Exception or if the byte threshold is passed."nil)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *purge-chan*"Gets a message whenever old entries are purged from the test backend."nil)@@ -140,8 +142,10 @@(defmacro with-mock-cache! [[& bindings] & body]`(do-with-mock-cache! (fn [{:keys [~@bindings]}] ~@body)))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic ^Long *query-execution-delay-ms* 10)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *query-caching-min-ttl*"Set this to zero to prevent flakes - we don't want a query to slip under the wire here."0)@@ -159,6 +163,7 @@:stages [{:lib/type :mbql.stage/mbql, :source-table 2}]}query-kvs))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *rows*"Rows the mock query execution returns. Bind to `[]` to exercise the empty-result path."[[:toucan 71]diff --git a/test/metabase/query_processor/middleware/process_userland_query_test.clj b/test/metabase/query_processor/middleware/process_userland_query_test.cljindex 92b7424fddd..565c87f12a4 100644--- a/test/metabase/query_processor/middleware/process_userland_query_test.clj+++ b/test/metabase/query_processor/middleware/process_userland_query_test.clj@@ -194,6 +194,7 @@:parameters nil}(qe))))))))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *viewlog-call-count* nil)(methodical/defmethod events/publish-event! ::eventdiff --git a/test/metabase/query_processor/streaming_test.clj b/test/metabase/query_processor/streaming_test.cljindex 8e1db3db0cf..203949cb6ad 100644--- a/test/metabase/query_processor/streaming_test.clj+++ b/test/metabase/query_processor/streaming_test.clj@@ -155,6 +155,7 @@(compare-results export-format (mt/native-query {:query sql:params args}))))))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *number-of-cans* nil)(deftest ^:parallel preserve-thread-bindings-testdiff --git a/test/metabase/search/api_test.clj b/test/metabase/search/api_test.cljindex aaba427e0cc..fb86c9f5b52 100644--- a/test/metabase/search/api_test.clj+++ b/test/metabase/search/api_test.clj@@ -263,6 +263,7 @@(defmacro ^:private with-search-items-in-collection [created-items-sym search-string & body]`(do-with-search-items ~search-string false (fn [~created-items-sym] ~@body)))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *search-request-results-database-id*"Filter out all results from `search-request` that don't have this Database ID. Default: the default H2 `test-data`Database. Other results are filtered out so these tests can be ran from the REPL without the presence of otherdiff --git a/test/metabase/search/test_util.clj b/test/metabase/search/test_util.cljindex 463596f94c9..b66a87e0f9e 100644--- a/test/metabase/search/test_util.clj+++ b/test/metabase/search/test_util.clj@@ -11,6 +11,7 @@[metabase.test :as mt][toucan2.core :as t2]))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *user-ctx* nil)(defmacro with-sync-search-indexingdiff --git a/test/metabase/server/streaming_response_test.clj b/test/metabase/server/streaming_response_test.cljindex 6b3d8782a96..19c46430b46 100644--- a/test/metabase/server/streaming_response_test.clj+++ b/test/metabase/server/streaming_response_test.clj@@ -235,6 +235,7 @@(finally(.stop server))))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *number-of-cans* nil)(deftest ^:parallel preserve-bindings-testdiff --git a/test/metabase/settings/models/setting/multi_setting_test.clj b/test/metabase/settings/models/setting/multi_setting_test.cljindex f5e1ff8a603..b44cd1ac096 100644--- a/test/metabase/settings/models/setting/multi_setting_test.clj+++ b/test/metabase/settings/models/setting/multi_setting_test.clj@@ -10,6 +10,7 @@(use-fixtures :once (fixtures/initialize :db))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic ^:private *parakeet* :green-friend)(multi-setting/define-multi-setting ^:private multi-setting-test-bird-namediff --git a/test/metabase/settings/models/setting_test.clj b/test/metabase/settings/models/setting_test.cljindex 4653754c0ad..daee5081935 100644--- a/test/metabase/settings/models/setting_test.clj+++ b/test/metabase/settings/models/setting_test.clj@@ -99,6 +99,7 @@:init (comp str random-uuid):encryption :when-encryption-key-set)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *enabled?* false)(defsetting test-enabled-setting-no-defaultdiff --git a/test/metabase/sso/ldap_test_util.clj b/test/metabase/sso/ldap_test_util.cljindex 2a28cb3f784..8df965e5ecb 100644--- a/test/metabase/sso/ldap_test_util.clj+++ b/test/metabase/sso/ldap_test_util.clj@@ -11,6 +11,7 @@(set! *warn-on-reflection* true)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic ^InMemoryDirectoryServer *ldap-server*"An in-memory LDAP testing server."nil)diff --git a/test/metabase/sync/sync_test.clj b/test/metabase/sync/sync_test.cljindex c1f109f1d9f..9a744200725 100644--- a/test/metabase/sync/sync_test.clj+++ b/test/metabase/sync/sync_test.clj@@ -29,6 +29,7 @@(driver/register! ::sync-test, :abstract? true)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *supports-schemas?*"Whether the database supports schemas."true)@@ -106,6 +107,7 @@[_ _query]{:query "SQL string"})+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(defn- ^:dynamic *execute-response*[query respond](mock.util/mock-execute-reducible-query query respond))diff --git a/test/metabase/test/data/env.clj b/test/metabase/test/data/env.cljindex 8e4c3a00e41..081217da266 100644--- a/test/metabase/test/data/env.clj+++ b/test/metabase/test/data/env.clj@@ -35,6 +35,7 @@{:pre [((some-fn sequential? set?) drivers)]}(reset! default-test-drivers (set drivers)))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(defn- ^:dynamic *test-drivers*[](or @default-test-driversdiff --git a/test/metabase/test/data/impl.clj b/test/metabase/test/data/impl.cljindex d47fa087598..27ee52f6139 100644--- a/test/metabase/test/data/impl.clj+++ b/test/metabase/test/data/impl.clj@@ -25,6 +25,7 @@(p/import-vars[verify verify-data-loaded-correctly])+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *skip-dataset-prewarm?*"Whether `with-temp` should skip materializing the test-data Database before opening its transaction.@@ -51,6 +52,7 @@([] (get-or-create-default-dataset! (tx/driver)))([driver] (get-or-create-database! driver (tx/default-dataset driver))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic ^{:arglists '([])} ^:private *db-fn*"Implementation of `db` function that should return the current working test database when called, always with noarguments. By default, this is [[get-or-create-default-dataset!]] for the current [[metabase.driver/*driver*]], which@@ -101,6 +103,7 @@(defn- test-data-database-id [](@memoized-test-data-database-id-fn (tx/driver)))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic ^{:arglists '([])} *db-id-fn*#'test-data-database-id)@@ -186,6 +189,7 @@(defn- cached-field-id [table-id parent-id field-name](get (field-lookup-map table-id) [parent-id field-name]))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic ^{:added "0.51.0"} *dbdef-used-to-create-db*"The database definition used to create the currently bound test database. For those rare occasions when you need torefer back to it."@@ -388,6 +392,7 @@prop->old-id)))database)))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *db-is-temp-copy?*"Whether the current test database is a temp copy created with the [[metabase.test/with-temp-copy-of-db]] macro."false)diff --git a/test/metabase/test/data/interface.clj b/test/metabase/test/data/interface.cljindex 5e2c0454c39..92f32663826 100644--- a/test/metabase/test/data/interface.clj+++ b/test/metabase/test/data/interface.clj@@ -50,6 +50,7 @@:type :string:database-local :only)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *use-routing-details*"Used to decide if routing details should be used for a db."false)@@ -213,6 +214,7 @@(defonce ^:private has-done-before-run (atom #{}))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *skip-before-run?*"When true, loading a driver's test extensions does NOT run its [[before-run]] hook. Bound by the nightly sweep([[metabase.test.data.gc]]), which needs the extensions to dispatch [[gc-orphans!]] but not the hooks: Redshift's@@ -295,6 +297,7 @@{:pre [(string? database-name)]}(str/replace database-name #"\s+" "_"))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *database-name-override*"Bind this to a string to override the database name, for the purpose of calculating the qualified table name. Thepurpose of this is to allow for a new Database to clone an existing one with the same details (ex: to test differentdiff --git a/test/metabase/test/data/mbql_query_impl.cljc b/test/metabase/test/data/mbql_query_impl.cljcindex e61cd7c7bc8..967e47a42e6 100644--- a/test/metabase/test/data/mbql_query_impl.cljc+++ b/test/metabase/test/data/mbql_query_impl.cljc@@ -22,9 +22,13 @@(apply (requiring-resolve 'metabase.test.data/id) args))));; TODO: druid-id-fn is just temporary until I figure out proper solution for rebinding that symb.+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *id-fn-symb* `druid-id-fn #_'metabase.test.data/id)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *field-name-fn-symb* `field-name)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *field-base-type-fn-symb* `field-base-type)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic ^Long *mbql-version* 4)(defn- token->sigil [token]diff --git a/test/metabase/test/data/one_off_dbs.clj b/test/metabase/test/data/one_off_dbs.cljindex f6a00202ef6..5dbd61cb49a 100644--- a/test/metabase/test/data/one_off_dbs.clj+++ b/test/metabase/test/data/one_off_dbs.clj@@ -11,6 +11,7 @@[metabase.test.data :as data][toucan2.core :as t2]))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *conn*"Bound to a JDBC connection spec when using one of the `with-db` macros below."nil)diff --git a/test/metabase/test/data/sql_jdbc/load_data.clj b/test/metabase/test/data/sql_jdbc/load_data.cljindex e0f0f89fec2..67c70dc2f7c 100644--- a/test/metabase/test/data/sql_jdbc/load_data.clj+++ b/test/metabase/test/data/sql_jdbc/load_data.clj@@ -24,6 +24,7 @@(set! *warn-on-reflection* true)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *disable-fk-checks*"When bound to `true`, drivers that support it (e.g., MySQL) will disable foreign key checks during data insertion.This is useful for tests that need to insert self-referencing data in a single batch."diff --git a/test/metabase/test/http_client.clj b/test/metabase/test/http_client.cljindex b225282270d..5231057787f 100644--- a/test/metabase/test/http_client.clj+++ b/test/metabase/test/http_client.clj@@ -41,6 +41,7 @@;;; build-url+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *url-prefix*"Prefix to automatically prepend to the URL of calls made with `client`.""/api")diff --git a/test/metabase/test/initialize.clj b/test/metabase/test/initialize.cljindex 7f5d6323e2c..aa42a30a553 100644--- a/test/metabase/test/initialize.clj+++ b/test/metabase/test/initialize.clj@@ -25,6 +25,7 @@(def ^:private init-timeout-ms (u/seconds->ms 120))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *initializing*"Collection of components that are being currently initialized by the current thread."[])diff --git a/test/metabase/test/redefs.clj b/test/metabase/test/redefs.cljindex 3362bc378c6..4882385040b 100644--- a/test/metabase/test/redefs.clj+++ b/test/metabase/test/redefs.clj@@ -10,6 +10,7 @@[toucan2.connection :as t2.connection][toucan2.tools.with-temp]))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic ^:private *in-with-temp*"Used to detect whether we're in a nested [[with-temp]]. Default is false."false)diff --git a/test/metabase/test/sync.clj b/test/metabase/test/sync.cljindex d7fc0b1df78..eca74e7a391 100644--- a/test/metabase/test/sync.clj+++ b/test/metabase/test/sync.clj@@ -6,7 +6,7 @@[toucan2.core :as t2]));; deliberately has no root value: the reader below checks `bound?` to tell a live cache from no cache at all-#_{:clj-kondo/ignore [:uninitialized-var]}+#_{:clj-kondo/ignore [:uninitialized-var :metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *sync-steps-run-to-completion-cache*)(defn sync-steps-run-to-completiondiff --git a/test/metabase/test/util/dynamic_redefs.clj b/test/metabase/test/util/dynamic_redefs.cljindex 88126b1087d..368ec10cee7 100644--- a/test/metabase/test/util/dynamic_redefs.clj+++ b/test/metabase/test/util/dynamic_redefs.clj@@ -4,10 +4,12 @@(set! *warn-on-reflection* true)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *local-redefs*"A thread-local mapping from vars to their most recently bound definition."{})+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *proxy-depths*"Thread-local map from redefined var to current recursion depth through its proxy.Used to detect capture bugs that would otherwise manifest as StackOverflowError."diff --git a/test/metabase/test/util/random.clj b/test/metabase/test/util/random.cljindex cbdb0e45d5a..997fcc25c6c 100644--- a/test/metabase/test/util/random.clj+++ b/test/metabase/test/util/random.clj@@ -5,6 +5,7 @@(set! *warn-on-reflection* true)+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(defonce^{:dynamic true:doc "Generator that could be rebound. Bind when you need to control the seed for exmaple."}diff --git a/test/metabase/test/util/thread_local.clj b/test/metabase/test/util/thread_local.cljindex 2023de6707b..ba94f73e84e 100644--- a/test/metabase/test/util/thread_local.clj+++ b/test/metabase/test/util/thread_local.clj@@ -4,6 +4,7 @@[mb.hawk.parallel][metabase.util :as u]))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:dynamic *thread-local*"Whether test helpers should set thread-local values for things, as opposed to setting global values."true)diff --git a/test/metabase/warehouses/models/database_test.clj b/test/metabase/warehouses/models/database_test.cljindex fca84c7f98f..45f132addec 100644--- a/test/metabase/warehouses/models/database_test.clj+++ b/test/metabase/warehouses/models/database_test.clj@@ -405,6 +405,7 @@(is (= driver.u/default-sensitive-fields(database/sensitive-fields-for-db {})))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *secret-can-connect?* (constantly true))(defmethod driver/can-connect? :secret-test-driver [& args] (apply *secret-can-connect?* args))diff --git a/test/metabase/xrays/related_test.clj b/test/metabase/xrays/related_test.cljindex 868da09349b..34c8d1675bb 100644--- a/test/metabase/xrays/related_test.clj+++ b/test/metabase/xrays/related_test.clj@@ -72,6 +72,7 @@(is (= ["similar" "broken"](map :name (#'related/rank-by-similarity reference [broken similar]))))))))+#_{:clj-kondo/ignore [:metabase/discourage-dynamic-vars]}(def ^:private ^:dynamic *world* {})(defn- do-with-world [f]