Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Reject impersonation role equal to the driver default-role sentinel (#80616)

Nicola Mometto4a47fda8d8a1
diff --git a/.clj-kondo/config/modules/config.edn b/.clj-kondo/config/modules/config.edn
index 31481e6de98..47ad74c053f 100644
--- a/.clj-kondo/config/modules/config.edn
+++ b/.clj-kondo/config/modules/config.edn
@@ -3421,7 +3421,7 @@
warehouse-schema
enterprise/sandbox}
:model-exports #{:model/ConnectionImpersonation}
- :model-imports #{:model/DataPermissions :model/PermissionsGroupMembership}}
+ :model-imports #{:model/DataPermissions :model/Database :model/PermissionsGroupMembership}}
enterprise/internal-stats
{:team "UX West"
diff --git a/enterprise/backend/src/metabase_enterprise/impersonation/driver.clj b/enterprise/backend/src/metabase_enterprise/impersonation/driver.clj
index caf55bbcfc4..4a9c01829c7 100644
--- a/enterprise/backend/src/metabase_enterprise/impersonation/driver.clj
+++ b/enterprise/backend/src/metabase_enterprise/impersonation/driver.clj
@@ -89,7 +89,11 @@
(let [conn-impersonation (first conn-impersonations)
role-attribute (:attribute conn-impersonation)
user-attributes (api/current-user-attributes)
- role (get user-attributes role-attribute)]
+ role (get user-attributes role-attribute)
+ database (if (map? database-or-id)
+ database-or-id
+ (t2/select-one :model/Database :id (u/the-id database-or-id)))
+ default-role (driver.sql/default-database-role (driver.u/database->driver database) database)]
(cond
(nil? role)
(throw (ex-info (tru "User does not have attribute required for connection impersonation.")
@@ -101,6 +105,13 @@
(throw (ex-info (tru "Connection impersonation attribute is invalid: role must be a single non-empty string.")
{:user-id api/*current-user-id*
:conn-impersonations conn-impersonations}))
+
+ (and default-role
+ (= (u/lower-case-en role) (u/lower-case-en default-role)))
+ (throw (ex-info (tru "Connection impersonation attribute is invalid: role must not be the database default role.")
+ {:user-id api/*current-user-id*
+ :conn-impersonations conn-impersonations}))
+
:else
role)))))))
diff --git a/enterprise/backend/test/metabase_enterprise/impersonation/driver_test.clj b/enterprise/backend/test/metabase_enterprise/impersonation/driver_test.clj
index e10553ca5f2..87ce411d3af 100644
--- a/enterprise/backend/test/metabase_enterprise/impersonation/driver_test.clj
+++ b/enterprise/backend/test/metabase_enterprise/impersonation/driver_test.clj
@@ -111,6 +111,21 @@
#"Conflicting sandboxing and impersonation policies found."
(impersonation.driver/connection-impersonation-role (mt/db))))))))))
+(deftest connection-impersonation-role-test-10
+ (testing "Rejects a role attribute equal to the driver's default-role sentinel (case-insensitively)"
+ (with-redefs [driver.sql/default-database-role (constantly "NONE")]
+ (impersonation.util-test/with-impersonations! {:impersonations [{:db-id (mt/id) :attribute "impersonation_attr"}]
+ :attributes {"impersonation_attr" "none"}}
+ (is (thrown-with-msg?
+ clojure.lang.ExceptionInfo
+ #"Connection impersonation attribute is invalid: role must not be the database default role."
+ (impersonation.driver/connection-impersonation-role (mt/db)))))
+ (testing "but a normal role value is still returned unchanged"
+ (impersonation.util-test/with-impersonations! {:impersonations [{:db-id (mt/id) :attribute "impersonation_attr"}]
+ :attributes {"impersonation_attr" "impersonation_role"}}
+ (is (= "impersonation_role"
+ (impersonation.driver/connection-impersonation-role (mt/db)))))))))
+
(deftest conn-impersonation-test-postgres
(mt/test-driver :postgres
(mt/with-premium-features #{:advanced-permissions}