Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Fix sample app e2e tests silently failing when containers don't start (#67127)

bryan4b01fe116a64
diff --git a/e2e/runner/embedding-sdk/sample-apps/helpers/start-containers.ts b/e2e/runner/embedding-sdk/sample-apps/helpers/start-containers.ts
index 650e2fa1968..c535a957c0c 100644
--- a/e2e/runner/embedding-sdk/sample-apps/helpers/start-containers.ts
+++ b/e2e/runner/embedding-sdk/sample-apps/helpers/start-containers.ts
@@ -34,8 +34,9 @@ export async function startContainers({
await Promise.all(healthcheckPromises);
shell(getLogsCommand(appName));
- } catch {
+ } catch (err) {
shell(getLogsCommand(appName));
shell(dockerDownCommand, { cwd, env });
+ throw err;
}
}