Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Remove Trunk (#79199)

Nemanja Glumac4b69a5a61da1
diff --git a/.github/actions/upload-test-results/action.yml b/.github/actions/upload-test-results/action.yml
index b00a1413457..fd3a2985b25 100644
--- a/.github/actions/upload-test-results/action.yml
+++ b/.github/actions/upload-test-results/action.yml
@@ -14,13 +14,12 @@ inputs:
default: us-east-1
bucket:
required: true
- trunk-api-token:
- required: true
- variant:
+ previous-step-outcome:
required: false
default: ""
- previous-step-outcome:
- required: true
+ description: >-
+ Outcome of the test step. Only read when `driver-status` is "info", to report the
+ real result of a job that was forced green.
driver-status:
required: false
default: ""
@@ -34,10 +33,6 @@ inputs:
description: >-
Optional label disambiguating matrix legs of the same job, so the info-driver
job summary and PR comment stay distinct per leg.
- run-trunk:
- required: false
- default: "true"
- description: Whether to run the Trunk step at all.
runs:
using: "composite"
@@ -63,25 +58,6 @@ runs:
DATE=$(date '+%Y-%m-%d')
aws s3 cp ${OUTPUT_FILE}.zip s3://$BUCKET/$DATE/$GITHUB_RUN_ID/$GITHUB_RUN_ATTEMPT/
- - name: Upload results to Trunk
- if: ${{ always() && github.repository_owner == 'metabase' && inputs.run-trunk == 'true' }}
- # Important!
- # For "info" drivers off master/release branches, our own status takes precedence: we let this
- # step pass so the job is reported as passing regardless of the real outcome (still uploaded).
- # On master and release branches, info status is ignored and the real outcome gates the job.
- continue-on-error: ${{ inputs.driver-status == 'info' && !(github.ref_name == 'master' || startsWith(github.ref_name, 'release-x')) }}
- uses: trunk-io/analytics-uploader@1198efcc0976501147b10a7e343c3fa069527526 # v2.0.9
- env:
- TRUNK_REPO_URL: [email protected]:metabase/metabase.git
- with:
- junit-paths: ${{ inputs.input-path }}
- variant: ${{ inputs.variant || inputs.output-name }}
- org-slug: metabase
- dry-run: ${{ (github.event_name == 'pull_request' && github.event.pull_request.draft == true) || github.repository != 'metabase/metabase' }} # quarantine, but do not upload results
- token: ${{ inputs.trunk-api-token }}
- use-cache: true
- previous-step-outcome: ${{ inputs.previous-step-outcome }}
-
# For "info" drivers the job is forced green above, so surface the real outcome here —
# but only when it did NOT pass, to avoid spamming summaries/comments for healthy runs.
# Never include logs or stack traces — only the real status and a link to the run.
diff --git a/.github/workflows/app-db.yml b/.github/workflows/app-db.yml
index ea13d99796e..439362102aa 100644
--- a/.github/workflows/app-db.yml
+++ b/.github/workflows/app-db.yml
@@ -130,9 +130,7 @@ jobs:
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
- run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-mysql:
if: ${{ !inputs.skip }}
@@ -264,9 +262,7 @@ jobs:
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
- run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-postgres:
if: ${{ !inputs.skip }}
@@ -376,9 +372,7 @@ jobs:
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
- run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
app-db-tests-result:
needs:
diff --git a/.github/workflows/backend.yml b/.github/workflows/backend.yml
index 8d3887c2bc8..7dc4e89d37e 100644
--- a/.github/workflows/backend.yml
+++ b/.github/workflows/backend.yml
@@ -228,9 +228,7 @@ jobs:
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.run-java-tests.outcome }}
- run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
- name: Publish Test Report (JUnit)
uses: dorny/test-reporter@a43b3a5f7366b97d083190328d2c652e1a8b6aa2 # v3.0.0
diff --git a/.github/workflows/drivers.yml b/.github/workflows/drivers.yml
index 1af28b38c81..10418089891 100644
--- a/.github/workflows/drivers.yml
+++ b/.github/workflows/drivers.yml
@@ -190,10 +190,8 @@ jobs:
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.athena-status }}
- run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-bigquery-cloud-sdk-ee:
needs: determine-driver-skips
@@ -268,11 +266,9 @@ jobs:
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.bigquery-status }}
report-variant: ${{ matrix.job.name }}
- run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
- name: Cleanup python-runner
if: ${{ always() && matrix.job.needs-python-runner == true }}
uses: ./.github/actions/cleanup-python-runner
@@ -356,10 +352,8 @@ jobs:
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.clickhouse-status }}
- run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
- name: Cleanup python-runner
if: ${{ always() && matrix.job.needs-python-runner == true }}
uses: ./.github/actions/cleanup-python-runner
@@ -414,10 +408,8 @@ jobs:
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.druid-jdbc-status }}
- run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-databricks-ee:
needs: determine-driver-skips
@@ -489,11 +481,9 @@ jobs:
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.databricks-status }}
report-variant: ${{ matrix.job.name }}
- run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-databricks-multi-catalog-ee:
needs: determine-driver-skips
@@ -566,11 +556,9 @@ jobs:
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.databricks-status }}
report-variant: ${{ matrix.job.name }}
- run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-h2:
needs: determine-driver-skips
@@ -601,10 +589,8 @@ jobs:
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.h2-status }}
- run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-h2-oss:
needs: determine-driver-skips
@@ -636,10 +622,8 @@ jobs:
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.h2-status }}
- run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-mysql-mariadb:
needs: determine-driver-skips
@@ -779,10 +763,8 @@ jobs:
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.mysql-mariadb-status }}
- run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
- name: Cleanup python-runner
if: always()
uses: ./.github/actions/cleanup-python-runner
@@ -863,10 +845,8 @@ jobs:
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.mongo-status }}
- run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
- name: Cleanup python-runner
if: ${{ always() && matrix.job.needs-python-runner == true }}
uses: ./.github/actions/cleanup-python-runner
@@ -949,10 +929,8 @@ jobs:
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.mongo-ssl-status }}
- run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-mongo-sharded-cluster-ee:
needs: determine-driver-skips
@@ -998,10 +976,8 @@ jobs:
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.mongo-sharded-cluster-status }}
- run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-oracle:
needs: determine-driver-skips
@@ -1087,10 +1063,8 @@ jobs:
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.oracle-status }}
- run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-postgres:
needs: determine-driver-skips
@@ -1195,11 +1169,9 @@ jobs:
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.postgres-status }}
report-variant: ${{ matrix.version.name }}-${{ matrix.job.name }}
- run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
- name: Cleanup python-runner
if: always()
uses: ./.github/actions/cleanup-python-runner
@@ -1287,10 +1259,8 @@ jobs:
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.presto-jdbc-status }}
- run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-redshift-ee:
needs: determine-driver-skips
@@ -1375,11 +1345,9 @@ jobs:
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.redshift-status }}
report-variant: ${{ matrix.job.name }}
- run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
- name: Cleanup python-runner
if: ${{ always() && matrix.job.needs-python-runner == true }}
uses: ./.github/actions/cleanup-python-runner
@@ -1463,11 +1431,9 @@ jobs:
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.snowflake-status }}
report-variant: ${{ matrix.job.name }}
- run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
- name: Cleanup python-runner
if: ${{ always() && matrix.job.needs-python-runner == true }}
uses: ./.github/actions/cleanup-python-runner
@@ -1520,10 +1486,8 @@ jobs:
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.sparksql-status }}
- run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-sqlite-ee:
needs: determine-driver-skips
@@ -1565,10 +1529,8 @@ jobs:
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.sqlite-status }}
- run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-sqlserver:
needs: determine-driver-skips
@@ -1645,10 +1607,8 @@ jobs:
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.sqlserver-status }}
- run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
- name: Cleanup python-runner
if: ${{ always() && matrix.job.needs-python-runner == true }}
uses: ./.github/actions/cleanup-python-runner
@@ -1692,7 +1652,6 @@ jobs:
# bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
# role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
# aws-region: ${{ vars.AWS_REGION }}
- # trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
login-to-ecr:
needs: determine-driver-skips
@@ -1776,10 +1735,8 @@ jobs:
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.vertica-status }}
- run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
drivers-tests-result:
needs:
diff --git a/.github/workflows/e2e-coverage-shard.yml b/.github/workflows/e2e-coverage-shard.yml
index 6bb695ea842..549a2812c6b 100644
--- a/.github/workflows/e2e-coverage-shard.yml
+++ b/.github/workflows/e2e-coverage-shard.yml
@@ -3,7 +3,7 @@ name: E2E Coverage Shard
# Reusable per-shard worker for the coverage manifest run. Trimmed extract of
# e2e-test.yml: runs one cypress-split shard against an instrumented build and
# uploads that shard's per-spec coverage. Intentionally omits the PR-only
-# concerns (failed-spec retry, Trunk quarantine, S3 result upload, timing
+# concerns (failed-spec retry, quarantine, S3 result upload, timing
# output) since this is a nightly, non-blocking job.
on:
diff --git a/.github/workflows/e2e-test.yml b/.github/workflows/e2e-test.yml
index b7265432da3..6d5323b88c1 100644
--- a/.github/workflows/e2e-test.yml
+++ b/.github/workflows/e2e-test.yml
@@ -221,11 +221,7 @@ jobs:
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- # Related to Trunk uploader
- variant: e2e-tests
- trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ inputs.specs && steps.tagged-e2e.outcome || steps.split-e2e.outcome }}
- run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
- name: Quarantine gate
# Only one of the two run steps executes; the other reports `skipped`. Only gate on actual failure.
diff --git a/.github/workflows/embedding-sdk-component-tests.yml b/.github/workflows/embedding-sdk-component-tests.yml
index 64a9cdb18da..f934138c241 100644
--- a/.github/workflows/embedding-sdk-component-tests.yml
+++ b/.github/workflows/embedding-sdk-component-tests.yml
@@ -120,9 +120,7 @@ jobs:
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.run-tests.outcome }}
- run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
- name: Quarantine gate
if: ${{ !cancelled() && steps.run-tests.outcome == 'failure' }}
@@ -302,9 +300,7 @@ jobs:
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.run-tests.outcome }}
- run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
- name: Quarantine gate
if: ${{ !cancelled() && steps.run-tests.outcome == 'failure' }}
diff --git a/.github/workflows/frontend.yml b/.github/workflows/frontend.yml
index f7e6c04e774..4657bf7a313 100644
--- a/.github/workflows/frontend.yml
+++ b/.github/workflows/frontend.yml
@@ -138,9 +138,7 @@ jobs:
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.fe-tests.outcome }}
- run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
fe-tests-timezones:
if: ${{ !inputs.skip }}
diff --git a/.github/workflows/minimal-tests.yml b/.github/workflows/minimal-tests.yml
index efb7ed833f6..e4dfce5df95 100644
--- a/.github/workflows/minimal-tests.yml
+++ b/.github/workflows/minimal-tests.yml
@@ -79,9 +79,7 @@ jobs:
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
- run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
# Postgres driver tests
postgres-driver-test:
@@ -128,9 +126,7 @@ jobs:
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
- run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
# Frontend unit tests
frontend-unit-tests:
@@ -183,9 +179,7 @@ jobs:
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.run-tests.outcome }}
- run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
# Summary job
minimal-tests-result:
diff --git a/.github/workflows/semantic-search.yml b/.github/workflows/semantic-search.yml
index 97fbe8a2f30..85053d4433b 100644
--- a/.github/workflows/semantic-search.yml
+++ b/.github/workflows/semantic-search.yml
@@ -71,9 +71,7 @@ jobs:
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
- run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
semantic-search-tests-mariadb:
if: ${{ !inputs.skip }}
@@ -146,9 +144,7 @@ jobs:
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
- run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
semantic-search-tests-mysql:
if: ${{ !inputs.skip }}
@@ -228,9 +224,7 @@ jobs:
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
- run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
semantic-search-tests-postgres:
if: ${{ !inputs.skip }}
@@ -304,9 +298,7 @@ jobs:
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
- run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
# pgvector-on-the-app-db mode: the app db itself is a pgvector-capable Postgres and
# MB_PGVECTOR_DB_URL is deliberately unset. The dedicated-harness tests gate themselves off; the
@@ -370,9 +362,7 @@ jobs:
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
- run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
semantic-search-tests-result:
needs:
diff --git a/.github/workflows/transforms-python-stress-test.yml b/.github/workflows/transforms-python-stress-test.yml
index 8cd39defa0c..2f41adfbf31 100644
--- a/.github/workflows/transforms-python-stress-test.yml
+++ b/.github/workflows/transforms-python-stress-test.yml
@@ -72,7 +72,6 @@ jobs:
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
- name: Cleanup python-runner
if: always()
uses: ./.github/actions/cleanup-python-runner
@@ -132,7 +131,6 @@ jobs:
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
- name: Cleanup python-runner
if: always()
uses: ./.github/actions/cleanup-python-runner
@@ -182,7 +180,6 @@ jobs:
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
- name: Cleanup python-runner
if: always()
uses: ./.github/actions/cleanup-python-runner
@@ -236,7 +233,6 @@ jobs:
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
- name: Cleanup python-runner
if: always()
uses: ./.github/actions/cleanup-python-runner
@@ -291,7 +287,6 @@ jobs:
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
- name: Cleanup python-runner
if: always()
uses: ./.github/actions/cleanup-python-runner
@@ -336,7 +331,6 @@ jobs:
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
- name: Cleanup python-runner
if: always()
uses: ./.github/actions/cleanup-python-runner
@@ -390,7 +384,6 @@ jobs:
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
- name: Cleanup python-runner
if: always()
uses: ./.github/actions/cleanup-python-runner
@@ -442,7 +435,6 @@ jobs:
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
- name: Cleanup python-runner
if: always()
uses: ./.github/actions/cleanup-python-runner
diff --git a/e2e/support/fix-junit-hooks.ts b/e2e/support/fix-junit-hooks.ts
index 688688b1c4e..8b08f102277 100755
--- a/e2e/support/fix-junit-hooks.ts
+++ b/e2e/support/fix-junit-hooks.ts
@@ -4,9 +4,9 @@
// underlying test. When a `before each` / `before all` / `after each` /
// `after all` hook throws, mocha-junit-reporter records the failing testcase
// as `<suite> "before each" hook for "<test name>"`. That breaks downstream
-// Trunk that keys on the test name. This script parses the
-// XML and strips the hook label from `name` and `classname`, leaving the
-// failure body intact so the error is still preserved.
+// consumers that key on the test name. This script parses the XML and strips
+// the hook label from `name` and `classname`, leaving the failure body intact
+// so the error is still preserved.
import {
copyFileSync,
diff --git a/jest.config.js b/jest.config.js
index 485eaac32af..9280294bc8a 100644
--- a/jest.config.js
+++ b/jest.config.js
@@ -141,10 +141,8 @@ const baseConfig = {
/** @type {import('jest').Config} */
const config = {
// `addFileAttribute` makes jest-junit emit the source path as a `file`
- // attribute on each <testcase>. Additive — it leaves classname/name untouched,
- // so Trunk's existing test identity is preserved — and it lets both Trunk
- // (codeowners/file attribution) and the ci-conductor reporter resolve a real
- // source file. Output dir/name come from the JEST_JUNIT_OUTPUT_* env vars.
+ // attribute on each <testcase>, which lets the ci-conductor reporter resolve a
+ // real source file. Output dir/name come from the JEST_JUNIT_OUTPUT_* env vars.
reporters: ["default", ["jest-junit", { addFileAttribute: "true" }]],
coverageReporters: ["html", "lcov"],
watchPlugins: [
diff --git a/release/ci-conductor/src/adapters/frontend.ts b/release/ci-conductor/src/adapters/frontend.ts
index 50a2c9d3d1c..4d7b8efcda0 100644
--- a/release/ci-conductor/src/adapters/frontend.ts
+++ b/release/ci-conductor/src/adapters/frontend.ts
@@ -15,12 +15,12 @@
//
// FILE / IDENTITY NOTE: `jest.config.js` sets jest-junit's `addFileAttribute`,
// so each <testcase> carries the source path as a `file` attribute, which the
-// shared parser surfaces as `file_path`. We deliberately leave jest-junit's
-// `classname`/`name` on their defaults (the same `{ancestors} {title}` blob in
-// both) rather than re-template them: that artifact is also what Trunk ingests,
-// and changing those fields would re-baseline its test identity. So `test_path`
-// and `test_name` carry that blob (redundant but a stable, unique key) and
-// identity is (test_suite, test_path, test_name, file_path).
+// shared parser surfaces as `file_path`. `classname`/`name` stay on jest-junit's
+// defaults — the same `{ancestors} {title}` blob in both — so `test_path` and
+// `test_name` carry that blob (redundant but a stable, unique key) and identity
+// is (test_suite, test_path, test_name, file_path). ci-conductor matches that
+// tuple exactly, so re-templating either field orphans a test's quarantine
+// entry and occurrence history.
import { readFileSync } from "node:fs";