Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Harden embedding-hub sandbox column-update e2e flake (#78620)

github-automation-metabase4ba63550a403
diff --git a/e2e/test/scenarios/embedding/embedding-hub/embedding-hub.cy.spec.ts b/e2e/test/scenarios/embedding/embedding-hub/embedding-hub.cy.spec.ts
index 332aa2706ca..4b5f2d22e4f 100644
--- a/e2e/test/scenarios/embedding/embedding-hub/embedding-hub.cy.spec.ts
+++ b/e2e/test/scenarios/embedding/embedding-hub/embedding-hub.cy.spec.ts
@@ -1216,9 +1216,24 @@ describe("scenarios - embedding hub", () => {
H.main().findByRole("button", { name: "Next" }).click();
cy.log("wait for sandbox update to complete");
- cy.wait("@updatePermissionsGraph");
+ // The "Next" click kicks off several sequential metadata fetches
+ // (list tables, list databases, read the permissions-graph revision)
+ // before it issues the PUT we're aliasing here, so under load the
+ // request can take longer than Cypress's default 5s request timeout.
+ cy.wait("@updatePermissionsGraph", { timeout: 15_000 });
+
+ cy.log("the 'Select data' step should be marked complete");
+ H.main()
+ .findByRole("listitem", {
+ name: "Select data to make available",
+ timeout: 10_000,
+ })
+ .icon("check")
+ .should("exist");
- cy.log("error toast should not appear");
+ // Anchor the negative assertion on the positive success signal above so
+ // it can't pass by racing an unrendered page.
+ cy.log("no error toast should appear once the update has settled");
H.undoToast().should("not.exist");
cy.log("sandbox should be updated and not created");
@@ -1243,14 +1258,6 @@ describe("scenarios - embedding hub", () => {
});
});
});
-
- H.main()
- .findByRole("listitem", {
- name: "Select data to make available",
- timeout: 10_000,
- })
- .icon("check")
- .should("exist");
});
it(