Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Fix sunburst chart labels not appearing (#70889)

Kevin Kelleher4cb40dd358b2
diff --git a/frontend/src/metabase/visualizations/echarts/pie/util/label.ts b/frontend/src/metabase/visualizations/echarts/pie/util/label.ts
index 4302cce84cc..48333bebf56 100644
--- a/frontend/src/metabase/visualizations/echarts/pie/util/label.ts
+++ b/frontend/src/metabase/visualizations/echarts/pie/util/label.ts
@@ -160,10 +160,13 @@ export const calcAvailableDonutSliceLabelLength = (
}
const arcAngle = endAngle - startAngle;
- const innerCordLength = calcChordLength(innerRadius, arcAngle);
+ const innerChordLength = calcChordLength(
+ innerRadius,
+ Math.min(arcAngle, Math.PI),
+ );
if (labelPosition === "radial") {
- return innerCordLength > fontSize ? donutThickness : 0;
+ return innerChordLength > fontSize ? donutThickness : 0;
}
const midRadius = (innerRadius + outerRadius) / 2;
@@ -179,12 +182,10 @@ export const calcAvailableDonutSliceLabelLength = (
outerRadius,
);
- const cordLengthLimit =
- arcAngle < Math.PI ? innerCordLength : 2 * innerRadius;
const sliceConstraint =
- isNearXAxis(midAngle) && innerCordLength > fontSize
+ isNearXAxis(midAngle) && innerChordLength > fontSize
? donutThickness
- : cordLengthLimit;
+ : innerChordLength;
return Math.min(maxRectLength, sliceConstraint);
};
diff --git a/frontend/src/metabase/visualizations/echarts/pie/util/label.unit.spec.ts b/frontend/src/metabase/visualizations/echarts/pie/util/label.unit.spec.ts
index def11fdb198..78a50cf2afa 100644
--- a/frontend/src/metabase/visualizations/echarts/pie/util/label.unit.spec.ts
+++ b/frontend/src/metabase/visualizations/echarts/pie/util/label.unit.spec.ts
@@ -140,6 +140,18 @@ describe("pie chart label utilities", () => {
expect(result).toBe(0);
});
+ it("returns donutThickness for large radial slice arc > PI even though chord is small (metabase#68802)", () => {
+ const result = calcAvailableDonutSliceLabelLength(
+ 50,
+ 100,
+ 0,
+ 6.2, // ~355 degrees
+ 12,
+ "radial",
+ );
+ expect(result).toBe(50); // should return donutThickness
+ });
+
it("calculates horizontal label length correctly", () => {
const result = calcAvailableDonutSliceLabelLength(
50,