The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Store transform create/updates in revision table (#64247)
Riley Thompson4d0eef7217fd
diff --git a/enterprise/backend/src/metabase_enterprise/transforms/api.clj b/enterprise/backend/src/metabase_enterprise/transforms/api.cljindex 25be43fe7e5..4e839be4a9a 100644--- a/enterprise/backend/src/metabase_enterprise/transforms/api.clj+++ b/enterprise/backend/src/metabase_enterprise/transforms/api.clj@@ -15,6 +15,7 @@[metabase.api.routes.common :refer [+auth]][metabase.api.util.handlers :as handlers][metabase.driver.util :as driver.u]+ [metabase.events.core :as events][metabase.request.core :as request][metabase.util :as u][metabase.util.i18n :refer [deferred-tru]]@@ -119,15 +120,17 @@(api/check (not (transforms.util/target-table-exists? body))403(deferred-tru "A table with that name already exists."))- (t2/with-transaction [_]- (let [tag-ids (:tag_ids body)- transform (t2/insert-returning-instance!- :model/Transform (select-keys body [:name :description :source :target :run_trigger]))]- ;; Add tag associations if provided- (when (seq tag-ids)- (transform.model/update-transform-tags! (:id transform) tag-ids))- ;; Return with hydrated tag_ids- (t2/hydrate transform :transform_tag_ids))))+ (let [transform (t2/with-transaction [_]+ (let [tag-ids (:tag_ids body)+ transform (t2/insert-returning-instance!+ :model/Transform (select-keys body [:name :description :source :target :run_trigger]))]+ ;; Add tag associations if provided+ (when (seq tag-ids)+ (transform.model/update-transform-tags! (:id transform) tag-ids))+ ;; Return with hydrated tag_ids+ (t2/hydrate transform :transform_tag_ids)))]+ (events/publish-event! :event/transform-create {:object transform :user-id api/*current-user-id*})+ transform))(api.macros/defendpoint :get "/:id""Get a specific transform."@@ -188,28 +191,29 @@[:tag_ids {:optional true} [:sequential ms/PositiveInt]]]](log/info "put transform" id)(api/check-superuser)- (t2/with-transaction [_]- ;; Cycle detection should occur within the transaction to avoid race- (let [old (t2/select-one :model/Transform id)- new (merge old body)- target-fields #(-> % :target (select-keys [:schema :name]))]- ;; we must validate on a full transform object- (check-feature-enabled! new)- (check-database-feature new)- (when (transforms.util/query-transform? old)- (when-let [{:keys [cycle-str]} (transforms.ordering/get-transform-cycle new)]- (throw (ex-info (str "Cyclic transform definitions detected: " cycle-str)- {:status-code 400}))))- (api/check (not (and (not= (target-fields old) (target-fields new))- (transforms.util/target-table-exists? new)))- 403- (deferred-tru "A table with that name already exists.")))-- (t2/update! :model/Transform id (dissoc body :tag_ids))- ;; Update tag associations if provided- (when (contains? body :tag_ids)- (transform.model/update-transform-tags! id (:tag_ids body)))- (t2/hydrate (t2/select-one :model/Transform id) :transform_tag_ids)))+ (let [transform (t2/with-transaction [_]+ ;; Cycle detection should occur within the transaction to avoid race+ (let [old (t2/select-one :model/Transform id)+ new (merge old body)+ target-fields #(-> % :target (select-keys [:schema :name]))]+ ;; we must validate on a full transform object+ (check-feature-enabled! new)+ (check-database-feature new)+ (when (transforms.util/query-transform? old)+ (when-let [{:keys [cycle-str]} (transforms.ordering/get-transform-cycle new)]+ (throw (ex-info (str "Cyclic transform definitions detected: " cycle-str)+ {:status-code 400}))))+ (api/check (not (and (not= (target-fields old) (target-fields new))+ (transforms.util/target-table-exists? new)))+ 403+ (deferred-tru "A table with that name already exists.")))+ (t2/update! :model/Transform id (dissoc body :tag_ids))+ ;; Update tag associations if provided+ (when (contains? body :tag_ids)+ (transform.model/update-transform-tags! id (:tag_ids body)))+ (t2/hydrate (t2/select-one :model/Transform id) :transform_tag_ids))]+ (events/publish-event! :event/transform-update {:object transform :user-id api/*current-user-id*})+ transform))(api.macros/defendpoint :delete "/:id""Delete a transform."diff --git a/enterprise/backend/test/metabase_enterprise/transforms/api_test.clj b/enterprise/backend/test/metabase_enterprise/transforms/api_test.cljindex d91fc3a11b5..406cebf52c2 100644--- a/enterprise/backend/test/metabase_enterprise/transforms/api_test.clj+++ b/enterprise/backend/test/metabase_enterprise/transforms/api_test.clj@@ -783,3 +783,39 @@(is (= "Transforms are not supported on databases with DB routing enabled."(mt/user-http-request :crowberto :put 400 (format "ee/transform/%s" (:id transform))(assoc transform :name "Gadget Products 2")))))))))))++(deftest transform-revisions-test+ (mt/test-drivers (mt/normal-drivers-with-feature :transforms/table)+ (mt/with-premium-features #{:transforms}+ (mt/dataset transforms-dataset/transforms-test+ (with-transform-cleanup! [table-name "transform_revisions_test"]+ (let [test-transform-revisions (fn [action url req exp-revisions]+ (let [transform (mt/user-http-request :crowberto action 200 url req)+ transform-id (:id transform)]+ (is (= exp-revisions (t2/count :model/Revision :model "Transform"+ :model_id transform-id)))+ (let [revision (t2/select-one :model/Revision :model "Transform"+ :model_id transform-id :most_recent true)+ rev-transform (:object revision)+ removed #{:id :entity_id :created_at :updated_at}]+ (is (every? #(not (contains? rev-transform %)) removed))+ ;; CI tries comparing "=" with := which fails+ (is (=? (dissoc rev-transform :source) transform)))+ transform-id))+ gadget-req {:name "Gadget Products"+ :description "The gadget products"+ :source {:type "query"+ :query (make-query "Gadget")}+ :target {:type "table"+ :schema (get-test-schema)+ :name table-name}}+ transform-id (test-transform-revisions :post "ee/transform" gadget-req 1)+ widget-req {:name "Widget Products"+ :description "The widget products"+ :source {:type "query"+ :query (make-query "Widget")}+ :tag_ids [4]+ :target {:type "table"+ :schema (get-test-schema)+ :name table-name}}]+ (test-transform-revisions :put (str "ee/transform/" transform-id) widget-req 2)))))))diff --git a/enterprise/backend/test/metabase_enterprise/transforms/revision_test.clj b/enterprise/backend/test/metabase_enterprise/transforms/revision_test.cljnew file mode 100644index 00000000000..d6b43dd3e5e--- /dev/null+++ b/enterprise/backend/test/metabase_enterprise/transforms/revision_test.clj@@ -0,0 +1,24 @@+(ns metabase-enterprise.transforms.revision-test+ (:require+ [clojure.test :refer :all]+ [metabase.revisions.models.revision :as revision]))++(deftest transform-serialize-instance-test+ (testing "serialize-instance for :model/Transform excludes the correct columns"+ (let [transform {:id 1+ :entity_id "wyQv6yHnXS-IqPrYm1osQ"+ :created_at "2025-09-30T00:00:00Z"+ :updated_at "2025-09-30T00:00:00Z"+ :name "Test Transform"+ :description "A test transform"+ :source {:type :query+ :query {:database 1+ :type :query+ :query {:source-table 2}}}+ :target {:type :table+ :name "transformed_table"+ :schema "public"+ :database 1}}+ exp-serialized (dissoc transform :id :entity_id :created_at :updated_at)]+ (is (= (revision/serialize-instance :model/Transform nil transform)+ exp-serialized)))))diff --git a/src/metabase/revisions/events.clj b/src/metabase/revisions/events.cljindex fb9b9bd68be..f037a37f452 100644--- a/src/metabase/revisions/events.clj+++ b/src/metabase/revisions/events.clj@@ -45,6 +45,14 @@[topic event](push-revision! :model/Dashboard event {:is-creation? (= topic :event/dashboard-create)}))+(derive ::transform-event ::event)+(derive :event/transform-create ::transform-event)+(derive :event/transform-update ::transform-event)++(methodical/defmethod events/publish-event! ::transform-event+ [topic event]+ (push-revision! :model/Transform event {:is-creation? (= topic :event/transform-create)}))+(derive ::segment-event ::event)(derive :event/segment-create ::segment-event)(derive :event/segment-update ::segment-event)diff --git a/src/metabase/revisions/impl/transform.clj b/src/metabase/revisions/impl/transform.cljnew file mode 100644index 00000000000..43fd6810bf8--- /dev/null+++ b/src/metabase/revisions/impl/transform.clj@@ -0,0 +1,9 @@+(ns metabase.revisions.impl.transform+ (:require+ [metabase.revisions.models.revision :as revision]))++(def ^:private excluded-columns-for-transform-revision+ #{:id :entity_id :created_at :updated_at})++(defmethod revision/serialize-instance :model/Transform [_model _id instance]+ (apply dissoc instance excluded-columns-for-transform-revision))diff --git a/src/metabase/revisions/init.clj b/src/metabase/revisions/init.cljindex a55907eb188..1cba8346066 100644--- a/src/metabase/revisions/init.clj+++ b/src/metabase/revisions/init.clj@@ -6,4 +6,5 @@;; https://linear.app/metabase/issue/DEV-326[metabase.revisions.impl.card][metabase.revisions.impl.dashboard]- [metabase.revisions.impl.segment]))+ [metabase.revisions.impl.segment]+ [metabase.revisions.impl.transform]))