The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Do not autopivot transform query results (#63669)
Alexander Polyankin4f764b82efbd
diff --git a/e2e/test/scenarios/admin/transforms.cy.spec.ts b/e2e/test/scenarios/admin/transforms.cy.spec.tsindex f5fa2fa47dc..494657c3f19 100644--- a/e2e/test/scenarios/admin/transforms.cy.spec.ts+++ b/e2e/test/scenarios/admin/transforms.cy.spec.ts@@ -441,6 +441,40 @@ H.describeWithSnowplowEE("scenarios > admin > transforms", () => {testCardSource({ type: "question", label: "Questions" });testCardSource({ type: "model", label: "Models" });});++ it("should not auto-pivot query results for MBQL transforms", () => {+ cy.log("create a new transform");+ visitTransformListPage();+ getTransformListPage().button("Create a transform").click();+ H.popover().findByText("Query builder").click();++ cy.log("build a query with 1 aggregation and 2 breakouts");+ H.entityPickerModal().within(() => {+ cy.findByText(DB_NAME).click();+ cy.findByText(SOURCE_TABLE).click();+ });+ H.getNotebookStep("summarize")+ .findByText("Pick a function or metric")+ .click();+ H.popover().findByText("Count of rows").click();+ H.getNotebookStep("summarize")+ .findByText("Pick a column to group by")+ .click();+ H.popover().findByText("Name").click();+ H.getNotebookStep("summarize")+ .findByTestId("breakout-step")+ .icon("add")+ .click();+ H.popover().findByText("Score").click();+ H.runButtonOverlay().click();++ cy.log("verify that no pivoting is applied");+ H.tableInteractiveHeader().within(() => {+ cy.findByText("Name").should("be.visible");+ cy.findByText(/Score/).should("be.visible");+ cy.findByText("Count").should("be.visible");+ });+ });});describe("name and description", () => {diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/hooks/use-query-results/use-query-results.ts b/enterprise/frontend/src/metabase-enterprise/transforms/hooks/use-query-results/use-query-results.tsindex d428c4a1cb6..6466052c508 100644--- a/enterprise/frontend/src/metabase-enterprise/transforms/hooks/use-query-results/use-query-results.ts+++ b/enterprise/frontend/src/metabase-enterprise/transforms/hooks/use-query-results/use-query-results.ts@@ -19,7 +19,11 @@ export function useQueryResults(question: Question) {const { result, rawSeries, isRunnable, isResultDirty } = useMemo(() => {const lastRunQuestion = lastRunQuery- ? Question.create({ dataset_query: lastRunQuery, metadata })+ ? Question.create({+ dataset_query: lastRunQuery,+ metadata,+ visualization_settings: question.settings(),+ }): null;const result = results ? results[0] : null;const rawSeries =diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/hooks/use-query-state/use-query-state.ts b/enterprise/frontend/src/metabase-enterprise/transforms/hooks/use-query-state/use-query-state.tsindex 6d243a88610..c2a5aa357b0 100644--- a/enterprise/frontend/src/metabase-enterprise/transforms/hooks/use-query-state/use-query-state.ts+++ b/enterprise/frontend/src/metabase-enterprise/transforms/hooks/use-query-state/use-query-state.ts@@ -4,14 +4,23 @@ import { useSelector } from "metabase/lib/redux";import { getMetadata } from "metabase/selectors/metadata";import * as Lib from "metabase-lib";import Question from "metabase-lib/v1/Question";-import type { DatasetQuery } from "metabase-types/api";+import type { DatasetQuery, VisualizationSettings } from "metabase-types/api";++const DEFAULT_VIZ_SETTINGS: VisualizationSettings = {+ "table.pivot": false,+};export function useQueryState(initialQuery: DatasetQuery) {const [query, setQuery] = useState(initialQuery);const metadata = useSelector(getMetadata);const question = useMemo(- () => Question.create({ dataset_query: query, metadata }),+ () =>+ Question.create({+ dataset_query: query,+ metadata,+ visualization_settings: DEFAULT_VIZ_SETTINGS,+ }),[query, metadata],);