The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
UXW-88 Fixed issue where `Show values for this series` switch is hidden because of the default value for show_stack_values (#64691)
Brad Anderson4f99d70eced7
diff --git a/frontend/src/metabase/visualizations/components/settings/ChartNestedSettingSeriesSingle.unit.spec.tsx b/frontend/src/metabase/visualizations/components/settings/ChartNestedSettingSeriesSingle.unit.spec.tsxindex bb1df5e3954..d0d971fa133 100644--- a/frontend/src/metabase/visualizations/components/settings/ChartNestedSettingSeriesSingle.unit.spec.tsx+++ b/frontend/src/metabase/visualizations/components/settings/ChartNestedSettingSeriesSingle.unit.spec.tsx@@ -74,18 +74,15 @@ function getSeries(): Series {] as any;}-const setup = () => {+const setup = ({ series }: { series: Series }) => {return renderWithProviders(- <QuestionChartSettings- series={getSeries()}- initial={{ section: "Data" }}- />,+ <QuestionChartSettings series={series} initial={{ section: "Data" }} />,);};describe("ChartNestedSettingSeriesSingle", () => {it("should render the `Show values for this series` switch (metabase#53248)", async () => {- setup();+ setup({ series: getSeries() });const expandButtons = screen.getAllByRole("img", { name: /ellipsis/i });expect(expandButtons).toHaveLength(5);@@ -102,4 +99,45 @@ describe("ChartNestedSettingSeriesSingle", () => {).getByTestId("chart-settings-widget-show_series_values"),).not.toHaveAttribute("hidden");});++ it("should not render the `Show values for this series` switch when graph.show_stack_values is 'total' (metabase#53248)", async () => {+ const series = getSeries();+ series[0].card.visualization_settings["graph.show_stack_values"] = "total";+ setup({ series });++ const expandButtons = screen.getAllByRole("img", { name: /ellipsis/i });+ expect(expandButtons).toHaveLength(5);++ await fireEvent.click(expandButtons[1]);++ await waitFor(() => {+ screen.getByTestId("chart-settings-widget-series_settings");+ });++ expect(+ within(+ screen.getByTestId("chart-settings-widget-series_settings"),+ ).getByTestId("chart-settings-widget-show_series_values"),+ ).toHaveAttribute("hidden");+ });++ it("should render the `Show values for this series` switch when stackable.stack_type is null (metabase#58552)", async () => {+ const series = getSeries();+ series[0].card.visualization_settings["stackable.stack_type"] = null;+ series[0].card.visualization_settings["graph.show_stack_values"] = "total";+ setup({ series });++ const expandButtons = screen.getAllByRole("img", { name: /ellipsis/i });+ await fireEvent.click(expandButtons[1]);++ await waitFor(() => {+ screen.getByTestId("chart-settings-widget-series_settings");+ });++ expect(+ within(+ screen.getByTestId("chart-settings-widget-series_settings"),+ ).getByTestId("chart-settings-widget-show_series_values"),+ ).not.toHaveAttribute("hidden");+ });});diff --git a/frontend/src/metabase/visualizations/lib/settings/series.js b/frontend/src/metabase/visualizations/lib/settings/series.jsindex 3804870bb6e..b8d0b08bb57 100644--- a/frontend/src/metabase/visualizations/lib/settings/series.js+++ b/frontend/src/metabase/visualizations/lib/settings/series.js@@ -189,7 +189,8 @@ export function seriesSetting({ readDependencies = [], def } = {}) {getHidden: (single, seriesSettings, { settings, series }) =>series.length <= 1 || // no need to show series-level control if there's only one series!settings["graph.show_values"] || // don't show it unless this chart has a global setting- settings["graph.show_stack_values"] === "total",+ (settings["stackable.stack_type"] &&+ settings["graph.show_stack_values"] === "total"),getDefault: (single, seriesSettings, { settings }) =>getSeriesDefaultShowSeriesValues(settings),readDependencies: ["graph.show_values", "stackable.stack_type"],