The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Only re-validate incremental checkpoint field when source changes (#74752)
Ngoc Khuat52bd3beefd50
diff --git a/src/metabase/transforms/crud.clj b/src/metabase/transforms/crud.cljindex 6484935abc7..c2f125651d1 100644--- a/src/metabase/transforms/crud.clj+++ b/src/metabase/transforms/crud.clj@@ -149,7 +149,8 @@(check-database-feature new)(when (contains? body :target)(validate-target-schema! new))- (validate-incremental-column-type! new)+ (when (contains? body :source)+ (validate-incremental-column-type! new))(when (transforms-base.u/query-transform? old)(validate-transform-query! new)(when-let [{:keys [cycle-str]} (transforms-base.ordering/get-transform-cycle new)]diff --git a/test/metabase/transforms_rest/api/transform_test.clj b/test/metabase/transforms_rest/api/transform_test.cljindex ccd72c9d911..4977e2110f6 100644--- a/test/metabase/transforms_rest/api/transform_test.clj+++ b/test/metabase/transforms_rest/api/transform_test.clj@@ -1673,6 +1673,41 @@(is (string? response))(is (re-find #"unsupported type" response))))))))))))+(deftest update-tag-ids-with-stale-checkpoint-field-test+ (testing "Updating only tag_ids succeeds even when the checkpoint field has since been deleted (GDGT-2410)"+ (mt/with-premium-features #{}+ (mt/test-drivers (mt/normal-drivers-with-feature :transforms/table)+ (mt/dataset transforms-dataset/transforms-test+ (let [schema (get-test-schema)+ id-field-id (mt/id :transforms_products :id)]+ (mt/with-temp [:model/TransformTag {tag-id :id} {:name "stale-checkpoint-tag"}]+ (with-transform-cleanup! [table-name "stale_checkpoint_test"]+ (let [created (mt/user-http-request :crowberto :post 200 "transform"+ {:name "Stale Checkpoint Transform"+ :tag_ids [tag-id]+ :source {:type "query"+ :query (lib/native-query (mt/metadata-provider)+ "SELECT id, name, category FROM transforms_products")+ :source-incremental-strategy {:type "checkpoint"+ :checkpoint-filter-field-id id-field-id}}+ :target {:type "table-incremental"+ :schema schema+ :name table-name+ :target-incremental-strategy {:type "append"}}})+ source (t2/select-one-fn :source :model/Transform (:id created))]+ ;; Simulate the checkpoint field being deleted out from under the transform+ ;; (e.g. its source table was re-synced), as happened with production transform 2344.+ ;; A non-existent field id is equivalent to a deleted field: the validator's+ ;; (select-one :model/Field id) returns nil either way.+ (t2/update! :model/Transform (:id created)+ {:source (assoc-in source [:source-incremental-strategy :checkpoint-filter-field-id]+ Integer/MAX_VALUE)})+ (testing "removing the tag (tag_ids-only update) should not re-validate the stale checkpoint field"+ (let [updated (mt/user-http-request :crowberto :put 200+ (format "transform/%d" (:id created))+ {:tag_ids []})]+ (is (= [] (:tag_ids updated))))))))))))))+(deftest search-filters-transform-source-types-test(mt/with-premium-features #{}(mt/test-drivers (mt/normal-drivers-with-feature :transforms/table)