The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Skip milestone backfill instead of throwing when no PR is referenced (#74205)
Nemanja Glumac536994e23d39
diff --git a/release/src/milestones.ts b/release/src/milestones.tsindex d857a19a98d..4b2600d1f7e 100644--- a/release/src/milestones.ts+++ b/release/src/milestones.ts@@ -253,7 +253,10 @@ export async function setMilestoneForCommits({.filter(isNotNull));if (!PRsToCheck.length) {- throw new Error('No PRs found in commit messages');+ // Not every commit on a release branch is a squash-merged PR (e.g. the+ // version-bump commit from cutting the branch). Nothing to backfill here.+ console.log('No PRs found in commit messages, skipping milestone backfill');+ return;}console.log(`Checking ${PRsToCheck.length} PRs for issues to tag`);diff --git a/release/src/milestones.unit.spec.ts b/release/src/milestones.unit.spec.tsindex 059a07844b7..b0875bd8a57 100644--- a/release/src/milestones.unit.spec.ts+++ b/release/src/milestones.unit.spec.ts@@ -1,4 +1,4 @@-import { getNextMilestone } from "./milestones";+import { getNextMilestone, setMilestoneForCommits } from "./milestones";import type { Milestone } from "./types";describe('milestones', () => {@@ -71,4 +71,31 @@ describe('milestones', () => {})?.number).toBe(612);});});++ describe('setMilestoneForCommits', () => {+ const buildGithub = () => ({+ paginate: jest.fn().mockResolvedValue(testMilestones),+ rest: {+ issues: {+ listMilestones: jest.fn(),+ update: jest.fn(),+ },+ },+ });++ it('is a no-op when no commit messages reference a PR', async () => {+ const github = buildGithub();++ // e.g. the version-bump commit created when cutting a release branch+ await expect(setMilestoneForCommits({+ github: github as any,+ owner: 'metabase',+ repo: 'metabase',+ branchName: 'release-x.57.x',+ commitMessages: ['Bump version to v0.57'],+ })).resolves.toBeUndefined();++ expect(github.rest.issues.update).not.toHaveBeenCalled();+ });+ });});