The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Don't drop DB before creating in Snowflake tests. (#74464)
technomancy55426fbde00b
diff --git a/modules/drivers/snowflake/test/metabase/driver/snowflake_test.clj b/modules/drivers/snowflake/test/metabase/driver/snowflake_test.cljindex 3db5a53b1c0..3cbb53f4840 100644--- a/modules/drivers/snowflake/test/metabase/driver/snowflake_test.clj+++ b/modules/drivers/snowflake/test/metabase/driver/snowflake_test.clj@@ -189,7 +189,7 @@(testing "make sure we didn't break the code that is used to generate DDL statements when we add new test datasets"(with-redefs [test.data.snowflake/qualified-db-name (constantly "v4_test-data")](testing "Create DB DDL statements"- (is (= "DROP DATABASE IF EXISTS \"v4_test-data\"; CREATE DATABASE \"v4_test-data\";"+ (is (= "CREATE DATABASE IF NOT EXISTS \"v4_test-data\";"(sql.tx/create-db-sql :snowflake (mt/get-dataset-definition defs/test-data)))))(testing "Create Table DDL statements"(is (= (mapdiff --git a/modules/drivers/snowflake/test/metabase/test/data/snowflake.clj b/modules/drivers/snowflake/test/metabase/test/data/snowflake.cljindex 3f2de5676f9..0b98d502ed0 100644--- a/modules/drivers/snowflake/test/metabase/test/data/snowflake.clj+++ b/modules/drivers/snowflake/test/metabase/test/data/snowflake.clj@@ -89,7 +89,7 @@(defmethod sql.tx/create-db-sql :snowflake[driver dbdef](let [db (sql.tx/qualify-and-quote driver (qualified-db-name dbdef))]- (format "DROP DATABASE IF EXISTS %s; CREATE DATABASE %s;" db db)))+ (format "CREATE DATABASE IF NOT EXISTS %s;" db)))(defn- no-db-connection-spec"Connection spec for connecting to our Snowflake instance without specifying a DB."