Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Handle unknown theme preset (#66554)

Timofey Kachalov5568ace394b2
diff --git a/frontend/src/embedding-sdk-shared/lib/apply-theme-preset.ts b/frontend/src/embedding-sdk-shared/lib/apply-theme-preset.ts
index 36f97b14773..1ad77698b22 100644
--- a/frontend/src/embedding-sdk-shared/lib/apply-theme-preset.ts
+++ b/frontend/src/embedding-sdk-shared/lib/apply-theme-preset.ts
@@ -30,7 +30,11 @@ const COLOR_GETTERS: Record<MetabaseThemePreset, () => ColorPalette> = {
};
const getPresetColors = (preset: MetabaseThemePreset): MetabaseColors => {
- const palette = COLOR_GETTERS[preset]();
+ const palette = COLOR_GETTERS[preset]?.();
+
+ if (!palette) {
+ return {};
+ }
return Object.fromEntries(
PRESET_SDK_COLORS.map((sdkColor) => {
diff --git a/frontend/src/embedding-sdk-shared/lib/apply-theme-preset.unit.spec.ts b/frontend/src/embedding-sdk-shared/lib/apply-theme-preset.unit.spec.ts
index 39e770ba775..951bb8422bf 100644
--- a/frontend/src/embedding-sdk-shared/lib/apply-theme-preset.unit.spec.ts
+++ b/frontend/src/embedding-sdk-shared/lib/apply-theme-preset.unit.spec.ts
@@ -66,4 +66,17 @@ describe("applyThemePreset", () => {
expect(applyThemePreset(theme)).toEqual(theme);
});
});
+
+ describe("invalid preset", () => {
+ it("returns empty colors for unknown preset", () => {
+ const theme = {
+ preset: "invalid-preset" as any,
+ colors: { brand: "#custom" },
+ };
+
+ const result = applyThemePreset(theme);
+
+ expect(result?.colors).toEqual({ brand: "#custom" });
+ });
+ });
});