Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Remove dead modules where the folders no longer exist (#78754)

Fraser56eaca30d699
diff --git a/frontend/CLAUDE.md b/frontend/CLAUDE.md
index 0382e4e7138..41420dad202 100644
--- a/frontend/CLAUDE.md
+++ b/frontend/CLAUDE.md
@@ -12,7 +12,6 @@ This is a high-level guide. Use available search tools to discover the current s
- API clients: `frontend/src/metabase/api`
- Query building and data modeling: `frontend/src/metabase-lib`
- Shared TypeScript types: `frontend/src/metabase-types`
-- Thin helpers reused across bundles: `frontend/src/metabase-shared`
- Global and ambient type declarations: `frontend/src/types`
- Embedding SDK OSS code: `frontend/src/embedding-sdk-bundle` and `frontend/src/embedding-sdk-shared`
- Enterprise-only features: `enterprise/frontend/src/metabase-enterprise`
diff --git a/frontend/lint/module-boundaries.mjs b/frontend/lint/module-boundaries.mjs
index 05d4977f8c7..c2a60d4bd7c 100644
--- a/frontend/lint/module-boundaries.mjs
+++ b/frontend/lint/module-boundaries.mjs
@@ -64,11 +64,6 @@ const elements = [
createElement({ type: "shared", name: "data-grid" }),
createElement({ type: "shared", name: "databases" }),
createElement({ type: "shared", name: "detail-view" }),
- createElement({
- type: "shared",
- name: "embed",
- pattern: "frontend/src/embed/**",
- }),
// embedding-iframe-sdk, embedding-iframe-sdk-setup and mcp-app must come before
// shared/embedding: their patterns are subfolders of
// frontend/src/metabase/embedding/, and the first matching element wins.
@@ -136,16 +131,10 @@ const elements = [
pattern: "frontend/src/embedding-sdk-shared/**",
}),
createElement({ type: "shared", name: "forms" }),
- createElement({ type: "shared", name: "history" }),
createElement({ type: "shared", name: "hoc" }),
createElement({ type: "feature", name: "home" }),
createElement({ type: "shared", name: "hooks" }),
createElement({ type: "shared", name: "content-translation" }),
- createElement({
- type: "shared",
- name: "metabase-shared",
- pattern: "frontend/src/metabase-shared/**",
- }),
createElement({ type: "shared", name: "metabot" }),
createElement({ type: "shared", name: "metadata" }),
createElement({ type: "feature", name: "models" }),
diff --git a/frontend/lint/tests/module-boundaries.unit.spec.js b/frontend/lint/tests/module-boundaries.unit.spec.js
new file mode 100644
index 00000000000..8fe6b5a0622
--- /dev/null
+++ b/frontend/lint/tests/module-boundaries.unit.spec.js
@@ -0,0 +1,24 @@
+import path from "path";
+
+import glob from "glob";
+
+import { elements } from "../module-boundaries.mjs";
+
+const REPO_ROOT = path.resolve(__dirname, "../../..");
+
+describe("module-boundaries elements", () => {
+ it("every element pattern matches at least one file", () => {
+ const stale = elements
+ .filter(
+ (element) =>
+ glob.sync(element.pattern, {
+ cwd: REPO_ROOT,
+ dot: true,
+ nodir: true,
+ }).length === 0,
+ )
+ .map((element) => `${element.type} -> ${element.pattern}`);
+
+ expect(stale).toEqual([]);
+ });
+});