Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Increase horizontal spacing between inline chart setting label and toggle / Convert ChartSettingsWidget.styled to css module (#78922)

Anderson56eec114ae43
diff --git a/frontend/src/metabase/visualizations/components/ChartSettingsWidget.module.css b/frontend/src/metabase/visualizations/components/ChartSettingsWidget.module.css
new file mode 100644
index 00000000000..8e88ba0e2e2
--- /dev/null
+++ b/frontend/src/metabase/visualizations/components/ChartSettingsWidget.module.css
@@ -0,0 +1,7 @@
+.inline {
+ display: flex;
+ flex-direction: row;
+ justify-content: space-between;
+ align-items: center;
+ gap: var(--mantine-spacing-sm);
+}
diff --git a/frontend/src/metabase/visualizations/components/ChartSettingsWidget.styled.tsx b/frontend/src/metabase/visualizations/components/ChartSettingsWidget.styled.tsx
deleted file mode 100644
index 9e10116602a..00000000000
--- a/frontend/src/metabase/visualizations/components/ChartSettingsWidget.styled.tsx
+++ /dev/null
@@ -1,27 +0,0 @@
-// eslint-disable-next-line no-restricted-imports
-import { css } from "@emotion/react";
-// eslint-disable-next-line no-restricted-imports
-import styled from "@emotion/styled";
-
-export const Root = styled.div<{
- inline?: boolean;
-}>`
- margin-inline: 1.5rem;
- margin-bottom: 1.5rem;
-
- ${(props) =>
- props.hidden &&
- css`
- display: none;
- `}
-
- ${(props) =>
- props.inline &&
- !props.hidden &&
- css`
- display: flex;
- flex-direction: row;
- justify-content: space-between;
- align-items: center;
- `}
-`;
diff --git a/frontend/src/metabase/visualizations/components/ChartSettingsWidget.tsx b/frontend/src/metabase/visualizations/components/ChartSettingsWidget.tsx
index a2cd9ebeab5..844cafb67d9 100644
--- a/frontend/src/metabase/visualizations/components/ChartSettingsWidget.tsx
+++ b/frontend/src/metabase/visualizations/components/ChartSettingsWidget.tsx
@@ -6,7 +6,7 @@ import FormS from "metabase/css/components/form.module.css";
import { PLUGIN_CUSTOM_VIZ } from "metabase/plugins";
import { Box, Group, Icon, Text, Tooltip } from "metabase/ui";
-import { Root } from "./ChartSettingsWidget.styled";
+import S from "./ChartSettingsWidget.module.css";
export type ChartSettingsWidgetVariant = "default" | "form-field";
@@ -42,12 +42,14 @@ const ChartSettingsWidget = ({
}: Props) => {
const isFormField = variant === "form-field";
return (
- <Root
+ <Box
hidden={hidden}
className={cx({
[FormS.FormField]: isFormField,
+ [S.inline]: inline && !hidden,
})}
- inline={inline}
+ mx="lg"
+ mb="lg"
data-testid={dataTestId ?? `chart-settings-widget-${extraWidgetProps.id}`}
data-field-title={title}
style={style}
@@ -84,7 +86,7 @@ const ChartSettingsWidget = ({
) : (
<Widget {...extraWidgetProps} {...props} />
))}
- </Root>
+ </Box>
);
};