Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Fix #50044 - Updates dashcard loading state so it shows the correct title while it's loading (#65363)

Brad Anderson57daa4d5dc58
diff --git a/frontend/src/metabase/visualizations/components/ChartCaption.tsx b/frontend/src/metabase/visualizations/components/ChartCaption.tsx
index f393b3a7064..cd39139cf69 100644
--- a/frontend/src/metabase/visualizations/components/ChartCaption.tsx
+++ b/frontend/src/metabase/visualizations/components/ChartCaption.tsx
@@ -37,7 +37,11 @@ const ChartCaption = ({
width,
titleMenuItems,
}: ChartCaptionProps) => {
- const title = settings["card.title"] ?? series?.[0].card.name ?? "";
+ const title =
+ settings["card.title"] ??
+ series?.[0].card.visualization_settings["card.title"] ??
+ series?.[0].card.name ??
+ "";
const description = settings["card.description"];
const data =
visualizerRawSeries ?? (series as TransformedSeries)._raw ?? series;
diff --git a/frontend/src/metabase/visualizations/components/ChartCaption.unit.spec.tsx b/frontend/src/metabase/visualizations/components/ChartCaption.unit.spec.tsx
index 969b78996d7..c9860c6f24a 100644
--- a/frontend/src/metabase/visualizations/components/ChartCaption.unit.spec.tsx
+++ b/frontend/src/metabase/visualizations/components/ChartCaption.unit.spec.tsx
@@ -105,4 +105,70 @@ describe("ChartCaption", () => {
expect(queryIcon("info")).not.toBeInTheDocument();
});
+
+ describe("title sources", () => {
+ it("should use card.title from settings as highest priority", () => {
+ setup({
+ series: getSeries({
+ card: createMockCard({
+ name: "Card Name",
+ visualization_settings: { "card.title": "Viz Settings Title" },
+ }),
+ }),
+ settings: { "card.title": "Settings Title" },
+ });
+
+ expect(screen.getByTestId("legend-caption")).toHaveTextContent(
+ "Settings Title",
+ );
+ });
+
+ it("should use card.title from visualization_settings when no settings title", () => {
+ setup({
+ series: getSeries({
+ card: createMockCard({
+ name: "Card Name",
+ visualization_settings: { "card.title": "Viz Settings Title" },
+ }),
+ }),
+ settings: {},
+ });
+
+ expect(screen.getByTestId("legend-caption")).toHaveTextContent(
+ "Viz Settings Title",
+ );
+ });
+
+ it("should use card.name when no title in settings or visualization_settings", () => {
+ setup({
+ series: getSeries({
+ card: createMockCard({
+ name: "Card Name",
+ visualization_settings: {},
+ }),
+ }),
+ settings: {},
+ });
+
+ expect(screen.getByTestId("legend-caption")).toHaveTextContent(
+ "Card Name",
+ );
+ });
+
+ it("should render empty title when no title sources available", () => {
+ setup({
+ series: getSeries({
+ card: createMockCard({
+ name: undefined,
+ visualization_settings: {},
+ }),
+ }),
+ settings: {},
+ });
+
+ const caption = screen.getByTestId("legend-caption");
+ expect(caption).toBeInTheDocument();
+ expect(caption).not.toHaveTextContent(/\S/); // Should not contain any non-whitespace characters
+ });
+ });
});