Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Enable Trunk Quarantine for drivers (#64995)

Nemanja Glumac5b2fd3536792
diff --git a/.github/actions/test-driver/action.yml b/.github/actions/test-driver/action.yml
index 6c2c90d0d0e..94afa18a5c1 100644
--- a/.github/actions/test-driver/action.yml
+++ b/.github/actions/test-driver/action.yml
@@ -27,9 +27,15 @@ runs:
- name: Test database driver
run: clojure -X:dev:ci:ee:ee-dev:drivers:drivers-dev:test ${{ inputs.test-args }}
shell: bash
+ id: run-test
+ # Trunk Quarantine controls the final state of the run in the CI!
+ # Even if this step fails, we let it pass and then `trunk-io/analytics-uploader` determines whether to fail or to
+ # pass the whole job, based on the quarantine list.
+ # We only want to "continue on error" (ignore failures) when the Trunk upload is active - i.e. not on drafts!
+ continue-on-error: ${{ !(github.event_name == 'pull_request' && github.event.pull_request.draft == true) }}
- name: Publish Test Report (JUnit)
uses: dorny/test-reporter@v1
- if: failure()
+ if: ${{ steps.run-test.outcome == 'failure' }}
with:
path: "target/junit/**/*_test.xml"
name: JUnit Test Report ${{ inputs.junit-name }}
@@ -38,9 +44,11 @@ runs:
list-tests: failed
fail-on-error: false
- name: Upload Logs on Failure
- if: always() && !success()
+ if: ${{ steps.run-test.outcome == 'failure' }}
uses: actions/upload-artifact@v4
with:
name: test-logs-${{ github.job }}
path: logs/test-log.json
retention-days: 1
+ # Failing to upload the artifact should never affect the outcome of the whole test run.
+ continue-on-error: true