The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Count only new runs in two task run tests (#85380)
Bartosz Rybacki5c8e18f69ea4
diff --git a/test/metabase/task_history/models/task_run_test.clj b/test/metabase/task_history/models/task_run_test.cljindex 6c55c819b5c..328466dad5b 100644--- a/test/metabase/task_history/models/task_run_test.clj+++ b/test/metabase/task_history/models/task_run_test.clj@@ -123,7 +123,8 @@(deftest with-task-run-prevents-nesting-test(mt/with-model-cleanup [:model/TaskRun](testing "nested with-task-run does not create a new run"- (let [outer-run-id (atom nil)+ (let [runs-before (t2/count :model/TaskRun)+ outer-run-id (atom nil)inner-run-id (atom nil)](task-history/with-task-run {:run_type :sync:entity_type :database@@ -134,14 +135,15 @@:entity_id 2}(reset! inner-run-id (task-history/current-run-id))))(is (= @outer-run-id @inner-run-id) "inner run uses same run-id")- (is (= 1 (t2/count :model/TaskRun)) "only one run created")))))+ (is (= (inc runs-before) (t2/count :model/TaskRun)) "only one run created")))))(deftest with-task-run-nil-info-test(mt/with-model-cleanup [:model/TaskRun](testing "with-task-run with nil run-info just executes body"- (task-history/with-task-run nil- (is (nil? (task-history/current-run-id)) "run-id remains nil"))- (is (zero? (t2/count :model/TaskRun)) "no run created"))))+ (let [runs-before (t2/count :model/TaskRun)]+ (task-history/with-task-run nil+ (is (nil? (task-history/current-run-id)) "run-id remains nil"))+ (is (= runs-before (t2/count :model/TaskRun)) "no run created")))));;; +----------------------------------------------------------------------------------------------------------------+;;; | complete-task-run! tests |