Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Add hover border for default Mantine Input and Select across the app (#73945)

Oleh K5d55d051aa35
diff --git a/frontend/src/metabase/common/components/SelectButton/SelectButton.styled.tsx b/frontend/src/metabase/common/components/SelectButton/SelectButton.styled.tsx
index 97212612505..b5e75624b83 100644
--- a/frontend/src/metabase/common/components/SelectButton/SelectButton.styled.tsx
+++ b/frontend/src/metabase/common/components/SelectButton/SelectButton.styled.tsx
@@ -33,9 +33,12 @@ export const SelectButtonRoot = styled.button<SelectButtonRootProps>`
border-radius: var(--mantine-spacing-sm);
font-weight: 700;
min-width: 104px;
- transition: all 200ms;
color: ${getColor};
+ &:hover {
+ border-color: var(--mb-color-brand);
+ }
+
&:focus {
border-color: var(--mb-color-brand);
outline: 2px solid var(--mb-color-focus);
diff --git a/frontend/src/metabase/dashboard/components/ParameterSettings/MoveParameterMenu/MoveParameterMenu.module.css b/frontend/src/metabase/dashboard/components/ParameterSettings/MoveParameterMenu/MoveParameterMenu.module.css
index c450cf52985..da083006ad3 100644
--- a/frontend/src/metabase/dashboard/components/ParameterSettings/MoveParameterMenu/MoveParameterMenu.module.css
+++ b/frontend/src/metabase/dashboard/components/ParameterSettings/MoveParameterMenu/MoveParameterMenu.module.css
@@ -4,12 +4,9 @@
cursor: pointer;
color: transparent;
- &:hover {
+ &[data-variant="default"]:hover:not(:disabled) {
+ border-color: var(--mb-color-border);
background-color: var(--mb-color-background-hover);
-
- &::placeholder {
- color: var(--mb-color-brand);
- }
}
}
@@ -26,6 +23,10 @@
transform: translate(-50%, -50%);
pointer-events: none;
}
+
+ &:hover::after {
+ color: var(--mb-color-text-hover);
+ }
}
.MoveParameterMenuOptionIcon {
diff --git a/frontend/src/metabase/parameters/components/ParameterValueWidget.module.css b/frontend/src/metabase/parameters/components/ParameterValueWidget.module.css
index 30f0f85f601..53c73550f59 100644
--- a/frontend/src/metabase/parameters/components/ParameterValueWidget.module.css
+++ b/frontend/src/metabase/parameters/components/ParameterValueWidget.module.css
@@ -108,6 +108,7 @@
border-radius: 0.25rem;
cursor: pointer;
+ &:hover,
&.hasValue {
border-color: var(--mb-color-brand);
}
diff --git a/frontend/src/metabase/ui/components/inputs/Input/Input.module.css b/frontend/src/metabase/ui/components/inputs/Input/Input.module.css
index e7cf8b9acc9..42bf4a2b0eb 100644
--- a/frontend/src/metabase/ui/components/inputs/Input/Input.module.css
+++ b/frontend/src/metabase/ui/components/inputs/Input/Input.module.css
@@ -34,6 +34,10 @@
&[data-variant="default"] {
border-color: var(--mb-color-border);
+ &:hover:not(:disabled) {
+ border-color: var(--mb-color-brand);
+ }
+
&:focus {
border-color: var(--mb-color-brand);
}
diff --git a/frontend/src/metabase/visualizations/components/ChartSettingsWidget.styled.tsx b/frontend/src/metabase/visualizations/components/ChartSettingsWidget.styled.tsx
index b5012f13464..9e10116602a 100644
--- a/frontend/src/metabase/visualizations/components/ChartSettingsWidget.styled.tsx
+++ b/frontend/src/metabase/visualizations/components/ChartSettingsWidget.styled.tsx
@@ -24,13 +24,4 @@ export const Root = styled.div<{
justify-content: space-between;
align-items: center;
`}
-
- input {
- transition: border 0.3s;
-
- &:hover {
- transition: border 0.3s;
- border-color: var(--mb-color-brand);
- }
- }
`;