Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Only default warehouse-allowed-networks to external-only on prod (#79672)

Nathan Voxland5dbc8db1d2c1
diff --git a/.github/workflows/embedding-sdk-component-tests.yml b/.github/workflows/embedding-sdk-component-tests.yml
index accf4104e40..631ab66d6db 100644
--- a/.github/workflows/embedding-sdk-component-tests.yml
+++ b/.github/workflows/embedding-sdk-component-tests.yml
@@ -176,6 +176,7 @@ jobs:
timeout-minutes: 45
env:
MB_RUN_MODE: "e2e"
+ MB_WAREHOUSE_ALLOWED_NETWORKS: "allow-all"
METASTORE_DEV_SERVER_URL: ${{ secrets.METASTORE_DEV_SERVER_URL }}
CI_CONDUCTOR_TEST_SUITE: embedding-sdk-component-backward-compatibility
# Sensitive env vars (tokens, secrets) starting with `CYPRESS_` are accessed via async `cy.env()`
diff --git a/.github/workflows/embedding-sdk-host-sample-apps-tests.yml b/.github/workflows/embedding-sdk-host-sample-apps-tests.yml
index b315d363c1d..45e21297d01 100644
--- a/.github/workflows/embedding-sdk-host-sample-apps-tests.yml
+++ b/.github/workflows/embedding-sdk-host-sample-apps-tests.yml
@@ -100,6 +100,7 @@ jobs:
env:
MB_EDITION: ee
MB_RUN_MODE: e2e
+ MB_WAREHOUSE_ALLOWED_NETWORKS: "allow-all"
METASTORE_DEV_SERVER_URL: ${{ secrets.METASTORE_DEV_SERVER_URL }}
CYPRESS_MB_ALL_FEATURES_TOKEN: ${{ secrets.STAGING_MB_ALL_FEATURES_TOKEN }}
SAMPLE_APP_BRANCH_NAME: ${{ needs.get-sample-apps-data.outputs.branch_name }}
@@ -211,6 +212,7 @@ jobs:
env:
MB_EDITION: ee
MB_RUN_MODE: e2e
+ MB_WAREHOUSE_ALLOWED_NETWORKS: "allow-all"
METASTORE_DEV_SERVER_URL: ${{ secrets.METASTORE_DEV_SERVER_URL }}
CYPRESS_MB_ALL_FEATURES_TOKEN: ${{ secrets.STAGING_MB_ALL_FEATURES_TOKEN }}
SAMPLE_APP_BRANCH_NAME: ${{ needs.get-sample-apps-data.outputs.branch_name }}
@@ -278,6 +280,7 @@ jobs:
env:
MB_EDITION: ee
MB_RUN_MODE: e2e
+ MB_WAREHOUSE_ALLOWED_NETWORKS: "allow-all"
METASTORE_DEV_SERVER_URL: ${{ secrets.METASTORE_DEV_SERVER_URL }}
CYPRESS_MB_ALL_FEATURES_TOKEN: ${{ secrets.STAGING_MB_ALL_FEATURES_TOKEN }}
SAMPLE_APP_BRANCH_NAME: ${{ needs.get-sample-apps-data.outputs.branch_name }}
diff --git a/deps.edn b/deps.edn
index 81a5d7fd9dc..12eb4871193 100644
--- a/deps.edn
+++ b/deps.edn
@@ -298,6 +298,7 @@
:jvm-opts ["-Dmb.run.mode=dev"
"-Dmb.field.filter.operators.enabled=true"
"-Dmb.test.env.setting=ABCDEFG"
+ "-Dmb.warehouse.allowed.networks=allow-all"
"-Dmacaw.run.mode=dev"
"-Duser.timezone=UTC"
"-Dfile.encoding=UTF-8"
@@ -339,6 +340,7 @@
;; clj -M:dev:dev-start:drivers:drivers-dev:ee:ee-dev
:dev-start {:main-opts ["-m" "user"]
:jvm-opts ["-Dmb.run.mode=dev"
+ "-Dmb.warehouse.allowed.networks=allow-all"
"-Dmacaw.run.mode=dev"
"-Djava.awt.headless=true"]}
@@ -348,6 +350,7 @@
:exec-fn metabase.test-runner/find-and-run-tests-cli
:exec-args {}
:jvm-opts ["-Dmb.run.mode=test"
+ "-Dmb.warehouse.allowed.networks=allow-all"
"-Dmacaw.run.mode=test"
"-Dmb.db.in.memory=true"
"-Dmb.jetty.join=false"
@@ -367,6 +370,7 @@
:run
{:main-opts ["-m" "metabase.core.bootstrap"]
:jvm-opts ["-Dmb.run.mode=dev"
+ "-Dmb.warehouse.allowed.networks=allow-all"
"-Dmacaw.run.mode=dev"
"-Djava.awt.headless=true"]} ; prevent Java icon from randomly popping up in macOS dock
@@ -378,6 +382,7 @@
;; clojure -M:dev:drivers:(oss|ee):run:e2e
:e2e
{:jvm-opts ["-Dmb.run.mode=e2e"
+ "-Dmb.warehouse.allowed.networks=allow-all"
"-Dmetastore.dev.server.url=https://token-check.staging.metabase.com"
;; prevent Java icon from randomly popping up in macOS dock
"-Djava.awt.headless=true"
@@ -422,6 +427,7 @@
:doc
{:main-opts ["-m" "metabase.core.bootstrap"]
:jvm-opts ["-Dmb.run.mode=prod"
+ "-Dmb.warehouse.allowed.networks=allow-all"
"-Djava.awt.headless=true"]} ; prevent Java icon from randomly popping up in macOS dock
;; alias for CI-specific options.
@@ -478,7 +484,8 @@
:cljs
{:extra-paths ["test"]
- :jvm-opts ["-Dmb.run.mode=dev"]
+ :jvm-opts ["-Dmb.run.mode=dev"
+ "-Dmb.warehouse.allowed.networks=allow-all"]
:extra-deps
{binaryage/devtools {:mvn/version "1.0.7"}
cider/cider-nrepl {:mvn/version "0.58.0"}