The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Show the metric icon for bookmarked metrics in the app sidebar (#83666)
Anderson5ddcbeeedf41
diff --git a/frontend/src/metabase/nav/containers/MainNavbar/MainNavbarContainer/BookmarkList/BookmarkList.tsx b/frontend/src/metabase/nav/containers/MainNavbar/MainNavbarContainer/BookmarkList/BookmarkList.tsxindex 8498b376460..c6d080fba04 100644--- a/frontend/src/metabase/nav/containers/MainNavbar/MainNavbarContainer/BookmarkList/BookmarkList.tsx+++ b/frontend/src/metabase/nav/containers/MainNavbar/MainNavbarContainer/BookmarkList/BookmarkList.tsx@@ -64,7 +64,14 @@ function isBookmarkSelected(bookmark: Bookmark, selectedItem?: SelectedItem) {function getBookmarkModel(bookmark: Bookmark) {// we should really fix this on the backend- return bookmark.card_type === "model" ? "dataset" : bookmark.type;+ switch (bookmark.card_type) {+ case "model":+ return "dataset";+ case "metric":+ return "metric";+ default:+ return bookmark.type;+ }}const BookmarkItem = ({diff --git a/frontend/src/metabase/nav/containers/MainNavbar/MainNavbarContainer/BookmarkList/BookmarkList.unit.spec.tsx b/frontend/src/metabase/nav/containers/MainNavbar/MainNavbarContainer/BookmarkList/BookmarkList.unit.spec.tsxindex 01c8c54cef4..2ed811ece5f 100644--- a/frontend/src/metabase/nav/containers/MainNavbar/MainNavbarContainer/BookmarkList/BookmarkList.unit.spec.tsx+++ b/frontend/src/metabase/nav/containers/MainNavbar/MainNavbarContainer/BookmarkList/BookmarkList.unit.spec.tsx@@ -68,6 +68,30 @@ describe("BookmarkList", () => {expect(screen.queryByLabelText("grabber icon")).not.toBeInTheDocument();});+ it("renders the metric icon for metric bookmarks (#83340)", () => {+ renderWithProviders(+ <BookmarkList+ {...mockProps}+ bookmarks={[+ createMockBookmark({+ id: "card-1",+ type: "card",+ card_type: "metric",+ display: "scalar",+ name: "Total revenue",+ }),+ ]}+ />,+ );++ const bookmarkItem = screen.getByRole("listitem", {+ name: "Total revenue",+ });+ expect(+ within(bookmarkItem).getByLabelText("metric icon"),+ ).toBeInTheDocument();+ });+describe("collection bookmark icons (enterprise)", () => {it.each([{