The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Move dashboard-click-drill into visualizations-click-actions (#74131)
Fraser5f1cef8d7fb5
diff --git a/frontend/src/metabase/dashboard/actions/getNewCardUrl.ts b/frontend/src/metabase/dashboard/actions/getNewCardUrl.tsindex bc167f1792b..16a7c0eb41a 100644--- a/frontend/src/metabase/dashboard/actions/getNewCardUrl.ts+++ b/frontend/src/metabase/dashboard/actions/getNewCardUrl.ts@@ -2,6 +2,7 @@ import _ from "underscore";import type { StoreDashboard } from "metabase/redux/store";import * as Urls from "metabase/urls";+import { getStructuredQuestionUrlWithParameters } from "metabase/visualizations/click-actions/lib/question-url";import { getCardAfterVisualizationClick } from "metabase/visualizations/lib/utils";import * as Lib from "metabase-lib";import Question from "metabase-lib/v1/Question";@@ -19,8 +20,6 @@ import type {VirtualCard,} from "metabase-types/api";-import { getStructuredQuestionUrlWithParameters } from "../utils/question-url";-/*** All navigation URLs from dashboards to cards (e.x. clicking a title, drill through)* should come from this function, which merges any currently applied dashboard filtersdiff --git a/frontend/src/metabase/visualizations/click-actions/actions/DashboardClickAction.tsx b/frontend/src/metabase/visualizations/click-actions/actions/DashboardClickAction.tsxindex 909eb995b07..991c4e001b5 100644--- a/frontend/src/metabase/visualizations/click-actions/actions/DashboardClickAction.tsx+++ b/frontend/src/metabase/visualizations/click-actions/actions/DashboardClickAction.tsx@@ -1,3 +1,5 @@+import { selectTab } from "metabase/redux/dashboard";+import type { Dispatch } from "metabase/redux/store";import {getDashboardDrillLinkUrl,getDashboardDrillParameters,@@ -5,9 +7,7 @@ import {getDashboardDrillTab,getDashboardDrillType,getDashboardDrillUrl,-} from "metabase/dashboard/utils/dashboard-click-drill";-import { selectTab } from "metabase/redux/dashboard";-import type { Dispatch } from "metabase/redux/store";+} from "metabase/visualizations/click-actions/lib/dashboard-click-drill";import type {AlwaysDefaultClickAction,AlwaysDefaultClickActionSubAction,diff --git a/frontend/src/metabase/dashboard/utils/dashboard-click-drill.js b/frontend/src/metabase/visualizations/click-actions/lib/dashboard-click-drill.jssimilarity index 100%rename from frontend/src/metabase/dashboard/utils/dashboard-click-drill.jsrename to frontend/src/metabase/visualizations/click-actions/lib/dashboard-click-drill.jsdiff --git a/frontend/src/metabase/dashboard/utils/question-url.ts b/frontend/src/metabase/visualizations/click-actions/lib/question-url.tssimilarity index 100%rename from frontend/src/metabase/dashboard/utils/question-url.tsrename to frontend/src/metabase/visualizations/click-actions/lib/question-url.tsdiff --git a/frontend/src/metabase/dashboard/utils/question-url.unit.spec.ts b/frontend/src/metabase/visualizations/click-actions/lib/question-url.unit.spec.tssimilarity index 100%rename from frontend/src/metabase/dashboard/utils/question-url.unit.spec.tsrename to frontend/src/metabase/visualizations/click-actions/lib/question-url.unit.spec.tsdiff --git a/frontend/src/metabase/visualizations/click-actions/modes/EmbeddingSdkMode.ts b/frontend/src/metabase/visualizations/click-actions/modes/EmbeddingSdkMode.tsindex 6be2e09d9e4..32c77eb71e8 100644--- a/frontend/src/metabase/visualizations/click-actions/modes/EmbeddingSdkMode.ts+++ b/frontend/src/metabase/visualizations/click-actions/modes/EmbeddingSdkMode.ts@@ -1,8 +1,3 @@-import {- getClickBehavior,- getClickBehaviorData,- getParameterValuesBySlug,-} from "metabase/dashboard/utils/dashboard-click-drill";import type { ParameterValues } from "metabase/embedding-sdk/types/dashboard";import type {@@ -15,6 +10,11 @@ import { DashboardClickAction } from "../actions/DashboardClickAction";import { ExtractColumnAction } from "../actions/ExtractColumnAction";import { HideColumnAction } from "../actions/HideColumnAction";import { NativeQueryClickFallback } from "../actions/NativeQueryClickFallback";+import {+ getClickBehavior,+ getClickBehaviorData,+ getParameterValuesBySlug,+} from "../lib/dashboard-click-drill";export type ClickBehaviorTarget = {type: "dashboard" | "question";