Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Add description to auto sync toggle in remote sync setup (#74507)

Nick Fitzpatrick5f87f066eebe
diff --git a/e2e/test/scenarios/admin/remote-sync.cy.spec.ts b/e2e/test/scenarios/admin/remote-sync.cy.spec.ts
index 467f50767c9..cc18d758aee 100644
--- a/e2e/test/scenarios/admin/remote-sync.cy.spec.ts
+++ b/e2e/test/scenarios/admin/remote-sync.cy.spec.ts
@@ -509,7 +509,7 @@ describe("Remote Sync", () => {
cy.visit("/admin/settings/remote-sync");
cy.button("Set up remote sync").should("be.disabled");
- cy.findByRole("switch", { name: "Auto-sync with git" }).click({
+ cy.findByRole("switch", { name: /Auto-sync with git/ }).click({
force: true,
});
diff --git a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/RemoteSyncAdminSettings/RemoteSyncSettingsForm.tsx b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/RemoteSyncAdminSettings/RemoteSyncSettingsForm.tsx
index 1afc1e9d732..51b0b9ac0a0 100644
--- a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/RemoteSyncAdminSettings/RemoteSyncSettingsForm.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/RemoteSyncAdminSettings/RemoteSyncSettingsForm.tsx
@@ -491,6 +491,7 @@ export const RemoteSyncSettingsForm = (props: RemoteSyncSettingsFormProps) => {
</Box>
<FormSwitch
label={t`Auto-sync with git`}
+ description={t`Periodically import changes from the sync branch. When auto-sync is off, you'll need to pull changes from the sync branch manually.`}
mb="0.6125rem"
name={AUTO_IMPORT_KEY}
size="sm"
diff --git a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/RemoteSyncAdminSettings/RemoteSyncSettingsForm.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/RemoteSyncAdminSettings/RemoteSyncSettingsForm.unit.spec.tsx
index 3ed10049d19..61e749ec238 100644
--- a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/RemoteSyncAdminSettings/RemoteSyncSettingsForm.unit.spec.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/RemoteSyncAdminSettings/RemoteSyncSettingsForm.unit.spec.tsx
@@ -39,7 +39,9 @@ describe("RemoteSyncSettingsForm", () => {
setup({ remoteSyncType: "read-only" });
expect(screen.getByText("Branch to sync with")).toBeInTheDocument();
- expect(screen.getByLabelText(/Sync branch/i)).toBeInTheDocument();
+ expect(
+ screen.getByRole("textbox", { name: "Sync branch" }),
+ ).toBeInTheDocument();
expect(screen.getByLabelText(/Auto-sync with git/i)).toBeInTheDocument();
});
@@ -94,7 +96,7 @@ describe("RemoteSyncSettingsForm", () => {
screen.getByRole("heading", { name: "Branch to sync with" }),
).toBeInTheDocument();
expect(
- screen.getByRole("switch", { name: "Auto-sync with git" }),
+ screen.getByRole("switch", { name: /Auto-sync with git/ }),
).toBeInTheDocument();
});
});
@@ -718,7 +720,9 @@ describe("RemoteSyncSettingsForm", () => {
).toBeInTheDocument();
});
- expect(screen.getByLabelText(/Sync branch/i)).toHaveAttribute("readonly");
+ expect(
+ screen.getByRole("textbox", { name: "Sync branch" }),
+ ).toHaveAttribute("readonly");
});
});