The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Build data apps into dist/ by default (#85811)
Alexander Polyankin601bab7c94bd
diff --git a/e2e/support/helpers/build-data-app-fixture.mjs b/e2e/support/helpers/build-data-app-fixture.mjsindex fa19b3dad42..1d18213b3fe 100644--- a/e2e/support/helpers/build-data-app-fixture.mjs+++ b/e2e/support/helpers/build-data-app-fixture.mjs@@ -61,6 +61,5 @@ await build({...buildInfoDefine,"process.env.IS_EMBEDDING_SDK": '"true"',},- build: { outDir: "dist" },plugins: dataAppConfig().plugins,});diff --git a/enterprise/frontend/src/embedding-sdk-package/data-app-dev/config/build-config.ts b/enterprise/frontend/src/embedding-sdk-package/data-app-dev/config/build-config.tsindex 8e876e6734b..5c0e5d3ad2b 100644--- a/enterprise/frontend/src/embedding-sdk-package/data-app-dev/config/build-config.ts+++ b/enterprise/frontend/src/embedding-sdk-package/data-app-dev/config/build-config.ts@@ -9,7 +9,7 @@ import {DATA_APP_GLOBALS,} from "../constants/bundle";-const DEFAULT_OUT_DIR = "build";+const DEFAULT_OUT_DIR = "dist";export function dataAppOutDir(config: UserConfig) {return config.build?.outDir ?? DEFAULT_OUT_DIR;diff --git a/enterprise/frontend/src/embedding-sdk-package/data-app-dev/config/build-config.unit.spec.ts b/enterprise/frontend/src/embedding-sdk-package/data-app-dev/config/build-config.unit.spec.tsindex e055c1bdd0d..3be68a31e85 100644--- a/enterprise/frontend/src/embedding-sdk-package/data-app-dev/config/build-config.unit.spec.ts+++ b/enterprise/frontend/src/embedding-sdk-package/data-app-dev/config/build-config.unit.spec.ts@@ -1,11 +1,11 @@import { dataAppOutDir } from "./build-config";describe("dataAppOutDir", () => {- it("builds into build/ by default", () => {- expect(dataAppOutDir({})).toBe("build");+ it("builds into dist/ by default", () => {+ expect(dataAppOutDir({})).toBe("dist");});it("builds into the outDir the user passes", () => {- expect(dataAppOutDir({ build: { outDir: "dist" } })).toBe("dist");+ expect(dataAppOutDir({ build: { outDir: "build" } })).toBe("build");});});