Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Fix flaky Other pie slice drill-through e2e test (#80717)

Anderson6059647f517c
diff --git a/e2e/test/scenarios/visualizations-tabular/drillthroughs/chart_drill.cy.spec.js b/e2e/test/scenarios/visualizations-tabular/drillthroughs/chart_drill.cy.spec.js
index 9e3117e6372..4f55263e165 100644
--- a/e2e/test/scenarios/visualizations-tabular/drillthroughs/chart_drill.cy.spec.js
+++ b/e2e/test/scenarios/visualizations-tabular/drillthroughs/chart_drill.cy.spec.js
@@ -652,17 +652,27 @@ describe("scenarios > visualizations > drillthroughs > chart drill", () => {
},
});
- H.pieSlices()
- .filter("[fill^='hsla']")
- .then(($slice) => {
- const { height } = $slice[0].getBoundingClientRect();
-
- cy.wrap($slice).realClick({
- x: 30,
- y: height / 2,
- scrollBehavior: false,
- });
- });
+ const otherPieSlice = () => H.pieSlices().filter("[fill^='hsla']");
+
+ H.pieSlices().should("have.length", 3);
+
+ otherPieSlice().then(($slice) => {
+ const { height } = $slice[0].getBoundingClientRect();
+ cy.wrap($slice).trigger("mousemove", 30, height / 2);
+ });
+
+ H.assertEChartsTooltip({
+ header: "Category",
+ rows: [
+ { name: "Doohickey", value: "42" },
+ { name: "Gizmo", value: "51" },
+ ],
+ });
+
+ otherPieSlice().then(($slice) => {
+ const { height } = $slice[0].getBoundingClientRect();
+ cy.wrap($slice).click(30, height / 2, { force: true });
+ });
H.popover().within(() => {
cy.findByTestId("click-actions-view").within(() => {
diff --git a/frontend/src/metabase/visualizations/click-actions/actions/CopyValueAction/CopyValueAction.tsx b/frontend/src/metabase/visualizations/click-actions/actions/CopyValueAction/CopyValueAction.tsx
index 13e7d64ea25..fe0be801ffc 100644
--- a/frontend/src/metabase/visualizations/click-actions/actions/CopyValueAction/CopyValueAction.tsx
+++ b/frontend/src/metabase/visualizations/click-actions/actions/CopyValueAction/CopyValueAction.tsx
@@ -22,6 +22,11 @@ export const CopyValueAction: LegacyDrill = ({
if (!clicked || column == null || clicked.value == null || isPK(column)) {
return [];
}
+ // Clicks that group several rows (the pie "Other" slice carries array dimension
+ // values) have no single cell value and only offer viewing the underlying records.
+ if (clicked.dimensions?.some((dimension) => Array.isArray(dimension.value))) {
+ return [];
+ }
// This action should not override the native query fallback
if (nativeDrillFallback({ question })) {
return [];
diff --git a/frontend/src/metabase/visualizations/click-actions/actions/CopyValueAction/CopyValueAction.unit.spec.tsx b/frontend/src/metabase/visualizations/click-actions/actions/CopyValueAction/CopyValueAction.unit.spec.tsx
index ac3e2501480..fde58ca41da 100644
--- a/frontend/src/metabase/visualizations/click-actions/actions/CopyValueAction/CopyValueAction.unit.spec.tsx
+++ b/frontend/src/metabase/visualizations/click-actions/actions/CopyValueAction/CopyValueAction.unit.spec.tsx
@@ -71,6 +71,21 @@ describe("CopyValueAction", () => {
expect(setup({ column: pkColumn, value: 42 })).toHaveLength(0);
});
+ it("returns no actions for clicks that group several rows, like the pie 'Other' slice (metabase#5334)", () => {
+ const metricColumn = createMockNumericColumn({
+ name: "count",
+ display_name: "Count",
+ });
+
+ const actions = setup({
+ column: metricColumn,
+ value: 93,
+ dimensions: [{ column, value: ["Doohickey", "Gizmo"] }],
+ });
+
+ expect(actions).toHaveLength(0);
+ });
+
it("returns an action on a foreign key cell", () => {
const fkColumn = createMockColumn({
name: "PRODUCT_ID",