The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Fix boolean cartesian charts defaulting to timeseries axis (#71486)
Kevin Kelleher617ca0f5f098
diff --git a/frontend/src/metabase/visualizations/lib/timeseries.ts b/frontend/src/metabase/visualizations/lib/timeseries.tsindex ed488a5c7cf..6fb722e2870 100644--- a/frontend/src/metabase/visualizations/lib/timeseries.ts+++ b/frontend/src/metabase/visualizations/lib/timeseries.ts@@ -30,7 +30,7 @@ export function dimensionIsTimeseries({ cols, rows = [] }: DatasetData, i = 0) {}if (- (typeof value === "number" || typeof value === "string") &&+ !(typeof value === "number" || typeof value === "string") ||!isValidIso8601(value)) {return false;diff --git a/frontend/src/metabase/visualizations/lib/timeseries.unit.spec.ts b/frontend/src/metabase/visualizations/lib/timeseries.unit.spec.tsindex 0a86324b8de..5fa84b444f7 100644--- a/frontend/src/metabase/visualizations/lib/timeseries.unit.spec.ts+++ b/frontend/src/metabase/visualizations/lib/timeseries.unit.spec.ts@@ -23,7 +23,16 @@ describe("visualization.lib.timeseries", () => {19210413,];- const NOT_DATES = ["100", "100 %", "scanner 005", 99999999];+ const NOT_DATES = [+ "100",+ "100 %",+ "scanner 005",+ 99999999,+ true,+ false,+ { foo: "bar" },+ null,+ ];it("should detect Date column as timeseries", () => {expect(