The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
write-through cache for transform deps in ee only (#77079)
Nicola Mometto631e2c157f06
diff --git a/.clj-kondo/config/modules/config.edn b/.clj-kondo/config/modules/config.ednindex 79423882756..b841d0833ea 100644--- a/.clj-kondo/config/modules/config.edn+++ b/.clj-kondo/config/modules/config.edn@@ -3609,7 +3609,9 @@{:team "Graphy":api #{metabase-enterprise.transforms.api}:uses #{premium-features- enterprise/transforms-inspector}}+ util+ enterprise/transforms-inspector}+ :model-imports #{:model/Transform}}enterprise/transforms-inspector{:team "Gadget"diff --git a/enterprise/backend/src/metabase_enterprise/transforms/core.clj b/enterprise/backend/src/metabase_enterprise/transforms/core.cljindex 63d9326da8c..edaca1a670b 100644--- a/enterprise/backend/src/metabase_enterprise/transforms/core.clj+++ b/enterprise/backend/src/metabase_enterprise/transforms/core.clj@@ -8,8 +8,21 @@(:require[java-time.api :as t][metabase.premium-features.core :as premium-features :refer [defenterprise]]+ [metabase.util.json :as json]+ [metabase.util.log :as log][toucan2.core :as t2]))+(defenterprise persist-table-dependencies!+ "Best-effort write-back of `:uncached` deps from `transform-ordering` into the+ `transform.table_dependencies` column, keyed by transform id."+ :feature :none+ [id->raw-deps]+ (doseq [[id raw-deps] id->raw-deps]+ (try+ (t2/update! (t2/table-name :model/Transform) id {:table_dependencies (json/encode (vec raw-deps))})+ (catch Throwable e+ (log/warnf e "Failed to cache table-dependencies for transform %s" id)))))+(defenterprise transform-metered-as"Return the meter bucket a new transform run of the given source-type counts toward,based on the instance's current premium features. Returns nil when the run is not metered."diff --git a/src/metabase/transforms_base/ordering.clj b/src/metabase/transforms_base/ordering.cljindex 039996296f0..9c3dc233cef 100644--- a/src/metabase/transforms_base/ordering.clj+++ b/src/metabase/transforms_base/ordering.clj@@ -9,13 +9,12 @@[metabase.driver :as driver][metabase.lib.core :as lib][metabase.lib.metadata :as lib.metadata]+ [metabase.premium-features.core :refer [defenterprise]][metabase.query-processor.preprocess :as qp.preprocess][metabase.transforms-base.interface :as transforms-base.i][metabase.transforms-base.util :as transforms-base.u][metabase.util :as u][metabase.util.i18n :as i18n]- [metabase.util.json :as json]- [metabase.util.log :as log][metabase.util.malli :as mu][toucan2.core :as t2])(:import@@ -204,15 +203,14 @@:failed failed:uncached uncached}))))-(defn persist-table-dependencies!+(defenterprise persist-table-dependencies!"Best-effort write-back of `:uncached` deps from `transform-ordering` into the- `transform.table_dependencies` column, keyed by transform id."- [id->raw-deps]- (doseq [[id raw-deps] id->raw-deps]- (try- (t2/update! (t2/table-name :model/Transform) id {:table_dependencies (json/encode (vec raw-deps))})- (catch Throwable e- (log/warnf e "Failed to cache table-dependencies for transform %s" id)))))+ `transform.table_dependencies` column, keyed by transform id.++ OSS fallback: a no-op. Caching transform dependencies is an EE-only optimization."+ metabase-enterprise.transforms.core+ [_id->raw-deps]+ nil)(defn find-cycle"Finds a path containing a cycle in the directed graph `node->children`.