Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Get rid of VisualizationSettingDefinition["value"] (#74078)

Oleh K638da79a5265
diff --git a/frontend/src/metabase/dashboard/visualizations/Heading/index.ts b/frontend/src/metabase/dashboard/visualizations/Heading/index.ts
index 4323d0925c1..6d70279ffe7 100644
--- a/frontend/src/metabase/dashboard/visualizations/Heading/index.ts
+++ b/frontend/src/metabase/dashboard/visualizations/Heading/index.ts
@@ -35,7 +35,6 @@ const HeadingViz: VisualizationDefinition = {
dashboard: false,
},
text: {
- value: "",
getDefault: () => "",
},
"dashcard.background": {
diff --git a/frontend/src/metabase/dashboard/visualizations/IFrameViz/IFrameVizSettings.ts b/frontend/src/metabase/dashboard/visualizations/IFrameViz/IFrameVizSettings.ts
index e857ed7f01d..6f1981cedff 100644
--- a/frontend/src/metabase/dashboard/visualizations/IFrameViz/IFrameVizSettings.ts
+++ b/frontend/src/metabase/dashboard/visualizations/IFrameViz/IFrameVizSettings.ts
@@ -29,7 +29,6 @@ export const settings: VisualizationDefinition = {
dashboard: false,
},
iframe: {
- value: "",
getDefault: () => "",
},
},
diff --git a/frontend/src/metabase/dashboard/visualizations/LinkViz/LinkVizSettings.ts b/frontend/src/metabase/dashboard/visualizations/LinkViz/LinkVizSettings.ts
index ad8d7e8a331..94b02ab726a 100644
--- a/frontend/src/metabase/dashboard/visualizations/LinkViz/LinkVizSettings.ts
+++ b/frontend/src/metabase/dashboard/visualizations/LinkViz/LinkVizSettings.ts
@@ -29,9 +29,6 @@ export const settings: VisualizationDefinition = {
dashboard: false,
},
link: {
- value: {
- url: "",
- },
getDefault: () => ({
url: "",
}),
diff --git a/frontend/src/metabase/dashboard/visualizations/Text/index.ts b/frontend/src/metabase/dashboard/visualizations/Text/index.ts
index 334c42c36eb..0289867f95e 100644
--- a/frontend/src/metabase/dashboard/visualizations/Text/index.ts
+++ b/frontend/src/metabase/dashboard/visualizations/Text/index.ts
@@ -35,7 +35,6 @@ const TextViz: VisualizationDefinition = {
dashboard: false,
},
text: {
- value: "",
getDefault: () => "",
},
"text.align_vertical": {
diff --git a/frontend/src/metabase/visualizations/lib/settings.unit.spec.ts b/frontend/src/metabase/visualizations/lib/settings.unit.spec.ts
index 8dd46e8174b..471793009a8 100644
--- a/frontend/src/metabase/visualizations/lib/settings.unit.spec.ts
+++ b/frontend/src/metabase/visualizations/lib/settings.unit.spec.ts
@@ -128,6 +128,12 @@ describe("settings framework", () => {
expect(widgets[0].section).toBeUndefined();
});
+ it("should ignore provided `value`", () => {
+ const defs = { foo: { widget: "input", value: "hardcoded" } };
+ const widgets = getSettingsWidgets(defs, {}, {}, mockObject, () => {});
+ expect(widgets[0].value).toBeUndefined();
+ });
+
it("should resolve section via `getSection`", () => {
const getSection = jest.fn().mockReturnValue("Display");
const defs = { foo: { widget: "input", getSection } };
diff --git a/frontend/src/metabase/visualizations/types/visualization.ts b/frontend/src/metabase/visualizations/types/visualization.ts
index 1d408447807..be64ecf9a6e 100644
--- a/frontend/src/metabase/visualizations/types/visualization.ts
+++ b/frontend/src/metabase/visualizations/types/visualization.ts
@@ -362,7 +362,6 @@ export type VisualizationSettingDefinition<
extra?: SettingsExtra,
) => CSSProperties | undefined;
autoOpenWhenUnset?: boolean;
- value?: TValue;
set?: boolean;
persistDefault?: boolean;
inline?: boolean;
@@ -399,6 +398,7 @@ export type CompleteVisualizationSettingDefinition<
props: Partial<TProps>;
hidden: boolean;
section?: string;
+ value?: TValue;
};
export type DatasetColumnSettingDefinition<