Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

fix(sdk,embed-js): Adjust disabled state opacity for EditableText component (#71836)

Timofey Kachalov63d5eb845ab1
diff --git a/frontend/src/embedding-sdk-bundle/components/private/PublicComponentStylesWrapper.tsx b/frontend/src/embedding-sdk-bundle/components/private/PublicComponentStylesWrapper.tsx
index d2711e72d2d..555db212e7e 100644
--- a/frontend/src/embedding-sdk-bundle/components/private/PublicComponentStylesWrapper.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/private/PublicComponentStylesWrapper.tsx
@@ -62,4 +62,13 @@ export const SCOPED_CSS_RESET = css`
:where(.mb-wrapper) *:where(svg) {
display: inline;
}
+
+ // Mobile Safari sets the opacity of disabled inputs/textareas to 0.4 which we don't want
+ // https://github.com/metabase/metabase/issues/49170
+ @supports (-webkit-touch-callout: none) {
+ :where(.mb-wrapper) *:where(input),
+ :where(.mb-wrapper) *:where(textarea) {
+ opacity: 1;
+ }
+ }
`;
diff --git a/frontend/src/metabase/css/core/base.styled.ts b/frontend/src/metabase/css/core/base.styled.ts
index ee85dc2104a..64f3aed9978 100644
--- a/frontend/src/metabase/css/core/base.styled.ts
+++ b/frontend/src/metabase/css/core/base.styled.ts
@@ -45,9 +45,10 @@ export const baseStyle = css`
list-style-type: none;
}
- // Mobile Safari sets the opacity of disabled inputs to 0.4 which we don't want
+ // Mobile Safari sets the opacity of disabled inputs/textareas to 0.4 which we don't want
// https://github.com/metabase/metabase/issues/49170
@supports (-webkit-touch-callout: none) {
+ textarea:disabled,
input:disabled {
opacity: 1;
}