Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Implement table privileges support for SQLite. (#71950)

technomancy657669dcc5dc
diff --git a/modules/drivers/sqlite/src/metabase/driver/sqlite.clj b/modules/drivers/sqlite/src/metabase/driver/sqlite.clj
index 8b262179000..0912a819b64 100644
--- a/modules/drivers/sqlite/src/metabase/driver/sqlite.clj
+++ b/modules/drivers/sqlite/src/metabase/driver/sqlite.clj
@@ -2,6 +2,7 @@
(:refer-clojure :exclude [mapv])
(:require
[clojure.java.io :as io]
+ [clojure.java.jdbc :as jdbc]
[clojure.math :as math]
[clojure.set :as set]
[clojure.string :as str]
@@ -46,6 +47,7 @@
:case-sensitivity-string-filter-options false
;; Index sync is turned off across the application as it is not used ATM.
:index-info false
+ :table-privileges true
:database-routing true
:describe-default-expr true
:describe-is-nullable true
@@ -130,6 +132,20 @@
:from [[(h2x/identifier :table table-name)]]
:limit 1}))
+(defmethod sql-jdbc.sync/current-user-table-privileges :sqlite
+ [_driver conn-spec & _options]
+ ;; SQLite has no per-user privileges; allow SELECT on all tables and views
+ (let [rows (jdbc/query conn-spec ["SELECT name AS \"table\" FROM sqlite_master WHERE type IN ('table','view')"])]
+ (map (fn [{:keys [table]}]
+ {:role nil
+ :schema nil
+ :table table
+ :select true
+ :insert true
+ :update true
+ :delete true})
+ rows)))
+
(defn- ->date [& args]
(-> (into [:date] args)
(h2x/with-database-type-info "date")))
diff --git a/modules/drivers/sqlite/test/metabase/driver/sqlite_test.clj b/modules/drivers/sqlite/test/metabase/driver/sqlite_test.clj
index 3408e695f0a..c07cd8bbe69 100644
--- a/modules/drivers/sqlite/test/metabase/driver/sqlite_test.clj
+++ b/modules/drivers/sqlite/test/metabase/driver/sqlite_test.clj
@@ -5,6 +5,7 @@
[clojure.test :refer :all]
[metabase.driver :as driver]
[metabase.driver.sql-jdbc.connection :as sql-jdbc.conn]
+ [metabase.driver.sql-jdbc.sync :as sql-jdbc.sync]
[metabase.driver.sql.query-processor-test-util :as sql.qp-test-util]
[metabase.lib.core :as lib]
[metabase.lib.metadata :as lib.metadata]
@@ -21,6 +22,23 @@
(is (= "UTC"
(driver/db-default-timezone :sqlite (mt/db))))))
+(deftest current-user-table-privileges-test
+ (testing "SQLite table privileges normalization"
+ (mt/test-driver :sqlite
+ (is (= {"people" {:role nil, :schema nil, :table "people", :select true, :insert true, :update true, :delete true}
+ "reviews" {:role nil, :schema nil, :table "reviews", :select true, :insert true, :update true, :delete true}
+ "checkins" {:role nil, :schema nil, :table "checkins", :select true, :insert true, :update true, :delete true}
+ "users" {:role nil, :schema nil, :table "users", :select true, :insert true, :update true, :delete true}
+ "orders" {:role nil, :schema nil, :table "orders", :select true, :insert true, :update true, :delete true}
+ "venues" {:role nil, :schema nil, :table "venues", :select true, :insert true, :update true, :delete true}
+ "categories" {:role nil, :schema nil, :table "categories", :select true, :insert true, :update true, :delete true}
+ "products" {:role nil, :schema nil, :table "products", :select true, :insert true, :update true, :delete true}}
+ (into {}
+ (map (fn [m] [(:table m) m])
+ (sql-jdbc.sync/current-user-table-privileges
+ :sqlite
+ (sql-jdbc.conn/db->pooled-connection-spec (mt/db))))))))))
+
(deftest ^:parallel filter-by-date-test
(testing "Make sure filtering against a LocalDate works correctly in SQLite"
(mt/test-driver :sqlite
@@ -118,7 +136,7 @@
{:name table-name
:schema nil
:description nil
- :is_writable nil})
+ :is_writable true})
(deftest timestamp-test-db
(let [driver :sqlite]