The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
fixing flakey tests (#72540)
Nick Fitzpatrick65f313d35c5d
diff --git a/e2e/test/scenarios/dashboard/visualizer/basics.cy.spec.ts b/e2e/test/scenarios/dashboard/visualizer/basics.cy.spec.tsindex 17155dae619..24a1d0fff96 100644--- a/e2e/test/scenarios/dashboard/visualizer/basics.cy.spec.ts+++ b/e2e/test/scenarios/dashboard/visualizer/basics.cy.spec.ts@@ -173,21 +173,23 @@ describe("scenarios > dashboard > visualizer > basics", () => {H.saveDashcardVisualizerModal();- H.getDashboardCard(1).within(() => {- cy.findByText(ORDERS_COUNT_BY_CREATED_AT.name).should("exist");- cy.findByText(PRODUCTS_COUNT_BY_CREATED_AT.name).should("exist");- cy.findAllByText("Created At: Month").should("exist");- });+ H.getDashboardCard(1)+ .findByTestId("chart-container")+ .within(() => {+ cy.findByText(ORDERS_COUNT_BY_CREATED_AT.name).should("exist");+ cy.findByText(PRODUCTS_COUNT_BY_CREATED_AT.name).should("exist");+ cy.findAllByText("Created At: Month").should("exist");+ });H.saveDashboard();- H.getDashboardCard(1).within(() => {- cy.findByTestId("chart-container").within(() => {+ H.getDashboardCard(1)+ .findByTestId("chart-container")+ .within(() => {cy.findByText(ORDERS_COUNT_BY_CREATED_AT.name).should("exist");cy.findByText(PRODUCTS_COUNT_BY_CREATED_AT.name).should("exist");cy.findAllByText("Created At: Month").should("exist");});- });});it("should allow to visualize an existing dashcard another way if its viz type isn't supported by visualizer", () => {diff --git a/e2e/test/scenarios/models/reproductions-1.cy.spec.ts b/e2e/test/scenarios/models/reproductions-1.cy.spec.tsindex b0f009cc4c7..9c1ab56ff66 100644--- a/e2e/test/scenarios/models/reproductions-1.cy.spec.ts+++ b/e2e/test/scenarios/models/reproductions-1.cy.spec.ts@@ -506,6 +506,11 @@ describe("issue 40635", () => {cy.button("Save").click();H.modal().button("Save").click();+ H.undoToast()+ .should("contain", "Add this to a dashboard")+ .icon("close")+ .click();+assertSettingsSidebar();assertVisualizationColumns();