Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Make file-path triggers more robust (#66311)

Nemanja Glumac66b504394069
diff --git a/.github/file-paths.yaml b/.github/file-paths.yaml
index 4d58eeb654e..b6f317949f7 100644
--- a/.github/file-paths.yaml
+++ b/.github/file-paths.yaml
@@ -11,9 +11,18 @@ shared_specs: &shared_specs
- "test/**/*.cljc"
- "test/**/*.cljs"
-frontend_ci: &frontend_ci
+shared_ci: &shared_ci
- ".github/actions/prepare-frontend/**"
- ".github/actions/prepare-backend/**"
+ - ".github/workflows/run-tests.yml"
+
+shared_e2e: &shared_e2e
+ - "e2e/runner/**"
+ - "e2e/snapshot-creators/**"
+ - "e2e/support/**"
+
+frontend_ci: &frontend_ci
+ - *shared_ci
- ".github/workflows/frontend.yml"
frontend_configs: &frontend_configs
@@ -36,14 +45,12 @@ frontend_sources: &frontend_sources
- "enterprise/frontend/!(test)**/**/{!(*.spec),}.{js,jsx,ts,tsx,css}"
- "frontend/!(test)**/**/{!(*.spec),}.{js,jsx,ts,tsx,css}"
+# Used only in .github/workflows/conventional-commit-pr-title-reminder.yml
frontend_embedding_sources:
- "enterprise/frontend/src/{embedding,embedding-*}/**/{!(*.spec),}.{js,jsx,ts,tsx,css}"
- "enterprise/frontend/src/metabase-enterprise/{embedding,embedding-*}**/{!(*.spec),}.{js,jsx,ts,tsx,css}"
-frontend_embedding_sdk_sources:
- - *frontend_configs
- - "enterprise/frontend/!(test)**/**/{!(*.spec),}.{js,jsx,ts,tsx,css}"
-
+# Used only in .github/workflows/embedding-sdk-labels-reminder.yml
frontend_embedding_sdk_package_sources:
- "enterprise/frontend/src/embedding-sdk-package/**/!(*.spec).{js,jsx,ts,tsx,css}"
@@ -71,8 +78,7 @@ frontend_loki_ci: &frontend_loki_ci
- ".storybook/**"
backend_ci: &backend_ci
- - ".github/actions/prepare-frontend/**"
- - ".github/actions/prepare-backend/**"
+ - *shared_ci
- ".github/actions/test-driver/**"
- ".github/workflows/backend.yml"
- ".github/workflows/drivers.yml"
@@ -112,9 +118,9 @@ sources: &sources
- *backend_sources
e2e_ci: &e2e_ci
- - ".github/actions/prepare-frontend/**"
- - ".github/actions/prepare-backend/**"
+ - *shared_ci
- ".github/actions/prepare-uberjar-artifact/**"
+ - ".github/actions/fetch-artifact/action.yml"
- ".github/actions/e2e-prepare-containers/**"
- ".github/actions/prepare-cypress/**"
- ".github/workflows/e2e-*"
@@ -123,13 +129,17 @@ e2e_specs: &e2e_specs
- e2e/!(test-host-app)**/*.cy.*.{js,ts}
embedding_sdk_ci: &embedding_sdk_ci
- - ".github/actions/prepare-frontend/**"
- - ".github/actions/prepare-backend/**"
+ - *shared_ci
+ - ".github/actions/prepare-uberjar-artifact/**"
+ - ".github/actions/fetch-artifact/action.yml"
+ - ".github/actions/prepare-cypress/**"
- ".github/workflows/embedding-sdk*.yml"
embedding_sdk_components:
+ - *default
- *embedding_sdk_ci
- *sources
+ - *shared_e2e
- "e2e/test-component/**/*.cy.*.{js,jsx,ts,tsx}"
embedding_sdk_host_sample_apps:
@@ -137,8 +147,8 @@ embedding_sdk_host_sample_apps:
- *embedding_sdk_ci
- *frontend_sources
- *backend_sources
+ - *shared_e2e
- "e2e/embedding-sdk-host-apps/**"
- - "e2e/runner/embedding-sdk/**"
- "e2e/test-host-app/**/*.cy.*.{js,ts}"
snowplow: &snowplow
diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml
index ee521f9cd30..e3c71c8ae91 100644
--- a/.github/workflows/run-tests.yml
+++ b/.github/workflows/run-tests.yml
@@ -25,7 +25,6 @@ jobs:
frontend_all: ${{ steps.changes.outputs.frontend_all }}
frontend_sources: ${{ steps.changes.outputs.frontend_sources }}
documentation: ${{ steps.changes.outputs.documentation }}
- frontend_embedding_sdk_sources: ${{ steps.changes.outputs.frontend_embedding_sdk_sources }}
embedding_documentation: ${{ steps.changes.outputs.embedding_documentation }}
embedding_sdk_components: ${{ steps.changes.outputs.embedding_sdk_components }}
embedding_sdk_host_sample_apps: ${{ steps.changes.outputs.embedding_sdk_host_sample_apps }}
@@ -102,7 +101,7 @@ jobs:
if: |
!cancelled() &&
(needs.files-changed.outputs.embedding_sdk_components == 'true' ||
- needs.files-changed.outputs.frontend_embedding_sdk_sources == 'true' ||
+ needs.files-changed.outputs.frontend_sources == 'true' ||
needs.files-changed.outputs.embedding_documentation == 'true' ||
needs.files-changed.outputs.embedding_sdk_ci == 'true')
uses: ./.github/workflows/embedding-sdk-package-build.yml
@@ -114,9 +113,9 @@ jobs:
uses: ./.github/workflows/embedding-sdk.yml
secrets: inherit
with:
- cli-snippets-type-check: ${{ needs.files-changed.outputs.frontend_embedding_sdk_sources == 'true' }}
+ cli-snippets-type-check: ${{ needs.files-changed.outputs.frontend_sources == 'true' }}
docs-snippets-type-check: ${{ needs.files-changed.outputs.embedding_documentation == 'true' }}
- documentation-validation: ${{ needs.files-changed.outputs.frontend_embedding_sdk_sources == 'true' }}
+ documentation-validation: ${{ needs.files-changed.outputs.frontend_sources == 'true' }}
component-tests: ${{ needs.files-changed.outputs.embedding_sdk_components == 'true' }}
host-sample-apps-tests: ${{ needs.files-changed.outputs.embedding_sdk_host_sample_apps == 'true' }}
skip: ${{ needs.embedding-sdk-package.result != 'success' || needs.uberjar.result != 'success' }}