The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Ask for loki stress testing (#68302)
Aleksandr Lesnenko68d40f2770e5
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.mdindex df7ca89785b..2d353cca9a1 100644--- a/.github/PULL_REQUEST_TEMPLATE.md+++ b/.github/PULL_REQUEST_TEMPLATE.md@@ -25,3 +25,4 @@ _Upload a demo video or before/after screenshots if sensible or remove the secti### Checklist- [ ] Tests have been added/updated to cover changes in this PR+- [ ] If adding new Loki tests: they pass [stress testing](https://github.com/metabase/metabase/actions/workflows/loki-stress-test-flake-fix.yml)diff --git a/.github/workflows/loki-stress-test-flake-fix.yml b/.github/workflows/loki-stress-test-flake-fix.ymlindex 05dbce079ac..0700f3b19bd 100644--- a/.github/workflows/loki-stress-test-flake-fix.yml+++ b/.github/workflows/loki-stress-test-flake-fix.yml@@ -8,10 +8,10 @@ on:type: stringrequired: trueburn_in:- description: "Number of times to run the test (e.g. 20)"+ description: "Number of times to run the test (e.g. 50)"type: stringrequired: true- default: "20"+ default: "50"jobs:workflow-summary:diff --git a/docs/developers-guide/visual-tests.md b/docs/developers-guide/visual-tests.mdindex 60383d99e9f..6a027f28b6f 100644--- a/docs/developers-guide/visual-tests.md+++ b/docs/developers-guide/visual-tests.md@@ -29,3 +29,5 @@ If the differences are intentional or caused by a flake, update the reference sn## Adding new testsAdding new test is as simple as adding new stories. As of today, we use visual tests only for charts, however, you can use it for any other stories. Make sure the `storiesFilter` value in `loki.config.js` includes the stories you want to have as visual tests.++Before merging, run the [Loki Visual Stress Test](https://github.com/metabase/metabase/actions/workflows/loki-stress-test-flake-fix.yml) workflow to verify your new test isn't flaky. Enter your story filter pattern and run it 50 times.