The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Make all model imports and exports explicit (#71224)
Chris Truter68ec84ae4d63
diff --git a/.clj-kondo/config/modules/config.edn b/.clj-kondo/config/modules/config.ednindex 64ac7d86fa9..ac7804c5338 100644--- a/.clj-kondo/config/modules/config.edn+++ b/.clj-kondo/config/modules/config.edn@@ -52,10 +52,8 @@;;;; ## `model-exports`:;;-;; Set of `:model/X` keywords that this module allows others to reference. Currently defaults to `:any` when-;; omitted, meaning all models defined in this module are freely usable by other modules. In the future we may-;; change to pure opt-in semantics where modules must explicitly list their exports. A set restricts external-;; access to only the listed models; an empty set `#{}` means no models are exported.+;; Set of `:model/X` keywords defined by this module that it allows others to reference. By default all are private.+;; If you know what you're doing, we support an :all keyword, but let's prefer explicit sets for now.;;;; enterprise/workspaces;; {...@@ -63,11 +61,8 @@;;;; ## `model-imports`:;;-;; Set of `:model/X` keywords that this module is allowed to reference from other modules. Currently defaults to-;; `:any` when omitted, meaning this module can freely reference any model. In the future we may change to pure-;; opt-in semantics where modules must explicitly list their imports. A set restricts the module to only the listed-;; models; any other `:model/X` keyword in the module's source files will be flagged as a violation. If a model is-;; used but its definition cannot be found, that is also a violation.+;; Set of `:model/X` keywords that this module is allowed to reference from other modules. Defaults to none.+;; If you know what you're doing, we support an :all keyword, but let's prefer explicit sets for now.;;;; transforms-base;; {...@@ -101,7 +96,16 @@searchsettingsutil- warehouses}}+ warehouses}+ :model-exports #{:model/Action :model/HTTPAction :model/ImplicitAction :model/QueryAction}+ :model-imports #{:model/Card+ :model/Collection+ :model/Dashboard+ :model/DashboardCard+ :model/Database+ :model/Field+ :model/Table+ :model/User}}actions-rest{:team "Gadget"@@ -114,7 +118,8 @@permissionspublic-sharingqueries- util}}+ util}+ :model-imports #{:model/Action :model/Card :model/Database}}activity-feed{:team "UX West"@@ -127,7 +132,14 @@configeventsmodels- util}}+ util}+ :model-exports #{:model/RecentViews}+ :model-imports #{:model/Card+ :model/Collection+ :model/Dashboard+ :model/Document+ :model/QueryExecution+ :model/Table}}analytics{:team "UX West"@@ -153,7 +165,28 @@systemtaskutil- version}}+ version}+ :model-imports #{:model/CacheConfig+ :model/Card+ :model/Collection+ :model/Dashboard+ :model/DashboardCard+ :model/Database+ :model/DatabaseRouter+ :model/Document+ :model/Field+ :model/ModerationReview+ :model/PermissionsGroup+ :model/Pulse+ :model/PulseCard+ :model/PulseChannel+ :model/QueryCache+ :model/QueryExecution+ :model/Segment+ :model/Table+ :model/Transform+ :model/TransformRun+ :model/User}}analyze{:team "Graphy"@@ -165,7 +198,8 @@modelsquery-processorsync- util}}+ util}+ :model-imports #{:model/Field :model/Table}};; TODO -- consolidate these into a `.core` API namespace.api@@ -186,7 +220,28 @@eventsmodelssettings- util}}+ util}+ :model-imports #{:model/Action+ :model/Card+ :model/Collection+ :model/Dashboard+ :model/DashboardCard+ :model/DashboardTab+ :model/Database+ :model/Dimension+ :model/Document+ :model/Measure+ :model/ModelIndexValue+ :model/NativeQuerySnippet+ :model/PermissionsGroup+ :model/Pulse+ :model/PulseCard+ :model/PulseChannel+ :model/Segment+ :model/Table+ :model/Timeline+ :model/Transform+ :model/User}}api-keys{:team "UX West"@@ -199,7 +254,9 @@modelspermissionsusers- util}}+ util}+ :model-exports #{:model/ApiKey}+ :model-imports #{:model/User}}api-routes{:team "UX West"@@ -218,13 +275,15 @@configconnection-pooltask- util}}+ util}+ :model-imports #{:model/Database :model/Field :model/QueryCache :model/Secret :model/Setting}}appearance{:team "UX West":api #{metabase.appearance.coremetabase.appearance.init}- :uses #{settings util}}+ :uses #{settings util}+ :model-imports #{:model/Dashboard}}audit-app{:team "UX West"@@ -239,7 +298,29 @@tasktask-historytracing- util}}+ util}+ :model-exports #{:model/AuditLog}+ :model-imports #{:model/ApiKey+ :model/Card+ :model/Channel+ :model/Collection+ :model/Comment+ :model/Dashboard+ :model/Database+ :model/Document+ :model/Glossary+ :model/Notification+ :model/NotificationHandler+ :model/PermissionsGroup+ :model/PermissionsGroupMembership+ :model/Pulse+ :model/QueryExecution+ :model/RemoteSyncTask+ :model/Segment+ :model/Table+ :model/Transform+ :model/TransformRun+ :model/User}}auth-identity{:team "UX West"@@ -252,7 +333,9 @@notificationpremium-featuresrequest- util}}+ util}+ :model-exports #{:model/AuthIdentity}+ :model-imports #{:model/Session :model/User}}auth-provider{:team "UX West"@@ -274,7 +357,13 @@app-dbcollectionsqueries- util}}+ util}+ :model-exports #{:model/BookmarkOrdering+ :model/CardBookmark+ :model/CollectionBookmark+ :model/DashboardBookmark+ :model/DocumentBookmark}+ :model-imports #{:model/Card :model/Collection :model/Dashboard :model/Document}}bug-reporting{:team "UX West"@@ -288,7 +377,8 @@permissionspremium-featuressettings- util}}+ util}+ :model-imports #{:model/Database}}cache{:team "UX West"@@ -304,7 +394,9 @@premium-featuresrequestsettings- util}}+ util}+ :model-exports #{:model/CacheConfig :model/QueryCache}+ :model-imports #{:model/Card :model/Dashboard :model/DashboardCard :model/Database}};; TODO -- way too many API namespaces.channel@@ -344,7 +436,9 @@tasktimelinetypes- util}}+ util}+ :model-exports #{:model/Channel :model/ChannelTemplate}+ :model-imports #{:model/Dashboard :model/Database :model/PulseChannel :model/User}}classloader{:team "DevEx"@@ -366,7 +460,15 @@settingsstore-apitask- util}}+ util}+ :model-imports #{:model/AuditLog+ :model/Card+ :model/LoginHistory+ :model/Session+ :model/Setting+ :model/User+ :model/UserParameterValue+ :model/ViewLog}}cmd{:team "UX West"@@ -383,7 +485,79 @@query-processorsearchsettings- util}}+ util}+ :model-imports #{:model/Action+ :model/ApiKey+ :model/ApplicationPermissionsRevision+ :model/AuditLog+ :model/AuthIdentity+ :model/BookmarkOrdering+ :model/Card+ :model/CardBookmark+ :model/Channel+ :model/ChannelTemplate+ :model/Collection+ :model/CollectionBookmark+ :model/CollectionPermissionGraphRevision+ :model/Comment+ :model/CommentReaction+ :model/ConnectionImpersonation+ :model/Dashboard+ :model/DashboardBookmark+ :model/DashboardCard+ :model/DashboardCardSeries+ :model/DashboardTab+ :model/DataPermissions+ :model/Database+ :model/Dimension+ :model/Document+ :model/DocumentBookmark+ :model/Field+ :model/FieldUserSettings+ :model/FieldValues+ :model/Glossary+ :model/HTTPAction+ :model/ImplicitAction+ :model/LoginHistory+ :model/Measure+ :model/Metabot+ :model/MetabotConversation+ :model/MetabotMessage+ :model/MetabotPrompt+ :model/ModelIndex+ :model/ModelIndexValue+ :model/ModerationReview+ :model/NativeQuerySnippet+ :model/Notification+ :model/NotificationCard+ :model/NotificationHandler+ :model/NotificationRecipient+ :model/NotificationSubscription+ :model/ParameterCard+ :model/Permissions+ :model/PermissionsGroup+ :model/PermissionsGroupMembership+ :model/PermissionsRevision+ :model/PersistedInfo+ :model/Pulse+ :model/PulseCard+ :model/PulseChannel+ :model/PulseChannelRecipient+ :model/QueryAction+ :model/RecentViews+ :model/Revision+ :model/Sandbox+ :model/Secret+ :model/Segment+ :model/Session+ :model/Setting+ :model/Table+ :model/Tenant+ :model/Timeline+ :model/TimelineEvent+ :model/User+ :model/UserParameterValue+ :model/ViewLog}}collections{:team "UX West"@@ -402,7 +576,23 @@premium-featuresremote-syncsearch- util}}+ util}+ :model-exports #{:model/Collection}+ :model-imports #{:model/Card+ :model/CollectionBookmark+ :model/CollectionPermissionGraphRevision+ :model/Dashboard+ :model/DashboardCard+ :model/DashboardCardSeries+ :model/Document+ :model/NativeQuerySnippet+ :model/Permissions+ :model/Pulse+ :model/Table+ :model/Timeline+ :model/Transform+ :model/User+ :model/Workspace}}collections-rest{:team "UX West"@@ -425,7 +615,16 @@tracingtransformsupload- util}}+ util}+ :model-imports #{:model/Card+ :model/Collection+ :model/Dashboard+ :model/Document+ :model/NativeQuerySnippet+ :model/Pulse+ :model/Table+ :model/Timeline+ :model/Transform}}comments{:team "UX West"@@ -438,7 +637,9 @@modelsrequestusers- util}}+ util}+ :model-exports #{:model/Comment :model/CommentReaction}+ :model-imports #{:model/Document :model/User}};; technically this 'uses' `enterprise/core` and `test` since it tries to load them to see if they exists so we know;; if EE/test code is available; however we can ignore them since they're not real usages.@@ -457,7 +658,8 @@{:team "UX West":api #{metabase.content-translation.models}:uses #{premium-features- util}}+ util}+ :model-exports #{:model/ContentTranslation}}content-verification{:team "UX West"@@ -465,7 +667,9 @@metabase.content-verification.init}:uses #{app-dbmodels- util}}+ util}+ :model-exports #{:model/ModerationReview}+ :model-imports #{:model/Card :model/Dashboard}}core{:team "UX West"@@ -498,7 +702,20 @@searchsettingsutil- warehouse-schema}}+ warehouse-schema}+ :model-exports #{:model/Dashboard+ :model/DashboardCard+ :model/DashboardCardSeries+ :model/DashboardTab}+ :model-imports #{:model/Action+ :model/Card+ :model/Collection+ :model/DashboardBookmark+ :model/ModerationReview+ :model/Pulse+ :model/PulseCard+ :model/Revision+ :model/User}}dashboards-rest{:team "UX West"@@ -527,7 +744,19 @@requestrevisionsutil- xrays}}+ xrays}+ :model-imports #{:model/Card+ :model/Collection+ :model/Dashboard+ :model/DashboardCard+ :model/DashboardTab+ :model/Field+ :model/Pulse+ :model/PulseChannel+ :model/PulseChannelRecipient+ :model/Query+ :model/Table+ :model/User}}data-studio{:team "Gadget"@@ -539,7 +768,8 @@requestsyncutil- warehouse-schema}}+ warehouse-schema}+ :model-imports #{:model/Database :model/Dimension :model/Field :model/FieldValues :model/Table}}database-routing{:team "UX West"@@ -567,7 +797,9 @@revisionssearchutil- view-log}}+ view-log}+ :model-exports #{:model/Document}+ :model-imports #{:model/Card :model/Collection :model/Dashboard :model/Table :model/User}}driver{:team "Querying"@@ -618,7 +850,8 @@tracingutilwarehouse-schema- warehouses}}+ warehouses}+ :model-imports #{:model/Database :model/Field :model/Table}}driver-api{:team "Querying"@@ -654,7 +887,25 @@metabase.eid-translation.init}:uses #{apisettings- util}}+ util}+ :model-imports #{:model/Action+ :model/Card+ :model/Collection+ :model/Dashboard+ :model/DashboardCard+ :model/DashboardTab+ :model/Dimension+ :model/Document+ :model/Measure+ :model/NativeQuerySnippet+ :model/PermissionsGroup+ :model/Pulse+ :model/PulseCard+ :model/PulseChannel+ :model/Segment+ :model/Timeline+ :model/Transform+ :model/User}}embedding{:team "Embedding"@@ -668,7 +919,8 @@premium-featuresserversettings- util}}+ util}+ :model-imports #{:model/Card :model/Dashboard}}embedding-rest{:team "Embedding"@@ -687,7 +939,8 @@query-processorrequesttiles- util}}+ util}+ :model-imports #{:model/Card :model/Dashboard}}events{:team "DevEx"@@ -695,7 +948,18 @@metabase.events.init}:uses #{modelsutil}- :friends #{tracing}}+ :friends #{tracing}+ :model-imports #{:model/Card+ :model/Collection+ :model/Dashboard+ :model/Database+ :model/Field+ :model/Measure+ :model/NativeQuerySnippet+ :model/Pulse+ :model/Segment+ :model/Table+ :model/User}}formatter{:team "UX West"@@ -721,7 +985,9 @@:uses #{apieventsmodels- util}}+ util}+ :model-exports #{:model/Glossary}+ :model-imports #{:model/User}}graph{:team "Graphy"@@ -742,7 +1008,9 @@searchsynctask- util}}+ util}+ :model-exports #{:model/ModelIndex :model/ModelIndexValue}+ :model-imports #{:model/Card :model/Collection}}initialization-status{:team "UX West"@@ -753,7 +1021,8 @@{:team "UX West":api #{metabase.internal-stats.core}:uses #{app-db- models}}+ models}+ :model-imports #{:model/Card :model/Dashboard :model/QueryExecution :model/User}}legacy-mbql{:team "Querying"@@ -815,7 +1084,18 @@:uses #{libmodelssettings- util}}+ util}+ :model-imports #{:model/Card+ :model/Database+ :model/Dimension+ :model/Field+ :model/FieldValues+ :model/Measure+ :model/NativeQuerySnippet+ :model/PersistedInfo+ :model/Segment+ :model/Table+ :model/Transform}}lib-metric{:team "UX West"@@ -825,7 +1105,8 @@lib-besettingstypes- util}}+ util}+ :model-imports #{:model/Card :model/Field :model/Table}}llm{:team "Metabot"@@ -842,7 +1123,8 @@sql-toolssyncutil- warehouse-schema}}+ warehouse-schema}+ :model-imports #{:model/Database :model/Field :model/Table}}logger{:team "DevEx"@@ -866,7 +1148,8 @@channelrequestsettings- util}}+ util}+ :model-exports #{:model/LoginHistory}}measures{:team "Querying"@@ -880,7 +1163,9 @@permissionsremote-syncsearch- util}}+ util}+ :model-exports #{:model/Measure}+ :model-imports #{:model/Collection :model/Table :model/User}}metrics{:team "UX West"@@ -896,7 +1181,8 @@query-processorrequestserver- util}}+ util}+ :model-imports #{:model/Card :model/Field :model/Measure}}model-persistence{:team "Querying"@@ -919,7 +1205,9 @@tasktask-historytracing- util}}+ util}+ :model-exports #{:model/PersistedInfo}+ :model-imports #{:model/Card :model/Database}}models{:team "DevEx"@@ -947,7 +1235,23 @@transformstransforms-baseutil}- :friends #{transforms}}+ :friends #{transforms}+ :model-exports #{:model/Transform+ :model/TransformJob+ :model/TransformJobTransformTag+ :model/TransformRun+ :model/TransformTag+ :model/TransformTransformTag}+ :model-imports #{:model/Card+ :model/Collection+ :model/Dashboard+ :model/DashboardTab+ :model/Database+ :model/Field+ :model/NativeQuerySnippet+ :model/Segment+ :model/Table+ :model/User}}native-query-snippets{:team "Querying"@@ -961,12 +1265,12 @@permissionspremium-featuresremote-sync- util}}+ util}+ :model-exports #{:model/NativeQuerySnippet}+ :model-imports #{:model/Collection :model/User}}notification- {;; TODO: re-enable when :model/NotificationDashboard is no longer a problem- :model-imports :skip-test- :team "Gadget"+ {:team "Gadget":api #{metabase.notification.apimetabase.notification.coremetabase.notification.init@@ -996,7 +1300,19 @@task-historytracingusers- util}}+ util}+ :model-exports #{:model/Notification+ :model/NotificationCard+ :model/NotificationHandler+ :model/NotificationRecipient+ :model/NotificationSubscription}+ :model-imports #{:model/Card+ :model/Channel+ :model/ChannelTemplate+ :model/Dashboard+ :model/DashboardCard+ :model/DashboardTab+ :model/User}};; TODO -- too many API namespacesparameters@@ -1020,7 +1336,8 @@query-processorutilwarehouse-schema- warehouses}}+ warehouses}+ :model-imports #{:model/Card :model/Dashboard :model/Field :model/FieldValues :model/Table}}permissions{:team "UX West"@@ -1040,7 +1357,15 @@settingstracingutil- enterprise/advanced-permissions}}+ enterprise/advanced-permissions}+ :model-exports #{:model/ApplicationPermissionsRevision+ :model/CollectionPermissionGraphRevision+ :model/DataPermissions+ :model/Permissions+ :model/PermissionsGroup+ :model/PermissionsGroupMembership+ :model/PermissionsRevision}+ :model-imports #{:model/Collection :model/Database :model/Table :model/User}}permissions-rest{:team "UX West"@@ -1053,7 +1378,14 @@premium-featuresrequestsettings- util}}+ util}+ :model-imports #{:model/DataPermissions+ :model/Database+ :model/PermissionsGroup+ :model/PermissionsGroupMembership+ :model/PermissionsRevision+ :model/Table+ :model/User}}pivot{:team "UX West"@@ -1085,7 +1417,8 @@startuptasktracing- util}}+ util}+ :model-imports #{:model/User}}product-feedback{:team "UX West"@@ -1099,7 +1432,8 @@premium-featuressettingstask- util}}+ util}+ :model-imports #{:model/Card :model/Dashboard :model/Database :model/User}}public-sharing{:team "UX West"@@ -1127,7 +1461,8 @@query-processorrequesttiles- util}}+ util}+ :model-imports #{:model/Card :model/Dashboard :model/Document}}pulse{:team "Gadget"@@ -1155,7 +1490,15 @@tracingutilenterprise/advanced-permissions- enterprise/sandbox}}+ enterprise/sandbox}+ :model-exports #{:model/Pulse :model/PulseCard :model/PulseChannel :model/PulseChannelRecipient}+ :model-imports #{:model/Card+ :model/Channel+ :model/Collection+ :model/Dashboard+ :model/DashboardCard+ :model/Notification+ :model/User}}queries{:team "Querying"@@ -1191,7 +1534,26 @@searchutilview-log- warehouse-schema}}+ warehouse-schema}+ :model-exports #{:model/Card+ :model/ParameterCard+ :model/Query+ :model/QueryExecution+ :model/QueryTable}+ :model-imports #{:model/Action+ :model/CardBookmark+ :model/Collection+ :model/Dashboard+ :model/DashboardCard+ :model/DashboardCardSeries+ :model/Database+ :model/Document+ :model/Field+ :model/ModerationReview+ :model/NativeQuerySnippet+ :model/Revision+ :model/Table+ :model/User}}queries-rest{:team "Querying"@@ -1214,7 +1576,13 @@requestrevisionssearch- util}}+ util}+ :model-imports #{:model/Card+ :model/CardBookmark+ :model/Collection+ :model/Dashboard+ :model/Database+ :model/Table}}query-permissions{:team "UX West"@@ -1227,7 +1595,8 @@permissionsquery-processorrequest- util}}+ util}+ :model-imports #{:model/Card :model/Field}}query-processor{:team "Querying"@@ -1298,7 +1667,15 @@systemtracingusers- util}}+ util}+ :model-imports #{:model/Card+ :model/Dashboard+ :model/DashboardCard+ :model/DashboardCardSeries+ :model/Database+ :model/QueryCache+ :model/QueryExecution+ :model/Table}}remote-sync{:team "UX West"@@ -1306,7 +1683,8 @@metabase.remote-sync.init}:uses #{apimodels- premium-features}}+ premium-features}+ :model-imports #{:model/Collection}}request{:team "UX West"@@ -1321,7 +1699,8 @@sessionsettingsusers- util}}+ util}+ :model-imports #{:model/User}}revisions{:team "UX West"@@ -1336,7 +1715,16 @@modelsqueriesquery-permissions- util}}+ util}+ :model-exports #{:model/Revision}+ :model-imports #{:model/Card+ :model/Dashboard+ :model/DashboardCard+ :model/DashboardTab+ :model/Document+ :model/Measure+ :model/Segment+ :model/Transform}}sample-data{:team "UX West"@@ -1345,7 +1733,8 @@:uses #{pluginssettingssync- util}}+ util}+ :model-imports #{:model/Database}}search{:team "UX West"@@ -1380,12 +1769,14 @@tasktracingtransforms- util}}+ util}+ :model-imports #{:model/Card :model/Collection :model/Dashboard :model/Table :model/User}}secrets{:team "Querying":api #{metabase.secrets.core}- :uses #{api driver models premium-features util}}+ :uses #{api driver models premium-features util}+ :model-exports #{:model/Secret}}segments{:team "Querying"@@ -1400,7 +1791,9 @@remote-syncsearchutil- xrays}}+ xrays}+ :model-exports #{:model/Segment}+ :model-imports #{:model/Collection :model/Table :model/User}}server{:team "UX West"@@ -1448,7 +1841,9 @@systemtasktracing- util}}+ util}+ :model-exports #{:model/Session}+ :model-imports #{:model/AuthIdentity :model/User}}settings{:team "DevEx"@@ -1461,7 +1856,8 @@modelspremium-featuresutil- enterprise/advanced-permissions}}+ enterprise/advanced-permissions}+ :model-exports #{:model/Setting}}settings-rest{:team "DevEx"@@ -1478,7 +1874,8 @@:uses #{app-dbconfigsettings- util}}+ util}+ :model-imports #{:model/User}}setup-rest{:team "UX West"@@ -1492,7 +1889,8 @@settingssetupsystem- util}}+ util}+ :model-imports #{:model/AuthIdentity :model/User}}source-swap{:team "Graphy"@@ -1532,7 +1930,8 @@premium-featuressettingssystem- util}}+ util}+ :model-imports #{:model/PermissionsGroupMembership}}startup{:team "DevEx"@@ -1573,7 +1972,8 @@tracingutilwarehouse-schema- warehouses}}+ warehouses}+ :model-imports #{:model/Database :model/Field :model/FieldValues :model/Table}}system{:team "UX West"@@ -1605,7 +2005,8 @@requesttasktracing- util}}+ util}+ :model-imports #{:model/Card :model/Dashboard :model/Database}}tenants{:team "Admin Webapp"@@ -1626,7 +2027,8 @@lib-bepremium-featuressearch- util}}+ util}+ :model-imports #{:model/Card :model/Dashboard}}tiles{:team "UX West"@@ -1650,7 +2052,9 @@collectionseventsmodels- util}}+ util}+ :model-exports #{:model/Timeline :model/TimelineEvent}+ :model-imports #{:model/Collection :model/User}}tracing{:team "DevEx"@@ -1688,7 +2092,15 @@util}:friends #{modelsenterprise/transforms-python- enterprise/workspaces}}+ enterprise/workspaces}+ :model-imports #{:model/Database+ :model/Field+ :model/Table+ :model/Transform+ :model/TransformJob+ :model/TransformJobTransformTag+ :model/TransformTransformTag+ :model/User}}transforms-base{:team "Querying"@@ -1697,7 +2109,6 @@metabase.transforms-base.util}:model-imports #{:model/Database:model/DatabaseRouter- :model/Field:model/Table;; TODO regressions — transforms-base should not depend on;; these directly. Remove once the module is agnostic to@@ -1731,7 +2142,13 @@requesttransformstransforms-base- util}}+ util}+ :model-imports #{:model/Transform+ :model/TransformJob+ :model/TransformJobTransformTag+ :model/TransformRun+ :model/TransformTag+ :model/WorkspaceMergeTransform}}types{:team "Querying"@@ -1758,7 +2175,8 @@settingssyncutil- warehouse-schema}}+ warehouse-schema}+ :model-imports #{:model/Card :model/Database :model/Field :model/Table}}user-key-value{:team "UX West"@@ -1792,7 +2210,14 @@systemtenantsutil- enterprise/advanced-permissions}}+ enterprise/advanced-permissions}+ :model-exports #{:model/User :model/UserParameterValue}+ :model-imports #{:model/AuthIdentity+ :model/Dashboard+ :model/Database+ :model/PermissionsGroupMembership+ :model/Session+ :model/Tenant}}users-rest{:team "UX West"@@ -1812,7 +2237,13 @@tenantsusersutil- enterprise/advanced-permissions}}+ enterprise/advanced-permissions}+ :model-imports #{:model/AuthIdentity+ :model/Card+ :model/Collection+ :model/Dashboard+ :model/LoginHistory+ :model/User}}util{:team "DevEx"@@ -1845,7 +2276,9 @@modelspremium-featuresquery-permissions- util}}+ util}+ :model-exports #{:model/ViewLog}+ :model-imports #{:model/Card :model/Dashboard :model/Table}}warehouse-schema{:team "UX West"@@ -1873,7 +2306,19 @@searchutilwarehouses- workspaces}}+ workspaces}+ :model-exports #{:model/Dimension+ :model/Field+ :model/FieldUserSettings+ :model/FieldValues+ :model/Table}+ :model-imports #{:model/Card+ :model/Collection+ :model/Database+ :model/Measure+ :model/Segment+ :model/Transform+ :model/User}}warehouse-schema-rest{:team "UX West"@@ -1896,7 +2341,8 @@uploadutilwarehouse-schema- xrays}}+ xrays}+ :model-imports #{:model/Database :model/Dimension :model/Field :model/FieldValues :model/Table}}warehouses{:team "UX West"@@ -1916,7 +2362,9 @@secretssettingssync- util}}+ util}+ :model-exports #{:model/Database}+ :model-imports #{:model/Card :model/Field :model/Table :model/User}}warehouses-rest{:team "UX West"@@ -1945,7 +2393,8 @@utilwarehouse-schemawarehouses- enterprise/advanced-permissions}}+ enterprise/advanced-permissions}+ :model-imports #{:model/Card :model/Collection :model/Database :model/Field :model/Table}}workspaces{:team "Metabot"@@ -1973,7 +2422,19 @@segmentssettingsutil- warehouse-schema}}+ warehouse-schema}+ :model-imports #{:model/Card+ :model/Collection+ :model/Dashboard+ :model/DashboardCard+ :model/Database+ :model/Field+ :model/ModelIndex+ :model/ModelIndexValue+ :model/Query+ :model/Revision+ :model/Segment+ :model/Table}}enterprise/action-v2{:team "Gadget"@@ -1987,7 +2448,8 @@modelsquery-processorutil- warehouse-schema}}+ warehouse-schema}+ :model-imports #{:model/Database :model/Field :model/FieldValues :model/Table}}enterprise/advanced-config{:team "UX West"@@ -2005,7 +2467,8 @@setupsyncusers- util}}+ util}+ :model-imports #{:model/ApiKey :model/Database :model/User}}enterprise/advanced-permissions{:team "UX West"@@ -2022,7 +2485,14 @@remote-syncutilwarehouses- enterprise/impersonation}}+ enterprise/impersonation}+ :model-imports #{:model/ApplicationPermissionsRevision+ :model/ConnectionImpersonation+ :model/DataPermissions+ :model/Permissions+ :model/PermissionsGroupMembership+ :model/Sandbox+ :model/Table}}enterprise/agent-api{:team "Metabot"@@ -2035,7 +2505,8 @@utilenterprise/apienterprise/metabot-v3- enterprise/workspaces}}+ enterprise/workspaces}+ :model-imports #{:model/User}}enterprise/ai-entity-analysis{:team "Metabot"@@ -2071,7 +2542,8 @@enterprise/advanced-configenterprise/scimenterprise/semantic-search- enterprise/sso}}+ enterprise/sso}+ :model-imports #{:model/Database :model/Sandbox}}enterprise/api{:team "UX West"@@ -2109,7 +2581,22 @@syncusersutil- enterprise/serialization}}+ enterprise/serialization}+ :model-imports #{:model/AuditLog+ :model/Card+ :model/Collection+ :model/Dashboard+ :model/Database+ :model/Field+ :model/Notification+ :model/NotificationRecipient+ :model/Permissions+ :model/Pulse+ :model/PulseChannelRecipient+ :model/QueryExecution+ :model/Table+ :model/User+ :model/ViewLog}}enterprise/auth-identity{:team "UX West"@@ -2128,7 +2615,8 @@:uses #{apipremium-featuresstore-api- util}}+ util}+ :model-imports #{:model/User}}enterprise/cache{:team "UX West"@@ -2137,7 +2625,13 @@premium-featuresquery-processortask- util}}+ util}+ :model-imports #{:model/CacheConfig+ :model/Card+ :model/Dashboard+ :model/Query+ :model/QueryCache+ :model/QueryExecution}}enterprise/cloud-add-ons{:team "Cloud"@@ -2165,7 +2659,8 @@embeddingpremium-featuresutil- enterprise/api}}+ enterprise/api}+ :model-imports #{:model/ContentTranslation}}enterprise/content-verification{:team "UX West"@@ -2194,7 +2689,8 @@modelspermissionspremium-features- util}}+ util}+ :model-imports #{:model/Collection :model/Dimension :model/Field :model/Table}}enterprise/database-replication{:team "Cloud"@@ -2205,7 +2701,8 @@premium-featuressettingsutil- enterprise/harbormaster}}+ enterprise/harbormaster}+ :model-imports #{:model/Database}}enterprise/database-routing{:team "UX West"@@ -2222,7 +2719,9 @@settingsutilwarehouse-schema- warehouses}}+ warehouses}+ :model-exports #{:model/DatabaseRouter}+ :model-imports #{:model/Database}}enterprise/dependencies{:team "Graphy"@@ -2254,7 +2753,21 @@tasktransformstransforms-base- util}}+ util}+ :model-exports #{:model/Dependency}+ :model-imports #{:model/Card+ :model/Collection+ :model/Dashboard+ :model/DashboardCard+ :model/DashboardCardSeries+ :model/Document+ :model/Field+ :model/Measure+ :model/NativeQuerySnippet+ :model/Sandbox+ :model/Segment+ :model/Table+ :model/Transform}}enterprise/email{:team "UX West"@@ -2275,7 +2788,16 @@embeddingpermissionspremium-features- enterprise/sso}}+ enterprise/sso}+ :model-imports #{:model/Card+ :model/Collection+ :model/ConnectionImpersonation+ :model/Dashboard+ :model/Database+ :model/DatabaseRouter+ :model/Sandbox+ :model/Table+ :model/Tenant}}enterprise/gsheets{:team "Cloud"@@ -2286,7 +2808,8 @@premium-featuressettingsutil- enterprise/harbormaster}}+ enterprise/harbormaster}+ :model-imports #{:model/Database :model/Setting}}enterprise/harbormaster{:team "Cloud"@@ -2307,7 +2830,9 @@query-processorutilwarehouse-schema- enterprise/sandbox}}+ enterprise/sandbox}+ :model-exports #{:model/ConnectionImpersonation}+ :model-imports #{:model/DataPermissions :model/PermissionsGroupMembership}}enterprise/internal-stats{:team "UX West"@@ -2320,7 +2845,8 @@:api #{metabase-enterprise.library.api}:uses #{apicollections- premium-features}}+ premium-features}+ :model-imports #{:model/Card :model/Collection :model/Table}}enterprise/llm{:team "Metabot"@@ -2333,7 +2859,8 @@parametersquery-processorsettings- util}}+ util}+ :model-imports #{:model/Dashboard}}enterprise/metabot-v3{:team "Metabot"@@ -2381,7 +2908,22 @@enterprise/dependenciesenterprise/llmenterprise/slackbot- enterprise/transforms-python}}+ enterprise/transforms-python}+ :model-exports #{:model/Metabot+ :model/MetabotConversation+ :model/MetabotMessage+ :model/MetabotPrompt}+ :model-imports #{:model/Card+ :model/Collection+ :model/Dashboard+ :model/Database+ :model/Field+ :model/Glossary+ :model/ModerationReview+ :model/QueryTable+ :model/Table+ :model/Transform+ :model/User}}enterprise/permission-debug{:team "UX West"@@ -2391,7 +2933,8 @@modelspermissionsquery-processor- util}}+ util}+ :model-imports #{:model/Card :model/User}}enterprise/premium-features{:team "UX West"@@ -2416,7 +2959,22 @@task-historyutilenterprise/serialization- enterprise/transforms-python}}+ enterprise/transforms-python}+ :model-exports #{:model/RemoteSyncTask}+ :model-imports #{:model/Card+ :model/Collection+ :model/Dashboard+ :model/Document+ :model/Field+ :model/Measure+ :model/NativeQuerySnippet+ :model/PythonLibrary+ :model/Segment+ :model/Table+ :model/Timeline+ :model/Transform+ :model/TransformTag+ :model/User}}enterprise/replacement{:team "Graphy"@@ -2431,7 +2989,15 @@source-swaptaskutil- enterprise/dependencies}}+ enterprise/dependencies}+ :model-imports #{:model/Card+ :model/Dashboard+ :model/DashboardCard+ :model/Field+ :model/Measure+ :model/Segment+ :model/Table+ :model/Transform}}enterprise/sandbox{:team "UX West"@@ -2454,7 +3020,15 @@utilwarehouse-schemawarehouses- enterprise/api}}+ enterprise/api}+ :model-exports #{:model/Sandbox}+ :model-imports #{:model/Card+ :model/ConnectionImpersonation+ :model/Database+ :model/Field+ :model/PermissionsGroupMembership+ :model/Table+ :model/User}}enterprise/scim{:team "UX West"@@ -2471,7 +3045,11 @@systemusersutil- enterprise/serialization}}+ enterprise/serialization}+ :model-imports #{:model/ApiKey+ :model/PermissionsGroup+ :model/PermissionsGroupMembership+ :model/User}}enterprise/search{:team "UX West"@@ -2498,7 +3076,8 @@tasktracingutil- enterprise/llm}}+ enterprise/llm}+ :model-imports #{:model/Card :model/Collection :model/ModelIndex}}enterprise/serialization{:team "Querying"@@ -2520,7 +3099,8 @@searchserversetup- util}}+ util}+ :model-imports #{:model/Card :model/Collection :model/Dashboard :model/User}}enterprise/slackbot{:team "Metabot"@@ -2541,7 +3121,12 @@uploadutilenterprise/metabot-v3- enterprise/sso}}+ enterprise/sso}+ :model-imports #{:model/AuthIdentity+ :model/Card+ :model/Database+ :model/MetabotMessage+ :model/User}}enterprise/snippet-collections{:team "Querying"@@ -2551,7 +3136,8 @@permissionspremium-featuresremote-sync- util}}+ util}+ :model-imports #{:model/NativeQuerySnippet}}enterprise/sso{:team "UX West"@@ -2569,7 +3155,8 @@ssosystemutil- enterprise/scim}}+ enterprise/scim}+ :model-imports #{:model/AuthIdentity :model/PermissionsGroup :model/Session}}enterprise/stale{:team "UX West"@@ -2583,7 +3170,8 @@queriesrequestsettings- util}}+ util}+ :model-imports #{:model/Card :model/Collection :model/Dashboard}}enterprise/support-access-grants{:team "UX West"@@ -2596,7 +3184,8 @@requestsettingssystem- util}}+ util}+ :model-imports #{:model/AuthIdentity :model/Session :model/User}}enterprise/tenants{:team "Admin Webapp"@@ -2611,7 +3200,9 @@premium-featuresrequestsettings- util}}+ util}+ :model-exports #{:model/Tenant}+ :model-imports #{:model/Collection :model/User}}enterprise/transforms{:team "Querying"@@ -2632,7 +3223,8 @@sql-toolstransformstransforms-base- util}}+ util}+ :model-imports #{:model/Database :model/Field :model/Table :model/Transform}}enterprise/transforms-python{:team "Querying"@@ -2654,7 +3246,9 @@settingstransformstransforms-base- util}}+ util}+ :model-exports #{:model/PythonLibrary}+ :model-imports #{:model/Database :model/Field :model/Table :model/TransformRun}}enterprise/upload-management{:team "UX West"@@ -2663,7 +3257,8 @@modelspremium-featuresupload- util}}+ util}+ :model-imports #{:model/Database :model/Table}}enterprise/workspaces{:team "Metabot"@@ -2692,7 +3287,13 @@transforms-baseutilwarehouse-schema- enterprise/transforms-python}}+ enterprise/transforms-python}+ :model-imports #{:model/Collection+ :model/Database+ :model/Dependency+ :model/Field+ :model/Table+ :model/Transform}}enterprise/writable-connection{:team "Querying"diff --git a/dev/notes/model-boundary-enforcement.md b/dev/notes/model-boundary-enforcement.mdindex f5d4b6f8829..fd8008affb9 100644--- a/dev/notes/model-boundary-enforcement.md+++ b/dev/notes/model-boundary-enforcement.md@@ -11,11 +11,13 @@ Two optional config keys per module in| Key | Default | Meaning ||------------------|---------|---------|-| `:model-exports` | `:any` | Set of `:model/X` keywords this module allows **others** to use. |-| `:model-imports` | `:any` | Set of `:model/X` keywords **this module** may use from other modules. |+| `:model-exports` | `#{}` | Set of `:model/X` keywords this module allows **others** to use. |+| `:model-imports` | `#{}` | Set of `:model/X` keywords **this module** may use from other modules. |-When omitted (or set to `:any`), no restrictions apply. `#{}` means export-nothing / import nothing.+When omitted, no models are exported/imported (closed by default). `:any`+opens all restrictions. Every module has explicit `:model-exports` and+`:model-imports` in `config.edn` — the defaults apply only to new modules+that haven't been configured yet.## Why it exists@@ -132,8 +134,18 @@ Or at the REPL:```The test also validates that configured `:model-exports` / `:model-imports`-only mention known models, and that exported models are actually owned by the-module exporting them.+only mention known models, that exported models are actually owned by the+module exporting them, and that no stale entries exist (exports not referenced+externally, imports not referenced in the module's source files).++### Computing model boundaries++Use the dev namespace to see what the config should contain:++```clojure+(dev.model-boundary-config/compute-and-print!) ;; print all exports/imports+(dev.model-boundary-config/compute-model-boundaries) ;; returns data+```## Limitations and future directions@@ -169,12 +181,10 @@ read-only/read-write distinction above.(source scanning with rewrite-clj) and avoids adding overhead to normaldevelopment. The tradeoff: violations are only caught when tests run.-- **Opt-in, not opt-out (for now).** Modules default to `:any` for both- exports and imports, so enforcement is incremental — restrict one module at a- time without touching anything else. Once enough modules have explicit sets,- we might flip the default to `#{}` so that new modules are restricted by- default and must explicitly declare their model dependencies. `:any` as the- starting default avoids a big-bang migration.+- **Closed by default.** Both `:model-exports` and `:model-imports` default+ to `#{}`. New modules must explicitly declare their model dependencies.+ All existing modules have explicit config entries populated from a scan of+ actual usage (see `dev.model-boundary-config`).- **Ownership is derived, not configured.** Instead of manually mapping modelsto modules, ownership is determined by scanning for `t2/table-name` defmethoddiff --git a/dev/src/dev/deps_graph.clj b/dev/src/dev/deps_graph.cljindex ddbe8c9da62..a97223e4168 100644--- a/dev/src/dev/deps_graph.clj+++ b/dev/src/dev/deps_graph.clj@@ -842,6 +842,29 @@(not (contains? model-imports model)))(conj :not-imported)))+(defn model-references-by-module+ "Scan all source files and build a map of `{module => #{:model/X ...}}` — the set of model keywords+ referenced in each module's source files. Exempt namespaces (e.g. `metabase.models.resolution`) are excluded."+ []+ (reduce+ (fn [acc file]+ (try+ (let [ns-symb (-> (ns.file/read-file-ns-decl file)+ ns.parse/name-from-ns-decl)+ mod (module ns-symb)]+ (if (and mod (not (contains? model-boundary-exempt-namespaces ns-symb)))+ (let [models (find-model-keywords file)]+ (if (seq models)+ (update acc mod (fnil into (sorted-set)) models)+ acc))+ acc))+ (catch Throwable e+ (throw (ex-info (format "Error scanning model references in %s" (str file))+ {:file file}+ e)))))+ (sorted-map)+ (find-source-files)))+(defn model-boundary-violations"Find all model boundary violations across the codebase.For each source file, checks that:@@ -863,16 +886,15 @@ns.parse/name-from-ns-decl)mod (module ns-symb)](when (and mod- (not (contains? model-boundary-exempt-namespaces ns-symb))- (not= :skip-test (get-in kondo-config [mod :model-imports])))- (let [model-imports (get-in kondo-config [mod :model-imports] :any)+ (not (contains? model-boundary-exempt-namespaces ns-symb)))+ (let [model-imports (get-in kondo-config [mod :model-imports] #{})models (find-model-keywords file)rel-path (file->path-relative-to-project-root file)](for [model models:let [defining-mod (get ownership model)]:when (not= defining-mod mod):let [model-exports (when defining-mod- (get-in kondo-config [defining-mod :model-exports] :any))]+ (get-in kondo-config [defining-mod :model-exports] #{}))]violation-type (model-reference-violationsmodel defining-mod model-exports model-imports)]{:file rel-pathdiff --git a/dev/src/dev/model_boundary_config.clj b/dev/src/dev/model_boundary_config.cljnew file mode 100644index 00000000000..ed1394e0a45--- /dev/null+++ b/dev/src/dev/model_boundary_config.clj@@ -0,0 +1,54 @@+(ns dev.model-boundary-config+ "Compute `:model-exports` and `:model-imports` for every module.++ Usage at the REPL:++ (dev.model-boundary-config/compute-model-boundaries)+ ;; => {:model-exports {module => #{:model/X ...}}+ ;; :model-imports {module => #{:model/X ...}}}"+ (:require+ [dev.deps-graph :as deps-graph]))++(set! *warn-on-reflection* true)++(defn compute-model-boundaries+ "Compute the required `:model-exports` and `:model-imports` for every module.++ Returns `{:model-exports {module => sorted-set-of-models}+ :model-imports {module => sorted-set-of-models}}`++ `:model-exports` for module M = models owned by M that are referenced by at least one other module.+ `:model-imports` for module M = models owned by other modules that M references."+ []+ (let [ownership (deps-graph/model-ownership)+ module-refs (deps-graph/model-references-by-module)+ all-modules (set (keys (deps-graph/kondo-config)))+ ;; {:model/X => #{modules that reference it}} — inverted index for fast export lookups+ model->referencing-modules+ (reduce-kv (fn [acc mod models]+ (reduce (fn [acc model]+ (update acc model (fnil conj #{}) mod))+ acc+ models))+ {}+ module-refs)]+ {:model-exports+ (into (sorted-map)+ (for [mod all-modules+ :let [owned (into #{} (comp (filter (fn [[_ owner]] (= owner mod))) (map key)) ownership)]+ :when (seq owned)]+ [mod (into (sorted-set)+ (for [model owned+ :let [refs (get model->referencing-modules model)]+ :when (some #(not= % mod) refs)]+ model))]))+ :model-imports+ (into (sorted-map)+ (for [mod all-modules+ :let [imported (into (sorted-set)+ (for [model (get module-refs mod)+ :let [defining-mod (get ownership model)]+ :when (and defining-mod (not= defining-mod mod))]+ model))]+ :when (seq imported)]+ [mod imported]))}))diff --git a/src/metabase/notification/send.clj b/src/metabase/notification/send.cljindex 64f6fd9a963..44b9c01783f 100644--- a/src/metabase/notification/send.clj+++ b/src/metabase/notification/send.clj@@ -448,14 +448,7 @@{:run_type :alert:entity_type :card:entity_id card-id})- :notification/dashboard (when-let [dashboard-id (or (:dashboard_id payload)- ;; TODO (Chris 2023-03-19) -- this model oesn't appear to be- ;; defined anywhere (no defmethod, no migration). Looks like- ;; dashboard notifications always carry :dashboard_id inline- ;; via :dashboard_subscription instead.- ;; Is this dead code?- (some->> payload_id- (t2/select-one-fn :dashboard_id :model/NotificationDashboard :id)))]+ :notification/dashboard (when-let [dashboard-id (:dashboard_id payload)]{:run_type :subscription:entity_type :dashboard:entity_id dashboard-id})diff --git a/test/metabase/core/modules_test.clj b/test/metabase/core/modules_test.cljindex 3f6f7d121c4..8b4461a64f1 100644--- a/test/metabase/core/modules_test.clj+++ b/test/metabase/core/modules_test.clj@@ -6,6 +6,7 @@[clojure.string :as str][clojure.test :refer :all][dev.deps-graph]+ [dev.model-boundary-config][metabase.util.json :as json][rewrite-clj.node :as n][rewrite-clj.parser :as r.parser]@@ -214,6 +215,23 @@(testing (format "\n'%s' exports %s (owned by %s)" module model (get ownership model))(is (= module (get ownership model)))))))))+(deftest ^:parallel model-config-not-stale-test+ (testing "Model exports and imports should not list models that are unused.\n"+ (let [{computed-exports :model-exports+ computed-imports :model-imports} (dev.model-boundary-config/compute-model-boundaries)+ config (modules-config)]+ (doseq [[config-key computed direction] [[:model-exports computed-exports "exports"]+ [:model-imports computed-imports "imports"]]+ [module module-config] config+ :when (set? (get module-config config-key))+ :let [needed (get computed module #{})+ configured (get module-config config-key)+ stale (set/difference configured needed)]+ :when (seq stale)]+ (testing (format "\n'%s' %s models that aren't used — remove them from %s."+ module direction config-key)+ (is (empty? (sort stale))))))))+(deftest ^:parallel model-exports-sorted-test(testing "Module :model-exports should be sorted"(do-each-module-config