Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Record when the page draws on the second and later visits (#82467)

Romeo Van Snick6964b63d2baf
diff --git a/.github/scripts/upload-bundle-load-stats.ts b/.github/scripts/upload-bundle-load-stats.ts
index 4d5ff2966bc..6f86129584f 100644
--- a/.github/scripts/upload-bundle-load-stats.ts
+++ b/.github/scripts/upload-bundle-load-stats.ts
@@ -23,6 +23,9 @@ interface Condition {
coldLargestPaintMs: number;
coldPageReadyMs: number;
warmPageReadyMs: number;
+ warmLargestPaintMs: number;
+ steadyLargestPaintMs: number;
+ steadyPageReadyMs: number;
locale: string;
scripts: number;
scriptKb: number;
@@ -69,6 +72,9 @@ function buildRows(
"Cold largest paint ms": condition.coldLargestPaintMs,
"Cold page ready ms": condition.coldPageReadyMs,
"Warm page ready ms": condition.warmPageReadyMs,
+ "Warm largest paint ms": condition.warmLargestPaintMs,
+ "Steady largest paint ms": condition.steadyLargestPaintMs,
+ "Steady page ready ms": condition.steadyPageReadyMs,
Locale: condition.locale,
Scripts: condition.scripts,
"Script kb": condition.scriptKb,
diff --git a/frontend/test/bench/matrix.ts b/frontend/test/bench/matrix.ts
index 5fa4f71cd84..5de473412de 100644
--- a/frontend/test/bench/matrix.ts
+++ b/frontend/test/bench/matrix.ts
@@ -189,6 +189,14 @@ function spreadPercent(values: number[]) {
coldLargestPaintMs: cold.median.largestContentfulPaintMs,
coldPageReadyMs: cold.median.pageReadyMs,
warmPageReadyMs: required(warm.secondLoad, "secondLoad").pageReadyMs,
+ // The same two readings for the visits that follow, so a returning
+ // user's page is measured by when it draws rather than by
+ // DOMContentLoaded alone.
+ warmLargestPaintMs: required(warm.secondLoad, "secondLoad")
+ .largestContentfulPaintMs,
+ steadyLargestPaintMs: required(warm.steady, "steady")
+ .largestContentfulPaintMs,
+ steadyPageReadyMs: required(warm.steady, "steady").pageReadyMs,
locale: cold.locale,
scripts: cold.scripts,
scriptKb: cold.scriptKb,