Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Keep metric dimension rows full-width by placing the vertical scrollbar in the column gutter (#80008)

Anderson6b4af5331900
diff --git a/frontend/src/metabase/metrics/components/MetricDimensions/AddDimensionsPanel.tsx b/frontend/src/metabase/metrics/components/MetricDimensions/AddDimensionsPanel.tsx
index 9efa86724bf..84c65a39a33 100644
--- a/frontend/src/metabase/metrics/components/MetricDimensions/AddDimensionsPanel.tsx
+++ b/frontend/src/metabase/metrics/components/MetricDimensions/AddDimensionsPanel.tsx
@@ -116,7 +116,9 @@ export function AddDimensionsPanel({
}
/>
) : (
- <ScrollArea className={S.scrollArea} offsetScrollbars="present">
+ <ScrollArea
+ classNames={{ viewport: S.scrollAreaViewport, root: S.scrollArea }}
+ >
<Accordion
key={groupIds.join(",")}
className={S.accordion}
diff --git a/frontend/src/metabase/metrics/components/MetricDimensions/DimensionList.tsx b/frontend/src/metabase/metrics/components/MetricDimensions/DimensionList.tsx
index cd1b5fb9de5..acfa65f1cdf 100644
--- a/frontend/src/metabase/metrics/components/MetricDimensions/DimensionList.tsx
+++ b/frontend/src/metabase/metrics/components/MetricDimensions/DimensionList.tsx
@@ -118,7 +118,9 @@ export function DimensionList({
}
/>
) : (
- <ScrollArea className={S.scrollArea} offsetScrollbars="present">
+ <ScrollArea
+ classNames={{ viewport: S.scrollAreaViewport, root: S.scrollArea }}
+ >
<Stack gap="sm">
<SortableList
items={dimensions}
diff --git a/frontend/src/metabase/metrics/components/MetricDimensions/MetricDimensions.module.css b/frontend/src/metabase/metrics/components/MetricDimensions/MetricDimensions.module.css
index 2885abb0dda..ee03f341f0a 100644
--- a/frontend/src/metabase/metrics/components/MetricDimensions/MetricDimensions.module.css
+++ b/frontend/src/metabase/metrics/components/MetricDimensions/MetricDimensions.module.css
@@ -28,6 +28,12 @@
.scrollArea {
flex: 1;
min-height: 0;
+ /* Extend into the column padding so the scrollbar sits beside the rows instead of shrinking them */
+ margin-right: calc(-1 * var(--scrollarea-scrollbar-size));
+
+ .scrollAreaViewport {
+ padding-right: var(--scrollarea-scrollbar-size);
+ }
}
.emptyState {