Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Fix Snowflake impersonation for roles that need to be quoted (#73800)

Cam Saul6ba2f4ca0e83
diff --git a/enterprise/backend/test/metabase_enterprise/impersonation/driver_test.clj b/enterprise/backend/test/metabase_enterprise/impersonation/driver_test.clj
index 14d4a04d423..2bd1dc6ee5a 100644
--- a/enterprise/backend/test/metabase_enterprise/impersonation/driver_test.clj
+++ b/enterprise/backend/test/metabase_enterprise/impersonation/driver_test.clj
@@ -709,7 +709,8 @@
;; (`LIMITED.ROLE` in CI Snowflake has no data access)
(is (thrown-with-msg?
clojure.lang.ExceptionInfo
- #"(?s)SQL compilation error.*operation cannot be performed"
+ ;; I've seen different error messages here, not 100% sure why but the important thing is that this fails
+ #"(?s)SQL compilation error.*(?:(?:operation cannot be performed)|(?:Object.*does not exist or not authorized))"
(mt/run-mbql-query venues
{:aggregation [[:count]]})))
diff --git a/modules/drivers/snowflake/src/metabase/driver/snowflake.clj b/modules/drivers/snowflake/src/metabase/driver/snowflake.clj
index 27fec76e226..ae9db9546c9 100644
--- a/modules/drivers/snowflake/src/metabase/driver/snowflake.clj
+++ b/modules/drivers/snowflake/src/metabase/driver/snowflake.clj
@@ -969,7 +969,17 @@
(defmethod sql-jdbc/set-role-statement :snowflake
[_driver _conn role]
- ["USE ROLE identifier(?);" role])
+ ;; Apparently `identifier(?)` still parses the identifier string as an unquoted identifier, so we still need to
+ ;; manually wrap it in double quotes and manually escape doubles quotes inside `role` itself :unamused: ...
+ ;; see (#73788)
+ (let [special-chars-pattern #"[^a-zA-Z0-9_]"
+ needs-quote? (re-find special-chars-pattern role)
+ quoted-role (if needs-quote?
+ (-> role
+ (str/replace #"\"" "\"\"")
+ (as-> $role (str \" $role \")))
+ role)]
+ ["USE ROLE identifier(?);" quoted-role]))
(defmethod driver.sql/default-database-role :snowflake
[_ database]
diff --git a/modules/drivers/snowflake/test/metabase/driver/snowflake_test.clj b/modules/drivers/snowflake/test/metabase/driver/snowflake_test.clj
index 9184f531a41..8325a519639 100644
--- a/modules/drivers/snowflake/test/metabase/driver/snowflake_test.clj
+++ b/modules/drivers/snowflake/test/metabase/driver/snowflake_test.clj
@@ -991,11 +991,14 @@
(testing "set-role-statement should return a parameterized USE ROLE command"
(are [role expected] (= expected
(driver.sql-jdbc/set-role-statement :snowflake nil role))
- "MY_ROLE" ["USE ROLE identifier(?);" "MY_ROLE"]
- "ROLE123" ["USE ROLE identifier(?);" "ROLE123"]
- "lowercase_role" ["USE ROLE identifier(?);" "lowercase_role"]
- "Role.123" ["USE ROLE identifier(?);" "Role.123"]
- "$role" ["USE ROLE identifier(?);" "$role"])))
+ "MY_ROLE" ["USE ROLE identifier(?);" "MY_ROLE"]
+ "ROLE123" ["USE ROLE identifier(?);" "ROLE123"]
+ "lowercase_role" ["USE ROLE identifier(?);" "lowercase_role"]
+ "Role.123" ["USE ROLE identifier(?);" "\"Role.123\""]
+ "$role" ["USE ROLE identifier(?);" "\"$role\""]
+ "Role-X" ["USE ROLE identifier(?);" "\"Role-X\""]
+ ;; should escape quotes in role name
+ "Role-X\"); DROP * FROM TABLE; --" ["USE ROLE identifier(?);" "\"Role-X\"\"); DROP * FROM TABLE; --\""])))
(deftest remark-test
(testing "Queries should have a remark formatted as JSON appended to them with additional metadata"