Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Enable JUnit hook-failure rewriting for all e2e tests (#75380)

Oleh K6bfd5cefd654
diff --git a/.github/workflows/e2e-test.yml b/.github/workflows/e2e-test.yml
index 9daedaaac99..9f915557b51 100644
--- a/.github/workflows/e2e-test.yml
+++ b/.github/workflows/e2e-test.yml
@@ -180,7 +180,7 @@ jobs:
# whether to fail or to pass the whole job, based on the quarantine list.
continue-on-error: true
- - name: Rewrite JUnit hook failures (partial rollout)
+ - name: Rewrite JUnit hook failures
if: always()
continue-on-error: true
timeout-minutes: 1
@@ -188,12 +188,7 @@ jobs:
run: |
if [ -d ./target/junit ]; then
echo "fix-junit-hooks: invoking bun"
- bun e2e/support/fix-junit-hooks.ts ./target/junit \
- --include sharing/public-resource-downloads \
- --include sharing/sharing-reproductions \
- --include visualizations-charts/custom-viz \
- --include metabot/metabot-query-builder \
- --include dashboard-filters/dashboard-filters-location
+ bun e2e/support/fix-junit-hooks.ts ./target/junit
else
echo "No ./target/junit directory; nothing to process."
fi
diff --git a/.github/workflows/embedding-sdk-component-tests.yml b/.github/workflows/embedding-sdk-component-tests.yml
index 6a5be66cc39..beb2c9bbdbc 100644
--- a/.github/workflows/embedding-sdk-component-tests.yml
+++ b/.github/workflows/embedding-sdk-component-tests.yml
@@ -87,7 +87,7 @@ jobs:
CYPRESS_BROWSER: ${{ steps.cypress-prep.outputs.chrome-path }}
run: node e2e/runner/run_cypress_ci.js component
- - name: Rewrite JUnit hook failures (dry-run)
+ - name: Rewrite JUnit hook failures
if: always()
continue-on-error: true
timeout-minutes: 1
@@ -95,7 +95,7 @@ jobs:
run: |
if [ -d ./target/junit ]; then
echo "fix-junit-hooks: invoking bun"
- bun e2e/support/fix-junit-hooks.ts --dry-run ./target/junit
+ bun e2e/support/fix-junit-hooks.ts ./target/junit
else
echo "No ./target/junit directory; nothing to process."
fi
@@ -253,7 +253,7 @@ jobs:
node e2e/runner/run_cypress_ci.js component \
--expose grepTags="-@skip-backward-compatibility"
- - name: Rewrite JUnit hook failures (dry-run)
+ - name: Rewrite JUnit hook failures
if: always()
continue-on-error: true
timeout-minutes: 1
@@ -261,7 +261,7 @@ jobs:
run: |
if [ -d ./target/junit ]; then
echo "fix-junit-hooks: invoking bun"
- bun e2e/support/fix-junit-hooks.ts --dry-run ./target/junit
+ bun e2e/support/fix-junit-hooks.ts ./target/junit
else
echo "No ./target/junit directory; nothing to process."
fi