Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Wire the minimal-tests to the ci-conductor quarantine (#79160)

Nemanja Glumac6c519afd6991
diff --git a/.github/workflows/minimal-tests.yml b/.github/workflows/minimal-tests.yml
index 6eda344cd26..efb7ed833f6 100644
--- a/.github/workflows/minimal-tests.yml
+++ b/.github/workflows/minimal-tests.yml
@@ -26,9 +26,9 @@ jobs:
id: check
run: |
if [[ "${{ contains(github.event.pull_request.labels.*.name, 'minimal-tests') }}" == "true" ]]; then
- echo "result=true" >> $GITHUB_OUTPUT
+ echo "result=true" >> "$GITHUB_OUTPUT"
else
- echo "result=false" >> $GITHUB_OUTPUT
+ echo "result=false" >> "$GITHUB_OUTPUT"
fi
# Postgres app-db tests - single version, single job
@@ -64,6 +64,7 @@ jobs:
with:
build-static-viz: true
junit-name: "minimal-be-tests-postgres-ee"
+ quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
test-args: >-
:only '["test" "enterprise/backend/test"]'
:exclude-tags '[:mb/driver-tests :mb/transforms-python-test]'
@@ -80,6 +81,7 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
+ run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
# Postgres driver tests
postgres-driver-test:
@@ -113,6 +115,7 @@ jobs:
uses: ./.github/actions/test-driver
with:
junit-name: "minimal-be-tests-postgres-driver-ee"
+ quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
@@ -127,6 +130,7 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
+ run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
# Frontend unit tests
frontend-unit-tests:
@@ -144,10 +148,32 @@ jobs:
uses: ./.github/actions/prepare-frontend
- name: Prepare back-end environment
uses: ./.github/actions/prepare-backend
+ - name: Resolve current job id
+ # Resolve JOB_ID before the long test step so the ci-conductor reporter
+ # below can link failures to this exact job. Best-effort.
+ uses: ./.github/actions/resolve-job-id
- name: Run frontend unit tests
id: run-tests
run: bun run test-unit --silent
+ # Keep this step continue-on-error because the quarantine logic controls whether it ultimately fails.
continue-on-error: true
+ - name: Report failed tests to ci-conductor
+ if: ${{ !cancelled() && steps.run-tests.outcome == 'failure' }}
+ # This step should NEVER fail the job!
+ continue-on-error: true
+ uses: ./.github/actions/report-failures-to-ci-conductor
+ with:
+ test-suite: fe-tests-unit
+ adapter: frontend
+ - name: Quarantine gate
+ if: ${{ !cancelled() && steps.run-tests.outcome == 'failure' }}
+ continue-on-error: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
+ timeout-minutes: 3
+ uses: ./.github/actions/quarantine-gate
+ with:
+ adapter: frontend
+ test-suite: fe-tests-unit
+ enforce-quarantine: ${{ vars.QUARANTINE_ENGINE == 'ci-conductor' }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -159,6 +185,7 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.run-tests.outcome }}
+ run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
# Summary job
minimal-tests-result: