The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Lift column-aware formatters to shared (#73499)
Fraser6d880197aa54
diff --git a/enterprise/frontend/src/metabase-enterprise/audit_app/components/AuditTableVisualization/AuditTableVisualization.jsx b/enterprise/frontend/src/metabase-enterprise/audit_app/components/AuditTableVisualization/AuditTableVisualization.jsxindex 90f2680f170..31d71a5c541 100644--- a/enterprise/frontend/src/metabase-enterprise/audit_app/components/AuditTableVisualization/AuditTableVisualization.jsx+++ b/enterprise/frontend/src/metabase-enterprise/audit_app/components/AuditTableVisualization/AuditTableVisualization.jsx@@ -10,8 +10,9 @@ import { EmptyState } from "metabase/common/components/EmptyState";import AdminS from "metabase/css/admin.module.css";import CS from "metabase/css/core/index.css";import { Icon } from "metabase/ui";-import { displayNameForColumn, formatValue } from "metabase/utils/formatting";+import { displayNameForColumn } from "metabase/utils/formatting";import { registerVisualization } from "metabase/visualizations/index";+import { formatValue } from "metabase/visualizations/lib/formatting";import { isColumnRightAligned } from "metabase/visualizations/lib/table";import { Table } from "metabase/visualizations/visualizations/Table/Table";diff --git a/enterprise/frontend/src/metabase-enterprise/license/components/BillingInfo/utils.ts b/enterprise/frontend/src/metabase-enterprise/license/components/BillingInfo/utils.tsindex c40c0803bec..613057f86b3 100644--- a/enterprise/frontend/src/metabase-enterprise/license/components/BillingInfo/utils.ts+++ b/enterprise/frontend/src/metabase-enterprise/license/components/BillingInfo/utils.ts@@ -1,7 +1,5 @@-import {- formatDateTimeWithUnit,- formatNumber,-} from "metabase/utils/formatting";+import { formatNumber } from "metabase/utils/formatting";+import { formatDateTimeWithUnit } from "metabase/visualizations/lib/formatting";import type { BillingInfoLineItem } from "metabase-types/api";import {supportedDisplayTypes,diff --git a/enterprise/frontend/src/metabase-enterprise/replacement/pages/MigrateModelsPage/ReplaceWithTransformModal/ReplaceWithTransformModal.tsx b/enterprise/frontend/src/metabase-enterprise/replacement/pages/MigrateModelsPage/ReplaceWithTransformModal/ReplaceWithTransformModal.tsxindex c9b1936fd9e..14c57b9962b 100644--- a/enterprise/frontend/src/metabase-enterprise/replacement/pages/MigrateModelsPage/ReplaceWithTransformModal/ReplaceWithTransformModal.tsx+++ b/enterprise/frontend/src/metabase-enterprise/replacement/pages/MigrateModelsPage/ReplaceWithTransformModal/ReplaceWithTransformModal.tsx@@ -30,7 +30,7 @@ import {Text,} from "metabase/ui";import * as Errors from "metabase/utils/errors";-import { slugify } from "metabase/utils/formatting/url";+import { slugify } from "metabase/visualizations/lib/formatting/url";import { useReplaceModelWithTransformMutation } from "metabase-enterprise/api";import type { Card, Database } from "metabase-types/api";diff --git a/enterprise/frontend/src/metabase-enterprise/table-editing/table-edit/data-grid/use-edit-datagrid-column-options.tsx b/enterprise/frontend/src/metabase-enterprise/table-editing/table-edit/data-grid/use-edit-datagrid-column-options.tsxindex d4e2dbb84c0..878c7680b1d 100644--- a/enterprise/frontend/src/metabase-enterprise/table-editing/table-edit/data-grid/use-edit-datagrid-column-options.tsx+++ b/enterprise/frontend/src/metabase-enterprise/table-editing/table-edit/data-grid/use-edit-datagrid-column-options.tsx@@ -2,7 +2,7 @@ import cx from "classnames";import { useCallback, useMemo } from "react";import type { ColumnOptions } from "metabase/data-grid";-import { formatValue } from "metabase/utils/formatting";+import { formatValue } from "metabase/visualizations/lib/formatting";import type { DescribeActionFormResponse } from "metabase-enterprise/table-editing/api/types";import type { DatasetColumn, RowValue, RowValues } from "metabase-types/api";diff --git a/enterprise/frontend/src/metabase-enterprise/tenants/components/CreateTenantsOnboardingStep/CreateTenantsOnboardingStep.tsx b/enterprise/frontend/src/metabase-enterprise/tenants/components/CreateTenantsOnboardingStep/CreateTenantsOnboardingStep.tsxindex 73df11eea32..9b788c4731d 100644--- a/enterprise/frontend/src/metabase-enterprise/tenants/components/CreateTenantsOnboardingStep/CreateTenantsOnboardingStep.tsx+++ b/enterprise/frontend/src/metabase-enterprise/tenants/components/CreateTenantsOnboardingStep/CreateTenantsOnboardingStep.tsx@@ -16,7 +16,7 @@ import {Text,TextInput,} from "metabase/ui";-import { slugify } from "metabase/utils/formatting";+import { slugify } from "metabase/visualizations/lib/formatting";import type { DataSegregationStrategy, FieldId } from "metabase-types/api";import { useCreateTenantMutation } from "../../../api/tenants";diff --git a/enterprise/frontend/src/metabase-enterprise/transforms-python/components/PythonTransformEditor/PythonDataPicker/utils.ts b/enterprise/frontend/src/metabase-enterprise/transforms-python/components/PythonTransformEditor/PythonDataPicker/utils.tsindex cfcdb82ade5..daed4c8420c 100644--- a/enterprise/frontend/src/metabase-enterprise/transforms-python/components/PythonTransformEditor/PythonDataPicker/utils.ts+++ b/enterprise/frontend/src/metabase-enterprise/transforms-python/components/PythonTransformEditor/PythonDataPicker/utils.ts@@ -1,4 +1,4 @@-import { slugify as toSlug } from "metabase/utils/formatting";+import { slugify as toSlug } from "metabase/visualizations/lib/formatting";import type {PythonTransformTableAliases,PythonTransformTableEntry,diff --git a/enterprise/frontend/src/metabase-enterprise/transforms-python/components/PythonTransformEditor/PythonEditorResults/ExecutionOutputTable.tsx b/enterprise/frontend/src/metabase-enterprise/transforms-python/components/PythonTransformEditor/PythonEditorResults/ExecutionOutputTable.tsxindex 2e7d32e8b6e..6dd62ea9bf3 100644--- a/enterprise/frontend/src/metabase-enterprise/transforms-python/components/PythonTransformEditor/PythonEditorResults/ExecutionOutputTable.tsx+++ b/enterprise/frontend/src/metabase-enterprise/transforms-python/components/PythonTransformEditor/PythonEditorResults/ExecutionOutputTable.tsx@@ -1,5 +1,5 @@import { DataGrid, useDataGridInstance } from "metabase/data-grid";-import { formatValue } from "metabase/utils/formatting";+import { formatValue } from "metabase/visualizations/lib/formatting";import type { RowValue, TestPythonTransformResponse } from "metabase-types/api";export type Row = Record<string, RowValue>;diff --git a/frontend/lint/module-boundaries.mjs b/frontend/lint/module-boundaries.mjsindex cb3d419e7cc..b87e37ff21a 100644--- a/frontend/lint/module-boundaries.mjs+++ b/frontend/lint/module-boundaries.mjs@@ -118,7 +118,7 @@ const elements = [enforceOutgoing: true,}),// feature- createElement({ type: "feature", name: "dashboard" }),+ createElement({ type: "feature", name: "dashboard", enforceOutgoing: true }),createElement({type: "feature",name: "query_builder",diff --git a/frontend/src/metabase/account/notifications/components/ArchiveModal/ArchiveModal.tsx b/frontend/src/metabase/account/notifications/components/ArchiveModal/ArchiveModal.tsxindex eed135711ba..e7c0c35557e 100644--- a/frontend/src/metabase/account/notifications/components/ArchiveModal/ArchiveModal.tsx+++ b/frontend/src/metabase/account/notifications/components/ArchiveModal/ArchiveModal.tsx@@ -6,8 +6,8 @@ import { ModalContent } from "metabase/common/components/ModalContent";import { FormMessage } from "metabase/forms";import { formatChannelRecipients } from "metabase/pulse";import { Box, Stack } from "metabase/ui";-import { formatDateTimeWithUnit } from "metabase/utils/formatting";import Settings from "metabase/utils/settings";+import { formatDateTimeWithUnit } from "metabase/visualizations/lib/formatting";import type { Alert, DashboardSubscription, User } from "metabase-types/api";import type { NotificationType } from "../../types";diff --git a/frontend/src/metabase/account/notifications/components/NotificationCard/utils.ts b/frontend/src/metabase/account/notifications/components/NotificationCard/utils.tsindex 0f7bebdb88c..fb60e1033fe 100644--- a/frontend/src/metabase/account/notifications/components/NotificationCard/utils.ts+++ b/frontend/src/metabase/account/notifications/components/NotificationCard/utils.ts@@ -1,8 +1,8 @@import { t } from "ttag";import type { NotificationListItem } from "metabase/account/notifications/types";-import { formatDateTimeWithUnit } from "metabase/utils/formatting/date";import Settings from "metabase/utils/settings";+import { formatDateTimeWithUnit } from "metabase/visualizations/lib/formatting/date";import type { UserId } from "metabase-types/api";export const formatCreatorMessage = (diff --git a/frontend/src/metabase/admin/settings/components/ApiKeys/ManageApiKeys.tsx b/frontend/src/metabase/admin/settings/components/ApiKeys/ManageApiKeys.tsxindex 3e73020affd..1923dc3e04f 100644--- a/frontend/src/metabase/admin/settings/components/ApiKeys/ManageApiKeys.tsx+++ b/frontend/src/metabase/admin/settings/components/ApiKeys/ManageApiKeys.tsx@@ -19,7 +19,7 @@ import {Title,} from "metabase/ui";import { getThemeOverrides } from "metabase/ui/theme";-import { formatDateTimeWithUnit } from "metabase/utils/formatting/date";+import { formatDateTimeWithUnit } from "metabase/visualizations/lib/formatting/date";import type { ApiKey } from "metabase-types/api";import { CreateApiKeyModal } from "./CreateApiKeyModal";diff --git a/frontend/src/metabase/admin/settings/components/widgets/FormattingWidget.tsx b/frontend/src/metabase/admin/settings/components/widgets/FormattingWidget.tsxindex b7e6b38b34d..128d908ceeb 100644--- a/frontend/src/metabase/admin/settings/components/widgets/FormattingWidget.tsx+++ b/frontend/src/metabase/admin/settings/components/widgets/FormattingWidget.tsx@@ -9,9 +9,11 @@ import {type CurrencyStyle,getCurrencyOptions,getCurrencyStyleOptions,+} from "metabase/utils/formatting";+import {getDateStyleOptionsForUnit,getTimeStyleOptions,-} from "metabase/utils/formatting";+} from "metabase/visualizations/lib/formatting";import type { FormattingSettings } from "metabase-types/api";import { SetByEnvVar } from "./AdminSettingInput";diff --git a/frontend/src/metabase/browse/metrics/utils.ts b/frontend/src/metabase/browse/metrics/utils.tsindex 69c92cdc242..85e3af4ff79 100644--- a/frontend/src/metabase/browse/metrics/utils.ts+++ b/frontend/src/metabase/browse/metrics/utils.ts@@ -1,7 +1,7 @@import { t } from "ttag";import { getCollectionPathAsString } from "metabase/collections/utils";-import { formatValue } from "metabase/utils/formatting";+import { formatValue } from "metabase/visualizations/lib/formatting";import { isDate } from "metabase-lib/v1/types/utils/isa";import type { Dataset, SortingOptions } from "metabase-types/api";diff --git a/frontend/src/metabase/common/components/DateTime/DateTime.tsx b/frontend/src/metabase/common/components/DateTime/DateTime.tsxindex 599ef8b9b14..e3e0f3a155d 100644--- a/frontend/src/metabase/common/components/DateTime/DateTime.tsx+++ b/frontend/src/metabase/common/components/DateTime/DateTime.tsx@@ -1,8 +1,8 @@import { type HTMLAttributes, forwardRef } from "react";-import { formatDateTimeWithUnit } from "metabase/utils/formatting";import type { OptionsType } from "metabase/utils/formatting/types";import MetabaseSettings from "metabase/utils/settings";+import { formatDateTimeWithUnit } from "metabase/visualizations/lib/formatting";import type { DatetimeUnit } from "metabase-types/api";type DateTimeProps = HTMLAttributes<HTMLSpanElement> & {diff --git a/frontend/src/metabase/common/components/MetadataInfo/ColumnFingerprintInfo/DateTimeFingerprint.tsx b/frontend/src/metabase/common/components/MetadataInfo/ColumnFingerprintInfo/DateTimeFingerprint.tsxindex 25f5d28cd7d..4a0522e96e3 100644--- a/frontend/src/metabase/common/components/MetadataInfo/ColumnFingerprintInfo/DateTimeFingerprint.tsx+++ b/frontend/src/metabase/common/components/MetadataInfo/ColumnFingerprintInfo/DateTimeFingerprint.tsx@@ -1,6 +1,6 @@import { t } from "ttag";-import { formatDateTimeWithUnit } from "metabase/utils/formatting";+import { formatDateTimeWithUnit } from "metabase/visualizations/lib/formatting";import type * as Lib from "metabase-lib";import { Table } from "../MetadataInfo.styled";diff --git a/frontend/src/metabase/dashboard/actions/data-fetching.ts b/frontend/src/metabase/dashboard/actions/data-fetching.tsindex 42cd6b0354f..7deb26293e0 100644--- a/frontend/src/metabase/dashboard/actions/data-fetching.ts+++ b/frontend/src/metabase/dashboard/actions/data-fetching.ts@@ -26,6 +26,7 @@ import {} from "metabase/dashboard/utils";import { entityCompatibleQuery } from "metabase/entities";import { getSavedDashboardUiParameters } from "metabase/parameters/utils/dashboards";+import { getParameterValuesByIdFromQueryParams } from "metabase/parameters/utils/parameter-parsing";import { addFields } from "metabase/redux/metadata";import type { Dispatch, GetState } from "metabase/redux/store";import { createAsyncThunk, createThunkAction } from "metabase/redux/utils";@@ -49,7 +50,6 @@ import { defer } from "metabase/utils/promise";import { uuid } from "metabase/utils/uuid";import { isVisualizerDashboardCard } from "metabase/visualizer/utils";import type { UiParameter } from "metabase-lib/v1/parameters/types";-import { getParameterValuesByIdFromQueryParams } from "metabase-lib/v1/parameters/utils/parameter-parsing";import { getParameterValuesBySlug } from "metabase-lib/v1/parameters/utils/parameter-values";import type {Card,diff --git a/frontend/src/metabase/dashboard/actions/parameters.tsx b/frontend/src/metabase/dashboard/actions/parameters.tsxindex 5665fabb5c9..63e36840fb9 100644--- a/frontend/src/metabase/dashboard/actions/parameters.tsx+++ b/frontend/src/metabase/dashboard/actions/parameters.tsx@@ -20,6 +20,7 @@ import {setParameterName as setParamName,setParameterType as setParamType,} from "metabase/parameters/utils/dashboards";+import { getParameterValuesByIdFromQueryParams } from "metabase/parameters/utils/parameter-parsing";import { createAction, createThunkAction } from "metabase/redux";import { selectTab, setParameterValues } from "metabase/redux/dashboard";import type { Dispatch, GetState } from "metabase/redux/store";@@ -28,7 +29,6 @@ import { getMetadata } from "metabase/selectors/metadata";import { Text } from "metabase/ui";import { isQuestionDashCard } from "metabase/utils/dashboard";import * as Lib from "metabase-lib";-import { getParameterValuesByIdFromQueryParams } from "metabase-lib/v1/parameters/utils/parameter-parsing";import {PULSE_PARAM_EMPTY,isParameterValueEmpty,diff --git a/frontend/src/metabase/dashboard/actions/save.ts b/frontend/src/metabase/dashboard/actions/save.tsindex 22a1d2549bf..eeba7e20933 100644--- a/frontend/src/metabase/dashboard/actions/save.ts+++ b/frontend/src/metabase/dashboard/actions/save.ts@@ -2,6 +2,7 @@ import { assocIn, dissocIn, getIn } from "icepick";import _ from "underscore";import { Dashboards } from "metabase/entities/dashboards";+import { clickBehaviorIsValid } from "metabase/parameters/utils/click-behavior";import { createThunkAction } from "metabase/redux";import { UPDATE_DASHBOARD_AND_CARDS } from "metabase/redux/dashboard";import type {@@ -11,7 +12,6 @@ import type {StoreDashcard,} from "metabase/redux/store";import { CardApi } from "metabase/services";-import { clickBehaviorIsValid } from "metabase-lib/v1/parameters/utils/click-behavior";import type { DashCardId, ParameterId } from "metabase-types/api";import { trackDashboardSaved } from "../analytics";diff --git a/frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/ClickBehaviorSidebar.tsx b/frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/ClickBehaviorSidebar.tsxindex 9059d3e5ad8..a4e9de348b3 100644--- a/frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/ClickBehaviorSidebar.tsx+++ b/frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/ClickBehaviorSidebar.tsx@@ -12,7 +12,7 @@ import { isTableDisplay } from "metabase/dashboard/utils";import {canSaveClickBehavior,clickBehaviorIsValid,-} from "metabase-lib/v1/parameters/utils/click-behavior";+} from "metabase/parameters/utils/click-behavior";import { getColumnKey } from "metabase-lib/v1/queries/utils/column-key";import type {ClickBehavior,diff --git a/frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/LinkOptions/CustomURLPicker.tsx b/frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/LinkOptions/CustomURLPicker.tsxindex 1091dd673e4..3b0a8e5842c 100644--- a/frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/LinkOptions/CustomURLPicker.tsx+++ b/frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/LinkOptions/CustomURLPicker.tsx@@ -5,6 +5,7 @@ import { t } from "ttag";import CS from "metabase/css/core/index.css";import { isTableDisplay } from "metabase/dashboard/utils";+import { clickBehaviorIsValid } from "metabase/parameters/utils/click-behavior";import {Button,Flex,@@ -14,7 +15,6 @@ import {TextInputBlurChange,} from "metabase/ui";import type { UiParameter } from "metabase-lib/v1/parameters/types";-import { clickBehaviorIsValid } from "metabase-lib/v1/parameters/utils/click-behavior";import type {ArbitraryCustomDestinationClickBehavior,ClickBehavior,diff --git a/frontend/src/metabase/dashboard/components/ClickMappings/hooks.ts b/frontend/src/metabase/dashboard/components/ClickMappings/hooks.tsindex 81f2f93e7ab..f774855039f 100644--- a/frontend/src/metabase/dashboard/components/ClickMappings/hooks.ts+++ b/frontend/src/metabase/dashboard/components/ClickMappings/hooks.ts@@ -1,6 +1,10 @@import { useEffect, useMemo, useState } from "react";import { getDashcardData, getParameters } from "metabase/dashboard/selectors";+import {+ getTargetsForDashboard,+ getTargetsForQuestion,+} from "metabase/parameters/utils/click-behavior";import { loadMetadataForCard } from "metabase/questions/actions";import { useDispatch, useSelector } from "metabase/redux";import { getMetadata } from "metabase/selectors/metadata";@@ -8,10 +12,6 @@ import { GTAPApi } from "metabase/services";import { isQuestionDashCard } from "metabase/utils/dashboard";import MetabaseSettings from "metabase/utils/settings";import Question from "metabase-lib/v1/Question";-import {- getTargetsForDashboard,- getTargetsForQuestion,-} from "metabase-lib/v1/parameters/utils/click-behavior";import type { DatasetColumn, Parameter } from "metabase-types/api";import type { ClickMappingsOwnProps, TargetItem } from "./types";diff --git a/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/PulsesListSidebar.tsx b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/PulsesListSidebar.tsxindex ec957faf1f3..a9383b3bab0 100644--- a/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/PulsesListSidebar.tsx+++ b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/PulsesListSidebar.tsx@@ -11,12 +11,9 @@ import { getActivePulseParameters } from "metabase/pulse";import { connect } from "metabase/redux";import type { State } from "metabase/redux/store";import { Button, Icon, Tooltip } from "metabase/ui";-import {- conjunct,- formatDateTimeWithUnit,- formatTimeWithUnit,-} from "metabase/utils/formatting";+import { conjunct, formatTimeWithUnit } from "metabase/utils/formatting";import { formatFrame } from "metabase/utils/time-dayjs";+import { formatDateTimeWithUnit } from "metabase/visualizations/lib/formatting";import type { UiParameter } from "metabase-lib/v1/parameters/types";import type {Channel,diff --git a/frontend/src/metabase/dashboard/components/ParameterSidebar/ParameterSidebar.tsx b/frontend/src/metabase/dashboard/components/ParameterSidebar/ParameterSidebar.tsxindex 3021571f94e..78099f13004 100644--- a/frontend/src/metabase/dashboard/components/ParameterSidebar/ParameterSidebar.tsx+++ b/frontend/src/metabase/dashboard/components/ParameterSidebar/ParameterSidebar.tsx@@ -8,7 +8,7 @@ import { canUseLinkedFilters } from "metabase/parameters/utils/linked-filters";import { useSelector } from "metabase/redux";import type { IconName } from "metabase/ui";import { Tabs } from "metabase/ui";-import { slugify } from "metabase/utils/formatting";+import { slugify } from "metabase/visualizations/lib/formatting";import { isFilterParameter } from "metabase-lib/v1/parameters/utils/parameter-type";import { parameterHasNoDisplayValue } from "metabase-lib/v1/parameters/utils/parameter-values";import type {diff --git a/frontend/src/metabase/dashboard/utils/dashboard-click-drill.js b/frontend/src/metabase/dashboard/utils/dashboard-click-drill.jsindex 350274b2898..aa2ed1e5785 100644--- a/frontend/src/metabase/dashboard/utils/dashboard-click-drill.js+++ b/frontend/src/metabase/dashboard/utils/dashboard-click-drill.js@@ -3,15 +3,15 @@ import querystring from "querystring";import { getIn } from "icepick";import _ from "underscore";-import * as Urls from "metabase/urls";-import { renderLinkURLForClick } from "metabase/utils/formatting/link";-import * as Lib from "metabase-lib";-import Question from "metabase-lib/v1/Question";import {formatSourceForTarget,getDataFromClicked,getTargetForQueryParams,-} from "metabase-lib/v1/parameters/utils/click-behavior";+} from "metabase/parameters/utils/click-behavior";+import * as Urls from "metabase/urls";+import { renderLinkURLForClick } from "metabase/visualizations/lib/formatting/link";+import * as Lib from "metabase-lib";+import Question from "metabase-lib/v1/Question";import { isDate } from "metabase-lib/v1/types/utils/isa";import { getStructuredQuestionUrlWithParameters } from "./question-url";diff --git a/frontend/src/metabase/dashboard/visualizations/IFrameViz/utils.ts b/frontend/src/metabase/dashboard/visualizations/IFrameViz/utils.tsindex 2591e4606f6..2c5de9df211 100644--- a/frontend/src/metabase/dashboard/visualizations/IFrameViz/utils.ts+++ b/frontend/src/metabase/dashboard/visualizations/IFrameViz/utils.ts@@ -1,4 +1,4 @@-import { isSafeUrl } from "metabase/utils/formatting/link";+import { isSafeUrl } from "metabase/visualizations/lib/formatting/link";/*** Reconstructs a URL from its parts while preserving parameter placeholders (e.g. {{param}}).diff --git a/frontend/src/metabase/detail-view/utils.ts b/frontend/src/metabase/detail-view/utils.tsindex c7687254f30..1f1a8426631 100644--- a/frontend/src/metabase/detail-view/utils.ts+++ b/frontend/src/metabase/detail-view/utils.ts@@ -1,5 +1,6 @@import type { ContentTranslationFunction } from "metabase/i18n/types";-import { type OptionsType, formatValue } from "metabase/utils/formatting";+import type { OptionsType } from "metabase/utils/formatting";+import { formatValue } from "metabase/visualizations/lib/formatting";import { getComputedSettings } from "metabase/visualizations/lib/settings";import {getGlobalSettingsForColumn,diff --git a/frontend/src/metabase/list-view/components/ListView/ColumnValue.tsx b/frontend/src/metabase/list-view/components/ListView/ColumnValue.tsxindex 76d6889d0e2..91a5227a3ea 100644--- a/frontend/src/metabase/list-view/components/ListView/ColumnValue.tsx+++ b/frontend/src/metabase/list-view/components/ListView/ColumnValue.tsx@@ -10,12 +10,9 @@ import {Stack,Text,} from "metabase/ui";-import {- formatNumber,- formatValue,- getCurrencySymbol,-} from "metabase/utils/formatting";+import { formatNumber, getCurrencySymbol } from "metabase/utils/formatting";import { MiniBarCell } from "metabase/visualizations/components/TableInteractive/cells/MiniBarCell";+import { formatValue } from "metabase/visualizations/lib/formatting";import { getColumnExtent } from "metabase/visualizations/lib/utils";import type { ComputedVisualizationSettings } from "metabase/visualizations/types";import { TYPE } from "metabase-lib/v1/types/constants";diff --git a/frontend/src/metabase/notifications/utils.ts b/frontend/src/metabase/notifications/utils.tsindex 241ff2af54a..f5d0997cc37 100644--- a/frontend/src/metabase/notifications/utils.ts+++ b/frontend/src/metabase/notifications/utils.ts@@ -5,10 +5,10 @@ import type { NotificationListItem } from "metabase/account/notifications/types"import { cronToScheduleSettings } from "metabase/common/components/Schedule/cron";import { getScheduleExplanation } from "metabase/utils/cron";import { getEmailDomain, isEmail } from "metabase/utils/email";-import { formatDateTimeWithUnit } from "metabase/utils/formatting/date";import { formatTimeWithUnit } from "metabase/utils/formatting/time";import MetabaseSettings from "metabase/utils/settings";import { formatFrame } from "metabase/utils/time-dayjs";+import { formatDateTimeWithUnit } from "metabase/visualizations/lib/formatting/date";import type Question from "metabase-lib/v1/Question";import type {CardId,diff --git a/frontend/src/metabase/parameters/components/widgets/ParameterFieldWidget/Value/RemappedValue.tsx b/frontend/src/metabase/parameters/components/widgets/ParameterFieldWidget/Value/RemappedValue.tsxindex 3091d88e7e4..60b2d126981 100644--- a/frontend/src/metabase/parameters/components/widgets/ParameterFieldWidget/Value/RemappedValue.tsx+++ b/frontend/src/metabase/parameters/components/widgets/ParameterFieldWidget/Value/RemappedValue.tsx@@ -2,7 +2,7 @@ import type { ReactNode } from "react";import CS from "metabase/css/core/index.css";import AutoLoadRemapped from "metabase/hoc/Remapped";-import { formatValue } from "metabase/utils/formatting";+import { formatValue } from "metabase/visualizations/lib/formatting";import type Field from "metabase-lib/v1/metadata/Field";type RenderNormal = (opts: { value?: unknown; column?: Field }) => ReactNode;diff --git a/frontend/src/metabase/parameters/components/widgets/ParameterFieldWidget/Value/Value.tsx b/frontend/src/metabase/parameters/components/widgets/ParameterFieldWidget/Value/Value.tsxindex 4181662c8ea..e4ddae0da8f 100644--- a/frontend/src/metabase/parameters/components/widgets/ParameterFieldWidget/Value/Value.tsx+++ b/frontend/src/metabase/parameters/components/widgets/ParameterFieldWidget/Value/Value.tsx@@ -2,8 +2,8 @@ import { isValidElement } from "react";import { useEmbeddingEntityContext } from "metabase/embedding/context";import { useTranslateContent } from "metabase/i18n/hooks";-import { formatValue } from "metabase/utils/formatting";import type { OptionsType } from "metabase/utils/formatting/types";+import { formatValue } from "metabase/visualizations/lib/formatting";import type { DashboardId, Parameter } from "metabase-types/api";import RemappedValue from "./RemappedValue";diff --git a/frontend/src/metabase-lib/v1/parameters/utils/click-behavior.ts b/frontend/src/metabase/parameters/utils/click-behavior.tssimilarity index 98%rename from frontend/src/metabase-lib/v1/parameters/utils/click-behavior.tsrename to frontend/src/metabase/parameters/utils/click-behavior.tsindex 621e0fb600b..688b0ccb160 100644--- a/frontend/src/metabase-lib/v1/parameters/utils/click-behavior.ts+++ b/frontend/src/metabase/parameters/utils/click-behavior.ts@@ -1,12 +1,12 @@import _ from "underscore";+import { parseTimestamp } from "metabase/utils/time-dayjs";+import { checkNotNull } from "metabase/utils/types";import {formatDateTimeForParameter,formatDateToRangeForParameter,-} from "metabase/utils/formatting/date";-import type { ValueAndColumnForColumnNameDate } from "metabase/utils/formatting/link";-import { parseTimestamp } from "metabase/utils/time-dayjs";-import { checkNotNull } from "metabase/utils/types";+} from "metabase/visualizations/lib/formatting/date";+import type { ValueAndColumnForColumnNameDate } from "metabase/visualizations/lib/formatting/link";import type { ClickObjectDimension as DimensionType } from "metabase-lib";import * as Lib from "metabase-lib";import type { TemplateTagDimension } from "metabase-lib/v1/Dimension";diff --git a/frontend/src/metabase-lib/v1/parameters/utils/click-behavior.unit.spec.ts b/frontend/src/metabase/parameters/utils/click-behavior.unit.spec.tssimilarity index 99%rename from frontend/src/metabase-lib/v1/parameters/utils/click-behavior.unit.spec.tsrename to frontend/src/metabase/parameters/utils/click-behavior.unit.spec.tsindex f6dbcc6fcad..c3b6063adb5 100644--- a/frontend/src/metabase-lib/v1/parameters/utils/click-behavior.unit.spec.ts+++ b/frontend/src/metabase/parameters/utils/click-behavior.unit.spec.ts@@ -1,6 +1,6 @@import { createMockMetadata } from "__support__/metadata";-import * as dateFormatUtils from "metabase/utils/formatting/date";import { checkNotNull } from "metabase/utils/types";+import * as dateFormatUtils from "metabase/visualizations/lib/formatting/date";import Question from "metabase-lib/v1/Question";import type Field from "metabase-lib/v1/metadata/Field";import type { FieldId, TemplateTagType } from "metabase-types/api";diff --git a/frontend/src/metabase/parameters/utils/dashboards.ts b/frontend/src/metabase/parameters/utils/dashboards.tsindex 6b5776d6bbe..37dd03a492e 100644--- a/frontend/src/metabase/parameters/utils/dashboards.ts+++ b/frontend/src/metabase/parameters/utils/dashboards.ts@@ -3,8 +3,8 @@ import _ from "underscore";import { tag_names } from "cljs/metabase.parameters.shared";import { generateParameterId } from "metabase/parameters/utils/parameter-id";import { isQuestionCard, isQuestionDashCard } from "metabase/utils/dashboard";-import { slugify } from "metabase/utils/formatting";import { isNotNull } from "metabase/utils/types";+import { slugify } from "metabase/visualizations/lib/formatting";import Question from "metabase-lib/v1/Question";import type Metadata from "metabase-lib/v1/metadata/Metadata";import type {diff --git a/frontend/src/metabase/parameters/utils/formatting.ts b/frontend/src/metabase/parameters/utils/formatting.tsindex 79af287fe2c..4952e5dbe50 100644--- a/frontend/src/metabase/parameters/utils/formatting.ts+++ b/frontend/src/metabase/parameters/utils/formatting.ts@@ -1,6 +1,6 @@import { msgid, ngettext } from "ttag";-import { formatValue } from "metabase/utils/formatting";+import { formatValue } from "metabase/visualizations/lib/formatting";import * as Lib from "metabase-lib";import Field from "metabase-lib/v1/metadata/Field";import type { UiParameter } from "metabase-lib/v1/parameters/types";diff --git a/frontend/src/metabase-lib/v1/parameters/utils/parameter-parsing.ts b/frontend/src/metabase/parameters/utils/parameter-parsing.tssimilarity index 100%rename from frontend/src/metabase-lib/v1/parameters/utils/parameter-parsing.tsrename to frontend/src/metabase/parameters/utils/parameter-parsing.tsdiff --git a/frontend/src/metabase-lib/v1/parameters/utils/parameter-parsing.unit.spec.js b/frontend/src/metabase/parameters/utils/parameter-parsing.unit.spec.jssimilarity index 100%rename from frontend/src/metabase-lib/v1/parameters/utils/parameter-parsing.unit.spec.jsrename to frontend/src/metabase/parameters/utils/parameter-parsing.unit.spec.jsdiff --git a/frontend/src/metabase/public/containers/PublicOrEmbeddedQuestion/PublicOrEmbeddedQuestion/PublicOrEmbeddedQuestion.tsx b/frontend/src/metabase/public/containers/PublicOrEmbeddedQuestion/PublicOrEmbeddedQuestion/PublicOrEmbeddedQuestion.tsxindex 42da506277f..52f641cf9d7 100644--- a/frontend/src/metabase/public/containers/PublicOrEmbeddedQuestion/PublicOrEmbeddedQuestion/PublicOrEmbeddedQuestion.tsx+++ b/frontend/src/metabase/public/containers/PublicOrEmbeddedQuestion/PublicOrEmbeddedQuestion/PublicOrEmbeddedQuestion.tsx@@ -5,6 +5,7 @@ import { useLatest, useMount } from "react-use";import { applyParameters } from "metabase/common/utils/card";import { fetchDataOrError } from "metabase/dashboard/utils";import { EmbeddingEntityContextProvider } from "metabase/embedding/context";+import { getParameterValuesByIdFromQueryParams } from "metabase/parameters/utils/parameter-parsing";import { LocaleProvider } from "metabase/public/LocaleProvider";import { useEmbedFrameOptions } from "metabase/public/hooks";import { usePublicEndpoints } from "metabase/public/hooks/use-public-endpoints";@@ -16,7 +17,6 @@ import { getMetadata } from "metabase/selectors/metadata";import { getCanWhitelabel } from "metabase/selectors/whitelabel";import { EmbedApi, PublicApi, maybeUsePivotEndpoint } from "metabase/services";import { getCardUiParameters } from "metabase-lib/v1/parameters/utils/cards";-import { getParameterValuesByIdFromQueryParams } from "metabase-lib/v1/parameters/utils/parameter-parsing";import { getParameterValuesBySlug } from "metabase-lib/v1/parameters/utils/parameter-values";import { getParametersFromCard } from "metabase-lib/v1/parameters/utils/template-tags";import type {diff --git a/frontend/src/metabase/pulse/pulse.ts b/frontend/src/metabase/pulse/pulse.tsindex 3c70c39c0c2..6f6bfa77473 100644--- a/frontend/src/metabase/pulse/pulse.ts+++ b/frontend/src/metabase/pulse/pulse.ts@@ -3,10 +3,10 @@ import _ from "underscore";import type { DashboardSubscriptionData } from "metabase/redux/store";import { getEmailDomain } from "metabase/utils/email";-import { formatDateTimeWithUnit } from "metabase/utils/formatting/date";import { formatTimeWithUnit } from "metabase/utils/formatting/time";import MetabaseSettings from "metabase/utils/settings";import { formatFrame } from "metabase/utils/time-dayjs";+import { formatDateTimeWithUnit } from "metabase/visualizations/lib/formatting/date";import {getDefaultValuePopulatedParameters,normalizeParameterValue,diff --git a/frontend/src/metabase/query_builder/actions/core/parameterUtils.ts b/frontend/src/metabase/query_builder/actions/core/parameterUtils.tsindex d42e2391521..18ae296c5ab 100644--- a/frontend/src/metabase/query_builder/actions/core/parameterUtils.ts+++ b/frontend/src/metabase/query_builder/actions/core/parameterUtils.ts@@ -3,12 +3,12 @@ import {cardParametersAreEquivalent,} from "metabase/common/utils/card";import { hasMatchingParameters } from "metabase/parameters/utils/dashboards";+import { getParameterValuesByIdFromQueryParams } from "metabase/parameters/utils/parameter-parsing";import { setErrorPage } from "metabase/redux/app";import type { Dispatch } from "metabase/redux/store";import { DashboardApi } from "metabase/services";import type Metadata from "metabase-lib/v1/metadata/Metadata";import { getCardUiParameters } from "metabase-lib/v1/parameters/utils/cards";-import { getParameterValuesByIdFromQueryParams } from "metabase-lib/v1/parameters/utils/parameter-parsing";import type { Card, Parameter } from "metabase-types/api";type BlankQueryOptions = {diff --git a/frontend/src/metabase/static-viz/components/ProgressBar/ProgressBar.tsx b/frontend/src/metabase/static-viz/components/ProgressBar/ProgressBar.tsxindex 5991af18315..1fbc44c4b59 100644--- a/frontend/src/metabase/static-viz/components/ProgressBar/ProgressBar.tsx+++ b/frontend/src/metabase/static-viz/components/ProgressBar/ProgressBar.tsx@@ -4,7 +4,7 @@ import { scaleLinear } from "@visx/scale";import { useMemo } from "react";import { c } from "ttag";-import { formatValue } from "metabase/utils/formatting";+import { formatValue } from "metabase/visualizations/lib/formatting";import {calculateProgressMetrics,extractProgressValue,diff --git a/frontend/src/metabase/timelines/collections/components/EventCard/EventCard.tsx b/frontend/src/metabase/timelines/collections/components/EventCard/EventCard.tsxindex 7288edc81b5..56c9ba183c9 100644--- a/frontend/src/metabase/timelines/collections/components/EventCard/EventCard.tsx+++ b/frontend/src/metabase/timelines/collections/components/EventCard/EventCard.tsx@@ -5,8 +5,8 @@ import { EntityMenu } from "metabase/common/components/EntityMenu";import { Link } from "metabase/common/components/Link";import type { IconName } from "metabase/ui";import * as Urls from "metabase/urls";-import { formatDateTimeWithUnit } from "metabase/utils/formatting";import Settings from "metabase/utils/settings";+import { formatDateTimeWithUnit } from "metabase/visualizations/lib/formatting";import type { Timeline, TimelineEvent } from "metabase-types/api";import {diff --git a/frontend/src/metabase/timelines/questions/components/EventCard/EventCard.tsx b/frontend/src/metabase/timelines/questions/components/EventCard/EventCard.tsxindex f214ea86227..0442bf979ca 100644--- a/frontend/src/metabase/timelines/questions/components/EventCard/EventCard.tsx+++ b/frontend/src/metabase/timelines/questions/components/EventCard/EventCard.tsx@@ -6,8 +6,8 @@ import { CheckBox as Checkbox } from "metabase/common/components/CheckBox/CheckBimport { EntityMenu } from "metabase/common/components/EntityMenu";import { useScrollOnMount } from "metabase/common/hooks/use-scroll-on-mount";import type { IconName } from "metabase/ui";-import { formatDateTimeWithUnit } from "metabase/utils/formatting";import Settings from "metabase/utils/settings";+import { formatDateTimeWithUnit } from "metabase/visualizations/lib/formatting";import type { Timeline, TimelineEvent } from "metabase-types/api";import {diff --git a/frontend/src/metabase/transforms/components/TargetNameInput/TargetNameInput.tsx b/frontend/src/metabase/transforms/components/TargetNameInput/TargetNameInput.tsxindex 22c74b2c495..9f4d0afc3ee 100644--- a/frontend/src/metabase/transforms/components/TargetNameInput/TargetNameInput.tsx+++ b/frontend/src/metabase/transforms/components/TargetNameInput/TargetNameInput.tsx@@ -3,7 +3,7 @@ import { useEffect, useRef } from "react";import { t } from "ttag";import { FormTextInput } from "metabase/forms";-import { slugify } from "metabase/utils/formatting/url";+import { slugify } from "metabase/visualizations/lib/formatting/url";type TargetNameInputProps = {description?: string;diff --git a/frontend/src/metabase/transforms/pages/NewTransformPage/CreateTransformModal/form.ts b/frontend/src/metabase/transforms/pages/NewTransformPage/CreateTransformModal/form.tsindex 8c3259fd76d..7cc304914d4 100644--- a/frontend/src/metabase/transforms/pages/NewTransformPage/CreateTransformModal/form.ts+++ b/frontend/src/metabase/transforms/pages/NewTransformPage/CreateTransformModal/form.ts@@ -1,7 +1,7 @@import * as Yup from "yup";import * as Errors from "metabase/utils/errors";-import { slugify } from "metabase/utils/formatting/url";+import { slugify } from "metabase/visualizations/lib/formatting/url";import type {CreateTransformRequest,TransformSource,diff --git a/frontend/src/metabase/utils/formatting/index.ts b/frontend/src/metabase/utils/formatting/index.tsindex 40623ac9960..d18618641ba 100644--- a/frontend/src/metabase/utils/formatting/index.ts+++ b/frontend/src/metabase/utils/formatting/index.ts@@ -1,13 +1,7 @@export * from "./column";export * from "./currency";-export * from "./date";-export * from "./email";export * from "./field";-export * from "./geography";-export * from "./image";export * from "./numbers";export * from "./strings";export * from "./time";export * from "./types";-export * from "./url";-export * from "./value";diff --git a/frontend/src/metabase/visualizations/components/ChartTooltip/utils.ts b/frontend/src/metabase/visualizations/components/ChartTooltip/utils.tsindex 71f3caec9f8..300f8aeb3ff 100644--- a/frontend/src/metabase/visualizations/components/ChartTooltip/utils.ts+++ b/frontend/src/metabase/visualizations/components/ChartTooltip/utils.ts@@ -1,6 +1,6 @@import { NULL_DISPLAY_VALUE } from "metabase/utils/constants";-import { formatValue } from "metabase/utils/formatting";import type { OptionsType } from "metabase/utils/formatting/types";+import { formatValue } from "metabase/visualizations/lib/formatting";import type {ComputedVisualizationSettings,RemappingHydratedDatasetColumn,diff --git a/frontend/src/metabase/visualizations/components/ChoroplethMap.jsx b/frontend/src/metabase/visualizations/components/ChoroplethMap.jsxindex 225ea2e4a93..e8f4f0e1fa2 100644--- a/frontend/src/metabase/visualizations/components/ChoroplethMap.jsx+++ b/frontend/src/metabase/visualizations/components/ChoroplethMap.jsx@@ -15,9 +15,9 @@ import { isEmbeddingSdk } from "metabase/embedding-sdk/config";import { connect, useSelector } from "metabase/redux";import { getUserIsAdmin } from "metabase/selectors/user";import { Flex, Text } from "metabase/ui";-import { formatValue } from "metabase/utils/formatting";import MetabaseSettings from "metabase/utils/settings";import { MinColumnsError } from "metabase/visualizations/lib/errors";+import { formatValue } from "metabase/visualizations/lib/formatting";import {computeMinimalBounds,getCanonicalRowKey,diff --git a/frontend/src/metabase/visualizations/components/FunnelNormal.tsx b/frontend/src/metabase/visualizations/components/FunnelNormal.tsxindex b256e531455..573578f73f6 100644--- a/frontend/src/metabase/visualizations/components/FunnelNormal.tsx+++ b/frontend/src/metabase/visualizations/components/FunnelNormal.tsx@@ -5,11 +5,7 @@ import { t } from "ttag";import CS from "metabase/css/core/index.css";import { Ellipsified } from "metabase/ui";import { color } from "metabase/ui/colors";-import {- formatChangeWithSign,- formatNumber,- formatValue,-} from "metabase/utils/formatting";+import { formatChangeWithSign, formatNumber } from "metabase/utils/formatting";import { formatNullable } from "metabase/utils/formatting/nullable";import { isNotNull } from "metabase/utils/types";import {@@ -21,6 +17,7 @@ import {Subtitle,Title,} from "metabase/visualizations/components/FunnelNormal.styled";+import { formatValue } from "metabase/visualizations/lib/formatting";import {calculateFunnelSteps,calculateStepOpacity,diff --git a/frontend/src/metabase/visualizations/components/ObjectDetail/ObjectDetailsTable.tsx b/frontend/src/metabase/visualizations/components/ObjectDetail/ObjectDetailsTable.tsxindex 16d79317960..15f670adb92 100644--- a/frontend/src/metabase/visualizations/components/ObjectDetail/ObjectDetailsTable.tsx+++ b/frontend/src/metabase/visualizations/components/ObjectDetail/ObjectDetailsTable.tsx@@ -7,7 +7,8 @@ import { EmptyState } from "metabase/common/components/EmptyState";import CS from "metabase/css/core/index.css";import QueryBuilderS from "metabase/css/query_builder.module.css";import { Box, Ellipsified } from "metabase/ui";-import { displayNameForColumn, formatValue } from "metabase/utils/formatting";+import { displayNameForColumn } from "metabase/utils/formatting";+import { formatValue } from "metabase/visualizations/lib/formatting";import type { ClickObject } from "metabase-lib";import { findColumnIndexesForColumnSettings } from "metabase-lib/v1/queries/utils/dataset";import { TYPE } from "metabase-lib/v1/types/constants";diff --git a/frontend/src/metabase/visualizations/components/ObjectDetail/utils.ts b/frontend/src/metabase/visualizations/components/ObjectDetail/utils.tsindex 7fb2ae8f4fb..a2cabe5b99b 100644--- a/frontend/src/metabase/visualizations/components/ObjectDetail/utils.ts+++ b/frontend/src/metabase/visualizations/components/ObjectDetail/utils.ts@@ -4,7 +4,8 @@ import {isImplicitDeleteAction,isImplicitUpdateAction,} from "metabase/actions/utils";-import { formatValue, singularize } from "metabase/utils/formatting";+import { singularize } from "metabase/utils/formatting";+import { formatValue } from "metabase/visualizations/lib/formatting";import type Question from "metabase-lib/v1/Question";import { canRunAction } from "metabase-lib/v1/actions/utils";import type Database from "metabase-lib/v1/metadata/Database";diff --git a/frontend/src/metabase/visualizations/components/TableInteractive/TableInteractive.tsx b/frontend/src/metabase/visualizations/components/TableInteractive/TableInteractive.tsxindex 7fc6883d37f..df030a49305 100644--- a/frontend/src/metabase/visualizations/components/TableInteractive/TableInteractive.tsx+++ b/frontend/src/metabase/visualizations/components/TableInteractive/TableInteractive.tsx@@ -48,7 +48,7 @@ import { useDispatch } from "metabase/redux";import { setUIControls } from "metabase/redux/query-builder";import { Flex, type MantineTheme } from "metabase/ui";import { getScrollBarSize } from "metabase/utils/dom";-import { formatValue } from "metabase/utils/formatting";+import { formatValue } from "metabase/visualizations/lib/formatting";import {getTableCellClickedObject,getTableClickedObjectRowData,diff --git a/frontend/src/metabase/visualizations/components/TrendInfo/use-trend-data.ts b/frontend/src/metabase/visualizations/components/TrendInfo/use-trend-data.tsindex 443cdc37dee..b655ae7405f 100644--- a/frontend/src/metabase/visualizations/components/TrendInfo/use-trend-data.ts+++ b/frontend/src/metabase/visualizations/components/TrendInfo/use-trend-data.ts@@ -1,7 +1,7 @@import { useMemo } from "react";-import { formatValue } from "metabase/utils/formatting";-import { formatDateTimeRangeWithUnit } from "metabase/utils/formatting/date";+import { formatValue } from "metabase/visualizations/lib/formatting";+import { formatDateTimeRangeWithUnit } from "metabase/visualizations/lib/formatting/date";import type { PreviousPeriodChange } from "metabase/visualizations/lib/trend-helpers";import {computePreviousPeriodChange,diff --git a/frontend/src/metabase/visualizations/echarts/boxplot/model/index.ts b/frontend/src/metabase/visualizations/echarts/boxplot/model/index.tsindex 3fbe457772b..3ed6c5057f2 100644--- a/frontend/src/metabase/visualizations/echarts/boxplot/model/index.ts+++ b/frontend/src/metabase/visualizations/echarts/boxplot/model/index.ts@@ -1,6 +1,5 @@import { memoize } from "metabase/common/hooks/use-memoized-callback";import { NULL_DISPLAY_VALUE } from "metabase/utils/constants";-import { formatValue } from "metabase/utils/formatting";import {ECHARTS_CATEGORY_AXIS_NULL_VALUE,X_AXIS_DATA_KEY,@@ -32,6 +31,7 @@ import type {YAxisModel,} from "metabase/visualizations/echarts/cartesian/model/types";import type { ShowWarning } from "metabase/visualizations/echarts/types";+import { formatValue } from "metabase/visualizations/lib/formatting";import type { CartesianChartColumns } from "metabase/visualizations/lib/graph/columns";import { getCartesianChartColumns } from "metabase/visualizations/lib/graph/columns";import type {diff --git a/frontend/src/metabase/visualizations/echarts/cartesian/model/axis.ts b/frontend/src/metabase/visualizations/echarts/cartesian/model/axis.tsindex a09be4c7541..e37d6e06bd0 100644--- a/frontend/src/metabase/visualizations/echarts/cartesian/model/axis.ts+++ b/frontend/src/metabase/visualizations/echarts/cartesian/model/axis.ts@@ -3,7 +3,6 @@ import dayjs from "dayjs";import _ from "underscore";import { NULL_DISPLAY_VALUE } from "metabase/utils/constants";-import { formatValue } from "metabase/utils/formatting";import type { OptionsType } from "metabase/utils/formatting/types";import { getObjectEntries, getObjectKeys } from "metabase/utils/objects";import { isNotNull, isNumber } from "metabase/utils/types";@@ -39,6 +38,7 @@ import {normalizeDate,tryGetDate,} from "metabase/visualizations/echarts/cartesian/utils/timeseries";+import { formatValue } from "metabase/visualizations/lib/formatting";import { computeNumericDataInterval } from "metabase/visualizations/lib/numeric";import { getLineAreaBarComparisonSettings } from "metabase/visualizations/lib/settings";import type {diff --git a/frontend/src/metabase/visualizations/echarts/cartesian/model/series.ts b/frontend/src/metabase/visualizations/echarts/cartesian/model/series.tsindex 675864175e4..15cc1e7af20 100644--- a/frontend/src/metabase/visualizations/echarts/cartesian/model/series.ts+++ b/frontend/src/metabase/visualizations/echarts/cartesian/model/series.ts@@ -1,6 +1,5 @@import { memoize } from "metabase/common/hooks/use-memoized-callback";import { NULL_DISPLAY_VALUE } from "metabase/utils/constants";-import { formatValue } from "metabase/utils/formatting";import type { OptionsType } from "metabase/utils/formatting/types";import { isEmpty } from "metabase/utils/validate";import { getDatasetKey } from "metabase/visualizations/echarts/cartesian/model/dataset";@@ -22,6 +21,7 @@ import type {WaterFallChartDataDensity,} from "metabase/visualizations/echarts/cartesian/model/types";import { getHexColor } from "metabase/visualizations/lib/color";+import { formatValue } from "metabase/visualizations/lib/formatting";import type { CartesianChartColumns } from "metabase/visualizations/lib/graph/columns";import {SERIES_COLORS_SETTING_KEY,diff --git a/frontend/src/metabase/visualizations/echarts/graph/sankey/model/formatters.ts b/frontend/src/metabase/visualizations/echarts/graph/sankey/model/formatters.tsindex 53becc17753..b5e0163ad3a 100644--- a/frontend/src/metabase/visualizations/echarts/graph/sankey/model/formatters.ts+++ b/frontend/src/metabase/visualizations/echarts/graph/sankey/model/formatters.ts@@ -1,5 +1,5 @@import { memoize } from "metabase/common/hooks/use-memoized-callback";-import { formatValue } from "metabase/utils/formatting";+import { formatValue } from "metabase/visualizations/lib/formatting";import type { ComputedVisualizationSettings } from "metabase/visualizations/types";import type { SankeyChartColumns, SankeyFormatters, SankeyNode } from "./types";diff --git a/frontend/src/metabase/visualizations/echarts/pie/format.ts b/frontend/src/metabase/visualizations/echarts/pie/format.tsindex abf469aee42..b83ae982c34 100644--- a/frontend/src/metabase/visualizations/echarts/pie/format.ts+++ b/frontend/src/metabase/visualizations/echarts/pie/format.ts@@ -1,5 +1,5 @@import { NULL_DISPLAY_VALUE } from "metabase/utils/constants";-import { formatValue } from "metabase/utils/formatting";+import { formatValue } from "metabase/visualizations/lib/formatting";import { computeMaxDecimalsForValues } from "metabase/visualizations/lib/utils";import type {ComputedVisualizationSettings,diff --git a/frontend/src/metabase/visualizations/lib/data_grid.js b/frontend/src/metabase/visualizations/lib/data_grid.jsindex 5989d5e640e..eb532b2bede 100644--- a/frontend/src/metabase/visualizations/lib/data_grid.js+++ b/frontend/src/metabase/visualizations/lib/data_grid.js@@ -1,7 +1,7 @@import _ from "underscore";import * as Pivot from "cljs/metabase.pivot.js";-import { formatValue } from "metabase/utils/formatting";+import { formatValue } from "metabase/visualizations/lib/formatting";import { makeCellBackgroundGetter } from "metabase/visualizations/lib/table_format";import { migratePivotColumnSplitSetting } from "metabase-lib/v1/queries/utils/pivot";diff --git a/frontend/src/metabase/utils/formatting/date.tsx b/frontend/src/metabase/visualizations/lib/formatting/date.tsxsimilarity index 99%rename from frontend/src/metabase/utils/formatting/date.tsxrename to frontend/src/metabase/visualizations/lib/formatting/date.tsxindex 5d7bf752c17..fd6b7ac3ec6 100644--- a/frontend/src/metabase/utils/formatting/date.tsx+++ b/frontend/src/metabase/visualizations/lib/formatting/date.tsx@@ -3,20 +3,18 @@ import dayjs, { type Dayjs, type OpUnitType, type QUnitType } from "dayjs";import { t } from "ttag";import CS from "metabase/css/core/index.css";-import { isDateWithoutTime } from "metabase-lib/v1/types/utils/isa";-import type { DatetimeUnit } from "metabase-types/api/query";-import { SCHEDULE_DAY, isScheduleDay } from "metabase-types/guards/settings";--import { parseTimestamp } from "../time-dayjs";-import {DEFAULT_DATE_STYLE,DEFAULT_TIME_STYLE,getTimeFormatFromStyle,hasDay,hasHour,-} from "./datetime-utils";-import type { OptionsType } from "./types";+} from "metabase/utils/formatting/datetime-utils";+import type { OptionsType } from "metabase/utils/formatting/types";+import { parseTimestamp } from "metabase/utils/time-dayjs";+import { isDateWithoutTime } from "metabase-lib/v1/types/utils/isa";+import type { DatetimeUnit } from "metabase-types/api/query";+import { SCHEDULE_DAY, isScheduleDay } from "metabase-types/guards/settings";const EN_DASH = `–`;diff --git a/frontend/src/metabase/utils/formatting/date.unit.spec.tsx b/frontend/src/metabase/visualizations/lib/formatting/date.unit.spec.tsxsimilarity index 99%rename from frontend/src/metabase/utils/formatting/date.unit.spec.tsxrename to frontend/src/metabase/visualizations/lib/formatting/date.unit.spec.tsxindex 806594b0b17..be9fe1e2730 100644--- a/frontend/src/metabase/utils/formatting/date.unit.spec.tsx+++ b/frontend/src/metabase/visualizations/lib/formatting/date.unit.spec.tsx@@ -6,7 +6,7 @@ import {formatDateTimeForParameter,formatDateTimeRangeWithUnit,formatDateTimeWithUnit,-} from "metabase/utils/formatting/date";+} from "metabase/visualizations/lib/formatting/date";import "dayjs/locale/es";import "dayjs/locale/fr";diff --git a/frontend/src/metabase/utils/formatting/email.tsx b/frontend/src/metabase/visualizations/lib/formatting/email.tsxsimilarity index 80%rename from frontend/src/metabase/utils/formatting/email.tsxrename to frontend/src/metabase/visualizations/lib/formatting/email.tsxindex 6e3ac09983c..ab59fe423a6 100644--- a/frontend/src/metabase/utils/formatting/email.tsx+++ b/frontend/src/metabase/visualizations/lib/formatting/email.tsx@@ -1,10 +1,10 @@import { ExternalLink } from "metabase/common/components/ExternalLink";+import { getDataFromClicked } from "metabase/parameters/utils/click-behavior";import { isEmail } from "metabase/utils/email";-import { getDataFromClicked } from "metabase-lib/v1/parameters/utils/click-behavior";+import { removeNewLines } from "metabase/utils/formatting/strings";+import type { OptionsType } from "metabase/utils/formatting/types";import { renderLinkTextForClick } from "./link";-import { removeNewLines } from "./strings";-import type { OptionsType } from "./types";export function formatEmail(value: string,diff --git a/frontend/src/metabase/utils/formatting/email.unit.spec.tsx b/frontend/src/metabase/visualizations/lib/formatting/email.unit.spec.tsxsimilarity index 100%rename from frontend/src/metabase/utils/formatting/email.unit.spec.tsxrename to frontend/src/metabase/visualizations/lib/formatting/email.unit.spec.tsxdiff --git a/frontend/src/metabase/utils/formatting/geography.ts b/frontend/src/metabase/visualizations/lib/formatting/geography.tssimilarity index 79%rename from frontend/src/metabase/utils/formatting/geography.tsrename to frontend/src/metabase/visualizations/lib/formatting/geography.tsindex c9665365e92..cee015fec2b 100644--- a/frontend/src/metabase/utils/formatting/geography.ts+++ b/frontend/src/metabase/visualizations/lib/formatting/geography.ts@@ -1,10 +1,8 @@import * as d3 from "d3";-import { decimalCount } from "metabase/visualizations/lib/numeric";+import type { OptionsType } from "metabase/utils/formatting/types";import { isLatitude, isLongitude } from "metabase-lib/v1/types/utils/isa";-import type { OptionsType } from "./types";-const DECIMAL_DEGREES_FORMATTER = d3.format(".08f");const DECIMAL_DEGREES_FORMATTER_COMPACT = d3.format(".02f");const BINNING_DEGREES_FORMATTER = (value: number, binWidth: number) => {@@ -31,3 +29,16 @@ export function formatCoordinate(value: number, options: OptionsType = {}) {: DECIMAL_DEGREES_FORMATTER(value);return formattedValue + "°" + direction;}++function decimalCount(a: number): number {+ if (!isFinite(a)) {+ return 0;+ }+ let e = 1;+ let p = 0;+ while (Math.round(a * e) / e !== a) {+ e *= 10;+ p++;+ }+ return p;+}diff --git a/frontend/src/metabase/utils/formatting/image.tsx b/frontend/src/metabase/visualizations/lib/formatting/image.tsxsimilarity index 86%rename from frontend/src/metabase/utils/formatting/image.tsxrename to frontend/src/metabase/visualizations/lib/formatting/image.tsxindex 398a3e97fcd..c6d531014e9 100644--- a/frontend/src/metabase/utils/formatting/image.tsx+++ b/frontend/src/metabase/visualizations/lib/formatting/image.tsx@@ -1,4 +1,5 @@-import type { OptionsType } from "./types";+import type { OptionsType } from "metabase/utils/formatting/types";+import { getUrlProtocol } from "./url";export function formatImage(diff --git a/frontend/src/metabase/visualizations/lib/formatting/index.ts b/frontend/src/metabase/visualizations/lib/formatting/index.tsnew file mode 100644index 00000000000..105d6ba547a--- /dev/null+++ b/frontend/src/metabase/visualizations/lib/formatting/index.ts@@ -0,0 +1,7 @@+export * from "./date";+export * from "./email";+export * from "./geography";+export * from "./image";+export * from "./link";+export * from "./url";+export * from "./value";diff --git a/frontend/src/metabase/utils/formatting/link.ts b/frontend/src/metabase/visualizations/lib/formatting/link.tssimilarity index 96%rename from frontend/src/metabase/utils/formatting/link.tsrename to frontend/src/metabase/visualizations/lib/formatting/link.tsindex cb404eaf483..d47881f4528 100644--- a/frontend/src/metabase/utils/formatting/link.ts+++ b/frontend/src/metabase/visualizations/lib/formatting/link.ts@@ -1,16 +1,12 @@+import { NULL_DISPLAY_VALUE } from "metabase/utils/constants";import { isSameOrSiteUrlOrigin } from "metabase/utils/dom";-import {- formatValue,- getUrlProtocol,- isDefaultLinkProtocol,-} from "metabase/utils/formatting";import { isDate } from "metabase-lib/v1/types/utils/isa";import type { ParameterValueOrArray } from "metabase-types/api";import type { DatasetColumn, RowValue } from "metabase-types/api/dataset";-import { NULL_DISPLAY_VALUE } from "../constants";-import { formatDateTimeForParameter } from "./date";+import { getUrlProtocol, isDefaultLinkProtocol } from "./url";+import { formatValue } from "./value";type Value = ParameterValueOrArray | RowValue | undefined;diff --git a/frontend/src/metabase/utils/formatting/link.unit.spec.tsx b/frontend/src/metabase/visualizations/lib/formatting/link.unit.spec.tsxsimilarity index 100%rename from frontend/src/metabase/utils/formatting/link.unit.spec.tsxrename to frontend/src/metabase/visualizations/lib/formatting/link.unit.spec.tsxdiff --git a/frontend/src/metabase/utils/formatting/url.tsx b/frontend/src/metabase/visualizations/lib/formatting/url.tsxsimilarity index 94%rename from frontend/src/metabase/utils/formatting/url.tsxrename to frontend/src/metabase/visualizations/lib/formatting/url.tsxindex b1ee35258f6..c8486029d53 100644--- a/frontend/src/metabase/utils/formatting/url.tsx+++ b/frontend/src/metabase/visualizations/lib/formatting/url.tsx@@ -5,13 +5,13 @@ import { ExternalLink } from "metabase/common/components/ExternalLink";import { Link } from "metabase/common/components/Link";import CS from "metabase/css/core/index.css";import { isEmbeddingSdk } from "metabase/embedding-sdk/config";+import { getDataFromClicked } from "metabase/parameters/utils/click-behavior";import { isSameOrSiteUrlOrigin } from "metabase/utils/dom";-import { getDataFromClicked } from "metabase-lib/v1/parameters/utils/click-behavior";+import { removeNewLines } from "metabase/utils/formatting/strings";+import type { OptionsType } from "metabase/utils/formatting/types";import { isURL } from "metabase-lib/v1/types/utils/isa";import { renderLinkTextForClick, renderLinkURLForClick } from "./link";-import { removeNewLines } from "./strings";-import type { OptionsType } from "./types";import { formatValue, getRemappedValue } from "./value";function isSafeProtocol(protocol: string) {diff --git a/frontend/src/metabase/utils/formatting/url.unit.spec.tsx b/frontend/src/metabase/visualizations/lib/formatting/url.unit.spec.tsxsimilarity index 100%rename from frontend/src/metabase/utils/formatting/url.unit.spec.tsxrename to frontend/src/metabase/visualizations/lib/formatting/url.unit.spec.tsxdiff --git a/frontend/src/metabase/utils/formatting/value.tsx b/frontend/src/metabase/visualizations/lib/formatting/value.tsxsimilarity index 95%rename from frontend/src/metabase/utils/formatting/value.tsxrename to frontend/src/metabase/visualizations/lib/formatting/value.tsxindex 8bb215b9a7c..5117250e53e 100644--- a/frontend/src/metabase/utils/formatting/value.tsx+++ b/frontend/src/metabase/visualizations/lib/formatting/value.tsx@@ -5,13 +5,16 @@ import ReactMarkdown from "react-markdown";import { ExternalLink } from "metabase/common/components/ExternalLink";import CS from "metabase/css/core/index.css";-import { NULL_DISPLAY_VALUE } from "metabase/utils/constants";-import { renderLinkTextForClick } from "metabase/utils/formatting/link";-import { parseNumber } from "metabase/utils/number";import {clickBehaviorIsValid,getDataFromClicked,-} from "metabase-lib/v1/parameters/utils/click-behavior";+} from "metabase/parameters/utils/click-behavior";+import { NULL_DISPLAY_VALUE } from "metabase/utils/constants";+import { formatNumber } from "metabase/utils/formatting/numbers";+import { removeNewLines } from "metabase/utils/formatting/strings";+import { formatTime } from "metabase/utils/formatting/time";+import type { OptionsType } from "metabase/utils/formatting/types";+import { parseNumber } from "metabase/utils/number";import {isBoolean,isCoordinate,@@ -27,10 +30,7 @@ import { formatDateTimeWithUnit, formatRange } from "./date";import { formatEmail } from "./email";import { formatCoordinate } from "./geography";import { formatImage } from "./image";-import { formatNumber } from "./numbers";-import { removeNewLines } from "./strings";-import { formatTime } from "./time";-import type { OptionsType } from "./types";+import { renderLinkTextForClick } from "./link";import { formatUrl } from "./url";const MARKDOWN_RENDERERS = {diff --git a/frontend/src/metabase/utils/formatting/value.unit.spec.tsx b/frontend/src/metabase/visualizations/lib/formatting/value.unit.spec.tsxsimilarity index 99%rename from frontend/src/metabase/utils/formatting/value.unit.spec.tsxrename to frontend/src/metabase/visualizations/lib/formatting/value.unit.spec.tsxindex 65c86960d31..be3f0a9d85b 100644--- a/frontend/src/metabase/utils/formatting/value.unit.spec.tsx+++ b/frontend/src/metabase/visualizations/lib/formatting/value.unit.spec.tsx@@ -5,10 +5,10 @@ import { mockSettings } from "__support__/settings";import { render, screen } from "__support__/ui";import { ExternalLink } from "metabase/common/components/ExternalLink";import { Link } from "metabase/common/components/Link";+import type { OptionsType } from "metabase/utils/formatting/types";import { TYPE } from "metabase-lib/v1/types/constants";import { createMockColumn } from "metabase-types/api/mocks";-import type { OptionsType } from "./types";import { formatValue } from "./value";const SITE_URL = "http://localhost:3000";diff --git a/frontend/src/metabase/visualizations/lib/numeric.ts b/frontend/src/metabase/visualizations/lib/numeric.tsindex fe0dc2eba9c..9ba67bd9a89 100644--- a/frontend/src/metabase/visualizations/lib/numeric.ts+++ b/frontend/src/metabase/visualizations/lib/numeric.ts@@ -56,19 +56,6 @@ export function precision(a: RowValue): number {return Math.pow(10, e);}-export function decimalCount(a: number): number {- if (!isFinite(a)) {- return 0;- }- let e = 1;- let p = 0;- while (Math.round(a * e) / e !== a) {- e *= 10;- p++;- }- return p;-}-export function computeNumericDataInterval(xValues: RowValues): number {let bestPrecision = Infinity;for (const value of xValues) {diff --git a/frontend/src/metabase/visualizations/lib/scalar_utils.tsx b/frontend/src/metabase/visualizations/lib/scalar_utils.tsxindex 3a7f701d84c..dc4de581e34 100644--- a/frontend/src/metabase/visualizations/lib/scalar_utils.tsx+++ b/frontend/src/metabase/visualizations/lib/scalar_utils.tsx@@ -1,8 +1,8 @@import { ColorPill } from "metabase/common/components/ColorPill";import { Text } from "metabase/ui";import { color } from "metabase/ui/utils/colors";-import { formatValue } from "metabase/utils/formatting";import type { OptionsType } from "metabase/utils/formatting/types";+import { formatValue } from "metabase/visualizations/lib/formatting";import type { RowValue, ScalarSegment } from "metabase-types/api";export const COMPACT_MAX_WIDTH = 250;diff --git a/frontend/src/metabase/visualizations/lib/settings/column.ts b/frontend/src/metabase/visualizations/lib/settings/column.tsindex b662bf2e4d4..93b2e740a9a 100644--- a/frontend/src/metabase/visualizations/lib/settings/column.ts+++ b/frontend/src/metabase/visualizations/lib/settings/column.ts@@ -9,9 +9,6 @@ import {getCurrencyNarrowSymbol,getCurrencyStyleOptions,getCurrencySymbol,- getDateFormatFromStyle,- getDateStyleOptionsForUnit,- getTimeStyleOptions,numberFormatterForOptions,} from "metabase/utils/formatting";import { hasHour } from "metabase/utils/formatting/datetime-utils";@@ -19,6 +16,11 @@ import MetabaseSettings from "metabase/utils/settings";import { getVisualizationRaw } from "metabase/visualizations";import { ChartNestedSettingColumns } from "metabase/visualizations/components/settings/ChartNestedSettingColumns";import { ChartSettingTableColumns } from "metabase/visualizations/components/settings/ChartSettingTableColumns";+import {+ getDateFormatFromStyle,+ getDateStyleOptionsForUnit,+ getTimeStyleOptions,+} from "metabase/visualizations/lib/formatting";import { getDeduplicatedTableColumnSettings } from "metabase/visualizations/lib/settings/utils";import {getDefaultCurrency,diff --git a/frontend/src/metabase/visualizations/lib/tooltip.ts b/frontend/src/metabase/visualizations/lib/tooltip.tsindex cbb686aa444..6f5b9222d46 100644--- a/frontend/src/metabase/visualizations/lib/tooltip.ts+++ b/frontend/src/metabase/visualizations/lib/tooltip.ts@@ -1,5 +1,5 @@-import { formatValue } from "metabase/utils/formatting";import { formatNullable } from "metabase/utils/formatting/nullable";+import { formatValue } from "metabase/visualizations/lib/formatting";import type { DatasetColumn, VisualizationSettings } from "metabase-types/api";import { getFormattingOptionsWithoutScaling } from "../echarts/cartesian/model/util";diff --git a/frontend/src/metabase/visualizations/visualizations/Funnel/funnel-bar-transform.ts b/frontend/src/metabase/visualizations/visualizations/Funnel/funnel-bar-transform.tsindex 1a73f966fd5..7b2989d1777 100644--- a/frontend/src/metabase/visualizations/visualizations/Funnel/funnel-bar-transform.ts+++ b/frontend/src/metabase/visualizations/visualizations/Funnel/funnel-bar-transform.ts@@ -1,6 +1,6 @@-import { formatValue } from "metabase/utils/formatting";import { isNotNull } from "metabase/utils/types";import type { TransformSeries } from "metabase/visualizations/components/TransformedVisualization";+import { formatValue } from "metabase/visualizations/lib/formatting";import type { RowValue } from "metabase-types/api";export const funnelToBarTransform: TransformSeries = (rawSeries, settings) => {diff --git a/frontend/src/metabase/visualizations/visualizations/Gauge/Gauge.tsx b/frontend/src/metabase/visualizations/visualizations/Gauge/Gauge.tsxindex 8b067425d1a..3894e143e23 100644--- a/frontend/src/metabase/visualizations/visualizations/Gauge/Gauge.tsx+++ b/frontend/src/metabase/visualizations/visualizations/Gauge/Gauge.tsx@@ -4,7 +4,7 @@ import * as d3 from "d3";import { useCallback, useEffect, useRef } from "react";import CS from "metabase/css/core/index.css";-import { formatValue } from "metabase/utils/formatting";+import { formatValue } from "metabase/visualizations/lib/formatting";import { segmentIsValid } from "metabase/visualizations/lib/utils";import type { VisualizationProps } from "metabase/visualizations/types";diff --git a/frontend/src/metabase/visualizations/visualizations/Gauge/GaugeArc.tsx b/frontend/src/metabase/visualizations/visualizations/Gauge/GaugeArc.tsxindex 025ccfdbe3b..96f9f59f87b 100644--- a/frontend/src/metabase/visualizations/visualizations/Gauge/GaugeArc.tsx+++ b/frontend/src/metabase/visualizations/visualizations/Gauge/GaugeArc.tsx@@ -1,7 +1,7 @@import * as d3 from "d3";import type { MouseEvent } from "react";-import { formatValue } from "metabase/utils/formatting";+import { formatValue } from "metabase/visualizations/lib/formatting";import type {ClickObject,ComputedVisualizationSettings,diff --git a/frontend/src/metabase/visualizations/visualizations/PieChart/chart-definition.ts b/frontend/src/metabase/visualizations/visualizations/PieChart/chart-definition.tsindex ffd556fcfc9..f9bea1344d8 100644--- a/frontend/src/metabase/visualizations/visualizations/PieChart/chart-definition.ts+++ b/frontend/src/metabase/visualizations/visualizations/PieChart/chart-definition.ts@@ -1,11 +1,11 @@import { t } from "ttag";import _ from "underscore";-import { formatValue } from "metabase/utils/formatting";import {ChartSettingsError,MinRowsError,} from "metabase/visualizations/lib/errors";+import { formatValue } from "metabase/visualizations/lib/formatting";import { columnSettings } from "metabase/visualizations/lib/settings/column";import { nestedSettings } from "metabase/visualizations/lib/settings/nested";import { keyForSingleSeries } from "metabase/visualizations/lib/settings/series";diff --git a/frontend/src/metabase/visualizations/visualizations/Progress/Progress.tsx b/frontend/src/metabase/visualizations/visualizations/Progress/Progress.tsxindex 7d53cd5b8bc..d08fe4bc24e 100644--- a/frontend/src/metabase/visualizations/visualizations/Progress/Progress.tsx+++ b/frontend/src/metabase/visualizations/visualizations/Progress/Progress.tsx@@ -4,8 +4,8 @@ import { t } from "ttag";import CS from "metabase/css/core/index.css";import { Flex, Icon } from "metabase/ui";-import { formatValue } from "metabase/utils/formatting";import { checkNotNull } from "metabase/utils/types";+import { formatValue } from "metabase/visualizations/lib/formatting";import type { VisualizationProps } from "metabase/visualizations/types";import { PROGRESS_CHART_DEFINITION } from "./chart-definition";diff --git a/frontend/src/metabase/visualizations/visualizations/RowChart/utils/format.ts b/frontend/src/metabase/visualizations/visualizations/RowChart/utils/format.tsindex 98eee834332..bb5aa69320d 100644--- a/frontend/src/metabase/visualizations/visualizations/RowChart/utils/format.ts+++ b/frontend/src/metabase/visualizations/visualizations/RowChart/utils/format.ts@@ -1,9 +1,9 @@import type { NumberLike, StringLike } from "@visx/scale";import { NULL_DISPLAY_VALUE } from "metabase/utils/constants";-import { formatValue } from "metabase/utils/formatting";import { isEmpty } from "metabase/utils/validate";import { getFormattingOptionsWithoutScaling } from "metabase/visualizations/echarts/cartesian/model/util";+import { formatValue } from "metabase/visualizations/lib/formatting";import type { CartesianChartColumns } from "metabase/visualizations/lib/graph/columns";import { getStackOffset } from "metabase/visualizations/lib/settings/stacking";import type {diff --git a/frontend/src/metabase/visualizations/visualizations/SmartScalar/PreviousValueComparison/PreviousValueComparison.tsx b/frontend/src/metabase/visualizations/visualizations/SmartScalar/PreviousValueComparison/PreviousValueComparison.tsxindex 53246b49f94..dfa9bee8426 100644--- a/frontend/src/metabase/visualizations/visualizations/SmartScalar/PreviousValueComparison/PreviousValueComparison.tsx+++ b/frontend/src/metabase/visualizations/visualizations/SmartScalar/PreviousValueComparison/PreviousValueComparison.tsx@@ -2,8 +2,8 @@ import innerText from "react-innertext";import DashboardS from "metabase/css/dashboard.module.css";import { Badge, Flex, Group, Icon, Stack, Tooltip } from "metabase/ui";-import { formatValue } from "metabase/utils/formatting/value";import { measureTextWidth } from "metabase/utils/measure-text";+import { formatValue } from "metabase/visualizations/lib/formatting/value";import type { ColumnSettings } from "metabase/visualizations/types";import { CHANGE_TYPE_OPTIONS, type ComparisonResult } from "../compute";diff --git a/frontend/src/metabase/visualizations/visualizations/SmartScalar/PreviousValueComparison/PreviousValueComparisonTooltip.tsx b/frontend/src/metabase/visualizations/visualizations/SmartScalar/PreviousValueComparison/PreviousValueComparisonTooltip.tsxindex 5ed701fcf43..55675453460 100644--- a/frontend/src/metabase/visualizations/visualizations/SmartScalar/PreviousValueComparison/PreviousValueComparisonTooltip.tsx+++ b/frontend/src/metabase/visualizations/visualizations/SmartScalar/PreviousValueComparison/PreviousValueComparisonTooltip.tsx@@ -1,5 +1,5 @@import { Flex } from "metabase/ui";-import { formatValue } from "metabase/utils/formatting/value";+import { formatValue } from "metabase/visualizations/lib/formatting/value";import type { ColumnSettings } from "metabase/visualizations/types";import { CHANGE_TYPE_OPTIONS, type ComparisonResult } from "../compute";diff --git a/frontend/src/metabase/visualizations/visualizations/SmartScalar/compute.ts b/frontend/src/metabase/visualizations/visualizations/SmartScalar/compute.tsindex abf8b4da70b..691702fcb6f 100644--- a/frontend/src/metabase/visualizations/visualizations/SmartScalar/compute.ts+++ b/frontend/src/metabase/visualizations/visualizations/SmartScalar/compute.ts@@ -2,11 +2,11 @@ import dayjs from "dayjs";import { t } from "ttag";import type { ColorGetter } from "metabase/ui/colors/types";-import { formatValue } from "metabase/utils/formatting";-import { formatDateTimeRangeWithUnit } from "metabase/utils/formatting/date";import type { OptionsType } from "metabase/utils/formatting/types";import { isNumber } from "metabase/utils/types";import { isEmpty } from "metabase/utils/validate";+import { formatValue } from "metabase/visualizations/lib/formatting";+import { formatDateTimeRangeWithUnit } from "metabase/visualizations/lib/formatting/date";import { computeChange } from "metabase/visualizations/lib/numeric";import { findPreviousNonEmptyRowIndex } from "metabase/visualizations/lib/trend-helpers";import type { ColumnSettings } from "metabase/visualizations/types";diff --git a/frontend/src/metabase/visualizations/visualizations/SmartScalar/compute.unit.spec.ts b/frontend/src/metabase/visualizations/visualizations/SmartScalar/compute.unit.spec.tsindex b20afc6acdd..3ffa7376680 100644--- a/frontend/src/metabase/visualizations/visualizations/SmartScalar/compute.unit.spec.ts+++ b/frontend/src/metabase/visualizations/visualizations/SmartScalar/compute.unit.spec.ts@@ -1,6 +1,6 @@import { color, colors } from "metabase/ui/colors";-import { formatValue } from "metabase/utils/formatting/value";import { isNumber } from "metabase/utils/types";+import { formatValue } from "metabase/visualizations/lib/formatting/value";import { computeChange } from "metabase/visualizations/lib/numeric";import {CHANGE_ARROW_ICONS,