Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Allow adding segments and measures to hidden tables (#69373)

Anderson70878781e44f
diff --git a/frontend/src/metabase/data-studio/measures/pages/NewMeasurePage/NewMeasurePage.tsx b/frontend/src/metabase/data-studio/measures/pages/NewMeasurePage/NewMeasurePage.tsx
index 4a1bc8a8f1f..3002aab4a0c 100644
--- a/frontend/src/metabase/data-studio/measures/pages/NewMeasurePage/NewMeasurePage.tsx
+++ b/frontend/src/metabase/data-studio/measures/pages/NewMeasurePage/NewMeasurePage.tsx
@@ -10,7 +10,7 @@ import { PageContainer } from "metabase/data-studio/common/components/PageContai
import { getDatasetQueryPreviewUrl } from "metabase/data-studio/common/utils/get-dataset-query-preview-url";
import { useDispatch, useSelector } from "metabase/lib/redux";
import { useMetadataToasts } from "metabase/metadata/hooks";
-import { getMetadata } from "metabase/selectors/metadata";
+import { getMetadataWithHiddenTables } from "metabase/selectors/metadata";
import { Button } from "metabase/ui";
import * as Lib from "metabase-lib";
import type { DatasetQuery, Measure, Table } from "metabase-types/api";
@@ -34,7 +34,7 @@ export function NewMeasurePage({
getSuccessUrl,
}: NewMeasurePageProps) {
const dispatch = useDispatch();
- const metadata = useSelector(getMetadata);
+ const metadata = useSelector(getMetadataWithHiddenTables);
const { sendSuccessToast, sendErrorToast } = useMetadataToasts();
const [name, setName] = useState("");
diff --git a/frontend/src/metabase/data-studio/measures/pages/NewMeasurePage/NewMeasurePage.unit.spec.tsx b/frontend/src/metabase/data-studio/measures/pages/NewMeasurePage/NewMeasurePage.unit.spec.tsx
new file mode 100644
index 00000000000..bbacf2b3119
--- /dev/null
+++ b/frontend/src/metabase/data-studio/measures/pages/NewMeasurePage/NewMeasurePage.unit.spec.tsx
@@ -0,0 +1,60 @@
+import { Route } from "react-router";
+
+import { setupSchemaEndpoints } from "__support__/server-mocks";
+import { createMockEntitiesState } from "__support__/store";
+import { renderWithProviders, screen } from "__support__/ui";
+import type { Table } from "metabase-types/api";
+import { createMockDatabase, createMockTable } from "metabase-types/api/mocks";
+import { createMockSettingsState } from "metabase-types/store/mocks";
+
+import { NewMeasurePage } from "./NewMeasurePage";
+
+const TEST_DATABASE = createMockDatabase({
+ id: 1,
+ name: "Test Database",
+});
+
+type SetupOpts = {
+ table: Table;
+};
+
+function setup({ table }: SetupOpts) {
+ setupSchemaEndpoints(TEST_DATABASE);
+
+ renderWithProviders(
+ <Route
+ path="/"
+ component={() => (
+ <NewMeasurePage
+ route={{ path: "/" } as never}
+ table={table}
+ breadcrumbs={<div />}
+ getSuccessUrl={() => "/success"}
+ />
+ )}
+ />,
+ {
+ withRouter: true,
+ storeInitialState: {
+ entities: createMockEntitiesState({
+ databases: [TEST_DATABASE],
+ tables: [table],
+ }),
+ settings: createMockSettingsState({}),
+ },
+ },
+ );
+}
+
+describe("NewMeasurePage", () => {
+ it("shows aggregation function picker even if table is hidden (UXW-2889)", async () => {
+ setup({
+ table: createMockTable({
+ visibility_type: "hidden",
+ }),
+ });
+ expect(
+ screen.getByText("Pick an aggregation function"),
+ ).toBeInTheDocument();
+ });
+});
diff --git a/frontend/src/metabase/data-studio/segments/pages/NewSegmentPage/NewSegmentPage.tsx b/frontend/src/metabase/data-studio/segments/pages/NewSegmentPage/NewSegmentPage.tsx
index 0c47a9e16cd..026cb84fa34 100644
--- a/frontend/src/metabase/data-studio/segments/pages/NewSegmentPage/NewSegmentPage.tsx
+++ b/frontend/src/metabase/data-studio/segments/pages/NewSegmentPage/NewSegmentPage.tsx
@@ -10,7 +10,7 @@ import { PageContainer } from "metabase/data-studio/common/components/PageContai
import { getDatasetQueryPreviewUrl } from "metabase/data-studio/common/utils/get-dataset-query-preview-url";
import { useDispatch, useSelector } from "metabase/lib/redux";
import { useMetadataToasts } from "metabase/metadata/hooks";
-import { getMetadata } from "metabase/selectors/metadata";
+import { getMetadataWithHiddenTables } from "metabase/selectors/metadata";
import { Button } from "metabase/ui";
import * as Lib from "metabase-lib";
import type { DatasetQuery, Segment, Table } from "metabase-types/api";
@@ -34,7 +34,7 @@ export function NewSegmentPage({
getSuccessUrl,
}: NewSegmentPageProps) {
const dispatch = useDispatch();
- const metadata = useSelector(getMetadata);
+ const metadata = useSelector(getMetadataWithHiddenTables);
const { sendSuccessToast, sendErrorToast } = useMetadataToasts();
const [name, setName] = useState("");
diff --git a/frontend/src/metabase/data-studio/segments/pages/NewSegmentPage/NewSegmentPage.unit.spec.tsx b/frontend/src/metabase/data-studio/segments/pages/NewSegmentPage/NewSegmentPage.unit.spec.tsx
index 71f7642895d..6656879d777 100644
--- a/frontend/src/metabase/data-studio/segments/pages/NewSegmentPage/NewSegmentPage.unit.spec.tsx
+++ b/frontend/src/metabase/data-studio/segments/pages/NewSegmentPage/NewSegmentPage.unit.spec.tsx
@@ -283,4 +283,16 @@ describe("NewSegmentPage", () => {
// The "Discard your changes?" modal should NOT appear after a successful save
expect(screen.queryByText("Discard your changes?")).not.toBeInTheDocument();
});
+
+ it("shows filter editor even if table is hidden (UXW-2889)", async () => {
+ setup({
+ table: {
+ ...TEST_TABLE,
+ visibility_type: "hidden",
+ },
+ });
+ expect(
+ screen.getByText("Add filters to narrow your answer"),
+ ).toBeInTheDocument();
+ });
});