The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Limit schemas in workspaces (#75405)
Alexander Polyankin70bb44ec4d74
diff --git a/enterprise/frontend/src/metabase-enterprise/workspaces/components/DatabaseInfo/DatabaseInfo.tsx b/enterprise/frontend/src/metabase-enterprise/workspaces/components/DatabaseInfo/DatabaseInfo.tsxindex 2ee1628ef50..8f39e5830b5 100644--- a/enterprise/frontend/src/metabase-enterprise/workspaces/components/DatabaseInfo/DatabaseInfo.tsx+++ b/enterprise/frontend/src/metabase-enterprise/workspaces/components/DatabaseInfo/DatabaseInfo.tsx@@ -1,6 +1,10 @@+import { c, msgid } from "ttag";+import { Group, Pill, Text } from "metabase/ui";import type { Database, WorkspaceDatabase } from "metabase-types/api";+const SCHEMAS_LIMIT = 10;+export type DatabaseInfoProps = {workspaceDatabase: WorkspaceDatabase;database: Database | undefined;@@ -10,13 +14,31 @@ export function DatabaseInfo({workspaceDatabase,database,}: DatabaseInfoProps) {+ const allSchemas = workspaceDatabase.input_schemas;+ const visibleSchemas = allSchemas.slice(0, SCHEMAS_LIMIT);+ const hasMoreSchemas = allSchemas.length > SCHEMAS_LIMIT;+ const moreSchemasCount = hasMoreSchemas+ ? allSchemas.length - SCHEMAS_LIMIT+ : 0;+return (<Group gap="sm"><Text fw="bold">{database?.name}</Text><Group gap="sm">- {workspaceDatabase.input_schemas.map((schema) => (+ {visibleSchemas.map((schema) => (<Pill key={schema}>{schema}</Pill>))}+ {hasMoreSchemas && (+ <Pill c="text-secondary">+ {c(+ "text shown after a list of schemas for a database, e.g. 'And 10 more'",+ ).ngettext(+ msgid`And ${moreSchemasCount} more`,+ `And ${moreSchemasCount} more`,+ moreSchemasCount,+ )}+ </Pill>+ )}</Group></Group>);diff --git a/enterprise/frontend/src/metabase-enterprise/workspaces/components/DatabaseInfo/DatabaseInfo.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/workspaces/components/DatabaseInfo/DatabaseInfo.unit.spec.tsxindex 12ce8d8c28b..bb460b9ae54 100644--- a/enterprise/frontend/src/metabase-enterprise/workspaces/components/DatabaseInfo/DatabaseInfo.unit.spec.tsx+++ b/enterprise/frontend/src/metabase-enterprise/workspaces/components/DatabaseInfo/DatabaseInfo.unit.spec.tsx@@ -1,4 +1,5 @@import { renderWithProviders, screen } from "__support__/ui";+import type { Database, WorkspaceDatabase } from "metabase-types/api";import {createMockDatabase,createMockWorkspaceDatabase,@@ -8,20 +9,47 @@ import { DatabaseInfo } from "./DatabaseInfo";const POSTGRES = createMockDatabase({ id: 10, name: "Postgres" });+type SetupOpts = {+ workspaceDatabase?: WorkspaceDatabase;+ database?: Database;+};++function setup({+ workspaceDatabase = createMockWorkspaceDatabase({ database_id: POSTGRES.id }),+ database = POSTGRES,+}: SetupOpts = {}) {+ renderWithProviders(+ <DatabaseInfo workspaceDatabase={workspaceDatabase} database={database} />,+ );+}+describe("DatabaseInfo", () => {it("renders the database name and schema pills when the database is found", () => {- renderWithProviders(- <DatabaseInfo- workspaceDatabase={createMockWorkspaceDatabase({- database_id: POSTGRES.id,- input_schemas: ["public", "analytics"],- })}- database={POSTGRES}- />,- );+ setup({+ workspaceDatabase: createMockWorkspaceDatabase({+ database_id: POSTGRES.id,+ input_schemas: ["public", "analytics"],+ }),+ });expect(screen.getByText("Postgres")).toBeInTheDocument();expect(screen.getByText("public")).toBeInTheDocument();expect(screen.getByText("analytics")).toBeInTheDocument();});++ it("shows a 'more' pill when there are more than 10 schemas", () => {+ const schemas = Array.from({ length: 13 }, (_, i) => `schema_${i + 1}`);++ setup({+ workspaceDatabase: createMockWorkspaceDatabase({+ database_id: POSTGRES.id,+ input_schemas: schemas,+ }),+ });++ expect(screen.getByText("schema_1")).toBeInTheDocument();+ expect(screen.getByText("schema_10")).toBeInTheDocument();+ expect(screen.queryByText("schema_11")).not.toBeInTheDocument();+ expect(screen.getByText("And 3 more")).toBeInTheDocument();+ });});