The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Wire the quarantine switch into the embedding e2e workflows (#77518)
Nemanja Glumac71863190b10b
diff --git a/.github/workflows/embedding-sdk-component-tests.yml b/.github/workflows/embedding-sdk-component-tests.ymlindex 8bc602e8400..64a9cdb18da 100644--- a/.github/workflows/embedding-sdk-component-tests.yml+++ b/.github/workflows/embedding-sdk-component-tests.yml@@ -95,6 +95,8 @@ jobs:env:CYPRESS_BROWSER: ${{ steps.cypress-prep.outputs.chrome-path }}run: node e2e/runner/run_cypress_ci.js component+ # Keep this step continue-on-error because the quarantine logic controls whether it ultimately fails.+ continue-on-error: true- name: Rewrite JUnit hook failuresif: always()@@ -120,19 +122,21 @@ jobs:aws-region: ${{ vars.AWS_REGION }}trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}previous-step-outcome: ${{ steps.run-tests.outcome }}+ run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}- - name: Quarantine gate (dry run)- if: always()- continue-on-error: true+ - name: Quarantine gate+ if: ${{ !cancelled() && steps.run-tests.outcome == 'failure' }}+ continue-on-error: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}timeout-minutes: 3uses: ./.github/actions/quarantine-gatewith:adapter: e2etest-suite: ${{ env.CI_CONDUCTOR_TEST_SUITE }}+ enforce-quarantine: ${{ vars.QUARANTINE_ENGINE == 'ci-conductor' }}- name: "SDK component tests > Upload Cypress Artifacts upon failure"uses: actions/upload-artifact@v7- if: failure()+ if: ${{ !cancelled() && steps.run-tests.outcome == 'failure' }}with:name: cypress-recording-embedding-sdk-react-${{ matrix.react-version }}path: |@@ -141,7 +145,7 @@ jobs:if-no-files-found: ignore- name: "SDK component tests > Publish Summary"- if: failure()+ if: ${{ !cancelled() && steps.run-tests.outcome == 'failure' }}uses: actions/github-script@v9with:script: | #js@@ -273,6 +277,8 @@ jobs:run: |node e2e/runner/run_cypress_ci.js component \--expose grepTags="-@skip-backward-compatibility"+ # Keep this step continue-on-error because the quarantine logic controls whether it ultimately fails.+ continue-on-error: true- name: Rewrite JUnit hook failuresif: always()@@ -298,19 +304,21 @@ jobs:aws-region: ${{ vars.AWS_REGION }}trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}previous-step-outcome: ${{ steps.run-tests.outcome }}+ run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}- - name: Quarantine gate (dry run)- if: always()- continue-on-error: true+ - name: Quarantine gate+ if: ${{ !cancelled() && steps.run-tests.outcome == 'failure' }}+ continue-on-error: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}timeout-minutes: 3uses: ./.github/actions/quarantine-gatewith:adapter: e2etest-suite: ${{ env.CI_CONDUCTOR_TEST_SUITE }}+ enforce-quarantine: ${{ vars.QUARANTINE_ENGINE == 'ci-conductor' }}- name: Upload Cypress Artifacts upon failureuses: actions/upload-artifact@v7- if: failure()+ if: ${{ !cancelled() && steps.run-tests.outcome == 'failure' }}with:name: cypress-recording-embedding-sdk-cross-versionpath: |@@ -319,7 +327,7 @@ jobs:if-no-files-found: ignore- name: Publish Summary- if: failure()+ if: ${{ !cancelled() && steps.run-tests.outcome == 'failure' }}uses: actions/github-script@v9with:script: | #jsdiff --git a/.github/workflows/embedding-sdk-host-sample-apps-tests.yml b/.github/workflows/embedding-sdk-host-sample-apps-tests.ymlindex 6a6c50f29d7..bda21273259 100644--- a/.github/workflows/embedding-sdk-host-sample-apps-tests.yml+++ b/.github/workflows/embedding-sdk-host-sample-apps-tests.yml@@ -10,11 +10,6 @@ env:GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}HASH: ${{ github.event.pull_request.head.sha || github.sha }}-${{ github.run_attempt }}MB_EDITION: ee- CI_CONDUCTOR_BASE_URL: ${{ secrets.CI_CONDUCTOR_BASE_URL }}- CI_CONDUCTOR_WEBHOOK_SECRET: ${{ secrets.CI_CONDUCTOR_WEBHOOK_SECRET }}- REPO_ID: ${{ github.event.repository.id }}- COMMIT_SHA: ${{ github.event.pull_request.head.sha || github.sha }}- TARGET_BRANCH: ${{ github.event.pull_request.base.ref || github.ref_name }}jobs:get-sample-apps-data:runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}@@ -103,7 +98,6 @@ jobs:timeout-minutes: 45name: e2e-sample-app-${{ matrix.test_suite }}-tests-${{ matrix.environment }}-bundleenv:- CI_CONDUCTOR_TEST_SUITE: embedding-sdk-sample-appMB_EDITION: eeMB_RUN_MODE: e2eMETASTORE_DEV_SERVER_URL: ${{ secrets.METASTORE_DEV_SERVER_URL }}@@ -215,7 +209,6 @@ jobs:timeout-minutes: 45name: e2e-sample-app-shoppy-e2e-tests-${{ matrix.environment }}-bundleenv:- CI_CONDUCTOR_TEST_SUITE: embedding-sdk-shoppyMB_EDITION: eeMB_RUN_MODE: e2eMETASTORE_DEV_SERVER_URL: ${{ secrets.METASTORE_DEV_SERVER_URL }}@@ -283,7 +276,6 @@ jobs:timeout-minutes: 45name: e2e-shoppy-synthetic-monitoring-testsenv:- CI_CONDUCTOR_TEST_SUITE: embedding-sdk-shoppy-syntheticMB_EDITION: eeMB_RUN_MODE: e2eMETASTORE_DEV_SERVER_URL: ${{ secrets.METASTORE_DEV_SERVER_URL }}@@ -377,8 +369,19 @@ jobs:timeout-minutes: 45name: e2e-host-app-${{ matrix.test_suite }}-tests-${{ matrix.environment }}-bundleenv:+ # Host apps are the only suite here running through Metabase's Cypress config,+ # whose `after:spec` hook reports failures and writes QUARANTINE_FAILURES_FILE.+ # Sample-app suites load their own config (no-op), so ci-conductor is scoped to this job.+ CI_CONDUCTOR_BASE_URL: ${{ secrets.CI_CONDUCTOR_BASE_URL }}+ CI_CONDUCTOR_WEBHOOK_SECRET: ${{ secrets.CI_CONDUCTOR_WEBHOOK_SECRET }}CI_CONDUCTOR_TEST_SUITE: embedding-sdk-host-app+ REPO_ID: ${{ github.event.repository.id }}+ COMMIT_SHA: ${{ github.event.pull_request.head.sha || github.sha }}+ TARGET_BRANCH: ${{ github.event.pull_request.base.ref || github.ref_name }}QUARANTINE_FAILURES_FILE: ${{ github.workspace }}/target/quarantine-failures.jsonl+ # `Fail job if tests failed` is the arbiter until ci-conductor takes over.+ # Exactly one of the two gates the job.+ CI_CONDUCTOR_QUARANTINE_ACTIVE: ${{ vars.QUARANTINE_ENGINE == 'ci-conductor' }}CYPRESS_MB_ALL_FEATURES_TOKEN: ${{ secrets.STAGING_MB_ALL_FEATURES_TOKEN }}HOST_APP_ENVIRONMENT: ${{ matrix.environment }}permissions:@@ -434,23 +437,24 @@ jobs:- name: Upload Cypress Artifacts upon failureuses: actions/upload-artifact@v7- if: ${{ steps.run-e2e-tests.outcome != 'success' }}+ if: ${{ !cancelled() && steps.run-e2e-tests.outcome == 'failure' }}with:name: cypress-recording-host-app-${{ matrix.test_suite }}-${{ matrix.environment }}-latestpath: |./cypressif-no-files-found: ignore- - name: Quarantine gate (dry run)- if: always()- continue-on-error: true+ - name: Quarantine gate+ if: ${{ !cancelled() && steps.run-e2e-tests.outcome == 'failure' }}+ continue-on-error: ${{ env.CI_CONDUCTOR_QUARANTINE_ACTIVE != 'true' }}timeout-minutes: 3uses: ./.github/actions/quarantine-gatewith:adapter: e2etest-suite: ${{ env.CI_CONDUCTOR_TEST_SUITE }}+ enforce-quarantine: ${{ env.CI_CONDUCTOR_QUARANTINE_ACTIVE }}- name: Fail job if tests failed- if: ${{ steps.run-e2e-tests.outcome != 'success' }}+ if: ${{ !cancelled() && steps.run-e2e-tests.outcome == 'failure' && env.CI_CONDUCTOR_QUARANTINE_ACTIVE != 'true' }}run: |exit 1