The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Add migration to fix library root collections with legacy random entity ids (#74178)
Anderson71cbb7d163a0
diff --git a/resources/migrations/062/20260513_legacy_library_root_entity_ids.yaml b/resources/migrations/062/20260513_legacy_library_root_entity_ids.yamlnew file mode 100644index 00000000000..eac42866ee5--- /dev/null+++ b/resources/migrations/062/20260513_legacy_library_root_entity_ids.yaml@@ -0,0 +1,133 @@+## Backfill canonical entity IDs for legacy Library root collections++databaseChangeLog:+ - logicalFilePath: migrations/062_update_migrations.yaml++ - changeSet:+ id: v62.2026-05-13T12:00:00+ author: andsalves+ comment: Backfill canonical entity_id for legacy Library root collection+ changes:+ - sql:+ sql: >-+ UPDATE collection+ SET entity_id = 'librarylibrarylibrary'+ WHERE type = 'library' AND location = '/'+ rollback:+ - empty: {}++ - changeSet:+ id: v62.2026-05-13T12:00:01+ author: andsalves+ comment: Backfill canonical entity_id for legacy Library Data section+ changes:+ - sql:+ dbms: postgresql,h2+ sql: >-+ UPDATE collection+ SET entity_id = 'librarylibrarydatadat'+ WHERE type = 'library-data'+ AND location IN (+ SELECT loc FROM (+ SELECT '/' || CAST(id AS VARCHAR) || '/' AS loc+ FROM collection+ WHERE type = 'library' AND location = '/'+ ) lib_loc+ )+ AND 1 = (+ SELECT cnt FROM (+ SELECT COUNT(*) AS cnt+ FROM collection child+ WHERE child.type = 'library-data'+ AND child.location IN (+ SELECT '/' || CAST(lib.id AS VARCHAR) || '/'+ FROM collection lib+ WHERE lib.type = 'library' AND lib.location = '/'+ )+ ) x+ )+ - sql:+ dbms: mysql,mariadb+ sql: >-+ UPDATE collection+ SET entity_id = 'librarylibrarydatadat'+ WHERE type = 'library-data'+ AND location IN (+ SELECT loc FROM (+ SELECT CONCAT('/', CAST(id AS CHAR), '/') AS loc+ FROM collection+ WHERE type = 'library' AND location = '/'+ ) lib_loc+ )+ AND 1 = (+ SELECT cnt FROM (+ SELECT COUNT(*) AS cnt+ FROM collection child+ WHERE child.type = 'library-data'+ AND child.location IN (+ SELECT CONCAT('/', CAST(lib.id AS CHAR), '/')+ FROM collection lib+ WHERE lib.type = 'library' AND lib.location = '/'+ )+ ) x+ )+ rollback:+ - empty: {}++ - changeSet:+ id: v62.2026-05-13T12:00:02+ author: andsalves+ comment: Backfill canonical entity_id for legacy Library Metrics section+ changes:+ - sql:+ dbms: postgresql,h2+ sql: >-+ UPDATE collection+ SET entity_id = 'librarylibrarymetrics'+ WHERE type = 'library-metrics'+ AND location IN (+ SELECT loc FROM (+ SELECT '/' || CAST(id AS VARCHAR) || '/' AS loc+ FROM collection+ WHERE type = 'library' AND location = '/'+ ) lib_loc+ )+ AND 1 = (+ SELECT cnt FROM (+ SELECT COUNT(*) AS cnt+ FROM collection child+ WHERE child.type = 'library-metrics'+ AND child.location IN (+ SELECT '/' || CAST(lib.id AS VARCHAR) || '/'+ FROM collection lib+ WHERE lib.type = 'library' AND lib.location = '/'+ )+ ) x+ )+ - sql:+ dbms: mysql,mariadb+ sql: >-+ UPDATE collection+ SET entity_id = 'librarylibrarymetrics'+ WHERE type = 'library-metrics'+ AND location IN (+ SELECT loc FROM (+ SELECT CONCAT('/', CAST(id AS CHAR), '/') AS loc+ FROM collection+ WHERE type = 'library' AND location = '/'+ ) lib_loc+ )+ AND 1 = (+ SELECT cnt FROM (+ SELECT COUNT(*) AS cnt+ FROM collection child+ WHERE child.type = 'library-metrics'+ AND child.location IN (+ SELECT CONCAT('/', CAST(lib.id AS CHAR), '/')+ FROM collection lib+ WHERE lib.type = 'library' AND lib.location = '/'+ )+ ) x+ )+ rollback:+ - empty: {}diff --git a/test/metabase/app_db/schema_migrations_test.clj b/test/metabase/app_db/schema_migrations_test.cljindex cafc4e17498..3d1368e085a 100644--- a/test/metabase/app_db/schema_migrations_test.clj+++ b/test/metabase/app_db/schema_migrations_test.clj@@ -18,6 +18,7 @@51.x or older are now 'old'."(:require[clojure.java.jdbc :as jdbc]+ [clojure.string :as str][clojure.test :refer :all][java-time.api :as t][medley.core :as m]@@ -2931,6 +2932,109 @@:created_at :%now:updated_at :%now}))))))))+;;;+;;; 62 tests+;;;++(defn- insert-legacy-library-collection!+ [attrs]+ (t2/insert-returning-pk!+ :collection+ (merge {:name (mt/random-name)+ :slug (mt/random-name)+ :location "/"+ :entity_id (mt/random-name)+ :archived false+ :is_sample false+ :is_remote_synced false+ :created_at :%now}+ attrs)))++(defn- collection-entity-id+ [collection-id]+ (str/trim (t2/select-one-fn :entity_id :collection :id collection-id)))++(deftest backfill-legacy-library-root-collection-entity-ids-test+ (testing "v62.2026-05-13T12:00:00 through v62.2026-05-13T12:00:02: backfill canonical Library root entity IDs"+ (impl/test-migrations ["v62.2026-05-13T12:00:00" "v62.2026-05-13T12:00:02"] [migrate!]+ (let [library-id (insert-legacy-library-collection! {:name "Library"+ :slug "library"+ :type "library"+ :entity_id "legacy-library-root"})+ data-id (insert-legacy-library-collection! {:name "Data"+ :slug "data"+ :type "library-data"+ :location (str "/" library-id "/")+ :entity_id "legacy-library-data"})+ metrics-id (insert-legacy-library-collection! {:name "Metrics"+ :slug "metrics"+ :type "library-metrics"+ :location (str "/" library-id "/")+ :entity_id "legacy-library-metric"})]+ (migrate!)+ (is (= "librarylibrarylibrary"+ (collection-entity-id library-id)))+ (is (= "librarylibrarydatadat"+ (collection-entity-id data-id)))+ (is (= "librarylibrarymetrics"+ (collection-entity-id metrics-id))))))+ (testing "ambiguous Library Data direct children are not modified"+ (impl/test-migrations ["v62.2026-05-13T12:00:00" "v62.2026-05-13T12:00:02"] [migrate!]+ (let [library-id (insert-legacy-library-collection! {:name "Library"+ :slug "library"+ :type "library"+ :entity_id "legacy-library-root"})+ data-id (insert-legacy-library-collection! {:name "Data"+ :slug "data"+ :type "library-data"+ :location (str "/" library-id "/")+ :entity_id "legacy-library-data"})+ duplicate-data-id (insert-legacy-library-collection! {:name "Other Data"+ :slug "other-data"+ :type "library-data"+ :location (str "/" library-id "/")+ :entity_id "legacy-other-data"})+ metrics-id (insert-legacy-library-collection! {:name "Metrics"+ :slug "metrics"+ :type "library-metrics"+ :location (str "/" library-id "/")+ :entity_id "legacy-library-metric"})]+ (migrate!)+ (is (= "librarylibrarylibrary"+ (collection-entity-id library-id)))+ (is (= "legacy-library-data"+ (collection-entity-id data-id)))+ (is (= "legacy-other-data"+ (collection-entity-id duplicate-data-id)))+ (is (= "librarylibrarymetrics"+ (collection-entity-id metrics-id))))))+ (testing "Library Data collections outside Library root do not count as ambiguous"+ (impl/test-migrations ["v62.2026-05-13T12:00:00" "v62.2026-05-13T12:00:02"] [migrate!]+ (let [library-id (insert-legacy-library-collection! {:name "Library"+ :slug "library"+ :type "library"+ :entity_id "legacy-library-root"})+ other-parent-id (insert-legacy-library-collection! {:name "Other parent"+ :slug "other-parent"+ :entity_id "legacy-other-parent"})+ data-id (insert-legacy-library-collection! {:name "Data"+ :slug "data"+ :type "library-data"+ :location (str "/" library-id "/")+ :entity_id "legacy-library-data"})+ orphan-data-id (insert-legacy-library-collection! {:name "Orphan Data"+ :slug "orphan-data"+ :type "library-data"+ :location (str "/" other-parent-id "/")+ :entity_id "legacy-orphan-data"})]+ (migrate!)+ (is (= "librarylibrarylibrary"+ (collection-entity-id library-id)))+ (is (= "librarylibrarydatadat"+ (collection-entity-id data-id)))+ (is (= "legacy-orphan-data"+ (collection-entity-id orphan-data-id)))))))+(deftest heal-effective-type-drift-without-coercion-test(testing "GHY-3388: heal metabase_field rows where coercion_strategy is NULL and effective_typedrifted away from base_type. The migration must repair such rows in both metabase_field